From patchwork Tue Nov 17 12:33:57 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5723 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:9292:b0:11a:f58a:e788 with SMTP id dc18csp2504498lab; Tue, 17 Nov 2026 04:34:40 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGOcARSWVwq5eXJJ0zGMvWoA+U37ytL/Az+/vgajk1+jQhw68FR+Mv7nFwVXRvI8T6umEV+E8y1HEE=@openvpn.net X-Received: by 2002:a17:903:3c23:b0:2e9:8505:5471 with SMTP id d9443c01a7336-2ee0d662918mr134223295ad.7.1794918880122; Tue, 17 Nov 2026 04:34:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794918880; cv=none; d=google.com; s=arc-20260327; b=UJTljcMPNU1KZAGg1h1aeVePRMfsEd0eke3PZHzpP7Q12nHeaG0E2boxKofCotqs4r LJF0RfRG8lHR5FochywwvZMvRXAtbJrEH7oINYeAMpZ2Swravs4eiuTc4WcO6w3j86KQ cv75k5DnWZuPcPWnAOOzrXnlbo2nAgQuJ4PU0BvtoQiO/n3yWt1wogTLLGNMXn0IEEvx PrkvmViHEJB+oXRYxO2YYbY/MaRknE4wgTXaRvQ6RkoWrhgIZUQt/NgXfcEdqQj9czzq OoCB+vBggqo3e/LNxW3TOiQeAk7KhmA641t4CZy6P0oFEfy89Eab8jIlaO0sC1F0IHr/ Mefg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=s2AYonEJ6nF2ZW3ZGIOcWZXTaZi3nphqRtz3Imfktfs=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=Xxqar3sI4tXWD1iDSy424uVmVJd6AG+8iooGJOmouRGnnXxRTXFlwNCR9/VeeVS/jN 30zZL0U3i2VtebD8fWuqAifd4ohWB1+ERWuLEBCPm2TtSv5fQFwrUa8HKIHfmpSaq7J3 VcA3rTu/X/kowiQAZQ7ojqdK3ZHWLaHGLPcdDiKTAGtQYF6eJr/7TlxFron9oWzFQLdA sFHfO2MeXKJKjwXkKLUHm71/n9altMHNW7KeBgbA/u5Mcfl3YdgZwOSDGp34BziihSVq L7c0aggHvucxRKC8YLWOTPnql4y6i8OL9apEgp2bDy3rE8A1OwOvinDLbJqX+UNEJ8Si Bbyw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=AF1QmUa5; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=RlXNnWvS; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gTWaWHGQ; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id d9443c01a7336-2efd7d7a827si65970515ad.159.2026.11.17.04.34.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Nov 2026 04:34:40 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=AF1QmUa5; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=RlXNnWvS; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gTWaWHGQ; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=s2AYonEJ6nF2ZW3ZGIOcWZXTaZi3nphqRtz3Imfktfs=; b=AF1QmUa5e4DK5P 4PtR4aaL2h9UkO3sR+s50vj/cCP3aUbmc0tdwCIy7Hw850+gIhovz7P5A9gA6nNFR5vqjZSvFRNJi mAGLlWyVvU1R7ogKUz74+oGBgSiVLSmyX9P6yYCS4AHEbtrVnbzDsXPkwI7g3Fqlj9zHPWNWrpRVF V1w=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xTIOS-000000006IO-498a; Tue, 17 Nov 2026 12:34:36 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xTIOA-000000006G6-2ACy for openvpn-devel@lists.sourceforge.net; Tue, 17 Nov 2026 12:34:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yEMVz4U27pBL/3456G9IKHDJ04zxgWdErV1x/VEkjzY=; b=RlXNnWvSQRVPXhJW1fdKEBS4YC iriAFDwrIFp4VESeHrrdjmE7YWrpRjb9XQ59gdjDm/9pRteQHCjwt+J68rGWDUuy6wN0yX6lQM931 8EKD/QoxgorKi9ZfFlbZwLmgEslCOYp64C/3oS6hQ1k3TFjbK9IqgqZ1N4Nb6hvmszP4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yEMVz4U27pBL/3456G9IKHDJ04zxgWdErV1x/VEkjzY=; b=gTWaWHGQ6+gJcq+ffWy2FHLJhU 67NXevSQTOxEGcXoGqrFnXL0jk+0L77esuZK/dvG8ihu2/Vjz7usdnr8kJdEDLr3Sp+2KFiQos8pl GN4zT0XLDYLsSbok0vrOXh/U22OFxD6WkxifpYX0sE8ciuYGOlhddEMS0hnjc8c9vRVg=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xTIO2-000000000vN-1REw for openvpn-devel@lists.sourceforge.net; Tue, 17 Nov 2026 12:34:12 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6AHCY3GG012538 for ; Tue, 17 Nov 2026 13:34:03 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6AHCY3R9012537 for openvpn-devel@lists.sourceforge.net; Tue, 17 Nov 2026 13:34:03 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 17 Nov 2026 13:33:57 +0100 Message-ID: <20261117123402.12520-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Razvan Cojocaru It was passed by value on every connection attempt and never read. Change-Id: I388a52d19633d0604a1610fbfba31cfff7f518ef Signed-off-by: Razvan Cojocaru Acked-by: Arne Schwabe Acked-by: Frank Lichtenheld List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1882108859342463868 X-GMAIL-MSGID: 1882108859342463868 From: Razvan Cojocaru It was passed by value on every connection attempt and never read. Change-Id: I388a52d19633d0604a1610fbfba31cfff7f518ef Signed-off-by: Razvan Cojocaru Acked-by: Arne Schwabe Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2202 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2202 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Arne Schwabe Frank Lichtenheld diff --git a/src/openvpn/mudp.c b/src/openvpn/mudp.c index 217b299..0e1e21d 100644 --- a/src/openvpn/mudp.c +++ b/src/openvpn/mudp.c @@ -113,7 +113,7 @@ /** Returns a verdict if this packet should create a new session */ static enum pre_decrypt_verdict do_pre_decrypt_check(struct multi_context *m, struct tls_pre_decrypt_state *state, - struct mroute_addr addr, struct link_socket *sock) + struct link_socket *sock) { ASSERT(m->top.c2.tls_auth_standalone); @@ -259,7 +259,7 @@ struct tls_pre_decrypt_state state = { 0 }; struct multi_instance *mi = NULL; - enum pre_decrypt_verdict verdict = do_pre_decrypt_check(m, &state, *real, sock); + enum pre_decrypt_verdict verdict = do_pre_decrypt_check(m, &state, sock); if (verdict != PRE_DECRYPT_NO_ACTION) {