[Openvpn-devel,v2] console_systemd: treat read() error as failure

Message ID 20261117175223.14555-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v2] console_systemd: treat read() error as failure |

Commit Message

Gert Doering Nov. 17, 2026, 5:52 p.m. UTC
  From: Razvan Cojocaru <razvanc@mailbox.org>

read() returning -1 was taken as success, so a failed read from
systemd-ask-password yielded an empty response instead of an error.

Change-Id: Ic49db236b36014ea6ee621a09252a534e3d05ef7
Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2205
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2205
This mail reflects revision 2 of this Change.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <frank@lichtenheld.com>
  

Patch

diff --git a/src/openvpn/console_systemd.c b/src/openvpn/console_systemd.c
index f0ca7fa..059686f 100644
--- a/src/openvpn/console_systemd.c
+++ b/src/openvpn/console_systemd.c
@@ -76,7 +76,7 @@ 
         return false;
     }
     memset(input, 0, capacity);
-    if (read(std_out, input, capacity - 1) != 0)
+    if (read(std_out, input, capacity - 1) > 0)
     {
         chomp(input);
         ret = true;