| Message ID | 20261118151224.14866-1-gert@greenie.muc.de |
|---|---|
| State | New |
| Headers |
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net>
Delivered-To: patchwork@openvpn.net
Received: by 2002:a05:6022:b1c3:10b0:11b:d6c:f273 with SMTP id
i3-n1csp292521laq;
Wed, 18 Nov 2026 07:13:04 -0800 (PST)
X-Forwarded-Encrypted: i=2;
AL+hErF+yucxW9z116h3wwJvaKG8h0b/z1LF8CFSaY4LizvlIl2DjgEiWK8OT4fbRc4ovaDMtUG3ptcK7sA=@openvpn.net
X-Received: by 2002:a05:7022:1701:b0:196:e2d0:129 with SMTP id
a92af1059eb24-1b543b09acamr2643474c88.2.1795014784270;
Wed, 18 Nov 2026 07:13:04 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1795014784; cv=none;
d=google.com; s=arc-20260327;
b=s9CIvlxvTmApQhOdfKzHF+G4WCt6y6OOeSlp5e6flx6g0EqMO3NtDAYcbvaqx8VlX2
TwIJ434KxxbBJvvqqXQvts4zpzVXmYOXMjFRY9Yd9CEhgGEP7UsBW3VYvUfYnv4+xPb5
IgDuNELRx7mEeMTb5gdETeQYPbx2TTCZ4oTPxL1bWnEraXQ4KmnzxQURaIPUCW840fVr
wwj2nsXN9NWRri07Ls7/XKZmaMTipCwuJ9cLc2VoD/GOR41XeKWqIAMAoqgmp9QxZoyZ
L/oJZT1q1YJXOTKBBzA/pHIUjoAkzzhyxj7Pgl5prcd6STZlfRejBMq5YLJyvbwozRoJ
ykBA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20260327;
h=errors-to:content-transfer-encoding:list-subscribe:list-help
:list-post:list-archive:list-unsubscribe:list-id:precedence:subject
:mime-version:references:in-reply-to:message-id:date:to:from
:dkim-signature:dkim-signature:dkim-signature;
bh=CIf4CHbJB6quSBt3mtzw8JgtBdAuFf8lMYSkE31W99E=;
fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=;
b=WRYA1y4gG73ELYIP/DLOJFyiOtXEarHSsSsF++5Y4QoSBqHWWMpBU+dZEFNCMRtCcc
/OTcB2iTqBTYZpccT4rZv8tu4mLSDcAfjHQyw6M8Aibnr6At98SMMWr7Q04ckzsHeDhR
nZ6vvYClrFbrcezAgO/GLvKNkiRPulaza4C9YL4PTAMh6fiJHgWWGYCbEFarqvcSw9DY
pw6U0dw4cNweqRi9tg0FECKiQE75Q1U7FhY2Lrt4zJTNDAGTgNWJFHL3V3QV+4FwURGb
n9UfGjTSysy0sugzAl1y+vCObZKrT5GLSCBG7knSaEIvxW6co1GoZGdYmJs78pYV93s4
L5rQ==;
dara=google.com
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b="Js/VJcYP";
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=cgAOEqme;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=ZXFY3nnq;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7])
by mx.google.com with ESMTPS id
a92af1059eb24-1b54b48bb72si976920c88.43.2026.11.18.07.13.03
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Wed, 18 Nov 2026 07:13:04 -0800 (PST)
Received-SPF: pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) client-ip=216.105.38.7;
Authentication-Results: mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b="Js/VJcYP";
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=cgAOEqme;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=ZXFY3nnq;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:
List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:
Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender:
Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post:
List-Owner; bh=CIf4CHbJB6quSBt3mtzw8JgtBdAuFf8lMYSkE31W99E=; b=Js/VJcYPm6YWpL
sWGqvratF4ano906zDws9m64HbvjhNT40BgVk5oO7bkZs831YSC5XUqM1fLQWIcMGF401TObG1foy
D31zVPdAvTDdbqO480Yv9+FkMWWmcTsU2MY0JaZr+nBB83AoNcr9TUNx1VbYQLXUnRnYyKQwn0BE1
vSI=;
Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com)
by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.100.1)
(envelope-from <openvpn-devel-bounces@lists.sourceforge.net>)
id 1xThLJ-0000000057Q-3SUo;
Wed, 18 Nov 2026 15:13:01 +0000
Received: from [172.30.29.66] (helo=mx.sourceforge.net)
by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1)
(envelope-from <gert@blue4.greenie.muc.de>)
id 1xThKt-0000000056v-10IM for openvpn-devel@lists.sourceforge.net;
Wed, 18 Nov 2026 15:12:35 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References:
In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=RwzW17I/F3v6nyGePrtzikLKAgr/9hS9wrkQkz8VkIw=; b=cgAOEqmeYmOF/P1ncLm9uLbThw
M9aYjIVsRLlK+9Zr5KgUR8nfpCObPAadJVwnX9WbOy8gHDqn2PVQCiOsuWWlw+WsnXUdYTb6if/T4
sCEOoL5mqxD7GBAsbQc/P83gOv2GiInPWjGsWZ42wsVELUmRQh0i66RmAH2xHW3Yr9EY=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:
Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=RwzW17I/F3v6nyGePrtzikLKAgr/9hS9wrkQkz8VkIw=; b=ZXFY3nnqxAECIQu5AFAEt/eO8U
b7CTOi6wdWktLp8kDAwCSGKrCyfD7zlzi3JgZOoq/Pv07JF0hi4XU3wat/Xj8MGcWKtO3R6HXl+2K
P6BlE4iLSX4JguNTYYCz6tnk/FBmPN2pDq9c50AwQMCRwnkKrhFVT/IHgGF1bg2+iejM=;
Received: from [193.149.48.129] (helo=blue.greenie.muc.de)
by sfi-mx-1.v28.lw.sourceforge.com with esmtps
(TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1)
id 1xThKq-000000003za-1cuG for openvpn-devel@lists.sourceforge.net;
Wed, 18 Nov 2026 15:12:35 +0000
Received: from blue.greenie.muc.de (localhost [127.0.0.1])
by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6AIFCP9k014899
for <openvpn-devel@lists.sourceforge.net>; Wed, 18 Nov 2026 16:12:25 +0100
Received: (from gert@localhost)
by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6AIFCPTd014898
for openvpn-devel@lists.sourceforge.net; Wed, 18 Nov 2026 16:12:25 +0100
From: Gert Doering <gert@greenie.muc.de>
To: openvpn-devel@lists.sourceforge.net
Date: Wed, 18 Nov 2026 16:12:19 +0100
Message-ID: <20261118151224.14866-1-gert@greenie.muc.de>
X-Mailer: git-send-email 2.55.0
In-Reply-To:
<gerrit.1794990920000.Ie5336121e8a48e5a63b509d6a30349be42d311f9@gerrit.openvpn.net>
References:
<gerrit.1794990920000.Ie5336121e8a48e5a63b509d6a30349be42d311f9@gerrit.openvpn.net>
MIME-Version: 1.0
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software,
running on the system "sfi-spamd-1.hosts.colo.sdot.me",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: From: Razvan Cojocaru <razvanc@mailbox.org> With an inline
<crl-verify>, crl_file holds the PEM data, and the "CRL: loaded" message
printed all of it. Use print_key_filename() as the other CRL messages do.
Content analysis details: (1.3 points, 5.0 required)
pts rule name description
---- ----------------------
--------------------------------------------------
1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Headers-End: 1xThKq-000000003za-1cuG
Subject: [Openvpn-devel] [PATCH v1] ssl_openssl: don't log inline CRL
contents
X-BeenThere: openvpn-devel@lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <openvpn-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive:
<http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel>
List-Post: <mailto:openvpn-devel@lists.sourceforge.net>
List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: openvpn-devel-bounces@lists.sourceforge.net
X-getmail-retrieved-from-mailbox: Inbox
X-GMAIL-THRID: 1882209422605980867
X-GMAIL-MSGID: 1882209422605980867
|
| Series |
[Openvpn-devel,v1] ssl_openssl: don't log inline CRL contents
|
|
Commit Message
Gert Doering
Nov. 18, 2026, 3:12 p.m. UTC
From: Razvan Cojocaru <razvanc@mailbox.org> With an inline <crl-verify>, crl_file holds the PEM data, and the "CRL: loaded" message printed all of it. Use print_key_filename() as the other CRL messages do. Change-Id: Ie5336121e8a48e5a63b509d6a30349be42d311f9 Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org> Acked-by: Frank Lichtenheld <frank@lichtenheld.com> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2216 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2216 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld <frank@lichtenheld.com>
diff --git a/src/openvpn/ssl_openssl.c b/src/openvpn/ssl_openssl.c index b95de8e..7fdb3c5 100644 --- a/src/openvpn/ssl_openssl.c +++ b/src/openvpn/ssl_openssl.c @@ -1415,7 +1415,8 @@ } num_crls_loaded++; } - msg(M_INFO, "CRL: loaded %d CRLs from file %s", num_crls_loaded, crl_file); + msg(M_INFO, "CRL: loaded %d CRLs from file %s", num_crls_loaded, + print_key_filename(crl_file, crl_inline)); ssl_ctx->crls = crls; BIO_free(in); }