From patchwork Thu Nov 19 13:04:50 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5749 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:b1c3:10b0:11b:d6c:f273 with SMTP id i3-n1csp1552534laq; Thu, 19 Nov 2026 05:05:24 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErHIvTO6L1CohSlAsyMFx16pmGLEGJNzsTDPxdgqwClnM3LT6H746AsIS3/vMPGMqwqZCYLrI5wqvCQ=@openvpn.net X-Received: by 2002:a05:7300:824a:b0:381:f33d:ed9d with SMTP id 5a478bee46e88-38280f1ef77mr5306370eec.21.1795093524480; Thu, 19 Nov 2026 05:05:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1795093524; cv=none; d=google.com; s=arc-20260327; b=PboA4TOTqy/aiy+N5Si5ZWRAod//o7B0uwuh+tN4V0flU3NT0a4sEoaUUlirpI+CfY apIETWfefR5hm+8a4a2+pIulxYKucE4JT9xMc/QvHD+uBh6+jKfsy72OGPIXhwHHZ0WT BOKWzTyfk7iBX6/0TOFPnZJBtySbQNU6TgaqmrsEIHx345k2+Wa5H/50Ap3BDeqXfjKL Ldz/Qr7y8GFwlLcYwSrvrEraH6oWQSRvuQYsr//mp1/GIy7t13Tu/gO7zHZ/Dn1fAhsZ sGp/2FmLAQJ+/Gd/5xnK3FVHUu1bN+6Fwz+X5YUZ9h8CYVKwRxUGo+Z0CXRtjiBVZwjo h3cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=jsTFLW9PlRjmELQFYZ4BSM66AuqZ8DIkX50ZS1MM1Fo=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=d1cWJ8c1bIDug9BiFeFUG9BIQhOkkRGqS/0+YSMbKi3lRwHkPBjsvVaffTDpHUQlYF rukH/LN5NrfRcoqdO3il6i6KGM9CrLnTm6VFsYhVX3j3yzr+9z/rFou5SBgCef3i/omE p+/7HKQ+hhwZVdxfneBKf8dhi2DtR0Z88sgPghZ2jH4qwfmDal7fy+TvDL3n7vSSW8Sj vpNM1YzHyAo8fDgtLYFSyj96CqjSjUYVe8PminBZnazdPkudBprQpohScPTlA8XOn/7V tweGfAzBzbPXq3hHCl2+RbPFeoBjfmMLpsdQIfaiWo/X9XkrZBoWadu/O9gJehvDiR6R tLoA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=MP5wzJM8; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UxE3PocS; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=cFrbfPSh; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5a478bee46e88-3846d4e9affsi4270315eec.35.2026.11.19.05.05.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Nov 2026 05:05:24 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=MP5wzJM8; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UxE3PocS; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=cFrbfPSh; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=jsTFLW9PlRjmELQFYZ4BSM66AuqZ8DIkX50ZS1MM1Fo=; b=MP5wzJM87pRWER AMa5uXR9T0DXQmWNaXmeQJ4xqy4i2L/zkOIIBuojET8a3mLTmcaAPPu0OzPAj4W18P0kl6Wvwwk4u vjjFVB0mjCnrUv5RfcDKacxAagZI4mI/Q2Ev9d9pTKCy8fibs2AHs2bq6DP5sAkQUWLOoC0uH8wJ+ DGU=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xU1pL-000000003V7-0vXd; Thu, 19 Nov 2026 13:05:23 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xU1p3-000000003Up-3MP1 for openvpn-devel@lists.sourceforge.net; Thu, 19 Nov 2026 13:05:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tvkeSPPKMqNcgw4r/rpfx68o95gJjdUhFqLmaiQRYg4=; b=UxE3PocSbYs1HgoaJrcpLvrSMd kWwB69gZ1zBJRNXzmz2Sylp7Y+2++hjeA4Svkwj5SypmyICRq8M6FfVhCZe7nQEuQVobc9RkcQmYL w1Y7hC52H2Ioees/UHffdmlcTjmZOukJq3bDVlEzysbQmCJkrroZ+F7cjPbwOfICuAPQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tvkeSPPKMqNcgw4r/rpfx68o95gJjdUhFqLmaiQRYg4=; b=cFrbfPShmF+Bc4HdfL9eIhwBEs h26zSv8O/RND58qxhiF3jYYOWrneMLgt4e3eg26dGBGzYVdOmePRZpD46dI1W5o3SY02puhIMoWxN 3K5LuYMC3mDoiroFpSHWGcpJ9JSL7m631NRJbhNCoFsPi8473SNwDM3R4kH8WIYRqf6w=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xU1p2-00000000148-09PB for openvpn-devel@lists.sourceforge.net; Thu, 19 Nov 2026 13:05:05 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6AJD4vFF020449 for ; Thu, 19 Nov 2026 14:04:57 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6AJD4vui020448 for openvpn-devel@lists.sourceforge.net; Thu, 19 Nov 2026 14:04:57 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Thu, 19 Nov 2026 14:04:50 +0100 Message-ID: <20261119130456.20423-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Razvan Cojocaru Both need a $1.def that doesn't exist in their directory. defer/simple.c and its .def were removed in d816207b ("plugins: Remove defer/simple.c sample plugin"); the remaining multi-auth.c uses fork() and doesn't build on Windows. log/winbuild came from the e [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xU1p2-00000000148-09PB Subject: [Openvpn-devel] [PATCH v1] sample-plugins: drop broken defer and log winbuild scripts X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1882291987413053458 X-GMAIL-MSGID: 1882291987413053458 From: Razvan Cojocaru Both need a $1.def that doesn't exist in their directory. defer/simple.c and its .def were removed in d816207b ("plugins: Remove defer/simple.c sample plugin"); the remaining multi-auth.c uses fork() and doesn't build on Windows. log/winbuild came from the examples/ -> log/ rename and never had a .def there. log.c builds on Windows with a plain "gcc -shared", since OPENVPN_EXPORT already marks the entry points __declspec(dllexport). Change-Id: I3d5caab3210b65551e2f2ff8f6e2edb50022e4ba Signed-off-by: Razvan Cojocaru Acked-by: Lev Stipakov Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2223 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2223 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Lev Stipakov diff --git a/sample/sample-plugins/defer/winbuild b/sample/sample-plugins/defer/winbuild deleted file mode 100755 index 82927d9..0000000 --- a/sample/sample-plugins/defer/winbuild +++ /dev/null @@ -1,18 +0,0 @@ -# -# Build an OpenVPN plugin module on Windows/MinGW. -# The argument should be the base name of the C source file -# (without the .c). -# - -# This directory is where we will look for openvpn-plugin.h -INCLUDE="-I../../../build" - -CC_FLAGS="-O2 -Wall" - -gcc -DBUILD_DLL $CC_FLAGS $INCLUDE -c $1.c -gcc --disable-stdcall-fixup -mdll -DBUILD_DLL -o junk.tmp -Wl,--base-file,base.tmp $1.o -rm junk.tmp -dlltool --dllname $1.dll --base-file base.tmp --output-exp temp.exp --input-def $1.def -rm base.tmp -gcc --enable-stdcall-fixup -mdll -DBUILD_DLL -o $1.dll $1.o -Wl,temp.exp -rm temp.exp diff --git a/sample/sample-plugins/log/winbuild b/sample/sample-plugins/log/winbuild deleted file mode 100755 index decf05f..0000000 --- a/sample/sample-plugins/log/winbuild +++ /dev/null @@ -1,18 +0,0 @@ -# -# Build an OpenVPN plugin module on Windows/MinGW. -# The argument should be the base name of the C source file -# (without the .c). -# - -# This directory is where we will look for openvpn-plugin.h -INCLUDE="-I../../../include" - -CC_FLAGS="-O2 -Wall" - -gcc -DBUILD_DLL $CC_FLAGS $INCLUDE -c $1.c -gcc --disable-stdcall-fixup -mdll -DBUILD_DLL -o junk.tmp -Wl,--base-file,base.tmp $1.o -rm junk.tmp -dlltool --dllname $1.dll --base-file base.tmp --output-exp temp.exp --input-def $1.def -rm base.tmp -gcc --enable-stdcall-fixup -mdll -DBUILD_DLL -o $1.dll $1.o -Wl,temp.exp -rm temp.exp