[Openvpn-devel,v3] ssl_verify: remove script temp files on all exit paths

Message ID 20261119212143.5413-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v3] ssl_verify: remove script temp files on all exit paths |

Commit Message

Gert Doering Nov. 19, 2026, 9:21 p.m. UTC
  From: Razvan Cojocaru <razvanc@mailbox.org>

The file holding the client's challenge response was never deleted,
although the manual says it is removed after the script returns. The
--auth-user-pass-verify via-file credentials file was kept when the
deferred auth control files could not be created. Unlink both on every
exit path.

Change-Id: Ifbd6badab31a48653fa0bca7f086db058f83f891
Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org>
Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2191
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2191
This mail reflects revision 3 of this Change.

Acked-by according to Gerrit (reflected above):
Arne Schwabe <arne-openvpn@rfc2549.org>
  

Patch

diff --git a/src/openvpn/ssl_verify.c b/src/openvpn/ssl_verify.c
index 8641d15..75cda97 100644
--- a/src/openvpn/ssl_verify.c
+++ b/src/openvpn/ssl_verify.c
@@ -1372,7 +1372,7 @@ 
             "could not create deferred auth control file",
             __func__);
         retval = OPENVPN_PLUGIN_FUNC_ERROR;
-        goto error;
+        goto done;
     }
 
     /* call command */
@@ -1415,7 +1415,6 @@ 
         platform_unlink(tmp_file);
     }
 
-error:
     if (!session->opt->auth_user_pass_verify_script_via_file)
     {
         setenv_del(session->opt->es, "password");
@@ -1487,6 +1486,10 @@ 
         tls_deauthenticate(multi);
     }
 done:
+    if (tmp_file)
+    {
+        platform_unlink(tmp_file);
+    }
     argv_free(&argv);
     gc_free(&gc);
 }