[Openvpn-devel,v1] openvpnserv: zero name server bufs with ZeroMemory

Message ID 20261121094633.28585-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v1] openvpnserv: zero name server bufs with ZeroMemory |

Commit Message

Gert Doering Nov. 21, 2026, 9:46 a.m. UTC
  From: Heiko Hund <heiko@ist.eigentlich.net>

The buffers in GetItfDnsServersV4/V6() are NUL terminated at their
start and their end at the start of the functions. For better
readability use ZeroMemory() here.

Change-Id: I1249834b1899461bc8f01e848bea95e30decf60c
Signed-off-by: Heiko Hund <heiko@ist.eigentlich.net>
Acked-by: Razvan Cojocaru <razvanc@mailbox.org>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2236
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2236
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Razvan Cojocaru <razvanc@mailbox.org>
  

Patch

diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c
index 7ea88a1..6c290ef 100644
--- a/src/openvpnserv/interactive.c
+++ b/src/openvpnserv/interactive.c
@@ -2177,8 +2177,7 @@ 
 static LSTATUS
 GetItfDnsServersV4(HKEY itf_key, PSTR addrs, PDWORD size)
 {
-    addrs[0] = '\0';
-    addrs[*size - 1] = '\0';
+    ZeroMemory(addrs, *size);
 
     LSTATUS err;
     DWORD s = *size;
@@ -2224,8 +2223,7 @@ 
 static LSTATUS
 GetItfDnsServersV6(HKEY itf_key, PSTR addrs, PDWORD size)
 {
-    addrs[0] = '\0';
-    addrs[*size - 1] = '\0';
+    ZeroMemory(addrs, *size);
 
     LSTATUS err;
     DWORD s = *size;