From patchwork Sat Nov 21 14:48:45 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5760 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:91c9:10b0:11b:d6c:f273 with SMTP id tl9-n1csp622895lad; Sat, 21 Nov 2026 06:49:02 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErF1Z47KGPfZ0GXO3pokslafo+OwiGchfeRg89WjPzl91j49cDRNkRdUCdm63LI76cNXkCN42dt17DA=@openvpn.net X-Received: by 2002:a05:7300:50fa:b0:383:9f52:e54d with SMTP id 5a478bee46e88-3856ff52e83mr7110432eec.8.1795272542526; Sat, 21 Nov 2026 06:49:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1795272542; cv=none; d=google.com; s=arc-20260327; b=cDzzkUvgqCvmTckTUDJXpngCNqTFjs5IR+8hTxBZ+7NJW5EQuQOvNM2ha32eNxINM6 8Gbffy+EulGCAJk8pzySOqnB/tKGR/1U+vBOosZ6H/ewjTnPXdVdcMt0SitDeVJ3M8V2 8LuSKtYvx51dh/VWfaLs2rNpJpmRDe/n/KxJhJTx88ODm8MhQs+GOa2Dag0TV55IAfM0 54ZOF/UX11yP9IkEMUzrbY2Nw+pEGbOgEt+LqNpWPsKnpuDK40+ZONM6KHJyJQQHCT3l gQ28klPtsG3/TFeuFtIXuwr3h0zDoC1POr/+SZtm3sTUMcQKaubDXFe9ALk9wzVXw92K t31Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=QXdexjyhUms8YpzSN4kd2J7CiZjG/1U78E/5ojZKe5E=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=HOhDHtBJue0aSU/MqM5KrGrj+vzh7HykNFFpOAzQyIPmnsJK2OT5KaOH1iCkOPI6uc TMjCa8WtuboNwH6mp9H78ggLgSGTOMt9TMd0lDeWL7tsRBG3aZhzMBDL9555AKm4VHON UiUPziVl7YFgQ8k/E0m3gNC7hMPUhhy/QmN43QPyPH4N5lysBZN5uWhluYulGoeLhcCf QydBL2nAsiiaIjpIEDL6kJrtgp3kiV+Qxhbt48/0cZ2sZipCUIkOvHYyRDYKgK+A0qyG n5sKiVh7oY5vA+wjCPUqwnulLRUKSLx5oRX+9IJgt1w6PCxmZ3TvQPdsn2FlR276COZ9 fdqg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=lyehIDWz; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=m8BxN5ur; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=V6mIEDwm; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5a478bee46e88-385669def3dsi16171092eec.16.2026.11.21.06.49.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Nov 2026 06:49:02 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=lyehIDWz; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=m8BxN5ur; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=V6mIEDwm; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=QXdexjyhUms8YpzSN4kd2J7CiZjG/1U78E/5ojZKe5E=; b=lyehIDWzeDy9Y8 v8WTxdL8y/oHaOtoKDVYqBRkXBKmCl2iSIvafKuNZ48UUi8+uE2xmmqjt+cHiqx5Xb2EueJiY68QN jUeW3vbRNmjWjc2n3zetCzRwXeNJ/UA7DvLuY8E/XLRWcnngGpKoeTMsYZw08Ywfv4mOvggdftLMf LCw=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xUmOj-000000005Zg-1Hsq; Sat, 21 Nov 2026 14:49:01 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xUmOi-000000005ZZ-0P1M for openvpn-devel@lists.sourceforge.net; Sat, 21 Nov 2026 14:49:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0ExzMidO66lj0vuL3MgyZGbWd/tbloxlU1w3SDdMzgI=; b=m8BxN5ur/3ONH73ElXzytdCxFE csfHb7vcSi1VoStqTQL9SSP+bcgnIwlpnsgQCVQ6d6rcK3vK2BV+p4N7S0EvZX4w9b0MhXcG2n44u W7otKiYg5PNRV27HLtzwfuYgVsX82lYd0O5DxQ8phtFq/SU078/n0xzXoqxlIRZCS4t8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0ExzMidO66lj0vuL3MgyZGbWd/tbloxlU1w3SDdMzgI=; b=V6mIEDwmE/1tnYno1nRa9DHsTE jpWvaptyjJny0cO7OTL2W6DH9s+Ald0LFVXbzp43AAKO9hyLWke/p8uQg2iuVPOeE/1EMAQqPQEy6 VaAs68tUMGXZ227gKMwLwhT9KUUYM5Jv1Wc/iwqEUmDGBhLHn6TDe1fpANirHKBpY0AQ=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xUmOg-000000004Rw-19Vs for openvpn-devel@lists.sourceforge.net; Sat, 21 Nov 2026 14:48:59 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6ALEmpAD026747 for ; Sat, 21 Nov 2026 15:48:51 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6ALEmp13026746 for openvpn-devel@lists.sourceforge.net; Sat, 21 Nov 2026 15:48:51 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sat, 21 Nov 2026 15:48:45 +0100 Message-ID: <20261121144850.26734-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Razvan Cojocaru add_block_local_item() allocates the routes without clearing them and left table_id unset, so the routes went to a garbage table. Use 0, the default table, like the other internal routes. Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xUmOg-000000004Rw-19Vs Subject: [Openvpn-devel] [PATCH v1] route: initialize the table of block-local routes X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1882479701411509049 X-GMAIL-MSGID: 1882479701411509049 From: Razvan Cojocaru add_block_local_item() allocates the routes without clearing them and left table_id unset, so the routes went to a garbage table. Use 0, the default table, like the other internal routes. Change-Id: I1d516b1acee3edc2a69c670d62f49e3cd34d6dc7 Signed-off-by: Razvan Cojocaru Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2227 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to release/2.7. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2227 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 4dfdd5f..5b1d012 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -557,6 +557,7 @@ /* split a route into two smaller blocking routes, and direct them to target */ l2 = ((~gateway->netmask) + 1) >> 1; r1->flags = RT_DEFINED; + r1->table_id = 0; r1->gateway = target; r1->network = gateway->addr & gateway->netmask; r1->netmask = ~(l2 - 1);