From patchwork Sat Nov 21 14:53:59 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5761 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:91c9:10b0:11b:d6c:f273 with SMTP id tl9-n1csp627543lad; Sat, 21 Nov 2026 06:54:17 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErECTi0pIpdv+Urt2hdQDmam5y9PKaxfcsSZB+jH7B0q/LI1yrzSaWZ8LGHqDBF96fqUyDTfmVmEqj8=@openvpn.net X-Received: by 2002:a05:693c:41cb:20b0:384:4fb:510 with SMTP id 5a478bee46e88-384b4e7510dmr7988639eec.27.1795272856825; Sat, 21 Nov 2026 06:54:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1795272856; cv=none; d=google.com; s=arc-20260327; b=lgp6xQLx2wgOb3ZAH8eLbei9Q7qPz473iMs8uFTd15sTkoChxVScsbyY/kiCjQy8iy jxWzDX6A1/sEbYwqvrT+30XipSCu7449ngXoT5QAL/w3c6ulUx/fhd1TMKKdxgvsyVEo 7qvcM2B5wuxzoSQ7lfpRijqftnttTvZjJidYRW9qG8Y9LCMrUDxRB0q8ZHK2T0hmx+Ck a2Yu2uvM7rfs5Kn/LDH5QKaCI/wlfBh2iKJHi89YOAfuL663LeHwuZLNl6WaUkpoqcAD cHu+gTcN2ThhSrmZ0FjJhgm71Glbnr525S3DcBQuW60WrzG2tV9FKbShULCw9DWTPaYG E1MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=uIYy1B0N/QZRP0Yn7TGXp2/j4p8pEE5YU2+It8HWTpA=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=AGvh/++OhXuPf+yird7GH7uJLp3io7QKFTTE8lgP+/Ce8InHEcA7bsa5Q16XvfJ6En owPRfqxSDr52SWuOKyo3J/YbefardvrAXbmD9Gydh2/Wn7H0E7QndlYQqnpTBQOPxjkE ZFKzW3PKueYImiRwy9yamU98Cr7fBIQdN93l2buNFrDmXtfihbueDL+yiZLToqXJDqk+ XZyR4+7w5S+YCbzxMuTaDe5sZsdSHfrC0DTaaw6HtHmWpodYAhsK5V+pd8LyO3wN06ze eKR+t/35ugnu8u6pqGpRvBwMMK80ErjEv88aApH9qK0GmcZuZbbUAdZ44akeI1HBZaGq ofeg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=RXYUzybS; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=N2Wqa0XD; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=jRbmXBhi; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5a478bee46e88-3856476816bsi14359147eec.2.2026.11.21.06.54.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Nov 2026 06:54:16 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=RXYUzybS; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=N2Wqa0XD; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=jRbmXBhi; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=uIYy1B0N/QZRP0Yn7TGXp2/j4p8pEE5YU2+It8HWTpA=; b=RXYUzybS37gxSx +uFMKhlECYGSip90NaFAfLeukFd8wUu+y92/A+HF0iRSsezFmBZWVmjYDHd0BNrttTQy88Ktbk3ZS Wsx/8MO6Yhl7kKXkB8PXu0u2PO90uBHx1jv8DIR3GTJXMNmtbj4gXZxwTPBR/rwiAcqk154ZUn6r/ Y/Q=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xUmTm-000000003xs-2NNS; Sat, 21 Nov 2026 14:54:14 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xUmTm-000000003xl-0e6T for openvpn-devel@lists.sourceforge.net; Sat, 21 Nov 2026 14:54:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BL/QwEcqxJj3rVEKsIdGmWXUopJ1I4UKZHNIIcBI5+g=; b=N2Wqa0XDoBe/Ko8KQbIyco4hNd +4C8ROAw/4QhJtS6WnyZV8ZiBhzmIJBBE5eBu/gCNBrRB2EfoI7FzzhzOLUQKWsuisl5mOKi2p9js yYyWWKqUJ9Ut8hCEEYGV3vzuw6/X8Pi+6DXivSogoK5W5O4ZZ3kYPdJr3NEj0hVP5504=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BL/QwEcqxJj3rVEKsIdGmWXUopJ1I4UKZHNIIcBI5+g=; b=jRbmXBhiJTsVb9Cy41gORKT9lo 3wc2bXJ59KWy9qsKaABRHt2bvK6iLHqo+8YELeVRFBknp+17QHo7yXuKNILGtLOUKjLQgnbu6RX9i l/RMlaHAabnofL7SDRDup2DGLR1/K1AzOApyWh0AbYuG+hLg34lFbJzEP+aFeI6JHJwQ=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xUmTl-000000004Za-11W9 for openvpn-devel@lists.sourceforge.net; Sat, 21 Nov 2026 14:54:14 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6ALEs6Gh027292 for ; Sat, 21 Nov 2026 15:54:06 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6ALEs6SN027291 for openvpn-devel@lists.sourceforge.net; Sat, 21 Nov 2026 15:54:06 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sat, 21 Nov 2026 15:53:59 +0100 Message-ID: <20261121145406.27273-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Razvan Cojocaru Unlike --route-gateway, the handler never called VERIFY_PERMISSION(), so the option was accepted in any context (, ccd, inline) and was missing from option_types_found. Require OPT_P_ROUTE [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xUmTl-000000004Za-11W9 Subject: [Openvpn-devel] [PATCH v1] options: check permission for --route-ipv6-gateway X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1882480030940402761 X-GMAIL-MSGID: 1882480030940402761 From: Razvan Cojocaru Unlike --route-gateway, the handler never called VERIFY_PERMISSION(), so the option was accepted in any context (, ccd, inline) and was missing from option_types_found. Require OPT_P_ROUTE_EXTRAS, as --route-gateway does. Change-Id: Ifc72b3677056dd089b8c6cfae4bd07911b6f8407 Signed-off-by: Razvan Cojocaru Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2228 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2228 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/options.c b/src/openvpn/options.c index e51ece7..2068393 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -5350,6 +5350,7 @@ } else if (streq(p[0], "route-ipv6-gateway") && p[1] && !p[2]) { + VERIFY_PERMISSION(OPT_P_ROUTE_EXTRAS); if (ipv6_addr_safe(p[1])) { options->route_ipv6_default_gateway = p[1];