| Message ID | 20261122111940.31671-1-gert@greenie.muc.de |
|---|---|
| State | New |
| Headers |
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net>
Delivered-To: patchwork@openvpn.net
Received: by 2002:a05:6022:91c9:10b0:11b:d6c:f273 with SMTP id
tl9-n1csp1482141lad;
Sun, 22 Nov 2026 03:19:51 -0800 (PST)
X-Forwarded-Encrypted: i=2;
AL+hErEfyrX2hQZAztCNh3QJjRTplalJ800mrhq8MTfjpQt5igz30fxXPQFeqaICA6dWTS35sVZyGg5Eknw=@openvpn.net
X-Received: by 2002:a05:7022:1504:b0:1b5:6e28:a2a6 with SMTP id
a92af1059eb24-1b56e28a3ccmr1734379c88.9.1795346391011;
Sun, 22 Nov 2026 03:19:51 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1795346391; cv=none;
d=google.com; s=arc-20260327;
b=bnXe0t3sHAiE4U9UWnDs4yzG4wzAwoKLE0FalZVZEXD67yh9Y4n3NFlA1+43vUUlLz
2wl8tzg9lyOxJFAkkkV1yVBo8TdO6IEYMt86052zAX2py7oWugRzIB6/SvGqKV5DzJoD
AEEuuR5atoBLMsGVSet9WlyCx7kJkpAfSTpFbGkZmxmIX+iFpwSJ+JjHWd3xKW0mjzFa
NzvVPQOfO8TA0zKE76ro2y9fWG4Dy78MOV52r76GFv7UC1L1HR+SWoE8KA8VabEKuR7q
aNiYmvJV8L7aPafWp5SrOf++BpI1DO1j1dfRGj6mC2ev1S8uMpl6dkawZyE083HCaIR0
R7gQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20260327;
h=errors-to:content-transfer-encoding:list-subscribe:list-help
:list-post:list-archive:list-unsubscribe:list-id:precedence:subject
:mime-version:references:in-reply-to:message-id:date:to:from
:dkim-signature:dkim-signature:dkim-signature;
bh=Lu7Jy1FNAANH34hjFGxWTFjYIdPzfSLD2hUemck6T8g=;
fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=;
b=Yf2X0y6CaTuI8tk4YMXp6c3XcKCBu625XxhPi6XMRQPl77J2gdCqZsC2ZuUcBulFqo
/Ac/K+TDxhImbLOjZljt+96CaG/oBj3u532ywS/9XJhl1iShAzDt6FQwZR3jYbm/C8RR
A7vgAG/AhKsFoShX+jKdZkmgcw0wswbwt8QhgICBOlFTltIOZNs2roraBu1qy2U2yucd
GRbLgkxa84wzwS6mwb+lwGzSVv8mIrJm5Urb6FI3KVNTzsyxzey46vRP6NC+BAxmh+Zm
PSMTcfaxeeuh9QWGHXCBJUJUI2i/p3dOuhwxtDvC25QxLhrjg5T/M6s9jYENeSBz8vl0
yMDg==;
dara=google.com
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b="bp6K/jyu";
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=S9TZe5iz;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=dM8Sz3dU;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7])
by mx.google.com with ESMTPS id
a92af1059eb24-1b55680e660si24427710c88.44.2026.11.22.03.19.50
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Sun, 22 Nov 2026 03:19:51 -0800 (PST)
Received-SPF: pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) client-ip=216.105.38.7;
Authentication-Results: mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b="bp6K/jyu";
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=S9TZe5iz;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=dM8Sz3dU;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:
List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:
Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender:
Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post:
List-Owner; bh=Lu7Jy1FNAANH34hjFGxWTFjYIdPzfSLD2hUemck6T8g=; b=bp6K/jyuvKyo2S
naLRmQRGHgyBn4H+lZbSYIohyC5JunvBiFff50g0p5Q6PhTlTgTX8KZuuknN1cb+GBK/y08SMPFVH
i5/hULDVKEKRmjtrNU8rfjlWhiKFuqIvb3fSU1yPAvSo1990uYYE7cGQq9FAWwGNSJYLts0yRUGLu
8+A=;
Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com)
by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.100.1)
(envelope-from <openvpn-devel-bounces@lists.sourceforge.net>)
id 1xV5bp-000000007Ox-3rtc;
Sun, 22 Nov 2026 11:19:49 +0000
Received: from [172.30.29.66] (helo=mx.sourceforge.net)
by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1)
(envelope-from <gert@blue4.greenie.muc.de>)
id 1xV5bp-000000007Or-1rCh for openvpn-devel@lists.sourceforge.net;
Sun, 22 Nov 2026 11:19:49 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References:
In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=D3Ip1vqHM5R91g4weBgnfd7D76Im/6vyTRwCjqBawW0=; b=S9TZe5iz2BaWQT8GMcgqda7Q+x
vxl4Uij1FeJfXgGE4+BjVD0945YE+dQ686NVjflx6SZv++BcLHkerZNAIrbvro8WbXbQKKnqM2rvE
5Tja0p8Fe52TR4oubryoAuRD8bKZ2dZ1N5bP/m4EGs01ka3bV8JyaR6cnPwt+2t7wp7E=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:
Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=D3Ip1vqHM5R91g4weBgnfd7D76Im/6vyTRwCjqBawW0=; b=dM8Sz3dU2bG8gdprpBwXZVwhoN
ZRJYDKiHflIW8u8csshwOIJBualxeCftgAIfJn9ht5LlV5VqbDRZucMCWY7m9iPvlKCvZ/tIjs1np
hN+aAphvFf+UPOmfcLPUj9lKfOcna4Lk902/5Zj4AphDigBrIZzhq1ggHDCwiy2S2EnQ=;
Received: from [193.149.48.129] (helo=blue.greenie.muc.de)
by sfi-mx-2.v28.lw.sourceforge.com with esmtps
(TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1)
id 1xV5bo-000000005Pi-1bSr for openvpn-devel@lists.sourceforge.net;
Sun, 22 Nov 2026 11:19:49 +0000
Received: from blue.greenie.muc.de (localhost [127.0.0.1])
by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6AMBJeoQ031708
for <openvpn-devel@lists.sourceforge.net>; Sun, 22 Nov 2026 12:19:40 +0100
Received: (from gert@localhost)
by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6AMBJe42031707
for openvpn-devel@lists.sourceforge.net; Sun, 22 Nov 2026 12:19:40 +0100
From: Gert Doering <gert@greenie.muc.de>
To: openvpn-devel@lists.sourceforge.net
Date: Sun, 22 Nov 2026 12:19:33 +0100
Message-ID: <20261122111940.31671-1-gert@greenie.muc.de>
X-Mailer: git-send-email 2.55.0
In-Reply-To:
<gerrit.1795207472000.I1d36996218c3c61f1f16e2c97f922afa66df6b66@gerrit.openvpn.net>
References:
<gerrit.1795207472000.I1d36996218c3c61f1f16e2c97f922afa66df6b66@gerrit.openvpn.net>
MIME-Version: 1.0
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software,
running on the system "sfi-spamd-2.hosts.colo.sdot.me",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: From: Heiko Hund <heiko@ist.eigentlich.net>
GetItfDnsServersV6()
added a separator between addresses even if only the terminating zero still
fit into the buffer, overwriting it, and relied on inet_ntop() failing with
a zero size buffer afterwar [...]
Content analysis details: (1.3 points, 5.0 required)
pts rule name description
---- ----------------------
--------------------------------------------------
1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Headers-End: 1xV5bo-000000005Pi-1bSr
Subject: [Openvpn-devel] [PATCH v2] openvpnserv: check room for the DHCPv6
name server separator
X-BeenThere: openvpn-devel@lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <openvpn-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive:
<http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel>
List-Post: <mailto:openvpn-devel@lists.sourceforge.net>
List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: openvpn-devel-bounces@lists.sourceforge.net
X-getmail-retrieved-from-mailbox: Inbox
X-GMAIL-THRID: 1882557137001310094
X-GMAIL-MSGID: 1882557137001310094
|
| Series |
[Openvpn-devel,v2] openvpnserv: check room for the DHCPv6 name server separator
|
|
Commit Message
Gert Doering
Nov. 22, 2026, 11:19 a.m. UTC
From: Heiko Hund <heiko@ist.eigentlich.net> GetItfDnsServersV6() added a separator between addresses even if only the terminating zero still fit into the buffer, overwriting it, and relied on inet_ntop() failing with a zero size buffer afterwards. Return ERROR_MORE_DATA before adding the separator instead. Change-Id: I1d36996218c3c61f1f16e2c97f922afa66df6b66 Signed-off-by: Heiko Hund <heiko@ist.eigentlich.net> Acked-by: Razvan Cojocaru <razvanc@mailbox.org> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2234 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2234 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Razvan Cojocaru <razvanc@mailbox.org>
diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index 24705a9..32b1688 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -2256,7 +2256,12 @@ { if (i != 0) { - /* Add separator */ + /* Add separator, if there is room for more than the terminator */ + if (s < 2) + { + *size = 0; + return ERROR_MORE_DATA; + } *pos++ = ','; s--; }