From patchwork Sun Nov 22 11:38:17 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5764 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:91c9:10b0:11b:d6c:f273 with SMTP id tl9-n1csp1495616lad; Sun, 22 Nov 2026 03:38:34 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErGD4MLsacDkkj1fyIqoMVIcefWGPb44QHg7bOIcKRelItGtWW1LNPnHf2NmHXXFFOGRoWgZrxwDh98=@openvpn.net X-Received: by 2002:a05:7301:1a84:b0:386:abfb:4a2 with SMTP id 5a478bee46e88-386abfb1a83mr890392eec.11.1795347514118; Sun, 22 Nov 2026 03:38:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1795347514; cv=none; d=google.com; s=arc-20260327; b=RsIkO5GeZhIXEXkYvVje/XeAUJ4kBXTNMCL0gdjN8oHOyxvBPK+qIw3w1MeeANXgOM CyF7QhwS8N2mEGdBLTMgCFPT4CYq0t7GMnww3asbxFK4/zK4Omz3vFbViTD84lgVl4Yx 0vOiai52QxQ18Ej9IHHvL251vTSu/ICFSipJvIWzfYJKaxCXvUk0Sna8t0BFatuEJss0 aZOGj5BvjSzX+ehBQgFqdOBXKFyFN4KKGgFFv0/6pD/j9x0fnBs2ALOwupZZEAJSvrxY Ii+YXHbstr3Ek65t7ptJzmNXkrLfuzO6za5kYhBa7DLicj7uz9Ff9u7kV5318lafNvp5 cgWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=1+Cl736hVRNohe6U0gZAc8+jfUvnkMDaS+VNqzQOurE=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=MyCQMrqpTy2oyGQUQzKcQablHqS0beuAJtBZuS4ZgISGgBhBSzLTLoRE715AAuU9E6 bQsmGZJoB/SuLWHGolSDS6B0OqLFYKZMm2PwzE53s/mMYJL/3XMvPQr+iMH2hqB50A0Y 325Kv+ApFtrBBDp9it7p1PBC9LMJPPAno1CJ8cHxG/s/qwBco17w5Lmg7G/wQ1gE0KFh 97TfHlEqkCGZuwwTp2wj4MUowHxs6uk32qeciVn5vQOC9b46tLgVvCJ0tdJ8fB1Srk1Y 4Zh+VKjMe1x4l8BT5zkdAPSXPKTlSycYgN6njLO4oprO6O7D+8uqm35/b6ZUuB90xulp Rm8g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=JIrwgVte; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="An4VP/Sv"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=QoglTbl7; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5a478bee46e88-38564768973si22726456eec.4.2026.11.22.03.38.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Nov 2026 03:38:34 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=JIrwgVte; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="An4VP/Sv"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=QoglTbl7; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=1+Cl736hVRNohe6U0gZAc8+jfUvnkMDaS+VNqzQOurE=; b=JIrwgVteFPvVdd Neeliq0ltxW/UcVxLHJFvubGBgQWQE+iy72tihRIwBQ2QcyGKDsB5cPNfq3aoFjcQ6QjlaiC3IjbH 7hMW6goSCJXomN+o+eBSjobMN1+a1Zf/HXnLCR2peTqIpk1qIuogngRcCp1V0VUwgxgdS8sP7LEaA Znc=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xV5tx-000000004Hu-1CPo; Sun, 22 Nov 2026 11:38:33 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xV5tv-000000004Ho-2HuR for openvpn-devel@lists.sourceforge.net; Sun, 22 Nov 2026 11:38:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cYw5mMPiylWhi8c/a3QM4fNQuzYTMlv161qZ72KFOs8=; b=An4VP/SvfyBt7Gk0R/+cMRIYep HTLUYJ8QBXNhFppyg4ORmo3vAkdrHBR37rIgycpv1jJyqzAX8+R/VKL3nTp/XaE3YauHb8ZJQRXFQ p1C3E9I6czfCSNIsjjCkt0ge+z6OZ3xZwQwsCI8q7wmG4UN97SxYeX5v3G6+pajz4TMY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cYw5mMPiylWhi8c/a3QM4fNQuzYTMlv161qZ72KFOs8=; b=QoglTbl7s8YuPAXP3zo4DLTsAn ULoylDg1b5vYYpS9kuIIkKCopV6JQA+1eG2WiN0FDiOoEfww/CNTsp5dIxKNwRh38MZGUyblPATT2 ARJGPbDP/XDqVQf9Q9BOgeuawVfcuF7/edJXXcsy3eOGngm3d4TuKqp4SCuLh8J1/J1o=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xV5tu-000000008HR-1Eue for openvpn-devel@lists.sourceforge.net; Sun, 22 Nov 2026 11:38:31 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6AMBcNN5000721 for ; Sun, 22 Nov 2026 12:38:23 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6AMBcNsD000720 for openvpn-devel@lists.sourceforge.net; Sun, 22 Nov 2026 12:38:23 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Sun, 22 Nov 2026 12:38:17 +0100 Message-ID: <20261122113822.710-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Razvan Cojocaru These printed the same SUCCESS/ERROR lines by hand. Output is unchanged. Change-Id: Ied65202d269dedfa7ce69e62ef68d775ec0da36c Signed-off-by: Razvan Cojocaru Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/ [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xV5tu-000000008HR-1Eue Subject: [Openvpn-devel] [PATCH v2] manage: use report_command_status() for client-deny, client-kill, push-update X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1882558314980491999 X-GMAIL-MSGID: 1882558314980491999 From: Razvan Cojocaru These printed the same SUCCESS/ERROR lines by hand. Output is unchanged. Change-Id: Ied65202d269dedfa7ce69e62ef68d775ec0da36c Signed-off-by: Razvan Cojocaru Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2231 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2231 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c index 86c498e..ab814d5 100644 --- a/src/openvpn/manage.c +++ b/src/openvpn/manage.c @@ -1286,14 +1286,7 @@ { const bool status = (*man->persist.callback.client_auth)( man->persist.callback.arg, cid, kid, false, reason, client_reason, NULL); - if (status) - { - msg(M_CLIENT, "SUCCESS: client-deny command succeeded"); - } - else - { - msg(M_CLIENT, "ERROR: client-deny command failed"); - } + report_command_status(status, "client-deny"); } else { @@ -1312,14 +1305,7 @@ { const bool status = (*man->persist.callback.kill_by_cid)(man->persist.callback.arg, cid, kill_msg); - if (status) - { - msg(M_CLIENT, "SUCCESS: client-kill command succeeded"); - } - else - { - msg(M_CLIENT, "ERROR: client-kill command failed"); - } + report_command_status(status, "client-kill"); } else { @@ -1523,12 +1509,7 @@ status = (*man->persist.callback.push_update_by_cid)(man->persist.callback.arg, cid, p[2]); } - if (status) - { - msg(M_CLIENT, "SUCCESS: push-update command succeeded"); - return; - } - msg(M_CLIENT, "ERROR: push-update command failed"); + report_command_status(status, "push-update"); } static void