From patchwork Tue Jul 9 13:32:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3759 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:298e:b0:59e:d24b:d55c with SMTP id f14csp2431284max; Tue, 9 Jul 2024 06:33:16 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWpcomId8IoHQsa0jLFB6NmkQsNBViyRFpRuJYsi8p9PzMOsZVPOamHHPQV+MyZwvRWvhRpRfN/yNqd5u4I79aKcnzeXCQ= X-Google-Smtp-Source: AGHT+IEo/c8wlo5cqeNiCBmVt9rh2atrAMp3/3EGQmslWDcd9YJX6LUVFlJGST/yBILDDwFM//qH X-Received: by 2002:a05:6a20:dd83:b0:1c2:8ad4:35db with SMTP id adf61e73a8af0-1c29820ed1cmr1977139637.1.1720531996509; Tue, 09 Jul 2024 06:33:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720531996; cv=none; d=google.com; s=arc-20160816; b=z0dABkDmQPebynIz+2n3IDelclvq3KAqVMlEtHftQNoI4PtCIMdlFtDWGVIatVcngQ CltBzP1suETUfbBk41QiEj3+CicxyTX8h1DspnLSA7/moBuV1VqVyzIpTApUYDJbvrze VIZvd2FMf1Yc0xZBCrdldEkxs2Csm61yW/OuxLgXTjjynONGak4vBP6AivACeK4U4hOX ifS1Pqr+7eRG1ngjd8RL6FiFijno+Yh+cjrkVenQe9BGGvYuXR3phiDiwt4MfqBCP4k8 VqOQshTt2FZsLYlNSfKDfQM+/pgMMi81z2MfzSGDkzBPUBcxGC5A7HUHN0Yqde2ipqM/ yF/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=WQX9Ju6F03gfnl/+Nev9RqQQnMlA4DNy6RtFGd6/NlY=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=N3gN1cEY/c5KwgKe0OOIWR16IbukYWErpLg/UwMpnQXA5WQk/IleFyXFKwVmo+itQm WeCYqIIk+TlBebcO6flpfmkxViUuQOKAPcWcWoTW45sK5i/2Ccstp/VOuEW9/cm3hsZz SfCPlQU3JifaSPjYvXY5AI5xQZXPrDo+P36xhyYUd04Zs3MXLZuDEplFdflTJB//kcNN MjAdrpPyGZaL2Zi61xVhcC6oZDCIT/kq+4ndu7YnZN2xqhRZSzwiAElfaowoQkj7dp68 h911DZTUTQgdwPJIJ2h0xCyNxtYhGkyfKia+v0qL/A031B6T5JYqBKAgyk98eypgGuuC 3CRQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=gIz5hLgl; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=PXSxysU5; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=YSMDt+wC; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id d2e1a72fcca58-70b438e1793si1988328b3a.273.2024.07.09.06.33.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jul 2024 06:33:16 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=gIz5hLgl; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=PXSxysU5; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=YSMDt+wC; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sRAxe-0005Vv-3I; Tue, 09 Jul 2024 13:32:51 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sRAxb-0005Vm-QL for openvpn-devel@lists.sourceforge.net; Tue, 09 Jul 2024 13:32:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=70hNlRGLqg1ffjl9mTHCgFWvKXuNIZEFgZzjEQpxmbo=; b=gIz5hLglsuemqcEQa7mBiVyvpk YedVRhFHX+hb/SEFDBBlFC2cLlcwb1GwSK0nF0gWEuCBT+GTZUVMlwKYapPBoScEPVu+WQt3RsPxa 7wQp+j3ppS3pxraFZUrJgvsisyD4mJZSWPV0MzK5w9JmAZfYsRBaflsoBcPSZ2f5tlRY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=70hNlRGLqg1ffjl9mTHCgFWvKXuNIZEFgZzjEQpxmbo=; b=P XSxysU510HV6lkcP3j9SNkprMsxbFw7DfvjjymQ+oWyjJt5godC8UxredoOaNAdMJnOwQjSvZ/opJ Mumd7waE1c3mQJtAUpRye//WioBMeQRGeNdDOF3kXOuGNJU3RW2W0T6Vblk/K/AqOZSh0uQ6yLVuj nkQdvznFvzBN2hmA=; Received: from mail-wr1-f50.google.com ([209.85.221.50]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sRAxc-0006Gy-Ua for openvpn-devel@lists.sourceforge.net; Tue, 09 Jul 2024 13:32:48 +0000 Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-36785e72a48so3063404f8f.3 for ; Tue, 09 Jul 2024 06:32:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1720531955; x=1721136755; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=70hNlRGLqg1ffjl9mTHCgFWvKXuNIZEFgZzjEQpxmbo=; b=YSMDt+wCb13LB1dsdfsOzLCxwhQaiEOGUIn3IoomEBpGZRQnyyM25UM7GJvcvLbeeR HDRHwgWcV3czxu2HiuvOpw6v7CPLMj0GY3MrQL2H8TlyJ7oxFwtjkqE8eER6THM4Ah+l Wshx/zlaG+RNdwMPcHUKxy49FJifcWWSHTc+TG6TRXQQkxLLDQuLqMfx71JdZ3SW8xWv g/EPQVXl/s7q4fkuqrAAlWM4ku1MfYJw/A3FXHGhgo8DdbTbmtx8uaSTMnN1htNDeqF7 /KoNGS7kny0+qtsFG9JRKJZy8h0fapEpUmM7O2Ft1jGHWdxEH/TmghethyedkeXxvXsK nV6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720531955; x=1721136755; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=70hNlRGLqg1ffjl9mTHCgFWvKXuNIZEFgZzjEQpxmbo=; b=M7hNLD7dSw6F9ok5oUW6dctIVki0+/OBmpvCrIXvdHEswQheHQseOY+58wFwK4Pf8t neUqj047sB1iFPOKYp9FqYIEtIEHKs6rpGTsU52BYYzKPvRu3rhvN1++j+uTG6oDJ3ug 7DE+5bbiSWTvEq89DrO+exxRkRLbZSncNcdiKzqkFo6NNvmFD2HGDBPR1S0ObZoj1+6k lg1n7gUCreoHPWaSQrZNW+UI6RU56LVvgW+cYp39eIZp2wHA1AjDRKEcMDlNntkJmeWD jhItDS1mm/lEPYjEMVX0/qHhfhLRxKlE/6DQglnJqxCKAMSHAxR3kLpznVKAUvvNrTv5 SdWQ== X-Gm-Message-State: AOJu0Ywz9JAT4pehaPv1hrstiwacxcmAg/1yL8hVTLwYwgJyJb1+qBgF wRFvKeZGBG+sf6dryIU0Nze3DmpplQ2I1kHOTvSplvh2f80G4tslLSlNqO1wdGTSmIx+Z7nSMj0 0 X-Received: by 2002:a5d:548b:0:b0:362:c7b3:764c with SMTP id ffacd0b85a97d-367ceac47bfmr1855523f8f.48.1720531955468; Tue, 09 Jul 2024 06:32:35 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cdfab16csm2570035f8f.93.2024.07.09.06.32.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 06:32:35 -0700 (PDT) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Tue, 9 Jul 2024 13:32:34 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I72934e747d1ad68a7e3675afbeb1b63df7941186 X-Gerrit-Change-Number: 673 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: e462bad4b519ec337a0f740e59fbf544519cef37 References: Message-ID: <204abeb47fc95a346c091f36f457648d44fa5a81-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.50 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.50 listed in sa-accredit.habeas.com] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.50 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1sRAxc-0006Gy-Ua Subject: [Openvpn-devel] [XS] Change in openvpn[master]: configure: Switch to C11 by default X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1804108558485230874?= X-GMAIL-MSGID: =?utf-8?q?1804108558485230874?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/673?usp=email to review the following change. Change subject: configure: Switch to C11 by default ...................................................................... configure: Switch to C11 by default Mostly so we can use anonymous structs without jumping through hoops or relying on unofficial support. Change-Id: I72934e747d1ad68a7e3675afbeb1b63df7941186 Signed-off-by: Frank Lichtenheld --- M CMakeLists.txt M configure.ac 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/73/673/1 diff --git a/CMakeLists.txt b/CMakeLists.txt index f8b37a9..6f8bc72 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -119,7 +119,7 @@ set(OPENVPN_VERSION_PATCH ${PRODUCT_VERSION_PATCH}) set(OPENVPN_VERSION_RESOURCE ${PRODUCT_VERSION_RESOURCE}) -set(CMAKE_C_STANDARD 99) +set(CMAKE_C_STANDARD 11) # Set the various defines for config.h.cmake.in if (${CMAKE_SYSTEM_NAME} STREQUAL "Linux") diff --git a/configure.ac b/configure.ac index 5f72029..de67a08 100644 --- a/configure.ac +++ b/configure.ac @@ -421,10 +421,10 @@ AC_CHECK_PROGS([RST2HTML], [rst2html rst2html.py]) AM_CONDITIONAL([HAVE_PYDOCUTILS], [test "${RST2MAN}" -a "${RST2HTML}"]) -# Set -std=c99 unless user already specified a -std= +# Set -std=c11 unless user already specified a -std= case "${CFLAGS}" in *-std=*) ;; - *) CFLAGS="${CFLAGS} -std=c99" ;; + *) CFLAGS="${CFLAGS} -std=c11" ;; esac #