From patchwork Thu Jul 18 12:47:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3766 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:1886:b0:5a1:d4fc:4ac6 with SMTP id r6csp492366max; Thu, 18 Jul 2024 05:48:04 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV2jzrE+XOAqJPmmAnMKqVgqoffD/ESo7EktC5AAM+lQtSE7D+lZC0zAxUNdQfVVgakW90FNJ5fgRl6q9AvLIDkNYZbet4= X-Google-Smtp-Source: AGHT+IF1zZvXfZB1H5tp7auoF17TDhVPw6l/a1PVGujBh4OHVIPdb6J/XWAPgdA95t+eYmWscpEq X-Received: by 2002:a05:6358:50c6:b0:1aa:ae3f:1e93 with SMTP id e5c5f4694b2df-1aca9fae32fmr159744755d.3.1721306883988; Thu, 18 Jul 2024 05:48:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1721306883; cv=none; d=google.com; s=arc-20160816; b=C0NiDa7VK3iNhWRFE72vjKCz6kKiT/xE1ULL355xL9j5qcTFmtKtaFhFhdOG3yeacV uF7aN/gnXjBg2LIs+oMvbphur+ZfQdGcq9GuxhkRBPEY5kQr5wEMdsmKg08TePPqxFZ6 d1D4x7dkJGKy7luldEVvVqUbqUIOrqYrgVaiRI62SDuclln5LlejTJVbyKl+TZL1Cvvr HPfGsK0UazB5qor/YfC5tJbgVMH65y4RFDzrFdPYhoqxBbZk8mvymnQnn+dK8jm02Sse Y75xE0ZlrMnUHHTmKKWroDSNJUldnl8S1FXxk/VU76+UnCA9yeP6jlpvgtnE/g2z8PAt 0hUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=PWwkR+j9mO5ssHMngoEury8UHJWdisLChb13EHVJiEk=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=JCvdi7grr6Hho3kxRhpiSwjtRgrpLP8/ArQUCd8Nv4+Et0jRh0kp4BkJ3XnquIooaB 4vQrsGFW+17ExRf2LzdEtfDGEqeVkCf7S3IlQE8RHOhnHKSs/m7Nisdd9vtXUSAmuE2V ns9EyAP/imZ/P6oTfpHlYtb3+Hb+l4BZocYMC7cPLubm4e6q0Ks3ptG4415IDsGdtsn6 nIVu1jfmYaxsUoSiehu2SsjTd//iIinYEhAd1iKCKAwTlWomxl+aZoq4wKFvrqIwsqeN iPHrz9hUF42VQbbrumoDVnLb8qgNvJSSnZItWvWeLm62AcoPhWVYul1CTon1zcsV31Tx XOrA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Dw86ySul; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XdFyrWpK; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=Xtq8PsmI; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 41be03b00d2f7-78e43192cb6si11388510a12.446.2024.07.18.05.48.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jul 2024 05:48:03 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=Dw86ySul; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XdFyrWpK; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=Xtq8PsmI; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sUQXn-0007bF-1n; Thu, 18 Jul 2024 12:47:35 +0000 Received: from [172.30.29.67] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sUQXl-0007b9-Fd for openvpn-devel@lists.sourceforge.net; Thu, 18 Jul 2024 12:47:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sA9+yd9vr58RXCGB6rWSb4Ydhmom9DrLhrjCyEWLgi4=; b=Dw86ySulTzotyLADnGIe7U1inw hCntr9DqCWrq6coWB0vs0bq4ghYrY+1mxNAt1Hm6AUGo8nO1IKJFyZtFeHgykxenOUv1M9H2pKJyQ jiNPs9HeTG0efsUywKB1E7zHH9v/+IqNusvr+EV2RFwkF5W/9ttlIa4nzpAfic0ahRhA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=sA9+yd9vr58RXCGB6rWSb4Ydhmom9DrLhrjCyEWLgi4=; b=X dFyrWpKpSUzpf6IDr2bhO8NtJwBQCs7ihqs5Ng6OEui0JV1y67MCs9mEGOvMjdN3UdF2WGZoz/Nen IC430j4Nj/O7ImRQjimCC/BQVDwvw7IyJuX5LqSYzzrVU/NnKb+Wz1fSlxqBfMeeanvlsFZE479g2 JRwmiLaChPVKOJds=; Received: from mail-wm1-f44.google.com ([209.85.128.44]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sUQXm-0005UX-2d for openvpn-devel@lists.sourceforge.net; Thu, 18 Jul 2024 12:47:34 +0000 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-42793fc0a6dso2384875e9.0 for ; Thu, 18 Jul 2024 05:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1721306841; x=1721911641; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=sA9+yd9vr58RXCGB6rWSb4Ydhmom9DrLhrjCyEWLgi4=; b=Xtq8PsmIZ2fvAWVxSfQ0tHDmJs5JpNiMVi/n9rw6va/0/tSMlJIKXkw/zByYynrCrX MK+b7sZttSYthKt/i9u4EyxpLpa8/yo9yEIGM26orjQLcwHNZh/uGJwG2k79bKMCyM3p Cqt7+KiNasWrQzJBnma24ig5SRqAds0Wshb7x67WtXleS5Gl8iXsEZp6ttpjjVmAhzjT rICJty/X6gNPa8LJOSx6arMHGbNvzGcRakWcnjxMp0CEhF5IQUITy1kDtBvByVkZflq7 w8CLNe8FBZLq6hqn1L6xbmK0CTtTB1A3D9rg2zcf0I5GY7qtOX6l9Vhd76RKr5wKRA2b pW+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721306841; x=1721911641; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sA9+yd9vr58RXCGB6rWSb4Ydhmom9DrLhrjCyEWLgi4=; b=dM08IwPRiLxAR0+2jH+6eMwSPpe61uvNlc6gkxHD0r7NvCeYy/a9naYhIELssECphn IdvONZOv4I0Cj5qFEYeIQVit8auhBo9XX8itOVjJJuvDs6SkbKm6wwVD1wk1SHO4kPtk 9HjhB40wMq0bAlFKPnOhhqGapB/t96TKk8idRZnulsI1YBat9dTBIoUjmpdWojyZ/q90 /yRwsSkaOMLN2JP2LYkbn0liOor8No4xqI/iL4jNbXg6MK8ui/qTEeW9BQC8LCHdjgQD u3cwfL8Xd4aAJExh6n7bv1kp8NzegPCX2vud/2euj59XeG0FXI+YDMu0mrmKV7xtE25c 9D5g== X-Gm-Message-State: AOJu0YzPpbAziiDyGmAIrCeDpYJ391Dgjcia52cwOJcxMIY2dc102n5C FXDy/0MVr3lY0yMtb6zARFJ7yI1IpQaboIlp7tvUnDznaCnbfVRTDOKuFHwIIg81fzjJGdizOx6 W X-Received: by 2002:a05:600c:1c15:b0:421:7bed:5274 with SMTP id 5b1f17b1804b1-427c2cb409fmr35015005e9.10.1721306841576; Thu, 18 Jul 2024 05:47:21 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3680db047f0sm14203165f8f.99.2024.07.18.05.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jul 2024 05:47:21 -0700 (PDT) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Thu, 18 Jul 2024 12:47:20 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I44b9003143fdad90bfff7b2c86d0bb503f9157de X-Gerrit-Change-Number: 676 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: be258f8eb8697044c4b45b5b7ff386a50e8ae6aa References: Message-ID: <2354d1da61f66b6ef2e013d6446369ea93d592bd-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -5.2 (-----) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-5.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [209.85.128.44 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.44 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.44 listed in bl.score.senderscore.com] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.44 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1sUQXm-0005UX-2d Subject: [Openvpn-devel] [S] Change in openvpn[master]: Add Ubuntu 24.04 runner to Github Actions X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1804921087018760558?= X-GMAIL-MSGID: =?utf-8?q?1804921087018760558?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/676?usp=email to review the following change. Change subject: Add Ubuntu 24.04 runner to Github Actions ...................................................................... Add Ubuntu 24.04 runner to Github Actions Change-Id: I44b9003143fdad90bfff7b2c86d0bb503f9157de Signed-off-by: Arne Schwabe --- M .github/workflows/build.yaml 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/76/676/1 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index d7c3ecd..6e361d5 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -106,7 +106,7 @@ strategy: fail-fast: false matrix: - os: [ubuntu-20.04, ubuntu-22.04] + os: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04] sslpkg: [libmbedtls-dev] ssllib: [mbedtls] libname: [mbed TLS] @@ -122,6 +122,12 @@ ssllib: openssl pkcs11pkg: "libpkcs11-helper1-dev softhsm2 gnutls-bin" extraconf: --enable-pkcs11 + - os: ubuntu-24.04 + sslpkg: "libssl-dev" + libname: OpenSSL 3.0.13 + ssllib: openssl + pkcs11pkg: "libpkcs11-helper1-dev softhsm2 gnutls-bin" + extraconf: --enable-pkcs11 - os: ubuntu-20.04 sslpkg: "libssl-dev" libname: OpenSSL 1.1.1 @@ -173,7 +179,7 @@ strategy: fail-fast: false matrix: - os: [ubuntu-20.04] + os: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04] ssllib: [mbedtls, openssl] name: "clang-asan - ${{matrix.os}} - ${{matrix.ssllib}}"