From patchwork Tue Sep 19 15:16:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "its_Giaan (Code Review)" X-Patchwork-Id: 3351 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:2697:b0:d7:3b0f:3938 with SMTP id ha23csp1688656dyb; Tue, 19 Sep 2023 08:17:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGmpEAKhwGWPaJnhkoV54ZLBiJL8KtoghQ5AttIVYkUxv4Y91ZqGcAaZz1rLejQZIgi4u2t X-Received: by 2002:a17:902:d509:b0:1c2:c60:8387 with SMTP id b9-20020a170902d50900b001c20c608387mr13928588plg.0.1695136641800; Tue, 19 Sep 2023 08:17:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695136641; cv=none; d=google.com; s=arc-20160816; b=gN4zHD+0bw9SREijCwudn1sdtWLdvNhciKKU0Gno3T0piIl0tjCXkHI1bWHIpM/0C+ 8xqyZJzMh8do35twOh/Zt/PfKDVnsCtAqJoWEw1a30xxSKOAsnvpj9nCl6MEYWufEl7m pxLW3IfGMEy9WY5/C4OcI2clO4IG54+E5ge1ybgSw3ZV5cj6voA0Urpcv6a8RGY68fsS uLhyxBd4DWFWOuTnVULHGHB21S9hSkGmRKlBetCZ7rnKhGMrgsTVe6Vieom0XJOqG825 TGZq+UNGsE7A8jDo91FOkCZoKRoen0wSLEKMncde5msyezRRLeU/oAC7DGa7FkUYr595 3Sqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=0VrrCSzt0Q2ScVjgfHdBJjoQ4ZcINhqm9ktosAFfGwc=; fh=76u+BKbf3g7YyYQGrvNiqrx/YetVLPAMQvZ6dx6SKzA=; b=a0eG7Ml+Hx9BlYSnupcCPoftXcv/6gR8MvxwoH4aya7pBOGy0hf54tyNnqijbHpLyw BTBw4vS6zeN7iSs+Jzjc8Eo73D78vo4InIWJkrVRmA7NEmGfGT6J9gXRa3CuKun6ytpm UwqhBcWENGoGd1XDayyUoQ4eIk/cxETFyeM35H91Kv3qPiGUQK5KeJvQ3RCZiQlUGj57 7KXZ3IO5R8BwTn19AeOY7e8AkWoosmveXsMn3W/PQOVjAJ6qAdjp3x8e/EO+aITCe4JF FXDn4+91pv53fjBrMtCXZfhLPGYLepELNtqInq2DEZ+cUXuIPP4+zzKI5aN7AGWoxEPd w5ZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=dOpgIbkR; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=fidctiwv; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=ONhXuJbY; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id q15-20020a17090311cf00b001b02e044c87si10237086plh.320.2023.09.19.08.17.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Sep 2023 08:17:21 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=dOpgIbkR; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=fidctiwv; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=ONhXuJbY; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qicSj-0005OA-OA; Tue, 19 Sep 2023 15:16:30 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qicSi-0005O3-6y for openvpn-devel@lists.sourceforge.net; Tue, 19 Sep 2023 15:16:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xPoaYyMJIiHR8BhsgNmqM+oCjBynBiNVRHKvKB/ZbsI=; b=dOpgIbkRG/QG8IMHZkoQccPU3/ c0U2Y23efaD2YuHtiQ9fl8aXB/BKywpwl35tgcKoos3YAuLeQudDS64IyBIuz1QN29aNR1maQ0C7e Vw4ok1fQDZ6L2qA9TYkiePlG9xX2PMAkALKIjbvMf6mRpRxxqXBm7Wo9EpLQ6bIs+918=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=xPoaYyMJIiHR8BhsgNmqM+oCjBynBiNVRHKvKB/ZbsI=; b=f idctiwvieVq5Ab61MaqjUQ/J1YwRCtDCXFSJUzy4xp7wazwNGubf5Zl5OMsg+xQYs3bOlT6jgEBP2 cgJtvAMT0hMlxTssX6BUFykm0+YVYMAnSrlMwMtA4pPa4/Xe9Fctkps2D+a/fRB7WXeqYKVsgN/21 NWYPAIgbUJ2K655U=; Received: from mail-wr1-f48.google.com ([209.85.221.48]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1qicSc-00Ex0S-2B for openvpn-devel@lists.sourceforge.net; Tue, 19 Sep 2023 15:16:28 +0000 Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-32008b5e2d2so1983580f8f.0 for ; Tue, 19 Sep 2023 08:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1695136575; x=1695741375; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=xPoaYyMJIiHR8BhsgNmqM+oCjBynBiNVRHKvKB/ZbsI=; b=ONhXuJbYk8poodfpKEkbfnsBMc5KdA7Qi3TjtKpxdFsJXTRSrwIbicwajo+pDNVH+t zQmY461BQuSTlH/ptP9DUvK7MUB14HWg/HX23znJCKMY+Dzqgkg4lEicJLWA6MAGm6Qu WwuH1DBucGrU/oBp2FK2lvD2p7uA6fxbbynwjCSa882J+MZPsUA4mK0Gq1mwFOlrU8N+ jR5uriGYjmfqhcPCJq5MearhoBEJbAjRKz/nhBCqjD9cyvSGq0fkFQ30RnAK4wCa8dQE JJ2RDPaxYKET1YxgZDU0fLjvGu8/RY87hcsY+rUboWAEn7yVJ67jdko8aUUE/X2v5kHG fH1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695136575; x=1695741375; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xPoaYyMJIiHR8BhsgNmqM+oCjBynBiNVRHKvKB/ZbsI=; b=GVZT3ZwAK18/4W89k0JL0pL091jsiAlh+HRx2rz0N9KKgRTkhZsZoP1MJBwaFBgSyN G8wdbWwR92L02SGIICsptLgyIaE+9GXFXf1izUNu6G4Y6cPzSjomeWZGI0ZyNgHjouQU rFlKdo4Rq/FuCyqQ02AblZ6hnreSezF9gaOYMHi64RNEElGAJVdIG9yrcY7iciaMfeOi S8IdC7AVxQZOHC8KWMtgUEdj31137Hh9I7g6zfp/RiMtihOD9Q4bBRkFTyB2F7UkP6zw QwOSSl9QXW349kMsgkRPtsmKwGTB/jSoNHFJd8dvwXVCRRSp06QpP0HutMfSzabscvaX wPgA== X-Gm-Message-State: AOJu0YxahEgtig5RNLuXg0XLhnfXQ6IDskDw4fr2qGSIAQkO3jDoAPYo P08RIDW2GWmRS1331bysoLg8SODXN5Nh1luyE9w= X-Received: by 2002:adf:d4d2:0:b0:319:6b56:94d9 with SMTP id w18-20020adfd4d2000000b003196b5694d9mr2186149wrk.2.1695136575344; Tue, 19 Sep 2023 08:16:15 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id m6-20020adfe946000000b0031980783d78sm15739149wrn.54.2023.09.19.08.16.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 08:16:14 -0700 (PDT) From: "uddr (Code Review)" X-Google-Original-From: "uddr (Code Review)" X-Gerrit-PatchSet: 23 Date: Tue, 19 Sep 2023 15:16:14 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I08d5574e5ed6098b5147357eee09fa796853efb8 X-Gerrit-Change-Number: 261 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 77bbbaf367a7306e8d37b2d9826bb74b5c0e23a9 References: Message-ID: <23723e64b1e5dea6347b839b4f1a0e52aa5994b3-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.48 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.48 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1qicSc-00Ex0S-2B Subject: [Openvpn-devel] [S] Change in openvpn[master]: Please ignore - Uncrustify code check X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: yura.uddr@gmail.com, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com, yura.darnobyt@openvpn.net Cc: uddr , openvpn-devel , buildbot Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1777469994589134565?= X-GMAIL-MSGID: =?utf-8?q?1777479599536015993?= Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/261?usp=email to review the following change. Change subject: Please ignore - Uncrustify code check ...................................................................... Please ignore - Uncrustify code check Change-Id: I08d5574e5ed6098b5147357eee09fa796853efb8 --- M INSTALL 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/61/261/23 diff --git a/INSTALL b/INSTALL index a63bab6..f7102fc 100644 --- a/INSTALL +++ b/INSTALL @@ -6,6 +6,28 @@ as published by the Free Software Foundation. ************************************************************************* +Uncrustify code check +Owners check 2 +R 3 +R 4 +R 5 +R 6 +R 7 +R 8 +R 9 +R 10 +R 11 +R 12 +R 13 +R 14 +R 15 +R 16 +R 17 +R 18 +R 19 +R 20 +R 21 +************************************************************************* QUICK START: