From patchwork Fri Oct 4 06:00:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "flichtenheld (Code Review)" X-Patchwork-Id: 3884 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:731c:b0:5b9:581e:f939 with SMTP id b28csp258927mag; Thu, 3 Oct 2024 23:00:55 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWVRx5RWm+PeKT7aO2jS5vCUyW9gC5at0puK6Rcw2qIXjX5X+krtIlO7WtEdKS8ZBd6OACiMSAf1OE=@openvpn.net X-Google-Smtp-Source: AGHT+IGee56zvkIlcFlyiUxp4ffYIScoX4Qceb3JwwxTZQdi7po2weC3Dm5hHShecxJCodLNDA50 X-Received: by 2002:a05:6830:25c5:b0:710:ea11:3d34 with SMTP id 46e09a7af769-7154e821a14mr1054216a34.12.1728021655500; Thu, 03 Oct 2024 23:00:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728021655; cv=none; d=google.com; s=arc-20240605; b=ZY4m5Z+rgtPyM6yJEthDDTMcKj7hECEasWlnQ3xCxIc9f9y8En1ZEHuTQT7VW6vGyz wQp/AUFKglNqkSSiNjzejADgMDuyccDoZYPySmtDUSvJSAg0ujrF6m2VfeLUM3zzjwji uQPblpwRDxrEuUk/yBWEggzg9z4rchXahtzWGjIvdgXtmii62PkHFqLgHvB4X88bNJpW DL6QT9MgNDGHtllPr/oEChHSKX0vuvjKmtOQJKMvJVg8e5n4b2ew5Yy8Zfds01xVgaSw LXhARac7ZEwztAS/oselYvQa7AlfBGQdACA563D605qPsDjGt+chXH8AbWYFu54UBZ2Q UPgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=FYvAAEDdgRpkkdtEdhRJWhUbE+68j4gNBbUVIr+jYTY=; fh=U7wEyxtwz2o5+UdevFSA47vNeG9knhWH0KV//QhD5a0=; b=CiVKZXowvuA/ext5p9s9wnSktJzAiDQJhptVM5wGMyaEIiUPsICX1jNNPv/s8Yeuhd ypU8U3g6qVshbVQLZBIcamZR98Z7Gktt7gkkAqwC/GoAK3zpqGGPB69L9diNX5VQYTBz jxh/CAof778T6MHrq4nshkQhNYtS+AbEeTIJ6jhQIB2DTt1AztcboRUOnroPaOavFN03 SBXY+I9cDFyMp/YMLQ6h/obLov1XOO2VpZxRgUEYRiYsp7wpXN8qkVsDkKP0Y5LvRtu9 /eSMFeQNHU1i1G4g6HQwmXweqc6BK6Fe4kMl8eZHKJ3L5EnMkVJUU658wrnkdFwSontg Qqlw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=HN3ESrK1; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=fEtAaAoq; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=g7zcmhyo; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-71547f87a9bsi1207355a34.284.2024.10.03.23.00.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Oct 2024 23:00:54 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=HN3ESrK1; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=fEtAaAoq; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=g7zcmhyo; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1swbMk-0001CA-Hj; Fri, 04 Oct 2024 06:00:39 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1swbMj-0001C3-CZ for openvpn-devel@lists.sourceforge.net; Fri, 04 Oct 2024 06:00:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IV01oDHd7Kl5Ezd7avLrVfGVDMR+7Il+URs7rUq+/es=; b=HN3ESrK1ecDCqJF6RZ6qQNolCS BpBoLj0Onr3B4zZ2eawGUGoncw5luw+ZCQGwnDv/sj6VgQw7wlQlHLfzwfQ9TW/AQmKsDMTeg+sky FevvWZx0VPQ6SAQVbyuNo4WrtUt5KuQjdJ1kn2dKFQbmlVbcR4tn725AM9F188pyuXWU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=IV01oDHd7Kl5Ezd7avLrVfGVDMR+7Il+URs7rUq+/es=; b=f EtAaAoqMAOQA+pmJw7bgk93OHWPgsVVtGhHBH8YslHTI+0wLplImzEM4PpNmhuOHEFQCV0vRUrCDV YPco4ogSy0hYN3zeQFLkH3/yFDbuLWUDIQ9b3H6E5LNbzsrUOB8d/iWsyGqk0cvtKvdmjOgygg7Bj G8jgfzAW3hzhpZGI=; Received: from mail-wm1-f46.google.com ([209.85.128.46]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1swbMj-0001s6-5S for openvpn-devel@lists.sourceforge.net; Fri, 04 Oct 2024 06:00:38 +0000 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-42cb0f28bfbso14646935e9.1 for ; Thu, 03 Oct 2024 23:00:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1728021625; x=1728626425; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=IV01oDHd7Kl5Ezd7avLrVfGVDMR+7Il+URs7rUq+/es=; b=g7zcmhyomfHcfuwB6Pipy5VF54P+GWbPVxEqnNlniK5SSXUcdizF0D9t3sC7obwG3p +oVmIqEiTytWZ2+kx/4XkM8uOU6Ik2t2SBCgHDjkMNzLEvZNOOFQW90n8+P0BjKI58tM INmWvieNhTnssZRi+98ckOpDmNBCzOisqNtmql4y7K099MtJr2WB6Z+2qTRP7vFsDTCM DjrNsFI41bk628TGyOqcy2eJGtc3QRLZkJZgSZiSpvYolhQzuQb6tiz4pqM+3vP8gV2A 5hhI5t5uEayTvCE1wflImli+BvQMJ+5nh7uzFnW0TKKqT9fZ8/nBRgho5pSf1oqxOGPh kzkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728021625; x=1728626425; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IV01oDHd7Kl5Ezd7avLrVfGVDMR+7Il+URs7rUq+/es=; b=MMvmbJosAvK3R+7RgeKPxc935mCLBokb/o4B5dXpkLh3czkkkjsCkp7HQUTfmTJjPD hjlOHKn6JGzP3IFvOecoSbVsnO0F4EZ1SdCFWY0nTdEHu4Y4inrR2n2HPuXcYRcDXNtu mpTCLI/H2HCr3DXIncBna2lgTR9eLZx2FWhYWv9XLfXYMxC5qsktefxIIc6g/yS+x1jD 0yJkJZikI+SivlLUYeV1h7upq7w+5kLFHxiTj0k7YTkT3TGtNe5/3jFP7tj24Jb3DuXQ PFmscaV5irZxwUm2kKhckFgtvCHd9s/JU4pe5X1FNIFLPR8JCDFXZAClNubG6AojzSNN oRNg== X-Gm-Message-State: AOJu0YzNsx8YQJyjXH642q/MaYZ+eT4psUaJH3OMTeB3dnnOGvKDRymx PPZofgR4ONuk5oJx0sKcO13vuGe59RlPL4zJPNn798NhRKP9qxxKRFwT91GtRlYg55ZRdYcHIPK m X-Received: by 2002:adf:f804:0:b0:37c:ccd1:5d55 with SMTP id ffacd0b85a97d-37d0e736821mr873321f8f.25.1728021625442; Thu, 03 Oct 2024 23:00:25 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d082a68d6sm2568834f8f.70.2024.10.03.23.00.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 23:00:25 -0700 (PDT) From: "mattock (Code Review)" X-Google-Original-From: "mattock (Code Review)" X-Gerrit-PatchSet: 1 Date: Fri, 4 Oct 2024 06:00:24 +0000 To: plaisthos , flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Ic0f98cd3b87a7b86e032e63167ac9036f7c08fcb X-Gerrit-Change-Number: 775 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 358d4c5738e16b007502a8dbcefea832ddf98689 References: Message-ID: <3086a86985d7f9217cde0db8b3104088fe6c513c-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.46 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.46 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1swbMj-0001s6-5S Subject: [Openvpn-devel] [XS] Change in openvpn[master]: t_server_null: forcibly kill misbehaving servers X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: samuli@openvpn.net, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1811962034088085379?= X-GMAIL-MSGID: =?utf-8?q?1811962034088085379?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/775?usp=email to review the following change. Change subject: t_server_null: forcibly kill misbehaving servers ...................................................................... t_server_null: forcibly kill misbehaving servers Change-Id: Ic0f98cd3b87a7b86e032e63167ac9036f7c08fcb Signed-off-by: Samuli Seppänen --- M tests/t_server_null_server.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/75/775/1 diff --git a/tests/t_server_null_server.sh b/tests/t_server_null_server.sh index 10bb44b..dea2a04 100755 --- a/tests/t_server_null_server.sh +++ b/tests/t_server_null_server.sh @@ -88,9 +88,9 @@ fi if [ -z "${RUN_SUDO}" ]; then - $KILL_EXEC "${SERVER_PID}" + $KILL_EXEC -15 "${SERVER_PID}" || $KILL_EXEC -9 "${SERVER_PID}" else - $RUN_SUDO $KILL_EXEC "${SERVER_PID}" + $RUN_SUDO $KILL_EXEC -15 "${SERVER_PID}" || $RUN_SUDO $KILL_EXEC -9 "${SERVER_PID}" fi count=0