From patchwork Mon Nov 20 11:37:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "its_Giaan (Code Review)" X-Patchwork-Id: 3459 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:50e4:b0:f2:62eb:61c1 with SMTP id r4csp2204358dyd; Mon, 20 Nov 2023 03:37:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IHotGOkhaag95fVNHs3V1iTISZTXheYWdH+bkF4tAYSVGiPbB9/m5hmptBr2q1p+InTdfUo X-Received: by 2002:a05:6808:1413:b0:3b6:db1b:67b7 with SMTP id w19-20020a056808141300b003b6db1b67b7mr8997284oiv.4.1700480262751; Mon, 20 Nov 2023 03:37:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700480262; cv=none; d=google.com; s=arc-20160816; b=s2PvCvHYzlYMor2dqgJgofq65U+D4kUOuBAeXQ+IKLfydY4j7Jg8u2DYIg9KxCpbhl 1YAyroAqmMOIKCOOfzgFJvwiW1r1MCujQ+l+W4xDTsM3Yg0kMHfc9QKlHQWBn7OaHlf1 cJ35+ysu+2omw3ddk5P7DwV1H+UhjTXSW/GJTlMSfRHx+WR09DuypGN+CrEkQjlfX+mj wP1FPfMDE8ArB/9evQdKkauI456YkCTzcu3+Aw5SAPMQjrFsVXG2mRd+JnyOoO7V3T2p L4Pyazw/is0Mgj0ZbpZ4XCL1o7pCcVFz6xalxyA71Vl0SDEvhFg8kMNxakSsVz5tBSdY okgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=et5KTLbq6Dl0OXFdu8MY6AkNUjvYpL5/y5rhZuHewsA=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=Ov5/UkcbBKZPEMKfbEfNTOiFZnv5f1pUS8hLvGhWyF0HNWU2SATPxY5TtSHhDRsRz7 iaE8tkCvI3X6p2yWw5ZKS7UPjwR0OGK5FB/Xp79Ln6wzlg0ni0Hal2QzihQCJxE7yTYe 30izlapHZ1Y+Q7fiXqWus6DMzfNWewD1bYI/ZPEjediVDcrp1mq+kcYn5Y0LHly9JiNO wwmyvhNR4zOMhR80kIfF+MK5aCYo3DKCkZ1uw4ZQCezy7lBCtbszSsfAnc3Sd+86VB/l j2w2KStK1zohKDWu689/95yc7gS6v4t12N+gSb3//B230YHaSdln1W8zwHoiJzsIJcYd yKUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=hdFKPUs9; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=OzOjePKa; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=G2rVWmXC; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id f3-20020a654003000000b0057776b67494si7899847pgp.887.2023.11.20.03.37.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Nov 2023 03:37:42 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=hdFKPUs9; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=OzOjePKa; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=G2rVWmXC; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1r52aj-0004HJ-WF; Mon, 20 Nov 2023 11:37:25 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r52ai-0004HD-Rm for openvpn-devel@lists.sourceforge.net; Mon, 20 Nov 2023 11:37:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0XABHRiu52LSsqAHTojatuO4Z99PTo40IoUcEbwcypc=; b=hdFKPUs9F08BdvidFnKKilAJWL 8BjkDvz20gVNK3JE98cOWoeLDtA/dbA1u1S18OQiAGkF/Tl/S7d+0oq7o05lHGZiVyvLlkjGyZ/yQ ZEmvATspxq/43+Bfv8ikvxm4WPuBahbxwrfr6lTokr1wRUfpYAvXUdCJr3qqwSiMoIuQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=0XABHRiu52LSsqAHTojatuO4Z99PTo40IoUcEbwcypc=; b=O zOjePKaYgwtrgKqdO1+E4CjPUNp+6IxSnFzzC08ksolzCPgItFSI6cW0gFRD4bBJkl721eOVSv7jP 5Srm/oTlLvVwOna0Y/1BTDYYBaqtEUXCz3F870rNH661ivYA6YJEPYTzPcCYwYFVeh8X59C16L1+j oBtGyRXcnJRtD1rc=; Received: from mail-wm1-f46.google.com ([209.85.128.46]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1r52ae-000176-DO for openvpn-devel@lists.sourceforge.net; Mon, 20 Nov 2023 11:37:23 +0000 Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4084095722aso17068815e9.1 for ; Mon, 20 Nov 2023 03:37:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1700480233; x=1701085033; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=0XABHRiu52LSsqAHTojatuO4Z99PTo40IoUcEbwcypc=; b=G2rVWmXCXpIm7sHyKgs/F7SL3IqBfQlI9FD4PEc1fTGWHjdqMhtidoL9eHVLRE5CHw 2kYrhFUW4uwYHPd7JitI5627wsklQn/jHlZ8u6DELFX15uC3ooXr8SKYpznMz+iAZyJ6 0lvot3AuQmnrbAZeG8I8XQQNKUTRqaFrn+fEgb1P1xV2JEskzwVosm1EQVsFn1ze+E8w gnKi3BHbFxSMRRj/RoNuAIFfhl8MCKA621tlDj/cqkPxZOiy7oQkhkZAUOld6WcahBnx SXIlalc5FXEhYqa1EVoGldw1yvXNXAdYme3pALg+Tdt5EJDJYu6pYnT7zTbUDHpaC6cc SPxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700480233; x=1701085033; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0XABHRiu52LSsqAHTojatuO4Z99PTo40IoUcEbwcypc=; b=gTqYeUdM6LyNfyBIDqDzEVzRT91Bmtq0utGa+pH3OOSEZgvERWbnrH2FRAqDwowbtk WFbIXQp5aRx6v2VvwQkiFKyT9VIn4jK3jmPqWo3fiFaKhn7DGeySRQM8uyHhhmt8mHsn F942tLbcJK9axr64hDWxeQXaR8aXD1hCMSmPFas6Mb9/dL2MXQXFJyNfv7KkKPNK/KRX GojQYisha4Nqrznlh6DKrC6ktHl5suOC7xn7QLDpzCrzTof5K0AMYd3osTMhDBpRIDmI w6tI2XOBGy0o/4an8HUKZmeBmeCmOvRVirR9W9Ar8OCfqDBRRDaQ1NLNLXF46zxGClgl 6ogw== X-Gm-Message-State: AOJu0Yz33cG29UaUzjTKV1m06J3ohn88jBNaAQRhBaI5Mzq04Oih2HQZ 3iEAC1UgcbbLCwkqAr933amv5t/TyQEmSTfLK1E= X-Received: by 2002:a05:600c:3106:b0:404:4b6f:d70d with SMTP id g6-20020a05600c310600b004044b6fd70dmr6332560wmo.17.1700480233612; Mon, 20 Nov 2023 03:37:13 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id n23-20020a7bcbd7000000b004064ac107cfsm13005977wmi.39.2023.11.20.03.37.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 03:37:13 -0800 (PST) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Mon, 20 Nov 2023 11:37:12 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I1141eb7740d8900ed4af0ff5ff52aa3659df99aa X-Gerrit-Change-Number: 451 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: a6ae4b5558d6189ce8bde03a701b1121749241db References: Message-ID: <3b3a66951cd684f20302f92d1c3d7bf370fcedeb-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.46 listed in wl.mailspike.net] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.46 listed in list.dnswl.org] 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1r52ae-000176-DO Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Remove unused function prototype crypto_adjust_frame_parameters X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1783082791986469674?= X-GMAIL-MSGID: =?utf-8?q?1783082791986469674?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/451?usp=email to review the following change. Change subject: Remove unused function prototype crypto_adjust_frame_parameters ...................................................................... Remove unused function prototype crypto_adjust_frame_parameters Change-Id: I1141eb7740d8900ed4af0ff5ff52aa3659df99aa --- M src/openvpn/crypto.h 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/51/451/1 diff --git a/src/openvpn/crypto.h b/src/openvpn/crypto.h index c5fd253..9255d38 100644 --- a/src/openvpn/crypto.h +++ b/src/openvpn/crypto.h @@ -429,12 +429,6 @@ struct gc_arena *gc); -/** Calculate crypto overhead and adjust frame to account for that */ -void crypto_adjust_frame_parameters(struct frame *frame, - const struct key_type *kt, - bool packet_id, - bool packet_id_long_form); - /** Calculate the maximum overhead that our encryption has * on a packet. This does not include needed additional buffer size *