From patchwork Tue Dec 12 13:19:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3522 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:8d12:b0:fc:24ac:f0cb with SMTP id i18csp5824581dys; Tue, 12 Dec 2023 05:20:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+ukIIooaILEPxaGsA4cBBEvYbOt9qIJJQLboqy56T7kl+hvh+c1oUho0xsKxBrpXyF2im X-Received: by 2002:a05:6a00:2401:b0:6ce:4f4c:d475 with SMTP id z1-20020a056a00240100b006ce4f4cd475mr13178839pfh.3.1702387221204; Tue, 12 Dec 2023 05:20:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702387221; cv=none; d=google.com; s=arc-20160816; b=vF6UOYmrBG1wvKVe1tkm5t3gG5awzh8x5Rz/iX3Dbi6jdc2lMk5PrIzck24imL2as2 Hkai4pL7u9GF0tkBsoKuutDh4G2pcTdMGrbjs9d5aZCLRndnoseQuvgoEeldBKl9wduh Ja0rl2VxkrUPgKur7HeCZofMas/29kjLFnhQZ4S8OpYRSKxEaeglBI+bq8ABGjZLVb3t o+G6irfSUYMdGzNDDCTT1AG9Mg8Ffp7KnTKnRKfwIzBGHsYknAupehKnympzlI79XjuD Jub9E6WymomX/LqSU/oA7XTb+lbc+TKyoSn1ReAZymuF/Td00Ij34IOgL4S7jgtTNddO nElg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=Xg+r0vvH+2kULImJfxmX0fvpT2PnSn2xhxzJNOZ31r4=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=YYkXSvJmdN2zAnClE9hmUQiCyMHmQOlybGkAnMGngWyY+GSOto5gQrZTJTW7Vi3VJO z48ZdMC/8/TTqlSnRXsXsftpCvnVTazbF8RSVN3WdgXc8YiT9mkk1cmi4Kds1BkxIj/A PlZr7suzwDGOSd5XmORfOuX1XF8buiWHZUYlDCKhj3EmNhs5e9Gp88J6cQy2zUIAwD3C +E6UQ8kJuF+UId1u9e8l5Z6wl15osmszi0LRZRPyRifwkqsUV3VfJ9ykBLE9L2fJZMYY ahu1tpVtC6cMY3veOt0+sMwQd6ax9sZSMLTc+VRXEKiODkoDQgnCzAiEQ+tfJM3/nozv gZVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=iGh6EOh4; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XBNKxIBR; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=NED2UBKS; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id m24-20020a635818000000b005a1d8816535si7673130pgb.5.2023.12.12.05.20.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Dec 2023 05:20:21 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=iGh6EOh4; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=XBNKxIBR; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=NED2UBKS; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rD2g2-0004Uz-5Z; Tue, 12 Dec 2023 13:19:58 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rD2g1-0004Ut-62 for openvpn-devel@lists.sourceforge.net; Tue, 12 Dec 2023 13:19:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6WoOsFNbOPZznFVArMqK5Dr44UTNAGQRGuG0dGyuHLw=; b=iGh6EOh4+BzsJV2EII+g8j1d4i PH6NRloqc1BV6Yv4HZfpHmKqBi6uzHBC3Uocc9nM4CANeD/l2/etv2uI5pFRmvGFQ08Z01BxqDX0M EgajvpY/dXXdjA541EpTWupXitZGkjBkqH4itmwVjPhBcsWQ/65tRKthTL2GGebYYBrg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=6WoOsFNbOPZznFVArMqK5Dr44UTNAGQRGuG0dGyuHLw=; b=X BNKxIBRPajjlF9pRu35sVB6GdQWw8M3fEyHo9YLrsbCMsXHlSqsJl+ebyzxh3bhSsFFJnpkch9YDI cXGOwGmHv6EkLR02z5ITlWYdR+7GIM0EK9uWbHlnW9Nndg89JAAyvt80ANlg4wyjnTPQ16OC7p2cy LfFriz4Ry1SZEkYs=; Received: from mail-wr1-f54.google.com ([209.85.221.54]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rD2g0-0001V6-Ks for openvpn-devel@lists.sourceforge.net; Tue, 12 Dec 2023 13:19:57 +0000 Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-33635d11dabso239040f8f.0 for ; Tue, 12 Dec 2023 05:19:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1702387185; x=1702991985; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=6WoOsFNbOPZznFVArMqK5Dr44UTNAGQRGuG0dGyuHLw=; b=NED2UBKS18DX8nZmSimIbJkBi2tN5o1P4KY7YWbE2DPLC7YUVf4zokPtiM6Sl4Q+jS ZmayF2Jrblf6JHysV92jWc2Rmw0PYjcXkGRl0oicAKXINqwL9mnNg/1EGDuKoCzXx8y8 YAFOXmwp/hfE8uFKK7czCW9uETgC0KoAMD/MqKMTIH2nt20pZI9Aw/VVDtAy3CLOwXUE cFGeeEV75fxE5aP6xCLglzN6z828CvXml4FG7vIXjFP34bM3L7RCqahGJdsorhjcGjlj T92db6YsyTk75MarANIENbTIdMGZu03rneTS6SBtStNvT6djjwN8WjA+8gQY1yr48Fw3 kaPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702387185; x=1702991985; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6WoOsFNbOPZznFVArMqK5Dr44UTNAGQRGuG0dGyuHLw=; b=pwFd3DUECLUFq4SIrR0bm+6rMzKtDnoSgWPhtjV2pgFG7tsR1x3F0WYW2V4uD5uygr xJHVeTrjGNu5WZALQP79NDEcuqsyXU8njl7rStz0hfwW86tg22z8ST7XQNmXaSD1ev4k gDiJRZXP7Gnye3SlbB634C1SbWS2mFvrMIfLQVyEaEutFsl21yVrIwHm+djr+5AmzfCL klJ+kPMkYmeI+6Bja8CuuOfBB+YRBZiSaDNllj57nxCjcDEmuEPqXs09wnRhZ7WNKEdN Si9u9xxoHKyraupeTRGu08hwHnEHraczdLBE8d0HDPjfsdsXvSj4KnhijHLPEbCtJMby YJTw== X-Gm-Message-State: AOJu0YweH+Eaqj2Plguem7GiO9zktIZZJKRNoWvWEwlefI6M1wV6ubk+ 7t/cXp/ioWj0lTCIMVutWXcNW5GKfSI20C11zfA= X-Received: by 2002:a5d:6b8d:0:b0:333:46a5:6d19 with SMTP id n13-20020a5d6b8d000000b0033346a56d19mr3414706wrx.51.1702387185195; Tue, 12 Dec 2023 05:19:45 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id e6-20020a5d4e86000000b00336365d1dafsm74739wru.69.2023.12.12.05.19.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 05:19:44 -0800 (PST) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Tue, 12 Dec 2023 13:19:44 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Ib226079d1543209e08e5fdcf7344cd20850bea9d X-Gerrit-Change-Number: 480 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: e32deaa76d7afbb4658770c18a5d15ff6319062d References: Message-ID: <3c15288b82145c3db21397b2c3e355d32b093fd7-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.54 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.54 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1rD2g0-0001V6-Ks Subject: [Openvpn-devel] [XS] Change in openvpn[master]: configure: enable silent rules by default X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1785082382897276787?= X-GMAIL-MSGID: =?utf-8?q?1785082382897276787?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/480?usp=email to review the following change. Change subject: configure: enable silent rules by default ...................................................................... configure: enable silent rules by default The default build log is big and basically unreadable. Go the way of other build systems and do not print compile commands by default. Verbose output can always be enabled with make V=1. Change-Id: Ib226079d1543209e08e5fdcf7344cd20850bea9d Signed-off-by: Frank Lichtenheld --- M configure.ac 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/80/480/1 diff --git a/configure.ac b/configure.ac index 2823f04..9bc4d64 100644 --- a/configure.ac +++ b/configure.ac @@ -56,6 +56,7 @@ # This foreign option prevents autoreconf from overriding our COPYING and # INSTALL targets: AM_INIT_AUTOMAKE(foreign subdir_objects 1.9) dnl NB: Do not [quote] this parameter. +AM_SILENT_RULES([yes]) AC_CANONICAL_HOST AC_USE_SYSTEM_EXTENSIONS