From patchwork Tue Oct 15 12:35:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "flichtenheld (Code Review)" X-Patchwork-Id: 3894 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:588f:b0:5b9:581e:f939 with SMTP id h15csp106206max; Tue, 15 Oct 2024 05:35:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUBZFxVLtBLdXcuCXtZEgWQMZXF2CUzY7My618qYiHT+Ghs6gjDgJhxxekzjTmxRU1Z6ebqLCOjoHY=@openvpn.net X-Google-Smtp-Source: AGHT+IEg2+vczIkZ3I4Iz0NLrDAjcR2wOelqmBaROGo043vUp+dXfBHoiSQ30cG7D+lghLcFTpb4 X-Received: by 2002:a05:6e02:2163:b0:3a0:9c04:8047 with SMTP id e9e14a558f8ab-3a3b587bf91mr86111325ab.6.1728995730204; Tue, 15 Oct 2024 05:35:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728995730; cv=none; d=google.com; s=arc-20240605; b=V+B8mrm7Wz5RM8Q8KlvJvQ7p218aZmFA6X9FRundvji8asZX7AamnUE0NVvo22yURU gYOZ/NUZfPfevNXAhvMST4zyUNRko4VPCTtJDXgkNJOu3bTh2THhYdkX9stlW8wV1JxT ofUSyhwiPEgzA/Uv4AuOgiP0XaahU7GFd1eTGbZOfKd4CQ13QDcgaFS6WnDQx7V5d7wr 466ket0pk8DJ0cajNM7F2Mjt7hod9qHCpMa+ecHyxNBsP1DkBobZKA9FFRGN+Kl/UOtf n9Y5LxWHhCNxYfSlrcRcutTXUGO7EXq2FpfylDtyDO+440I79/LjhBQqT5l0wlEVrzGl FMmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=U8LvGqzO6HR97V6dOWJxzG3NOruDT3QwudJFG6PLcoo=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=PGiDi1BxXMM72EB32/egGV2uPnP692VdoNPzoKxof/yezwVMYiiX+g6QZSDPgIrHTX dUWVon/XA20t7yCcH/i0mU+V94taRa0gSpRSh5NKrDN0IxDOYvMprhKhuMXrmFIheKdW /7YPAvvZ2ZfCCYAtL41afO6za9tyCzIY4e7JmB20Kml6j4Hdb4gwGjzwEg4J46k5GxBg JQnKQ6ylWXNvgbmoirtkx7SOfwugNz2QZtA8mkgxbO33+eBHExliSynR1FN/WnX9sLyr Sh1ZgKY/FOYNeEAUt9RacXzQAX1KRKFTLfD1mdKqDbT6PB5PWcBeqsezPsupwzPiFcGZ IWCA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=BPmFhpp4; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=C4JUYUbL; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=EBZD+KUw; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id e9e14a558f8ab-3a3d71e29ffsi5646115ab.200.2024.10.15.05.35.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Oct 2024 05:35:30 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=BPmFhpp4; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=C4JUYUbL; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=EBZD+KUw; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1t0gli-0005jm-NJ; Tue, 15 Oct 2024 12:35:18 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1t0glh-0005jd-LR for openvpn-devel@lists.sourceforge.net; Tue, 15 Oct 2024 12:35:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lhsnYYIJGohSjFlIbVpAuCgfcbTOOCZFGqyxKAC7Xeo=; b=BPmFhpp4CPahLJAFOiAntB9Wik GR0RJqVpTmfIEfAiAnuW91brPIS4BmNcuqpLjTx+r8yPLJkIURZccIwEOcw0fP03aBMNq8YD/2hnG udC3xr32bLGBS8oLGASumEhYghER03NAWKvINew1m44d6mX4mzdESIF4me8L1OE8v7kw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=lhsnYYIJGohSjFlIbVpAuCgfcbTOOCZFGqyxKAC7Xeo=; b=C 4JUYUbLK3TgVe8XLgVRTorRZgP54y4CqlyYnvN0SCGJCNe6QuwWD7rCSmq8/dLWPRn5eJklpHM4+R ujuOUWU8HY2Lb0v4eVBr0ySp/CH4K1rsk+ts/90ZsVyygnSD2BJndYVwDBqPEJvPlAyHYn5PvMRxg 2QmMwHVTZLD6Y7mw=; Received: from mail-wr1-f51.google.com ([209.85.221.51]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1t0glg-0004ML-7K for openvpn-devel@lists.sourceforge.net; Tue, 15 Oct 2024 12:35:16 +0000 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-37d41894a32so3569296f8f.1 for ; Tue, 15 Oct 2024 05:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1728995704; x=1729600504; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=lhsnYYIJGohSjFlIbVpAuCgfcbTOOCZFGqyxKAC7Xeo=; b=EBZD+KUwyCGwQX+K2ImXsniBMEmLEVgXDrNPPmd3Pn3r6v9gfDa3phbWo8uAKAnH6B Wjh68i3LcY1NAAqfCV1t6FhDP4EHHQNuuNVSTec/6IagGX7wtOisc7J4iimSQ7aQyTP0 9tmHKkIuWWwdNvTt8mO0PD30AB7ubSwINHOPCLBlF1SaC7WrxSIwuNL9n4mjLaBMzQf0 JMYB3PYGbEvkHyxM+qwkq62qkIvtNa8gLFLLu36uq9Q8xSBIBAt+dfl/KELCCSKgGAz3 vDHGLW1fASEL+k+KJuilKRatwwUFqdwsb42PeL/8X3wvlt9Qjfq4ZIMPRJGhNTC5LCbf b47w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728995704; x=1729600504; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lhsnYYIJGohSjFlIbVpAuCgfcbTOOCZFGqyxKAC7Xeo=; b=YMRnQWgvtBjiabqXnGoYt4JYcQcZ+da2KpcCuwjTRgu+cOnkEHk0mbXgcRrToPiDo7 LqyDnxx5OnsplUQeT1RnSRxiglKLg8GHaWMOkLWnr77ij0mY46O3hizhIuSD5yjDZzPz 8bZ5UBGA1V6DOBTTvLagtqxqCkpm3NMgFlAjPTPSIbqy6uyVDgm0nuoqvLsWJn1YJkhy XDZHoEV7zuKJkGydxlbbmixlH9gK+LhFSoVVim+Fl0Oxesr2vlifxppvaOzrIdwYK54G N1K/UlQuWMMqDtjNPu0u7cKxEMxAsbqQGBVaQtG+3z8aH2cPiL7bVLlmgbxIoAg9bm5H OPeQ== X-Gm-Message-State: AOJu0YyRwdmtp3oX74Dj2rjK27oYNXMIwGXztRhhco0niB8PXn3N1JH1 0PqC8M2+592Xysoq47fa20Tr7sUUbeAsRqL11uwYhxZ/tsIRw7mEL4wGk5izM1X2guxL4CkYSoc K X-Received: by 2002:a5d:498c:0:b0:37c:cce8:4acc with SMTP id ffacd0b85a97d-37d862ab2c6mr347715f8f.13.1728995704532; Tue, 15 Oct 2024 05:35:04 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4313f6c5d7fsm16652625e9.42.2024.10.15.05.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 05:35:04 -0700 (PDT) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Tue, 15 Oct 2024 12:35:03 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Ibaa591904095a824df2c0c5aaff73687e0af24fe X-Gerrit-Change-Number: 780 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 1d8f5087dbf97ad31cd120da42059c226346b72b References: Message-ID: <3f16ba14d41977c139213154fd8eb81ebfe543a6-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -1.4 (-) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-1.4 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.51 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -1.2 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.51 listed in wl.mailspike.net] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1t0glg-0004ML-7K Subject: [Openvpn-devel] [XS] Change in openvpn[master]: GHA: Update macOS runners X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1812983426822583328?= X-GMAIL-MSGID: =?utf-8?q?1812983426822583328?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/780?usp=email to review the following change. Change subject: GHA: Update macOS runners ...................................................................... GHA: Update macOS runners Remove macos-12, not supported anymore. Add macos-15, runner is available in Beta status. Change-Id: Ibaa591904095a824df2c0c5aaff73687e0af24fe Signed-off-by: Frank Lichtenheld --- M .github/workflows/build.yaml 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/80/780/1 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 1bc250d..fdd133e 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -213,16 +213,16 @@ matrix: ssllib: [ openssl11, openssl3, libressl] build: [ normal, asan ] - os: [macos-12, macos-13, macos-14] + os: [macos-13, macos-14, macos-15] include: # macos14 and newer runners use ARM CPUs and homebrew uses /opt/homebrew/ # on ARM instead of /usr/local/ - - os: macos-12 - homebrew: /usr/local/opt - os: macos-13 homebrew: /usr/local/opt - os: macos-14 homebrew: /opt/homebrew/opt + - os: macos-15 + homebrew: /opt/homebrew/opt - build: asan cflags: "-fsanitize=address,undefined -fno-sanitize-recover=all -fno-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame-pointer -g -O1" ldflags: -fsanitize=address,undefined -fno-sanitize-recover=all