From patchwork Tue Jan 14 13:14:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "mrbff (Code Review)" X-Patchwork-Id: 4054 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:b7cb:b0:5e7:b9eb:58e8 with SMTP id en11csp2231612mab; Tue, 14 Jan 2025 05:14:34 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWwKbcB3CRrVTLr4yQ8A4plulw0iL21MR5uRcHgSId0k8QjHgLHazdt6epwiL8XLAaBgbfwX7NGJzo=@openvpn.net X-Google-Smtp-Source: AGHT+IHHCjfKstYb/J/VpxgldaCsM46NwkuSN9nK8BNpWs1KDRf8ZlEf71fnXBGaugl9mrmNTwXI X-Received: by 2002:a05:6870:e6ca:b0:29f:a0b8:6f7f with SMTP id 586e51a60fabf-2aa066c6dc7mr14097699fac.12.1736860473808; Tue, 14 Jan 2025 05:14:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1736860473; cv=none; d=google.com; s=arc-20240605; b=dOijdiN5zvMibT9NJkVgXussw0/KAU+pHjcmW8L7itlCZeLpcfZhtmEExY6xadiOxh 6ou1Ai6/ljCvHEZGuRim8Dc+qFOouCca+x6NiX2iP+ffeR4Jm14DEwFsoFxOzTegTpv9 yVIL8aNrMCJ34xvI7atIi3+rhIAlS/wBauRDCO0T+AWNqsSv3dlSsas197SAmIgcOBsK Uf/46uHliGLolPB2aqWYxijwIueQL/84d7u/Nly3c3R1K+JF/cCnMInkFzq6trvAvw8O mJTDp/V7ClIg2u+i+Dpy7pGc4Sz7ot3Pj5svpLmmo1+MWpfGOmQVrwY72/ftXSyoptno pPgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=NWPXdS3fGpOsvdaN1BCGw4wSs4YWUqldiWFvU7ie91A=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=N8fWLBZglRdC/1VZVdREVGHZsKMIm0Figyb+nChs9CnZj5KBCsBy1ux6pzRMoLjyhN vTkODgCNFcGFb7AM40FdSMRZWIbKFxM0O+g93EkmiCoenOHFWbp8Uaah3/O+eGaGWdzb Cg/MpcJGhVLn1sJRPq7OJdNJRWmftv4fwaGdql9DPdVElgjKXPXjCrHoho8vzeu5AWZ0 Jh/pDXXxInFnP7VgzupAARDrTEQR88aESkaSF/lMw5Fln2VQ9dQ5DgbyRd6Rh2M+Z0uh gzfOZdKYq4JtlsotjrFV9xAoxovs1NwYVEHCjww2FOHdfy/+Uw2Ss9tkvptG7JQaoyuI GTHA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ReCw7vWp; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=N1f2Iuq2; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="a5INsv/w"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-2ad809a6430si8418901fac.179.2025.01.14.05.14.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jan 2025 05:14:33 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ReCw7vWp; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=N1f2Iuq2; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="a5INsv/w"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tXgkX-0003LI-2O; Tue, 14 Jan 2025 13:14:29 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tXgkR-0003L8-Nb for openvpn-devel@lists.sourceforge.net; Tue, 14 Jan 2025 13:14:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pCRSuZqja2X6V+YyopJfofXhJCOkI6P6Pw28YIHCEm8=; b=ReCw7vWp9e3m6kh+7i3paQRKBv Pg6DeWysBrU8o7sJiT8MFuH743KSvHD6ahtE5Fkv5yvrAyEb75QtuRQ2ovmIe3FgYHHGuwf+7CDbn vDYX2RzngU14slf8MNUpCoHITdDE+pJqXQ2n/fC8uaRYyHsG7WblqXUZVtSYBd2/RFrQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=pCRSuZqja2X6V+YyopJfofXhJCOkI6P6Pw28YIHCEm8=; b=N 1f2Iuq25nWIzA8XNi0dvLe7ArTqK59tsPNGki3EM0Y5eca/n6el48EYHB8ifkxsHGvrtjhU9SbNTN 5qxYiM6dtMw14rI+1xS7pSyZql2gTtkPSDWl4C5AkmoPf1qwyAkGe2t+/Lm4g4gWKTzBnvgO5K4FW i2AFEzpBr1Xeru8w=; Received: from mail-wr1-f51.google.com ([209.85.221.51]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tXgkR-0003j3-B5 for openvpn-devel@lists.sourceforge.net; Tue, 14 Jan 2025 13:14:24 +0000 Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-38633b5dbcfso5575786f8f.2 for ; Tue, 14 Jan 2025 05:14:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1736860457; x=1737465257; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=pCRSuZqja2X6V+YyopJfofXhJCOkI6P6Pw28YIHCEm8=; b=a5INsv/wylOcDHMTfuoMKfRIP4RKktQJTA+PBoPHcLniT2TALBY2Kf7gu9WIZ/uD7t My81rvnPgx9E4P6mlO2NlM509Y5mgbo48HI+np+DTvtqecoUrd/R+XvXx7CvuqXkvJAq 470MgjUt3IDDMiwPRn7HZnqRof+inTEum93aHZDmhIhI5e0ZT12KgqPHbvDfjiNPopN+ qe6UkJQgjgzylzlDJpFGwxjrceTX5YDudDvgrdFlDVizDbh6SQJjj7RJPYsQ98JNWP3l l00z5EmA+oF/dCDmqB+/43SzDpnbmW98j7827QIXWAG3eckLTpHkgZ24EI50lCnLPskt 2kOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736860457; x=1737465257; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pCRSuZqja2X6V+YyopJfofXhJCOkI6P6Pw28YIHCEm8=; b=TH6fU28nzT83iYNoiM8VMLO/DIDslMKGFrijC5mIjTI0/Uv1YWXCIKMznPNkr/MvR2 gmvvtpd8o+JiOKWGNLgVRArK89eX0j6vmJvYOv+R7xFgMHEs+jBEXCoAANz/6LYXUBLq cnpENdLcY7lbQK05HMwxpGn/7NnWcSCi46Y9ulprxSmEiRIkAD4uU7fHZJsBZuirK3fb y6XsVbM6mOChTxJnb6ECzLqjvhDeOtYbIWDywtSAgNcNA3O2a6Cy5pkQQ4G7iHskXgv3 ORX2qk9foOlQSzp5FmJkGCasTj8ZAZm5+JImYj5xxrv3lOR909pCLXbJ9KZBMlGlLpJI Ee2w== X-Gm-Message-State: AOJu0YxIXoiCWB6QRf7e6yWiB5C1LRDpXViLCr8F0iXC7WOfB5HcA9qP Oa6ijvVBF/VRi0VvqMwmqKSWcp+TVI9tZCWXeIyBBLcNvZmvI2s/+MMf5fuiO0ch7FPNV5wW1rM g X-Gm-Gg: ASbGnctZt0347wm4SXBrUBpN8abke+LGGlhEq7/UAlypRTlqVBAGJbOJTCXuidb+V21 xfyW3ZB4dUC44tWmqFCK96pg0mueLW94oSmimdRl00riGG94duFBbhaIhyNf2g2+pn/iSWz5X5o +5CNscCZ5BRoKmBQFearlcQA2Kbeobgq9oxx7fu/q4Wxu5ebmf08/a+0D676Kre9bZg08ojaMjY Ep/OfKw7ssv+yu3M696YIZPK9/PoHm9/x9lbNdFfIuGcNJcj/biM51d5pqKL2maQjoatKW+OxXw WLLKc40ncl3ooKd1NUKgK3dQJskQ83k3E4eNiPyJdmrYO53D X-Received: by 2002:a05:6000:154f:b0:385:fd31:ca23 with SMTP id ffacd0b85a97d-38a87338c76mr24198766f8f.40.1736860456799; Tue, 14 Jan 2025 05:14:16 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e37d2f5sm14941900f8f.17.2025.01.14.05.14.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 05:14:16 -0800 (PST) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Tue, 14 Jan 2025 13:14:15 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I925accd8267f94ecfd9ccea85bae965dc2a10208 X-Gerrit-Change-Number: 864 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 49504c83d899025e6ace424b1237a46a52e368d1 References: Message-ID: <458e038e57dbb3c4559aafc21dd76744b158782b-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -2.0 (--) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-2.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.51 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.51 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.51 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.8 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.51 listed in wl.mailspike.net] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1tXgkR-0003j3-B5 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Add more "intentional fallthrough" comments X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1821230208162254375?= X-GMAIL-MSGID: =?utf-8?q?1821230208162254375?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/864?usp=email to review the following change. Change subject: Add more "intentional fallthrough" comments ...................................................................... Add more "intentional fallthrough" comments To make it easier to exclude them from compiler warnings. Change-Id: I925accd8267f94ecfd9ccea85bae965dc2a10208 Signed-off-by: Frank Lichtenheld --- M src/openvpn/list.c M src/openvpn/push.c 2 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/64/864/1 diff --git a/src/openvpn/list.c b/src/openvpn/list.c index 69f1510..b339c7b 100644 --- a/src/openvpn/list.c +++ b/src/openvpn/list.c @@ -437,34 +437,44 @@ { case 11: c += ((uint32_t) k[10] << 24); + /* Intentional [[fallthrough]]; */ case 10: c += ((uint32_t) k[9] << 16); + /* Intentional [[fallthrough]]; */ case 9: c += ((uint32_t) k[8] << 8); + /* Intentional [[fallthrough]]; */ /* the first byte of c is reserved for the length */ case 8: b += ((uint32_t) k[7] << 24); + /* Intentional [[fallthrough]]; */ case 7: b += ((uint32_t) k[6] << 16); + /* Intentional [[fallthrough]]; */ case 6: b += ((uint32_t) k[5] << 8); + /* Intentional [[fallthrough]]; */ case 5: b += k[4]; + /* Intentional [[fallthrough]]; */ case 4: a += ((uint32_t) k[3] << 24); + /* Intentional [[fallthrough]]; */ case 3: a += ((uint32_t) k[2] << 16); + /* Intentional [[fallthrough]]; */ case 2: a += ((uint32_t) k[1] << 8); + /* Intentional [[fallthrough]]; */ case 1: a += k[0]; diff --git a/src/openvpn/push.c b/src/openvpn/push.c index ddad109..06e421c 100644 --- a/src/openvpn/push.c +++ b/src/openvpn/push.c @@ -98,6 +98,7 @@ case AR_INTERACT: ssl_purge_auth(false); + /* Intentional [[fallthrough]]; */ case AR_NOINTERACT: /* SOFT-SIGTUSR1 -- Auth failure error */