From patchwork Wed Aug 17 12:40:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arne Schwabe X-Patchwork-Id: 2689 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director10.mail.ord1d.rsapps.net ([172.27.255.8]) by backend30.mail.ord1d.rsapps.net with LMTP id qB05Kcsl/mI9NQAAIUCqbw (envelope-from ) for ; Thu, 18 Aug 2022 07:43:07 -0400 Received: from proxy9.mail.iad3a.rsapps.net ([172.27.255.8]) by director10.mail.ord1d.rsapps.net with LMTP id AGbzKMsl/mKEDgAApN4f7A (envelope-from ) for ; Thu, 18 Aug 2022 07:43:07 -0400 Received: from smtp2.gate.iad3a ([172.27.255.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy9.mail.iad3a.rsapps.net with LMTPS id UM8sIssl/mIHCwAAGuSQww (envelope-from ) for ; Thu, 18 Aug 2022 07:43:07 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: patchwork@openvpn.net X-Originating-Ip: [192.26.174.232] Authentication-Results: smtp2.gate.iad3a.rsapps.net; iprev=pass policy.iprev="192.26.174.232"; spf=pass smtp.mailfrom="arne@rfc2549.org" smtp.helo="mail.blinkt.de"; dkim=none (message not signed) header.d=none; dmarc=none (p=nil; dis=none) header.from=rfc2549.org X-Suspicious-Flag: NO X-Classification-ID: ecb1c59e-1eea-11ed-bbeb-525400de56ae-1-1 Received: from [192.26.174.232] ([192.26.174.232:39856] helo=mail.blinkt.de) by smtp2.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id BB/87-10547-AC52EF26; Thu, 18 Aug 2022 07:43:07 -0400 Received: from [195.70.183.100] (helo=[192.168.12.111]) by mail.blinkt.de with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (Exim 4.95 (FreeBSD)) (envelope-from ) id 1oOdvV-0000UN-Pw for patchwork@openvpn.net; Thu, 18 Aug 2022 13:43:05 +0200 Resent-From: Arne Schwabe Resent-To: patchwork@openvpn.net Resent-Date: Thu, 18 Aug 2022 13:43:05 +0200 Resent-Message-ID: <6b2803b1-771d-dea8-0a95-6e208c5d3268@rfc2549.org> Received: from mail.blinkt.de ([unix socket]) by mail.blinkt.de (Cyrus 3.4.4) with LMTPA; Thu, 18 Aug 2022 00:41:50 +0200 X-Cyrus-Session-Id: mail.blinkt.de-1660776110-87441-2-7566924464364343033 X-Sieve: CMU Sieve 3.0 Received: from lists.sourceforge.net ([216.105.38.7]) by mail.blinkt.de with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95 (FreeBSD)) (envelope-from ) id 1oORjR-000MkI-Lk for arne@rfc2549.org; Thu, 18 Aug 2022 00:41:50 +0200 Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1oORiP-0006QE-SC; Wed, 17 Aug 2022 22:40:45 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oORi2-0006Ps-A8 for openvpn-devel@lists.sourceforge.net; Wed, 17 Aug 2022 22:40:26 +0000 Received: from mail.blinkt.de ([192.26.174.232]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1oORhz-006zRA-Vl for openvpn-devel@lists.sourceforge.net; Wed, 17 Aug 2022 22:40:22 +0000 Received: from 148122135023.sia.telenor.net ([148.122.135.23] helo=[10.115.1.224]) by mail.blinkt.de with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (Exim 4.95 (FreeBSD)) (envelope-from ) id 1oORhq-000Mjt-El; Thu, 18 Aug 2022 00:40:10 +0200 Message-ID: <48db419f-0d5d-a9b9-6f55-dffc5d4fbbe5@rfc2549.org> Date: Thu, 18 Aug 2022 00:40:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 To: Juliusz Sosinowicz , "openvpn-devel@lists.sourceforge.net" Content-Language: en-GB From: Arne Schwabe X-Headers-End: 1oORhz-006zRA-Vl Subject: [Openvpn-devel] wolfSSL unit test failures X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-Spam-Bar: + X-getmail-retrieved-from-mailbox: Inbox Hey, currently we still have test failures in wolfSSL in EVP_PKEY_CTX_new with clang asan. Github action patch that reproduces this also attached. With the OpenVPN 2.6 release coming up in the next months it would be good if these can be fixed. These look like problems in the upstream wolfSSL code. Details are below: ================================================================= ==19723==ERROR: LeakSanitizer: detected memory leaks Direct leak of 160 byte(s) in 4 object(s) allocated from: #0 0x49604d in malloc (/home/runner/work/openvpn/openvpn/tests/unit_tests/openvpn/crypto_testdriver+0x49604d) #1 0x7f64e8318291 in wolfSSL_EVP_PKEY_CTX_new (/usr/local/lib/libwolfssl.so.34+0x9e291) Indirect leak of 400 byte(s) in 2 object(s) allocated from: #0 0x49604d in malloc (/home/runner/work/openvpn/openvpn/tests/unit_tests/openvpn/crypto_testdriver+0x49604d) #1 0x7f64e833c537 in wolfSSL_EVP_PKEY_new_ex (/usr/local/lib/libwolfssl.so.34+0xc2537) Indirect leak of 240 byte(s) in 2 object(s) allocated from: #0 0x49604d in malloc (/home/runner/work/openvpn/openvpn/tests/unit_tests/openvpn/crypto_testdriver+0x49604d) #1 0x7f64e82b4ac2 in _InitRng.isra.0 (/usr/local/lib/libwolfssl.so.34+0x3aac2) Indirect leak of 118 byte(s) in 2 object(s) allocated from: #0 0x49604d in malloc (/home/runner/work/openvpn/openvpn/tests/unit_tests/openvpn/crypto_testdriver+0x49604d) #1 0x7f64e833c72b in wolfSSL_EVP_PKEY_new_mac_key (/usr/local/lib/libwolfssl.so.34+0xc272b) SUMMARY: AddressSanitizer: 918 byte(s) leaked in 10 allocation(s). FAIL: crypto_testdriver From 02d4c4d8444188bdf32a054171ea7e20cc7c12ff Mon Sep 17 00:00:00 2001 From: Arne Schwabe Date: Thu, 11 Aug 2022 19:27:12 +0200 Subject: [PATCH] Add wolfSSL to github actions I just want to see the world burn a little bit Signed-off-by: Arne Schwabe --- .github/workflows/build.yaml | 42 ++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 2a9a4e946..9c640cc7f 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -34,6 +34,48 @@ jobs: - name: Set job status run: test ! -s uncrustify-changes.patch working-directory: openvpn + wolfssl: + strategy: + fail-fast: false + matrix: + os: [ubuntu-20.04] + ssllib: [wolfssl] + + name: "gcc - ${{matrix.os}} - ${{matrix.ssllib}}" + + runs-on: ${{matrix.os}} + steps: + - name: Install dependencies + run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils libtool automake autoconf libmbedtls-dev pkg-config libcap-ng-dev + - name: "wolfSSL: checkout" + uses: actions/checkout@v3 + with: + path: wolfssl + repository: wolfSSL/wolfssl + - name: "wolfSSL: autoconf" + run: autoreconf -fvi + working-directory: wolfssl + - name: "wolfSSL: configure" + run: ./configure --enable-openvpn + working-directory: wolfssl + - name: "wolfSSL: make all" + run: make -j3 + working-directory: wolfssl + - name: "wolfSSL: make install" + run: sudo make install + working-directory: wolfssl + - name: "ldconfig" + run: sudo ldconfig + - name: Checkout OpenVPN + uses: actions/checkout@v3 + - name: autoconf + run: autoreconf -fvi + - name: configure + run: CFLAGS="-fsanitize=address -fno-omit-frame-pointer -O2" CC=clang ./configure --with-crypto-library=${{matrix.ssllib}} + - name: make all + run: make -j3 + - name: make check + run: make check mingw: strategy: