From patchwork Tue Jun 4 12:57:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3716 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:ab0:2492:0:b0:80a:cfd8:f00 with SMTP id i18csp2562302uan; Tue, 4 Jun 2024 05:58:38 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW33gDMibVXX2OoDY4oyX5s842SXt1uOuvIwgnF3GYg5Xzb9LGXXbPuPnYAoRIk6/sKf9wl6OFlNhJOplQmMeRoX09DWnw= X-Google-Smtp-Source: AGHT+IElN3ZYoBbbFssrZkJQQ2/qNi+9uTVDsyYyv+2AKeFALjusSiqONu4TAQpamBXaW/kS9ehX X-Received: by 2002:a17:902:d488:b0:1f3:ef9:d49c with SMTP id d9443c01a7336-1f636fe13d9mr134377815ad.1.1717505918513; Tue, 04 Jun 2024 05:58:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1717505918; cv=none; d=google.com; s=arc-20160816; b=LCe2uZFYO96aupFUoo/J4W6afw0FaPSjIaysr8hcCGxd9xD21iwsYwH7AcpABmZAP2 W1+5spdd+JvG3T+Pi4GIRTteOP8q7XxGkte9fzSUtcUsnh5mnnFgbJY/UNKRoLbRYKlY eYWBtr8TTMz782jLygGB3DjzZfENCKXoH5poO3286cA0SYe60ofiHNdlOy+2sVHFNWFj AC3IYGwDB998hnEb8D4Fo3q9PtMKawOeFJHfRbIKqXxdoqL9ijCMiz8oWw1uO6cRBDKA WcyZGIcrWE06G3+bCVQyzg4X5Zm+R7KCden1E/XnAXBFSUC5QFHFJfhFrr6nCIqkFYY4 oulw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=ekFrMmkZXqLNbnJiG7VrhuWvovvCb1/ELH3Y39dDKmU=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=kmKAvhXZ7HAFGmM9xgQUgyPzhF0zDuoDr5Sj03vaWYfKJ8QJ+qmj+OsQiszrK2BLNz cIXSQiEiUTpICCN84mkSf5DQDl1lbbD3poDzksR2ATKAB0caLCXbxWZGGpW0uOMB3yKZ +lx6c/4LuZjSV3h6VpC+oSnXhFwvUntl4J2oPf1StH/jjIy/fRC7akWb6E5rne6qNTc5 DdXzZXPIYrab0hLcWub4HKIyeP9XrV3as230r/2M42F3gTef/fuircFeAgTeydoQPurQ +CBbPiKiDH5Gx232Ry/EWRqjl4vijktciKKHb20v0Og8ibtM+5F27r/RQgNxnkWSRWMX 6mBg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="R/RbDGEM"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=NoyfVS4J; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=czobIOHY; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id d9443c01a7336-1f68211dfb8si30334695ad.256.2024.06.04.05.58.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2024 05:58:38 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="R/RbDGEM"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=NoyfVS4J; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=czobIOHY; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sETjm-0006q0-Ff; Tue, 04 Jun 2024 12:58:02 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sETjk-0006pi-4Z for openvpn-devel@lists.sourceforge.net; Tue, 04 Jun 2024 12:58:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7WRwMMAFbI7hxArt1n0sF7WFw5pH1mFD9JOEiYg3OYs=; b=R/RbDGEMbxYNPCKPMmUfn124tY 1PRFUVSJpSF03HW5j4VzNfqhkI81IDdRpQZBJn+ZPlszSjm/zCSYodTkcmbO2Uibxe71BfzT914vu sBa0bPCiSLuK8vjG6x/lGic8t5vdd4N8ZP12omTUCInvZ9I5HRsKUnIYygFShxuE5Hp0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=7WRwMMAFbI7hxArt1n0sF7WFw5pH1mFD9JOEiYg3OYs=; b=N oyfVS4JI/x626g2yV67n9pwv6zrWAhnilqpMhQHRZNI+/KvXe346BMjZOiPdrVe2220ZUaiOMeX6i 47wN6tZOixZlyL9dqVPB2ewNpFY2MiipsypIIGAr+U+lodf9lvi/ufQBzukXymPT/atHWaQYYeSqC ztNpPB2YaJTDHjk4=; Received: from mail-wm1-f51.google.com ([209.85.128.51]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sETjk-0006Mb-8L for openvpn-devel@lists.sourceforge.net; Tue, 04 Jun 2024 12:58:00 +0000 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-42120e3911eso51080085e9.0 for ; Tue, 04 Jun 2024 05:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1717505873; x=1718110673; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=7WRwMMAFbI7hxArt1n0sF7WFw5pH1mFD9JOEiYg3OYs=; b=czobIOHYKb3kEq6vI9kiFanq4jT6/E8mmtqyKVGYTh8ZpRjT3y0rLCOUP67Pm57JZN PEAJye7MOkhP0Wvlmyc9Ly+/6eD6TNgv/96uPrOG/uY326Huf0fNvJfuERq2Clop/jBv 0/e97aM2gfjWCg4niZYLiL/EeivVqU6Ug205KS0sUTzEvG3KP/NkQ5w0hy1dDSmRfAzi iujL29CLyVMNG+ttVs4FOUQvhJ1EihUnu4kamwTml1qOEYJAvIc2u27atniZm3EFh3yB NJ3zGm1RH63M8Mw0nJOF+ykihHQB5LoXxde/CGgFhcucyLcu/FC0ofwS4AOe+UhJ1y8h CQvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717505873; x=1718110673; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7WRwMMAFbI7hxArt1n0sF7WFw5pH1mFD9JOEiYg3OYs=; b=Cqn/mt2PLPKCitKHTwGkaYHsBEXKxDhs9P6FjW6ysyWPanNBdNdxxek0X0Bs2DnJfI JT4wDfa5Q1ZMkkyGBTBDi8Wj2YlV3BB4yPWkQIiZHtt4SIyZRoOQg14IgJYSY0b6tRDG OuYh83h7z5Wgwfi9V1CY+RYKx/zYp17GL+sLZiQpDgA3dllyDu+OG8PZUZmaYjvmMtm6 zz5m1adiPRmOcBLfl3BFxDP39GOhj+mlKvAT/wbb+APQ45/qsK0Jt58jlJ7V0+bkt0Pc wXxK53EGongAO1PPSoUS16UwK3C7PD9+XFA4TSKrXK91Ru7utVAeQyjZe6q2pYonPPlQ Uk1A== X-Gm-Message-State: AOJu0Yw39UsyjehJ0Y4Ot41WqOT3V/G8I3hKdWAEg/07cT0gKFsKo+tm nxFRNLPpRqRgC4IrFJrggIqHB9vwMjc8QP0iqQnAgfGOylGof1auAequZhA2R72W4NxV8AyhKmG z X-Received: by 2002:a05:600c:4e52:b0:420:2986:ccee with SMTP id 5b1f17b1804b1-4212e0a5363mr108194025e9.30.1717505872740; Tue, 04 Jun 2024 05:57:52 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4212709d336sm183495935e9.37.2024.06.04.05.57.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 05:57:52 -0700 (PDT) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Tue, 4 Jun 2024 12:57:51 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Ic33c210f06e173a450534aa0969c57f140086655 X-Gerrit-Change-Number: 641 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 3379abfa471e4600d2bb60769fb6bd5fb2581314 References: Message-ID: <50abac374d6c37804cff35e0161a37bb5e31ddac-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -5.2 (-----) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-5.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.51 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.51 listed in bl.score.senderscore.com] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.51 listed in wl.mailspike.net] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [209.85.128.51 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1sETjk-0006Mb-8L Subject: [Openvpn-devel] [XS] Change in openvpn[master]: test_user_pass: Fix building with --enable-systemd X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1800935486162970571?= X-GMAIL-MSGID: =?utf-8?q?1800935486162970571?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/641?usp=email to review the following change. Change subject: test_user_pass: Fix building with --enable-systemd ...................................................................... test_user_pass: Fix building with --enable-systemd Need to make sure that ENABLE_SYSTEMD is really disabled. Change-Id: Ic33c210f06e173a450534aa0969c57f140086655 Signed-off-by: Frank Lichtenheld --- M tests/unit_tests/openvpn/test_user_pass.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/41/641/1 diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/openvpn/test_user_pass.c index ac84654..b43e655 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -27,6 +27,8 @@ #endif #undef ENABLE_SYSTEMD +/* avoid redefining ENABLE_SYSTEMD in misc.c */ +#undef HAVE_CONFIG_H #include "syshead.h" #include "manage.h"