[Openvpn-devel,XS] Change in openvpn[master]: Add missing EVP_KDF_CTX_free in ssl_tls1_PRF

Message ID 5fd5f770af789f38b9b4a47a8b762789d0fa30fe-HTML@gerrit.openvpn.net
State Superseded
Headers show
Series [Openvpn-devel,XS] Change in openvpn[master]: Add missing EVP_KDF_CTX_free in ssl_tls1_PRF | expand

Commit Message

selvanair (Code Review) April 30, 2024, 2:11 p.m. UTC
Attention is currently required from: flichtenheld.

Hello flichtenheld,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/581?usp=email

to review the following change.


Change subject: Add missing EVP_KDF_CTX_free in ssl_tls1_PRF
......................................................................

Add missing EVP_KDF_CTX_free in ssl_tls1_PRF

This is just missing in the function. Found by clang+ASAN.

Change-Id: I5d70198f6adbee8add619ee8a0bd6b5b1f61e506
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
---
M src/openvpn/crypto_openssl.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/81/581/1

Patch

diff --git a/src/openvpn/crypto_openssl.c b/src/openvpn/crypto_openssl.c
index b2c4eb6..61c6518 100644
--- a/src/openvpn/crypto_openssl.c
+++ b/src/openvpn/crypto_openssl.c
@@ -1372,6 +1372,7 @@ 
 err:
     ret = false;
 out:
+    EVP_KDF_CTX_free(kctx);
     EVP_KDF_free(kdf);
 
     return ret;