From patchwork Mon Jan 29 10:45:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3596 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7001:10:b0:550:f63e:f504 with SMTP id rm16csp1336145mab; Mon, 29 Jan 2024 02:46:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEE6zk/gkV0qElp/ey1KJmfgCua1Ddw+hjRgU0lIh+/4tEP3Gq4+8JpAEqw7Lj6Qjp5bR8L X-Received: by 2002:a05:6a20:3d81:b0:19c:b1f1:614e with SMTP id s1-20020a056a203d8100b0019cb1f1614emr1033172pzi.5.1706525186576; Mon, 29 Jan 2024 02:46:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1706525186; cv=none; d=google.com; s=arc-20160816; b=MYBQUW+iQLJEFpbjetU1JNfgqtwc94Bf/Mnv5psXm48q5J6eT8IvNgGlYwlnYmh+bP 0vm0A76bF9l8Z8MykYQyQxalzRDvv6qWV7zxV9K4H524v3pudkASX/z3J8BaatEEKpQo FCO0h4R/ek45YE8YsinzLcErvDgVNs3VIet5KaD2x2s3KT9M2vXTr9/g4Mmuxkhbswin GO3PByXd9ir19CF0tt3oHUzJijqWObDtMQxjslvdQwi5w7WwRQ0s/Gu5wBb+uM4Iwgi7 Ug34QyWWi/Hut0kx5cJqeUXRHx5tJC6OolreQLgJrNm41eVbLJNE8acwM84fVPb1ajhA oWJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=3s8CdZE5bCT9WgA0m63c2zQliis4hi2E6D7/9BbWMuE=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=u9I5gj4J7f0dGV9SY/pqlTWtBA7vyR6A8zWSec2lMl79zbJJfhJIFpOZlyD2xHtJxp UfHooTnYW9/FFAZYMZzMJUA5bcR+xQGDVPDNnDly6CIigNqVGRLKmSrBQ+71JO3H3yNj NY7vFAXyqPETBgL5z6hLsk6UWJYoeLrhwZkt97hl7AmE2YkwGk2/L4QYTXrIjE5piYI9 3QOrcYbzf93g2NF+Zs+xMhaS9dF77aS2EVJQs10HAVlgpdlawfF4O6/ia+aYqW5fLihz qZravBNrF5+LxyvHHqytcvor6czHpntg36BAGmSuPVNB672kl/jd0qkzQvbbSD9T77oZ /5MA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="h9/bSyUj"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=StypLJzu; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=L8bHRXER; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id bs185-20020a6328c2000000b005d7a13d0be6si5345346pgb.232.2024.01.29.02.46.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jan 2024 02:46:26 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="h9/bSyUj"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=StypLJzu; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=L8bHRXER; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rUP9O-00045c-0W; Mon, 29 Jan 2024 10:46:03 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rUP9K-00045L-SD for openvpn-devel@lists.sourceforge.net; Mon, 29 Jan 2024 10:45:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nMX4BbjHaiI4/p+c6ntErYnXWG4jIw0X848zGioGFQc=; b=h9/bSyUjlPd6/iXbutoUgJpCLQ SOxfr/+GrIjByNrPppRAsAyQLBgsup7XLo3kVeFYRZPIOWRygFGPobM7ncsKhCdekzOlKR1qAS8Gs 2RDCPpAghpXPU4RgrRhmWhJBb8O+KSPIxVV/QaHRHiKVObKQJ/KEDJWw+wGbPp9uIkCs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=nMX4BbjHaiI4/p+c6ntErYnXWG4jIw0X848zGioGFQc=; b=S typLJzu6MdOrivwPG8GcAwLSS+SslLChJjwRP18xQVN1uH2dyuQgdTNqtIkwBc4H26Toi6Eaj0YTs hmeLXHbq2pao3FQR2W8jtwE5zFtcIUl8rZWH2l1v/yI+rua0aQcZNEJOQ4N3SECBAKw4WCluoTNlu L14lJxxdAH0IF1nw=; Received: from mail-wr1-f53.google.com ([209.85.221.53]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rUP9H-0006uA-Mb for openvpn-devel@lists.sourceforge.net; Mon, 29 Jan 2024 10:45:59 +0000 Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-33ae4eb360aso1376557f8f.0 for ; Mon, 29 Jan 2024 02:45:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1706525150; x=1707129950; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=nMX4BbjHaiI4/p+c6ntErYnXWG4jIw0X848zGioGFQc=; b=L8bHRXERd2M4ubLC8OZNbTWyWG/1rb2ddpcdj6cRjmzaJTiQlKbkxxZUTiiowTu6kX iWP6C8Iuw1jAQjacq2GQ7Tg50hZya9Y3qQKOJTGntqiB5gEkYMzYtF/sSMZ38lSWNSz/ IQ3gupHT+t9kK7iPYQgEQjeew7j6fXLljzqO8S8EvHfE9NBnPh1MCdMihyZ8erViDkKi Eb7tYXQYv4q2fjiw3b5ev1yG0AEPIboFPw+BscwzbYzYlmWAsv/8W8l27S8ULxnfW0Ry fWF0oAX3uRCIFZ2u+2Ep1UeIdi0GCGqJ7dIf3RZ6WJTppFT5e397X+/R0iCinAMGyyxg VWQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706525150; x=1707129950; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nMX4BbjHaiI4/p+c6ntErYnXWG4jIw0X848zGioGFQc=; b=w/UoUinqDuRnP+GqtAsXPn8VBJT/XJD2FaWe/xzmT7odW9Iezi0/9KirnQ4OvY1Bdr Z56584D7kp3xVMSxVRKV12w/wfoC6jKzqQdkcsZSYkCcn7VjqXwP3aNS1Qbqm5COK4B3 22m+IAEJaYSIei17RnvowsoThveFEEf4fwQh1+n/JZSjb6dzKRbL/nXr2kN19izlUZRj LW2tg7KWMOC+1l2OPG9wDo/VMEeYDioYVaeetptUANCY4izaHDNvTCwKjxW/pTDGVu4F hlB/JNGexM/wRxQCRdgYZ9grIs4KPjXTqbMpmRqS/cQCQQDZPJ225wKDj8Qsf5lwYHws OGZw== X-Gm-Message-State: AOJu0Yyf05alpipeeRAXf0P05BNWOM8mRAQVk6eo713EGvRThn20/R76 QivM2jABqBjw1cgH/b4JodToP/u139klNC/BI81N86WAYg6eD13YLSjTXp7xZq/96jAtPJhz3i1 + X-Received: by 2002:a5d:47c4:0:b0:33a:f50c:d4e5 with SMTP id o4-20020a5d47c4000000b0033af50cd4e5mr350560wrc.49.1706525149603; Mon, 29 Jan 2024 02:45:49 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id bh5-20020a05600005c500b0033aed46956csm2622621wrb.80.2024.01.29.02.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 02:45:49 -0800 (PST) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Mon, 29 Jan 2024 10:45:48 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Id7b4bda38adfbb446bdac635ac5d5207ef3f2f40 X-Gerrit-Change-Number: 508 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 9e73f372dfa2bd9298ff217b6e42009f183c6a89 References: Message-ID: <62782a197aefc6227cf97b1549a0807d39f96b42-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.53 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.53 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1rUP9H-0006uA-Mb Subject: [Openvpn-devel] [XS] Change in openvpn[master]: gerrit-send-mail: Make output consistent across systems X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1789421353643600714?= X-GMAIL-MSGID: =?utf-8?q?1789421353643600714?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/508?usp=email to review the following change. Change subject: gerrit-send-mail: Make output consistent across systems ...................................................................... gerrit-send-mail: Make output consistent across systems When writing the file specify encoding and newline, so that the local settings (like locale) do not change the output. Change-Id: Id7b4bda38adfbb446bdac635ac5d5207ef3f2f40 Signed-off-by: Frank Lichtenheld --- M dev-tools/gerrit-send-mail.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/08/508/1 diff --git a/dev-tools/gerrit-send-mail.py b/dev-tools/gerrit-send-mail.py index 5429aef..67a2cf1 100755 --- a/dev-tools/gerrit-send-mail.py +++ b/dev-tools/gerrit-send-mail.py @@ -109,7 +109,7 @@ ) filename = f"gerrit-{args.changeid}-{details['revision']}.patch" patch_text_final = patch_text_mod.replace("Subject: [PATCH]", f"Subject: [PATCH v{details['revision']}]") - with open(filename, "w") as patch_file: + with open(filename, "w", encoding="utf-8", newline="\n") as patch_file: patch_file.write(patch_text_final) print("send with:") print(f"git send-email --in-reply-to {details['msg_id']} {filename}")