Message ID | 70ededc245c6c214e5626dd879ac4297e55c3397-HTML@gerrit.openvpn.net |
---|---|
State | New |
Headers | show
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net> Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:998b:b0:5e7:b9eb:58e8 with SMTP id d11csp10717131mav; Sat, 4 Jan 2025 14:52:25 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXy5nx9ZKeMdh5aqXAvLQj8brOViWB7fblz+tawiNWzg4r2FXb6greqBxqb/MkWRhPJcTkZqbUStq0=@openvpn.net X-Google-Smtp-Source: AGHT+IGnqZGkImwpXHhpzaI/1SPJdpnGsLkzX0/d4iTXRyehFdlaG8of/+pT3XvhHU8lJO3v9hDc X-Received: by 2002:a05:6870:9e8d:b0:296:e6d9:a2e1 with SMTP id 586e51a60fabf-2a7fb0aa2edmr29231344fac.11.1736031145239; Sat, 04 Jan 2025 14:52:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1736031145; cv=none; d=google.com; s=arc-20240605; b=ay/kPYbkC8ZLWZjlgOtkKC9uIh9VP8q/D1+kIUXyqqItBeOaZyUyDGDq1PSbw7Crew 8McVo/AbkAtXgW2QePR+VnYu2oEWzYe98QYcwQc5Jl4SEMRqOeXWWcRrhaY6LQ0aNhqj q6Eh9xN6mtYLoqIg2CB6Ebv3Pi6Wo/daob4vYxaxNhMSyr9OFvjsHhlP/jKU/Sbh8Tfj C6xtQ1vRjLHXkYutIqopczOstnjT3jkIGcExZcg6DJTAWRpDR/x/hBHMQHRLudw5nT52 PiOWoUXf0xsIBtmufIXoEGlx33amwZxX3iRgw6ZTMawSBm/MdzgXJXWmgeoDJcF9lg9o sa0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=lEfyZUTooPmKwvyruvL1yFr8OImPT/NJDB6dWb0ewHI=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=LSGePnWsukY1+6AZzku3wYh//uLxi5znG7yeLOKUogTguW0YQVrrrlvVQ7BmbngUwB fPaYIw8AAar0gau3ZnLDYuc5VpxasOBpnFo1NEDe5GFKD36H6B0QW+G0eXKghynGcPpc 53hxaWFrc5VgvQN7lVJL+e6dqAy03M0O1qri6AEnZd4ke4dQ9fLxjTjkheNmkzFYNakJ HacS9P9Fv1eR1q7MjKQm0mHLhLJgwvNmR0VuzNTzwWr+qRZRrF2tdsjJ/J+0xKfx9lt+ ImgTIXL8su3Ei8YxoUqf8z5bYYh78iybAeYXL/62nIE6OiJANQreoKMUNh3Z9ABlmKqC RIog==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=TqGYuKY8; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=FmhTxRzA; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=L9bdWHex; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-2a7d77c60ccsi20636826fac.126.2025.01.04.14.52.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Jan 2025 14:52:25 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=TqGYuKY8; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=FmhTxRzA; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=L9bdWHex; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from <openvpn-devel-bounces@lists.sourceforge.net>) id 1tUD0I-0002IT-O4; Sat, 04 Jan 2025 22:52:22 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from <gerrit@openvpn.net>) id 1tUD0G-0002IM-T4 for openvpn-devel@lists.sourceforge.net; Sat, 04 Jan 2025 22:52:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cfBm9fkaNkdWQ/sa/p6NBc95LFLaQL70IaznVPlev0o=; b=TqGYuKY8kjRYeh7K3+PvV/YWJF NqNSA5PaD4W9TunKCC8WAEf+A3pdy/tzxqjEIbQetaJ6jphz/8Yg0pM2bZXq4XxDhpEdiGdRGcATh eXPGHR1B7SvBH9FmrTx63UYnKVu49Z+eulxajs/1ppBT0ZPKQtcrtpDX0vhtrcklJu1E=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=cfBm9fkaNkdWQ/sa/p6NBc95LFLaQL70IaznVPlev0o=; b=F mhTxRzA48abPS9yo95qg2BhDJ1H1nRqWLS+M4mpwXWf0uq3BgAEx0qPA95mggvLMSwbpVPdu61jwF 41/cSZrOwhS/As3kF3yUTbv2vftiA4f4VkySC/SMiT/YnIkQWMLMLoMbe8vxZH/ygBPzbADeNcyX+ yB3G8o1B8jaGqIrI=; Received: from mail-wr1-f48.google.com ([209.85.221.48]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tUD0F-0002wb-D6 for openvpn-devel@lists.sourceforge.net; Sat, 04 Jan 2025 22:52:20 +0000 Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-385de59c1a0so8016308f8f.2 for <openvpn-devel@lists.sourceforge.net>; Sat, 04 Jan 2025 14:52:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1736031132; x=1736635932; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=cfBm9fkaNkdWQ/sa/p6NBc95LFLaQL70IaznVPlev0o=; b=L9bdWHexoaR2Z2Czc8VGNNM3xf5NT0txmk2gGmcgncmLuXL/vf/uiP13WaVHqh/riO OX9mTg8zV+XCdCdgowotzqISwbAxmmySL4THnw+cc+0j4+mO4zoHbRkEwEZYPXEFSn10 I3DlLNnpszvhCtVYwxZgAqeJL8SpSVFVZmUTwxDHY/Re+HzbTrhNFZd6qfxbPInvB6HX O6j5yht5Uh7j/9Z8rmLxmkB6zv3omxzAEHopUVYOFeIBE9JmHUXaBG7mQ7/Rc2y3VGum 5yzj+MYLaPz0HyM23nt8PTbQm33gp8VoWWCK1kfvXKrd6NyZLEw0YboH76pKYV8iBkPs u7XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736031132; x=1736635932; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cfBm9fkaNkdWQ/sa/p6NBc95LFLaQL70IaznVPlev0o=; b=lWRUI1QKZMkvTgO1X7nn9giW04LiJ/QTgiPPSQq2AKG7atIomUvEUM1cG45f7j1u+j op4wG0L5wTVCAAjIvTXeWf2E3A/CmHKuiwG7W/dCznIHKncPLj/ZWl4jLG2zKRf+Wk8E MztxsS0QBsYnnd7gkR0IE2BDsTFZqYBODCI00a0yH9RvrikBqxRmUo6Y9fcIOdMUD8o7 2vO1YpyWUWduojuDP3BUfyAH3uwnqmO8NNixmADzCJQQHivFvKnAmD7oYEhW9iSgvOV2 Qug3X6rwVO6Y1+VyOUiagpKIpk+f338mC1CI7paUCwO57sZehx4G0XxMn8D2VRwzAr4r N4Lg== X-Gm-Message-State: AOJu0YyJnBG18H4TF25T+mEGbcF1ga1ICIQOVL0+O9YutV1TfrY15O4g KurwSwk6LthX3XSeZRWbwAVi2NRngKGebgpE6iIxwbNtniirKpVHiHfUWOrto5SfuokoPlcSljZ W X-Gm-Gg: ASbGnctBH0wMKij567KT63fu7BOk1zyT+AYVzLq84P7e4ZLs7uy3OJLu7pXymZMMLnp yHxpmIydiMlADDH1iOjw5kHe/f8sGjXLc8+4mFqUowbag5AHnDI25SS4gl33OiiXttloJxcmZHr wXTL3d9oJpk47vtbe9N5HoYx6JvCXhtl+JlClLHsS7U5CRiRcY/aJUwvKZtWWYxeHrnzf0UVx+v Q/FaShFERC8jK/uYQanOGaxUtcQi6DT2GxRRdqtYWIq6kBDctodNoao7aoizZ6SyLGthy5H8wQR j8NJc7bXjgUf3gOPnBlz7SN7ourNR8o14gvpQZ1xhmaJgbdC X-Received: by 2002:a5d:584e:0:b0:385:e5d8:3ec2 with SMTP id ffacd0b85a97d-38a221f9c94mr51068291f8f.28.1736031132474; Sat, 04 Jan 2025 14:52:12 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a47c9b2efsm24635135f8f.91.2025.01.04.14.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jan 2025 14:52:11 -0800 (PST) From: "plaisthos (Code Review)" <gerrit@openvpn.net> X-Google-Original-From: "plaisthos (Code Review)" <gerrit@gerrit.openvpn.in> X-Gerrit-PatchSet: 1 Date: Sat, 4 Jan 2025 22:52:10 +0000 To: flichtenheld <frank@lichtenheld.com> Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Id1632e4e47f5a9019afecae60457634c4a3c4d31 X-Gerrit-Change-Number: 850 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: <http://gerrit.openvpn.net/c/openvpn/+/850?usp=email> X-Gerrit-Commit: 5792bd724df706d0447b3b7530536df26cc0dce1 References: <gerrit.1736031115000.Id1632e4e47f5a9019afecae60457634c4a3c4d31@gerrit.openvpn.net> Message-ID: <70ededc245c6c214e5626dd879ac4297e55c3397-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.48 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.48 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.48 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.48 listed in wl.mailspike.net] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1tUD0F-0002wb-D6 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: fixup! Add methods to read/write packet ids for epoch data X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: <openvpn-devel.lists.sourceforge.net> List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>, <mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe> List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel> List-Post: <mailto:openvpn-devel@lists.sourceforge.net> List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help> List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>, <mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe> Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel <openvpn-devel@lists.sourceforge.net> Content-Type: multipart/mixed; boundary="===============1330007216218643011==" Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1820360594114698325?= X-GMAIL-MSGID: =?utf-8?q?1820360594114698325?= X-getmail-filter-classifier: gerrit message type newchange |
Series |
[Openvpn-devel,XS] Change in openvpn[master]: fixup! Add methods to read/write packet ids for epoch data
|
expand
|
diff --git a/src/openvpn/packet_id.h b/src/openvpn/packet_id.h index e78d912..9c0f464 100644 --- a/src/openvpn/packet_id.h +++ b/src/openvpn/packet_id.h @@ -336,7 +336,7 @@ /** * Writes the packet ID containing both the epoch and the packet id to the * buffer specified by buf. - * @param p packed id send structure to use for the packet id + * @param p packet id send structure to use for the packet id * @param epoch epoch to write to the packet * @param buf buffer to write the packet id/epoch to * @return false if the packet id space is exhausted and cannot be written @@ -347,7 +347,7 @@ /** * Reads the packet ID containing both the epoch and the per-epoch counter * from the buf. Will return 0 as epoch id if there is any error. - * @param p packet_id struct to popupulate with the on-wire counter + * @param p packet_id struct to populate with the on-wire counter * @param buf buffer to read the packet id from. * @return 0 for an error/invalid id, epoch otherwise */