From patchwork Tue Nov 14 12:18:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3431 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:3c06:b0:f2:62eb:61c1 with SMTP id e6csp2129017dys; Tue, 14 Nov 2023 04:19:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IHkIUftVRJGwVp217Z0LPasjN5jIjWatx1LNkSSXO8KcqRb3TOSf4HyZOFNrEDeuwpgxeGQ X-Received: by 2002:a05:6a20:9381:b0:163:d382:ba84 with SMTP id x1-20020a056a20938100b00163d382ba84mr2159908pzh.5.1699964364532; Tue, 14 Nov 2023 04:19:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699964364; cv=none; d=google.com; s=arc-20160816; b=CY9F7Tr3UJqnQ4UW5Lcw73KwqwsJ/MSZJpXPq156ZQ8eo+uR9RhAXWdeX25qGuNVD0 DsYkM/sEGqAw1BeoZ+wkh5ayQsAhwfWOQZL99ebpcDPC4JVxMXxeFD2ut4BwpiGARVqx jvx1Cd8BJ5JE4X09JQgTCzzRZ7gS/4QGhLS4KbctZPsQ4djN5v4VRAz0x6y4sicOe+bJ jiLg0F+wBrGONBmeCXYHjOVasClUX93kPX0/fxM+7Zlj+ZPJtF9ZRZOGm3m/7LyI9sQ5 FYyYpsdgi+J3uKtAAKJIc67xq5+f2YUtxJYESSMSKqUyqQS3flQeItsZVCvE1rsui+0d JkxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=Bd1KJlD892ywnuskCMCS3TmDD/6Qfi8bVJieUh6y2UI=; fh=U7wEyxtwz2o5+UdevFSA47vNeG9knhWH0KV//QhD5a0=; b=W9g2p9bPX4LzsiGbBCLhkoQXcBatr66iHupDxECy3qiWDuWPF1t6AEKM9pqRyno72o 9LC/QStjB/cYEi9Pllux6doaY9GMBTrO1KN04HPMkOrTxYGNCEmDeOaz1jZDLK9Ik9lU Y+1fC31opQduBOtiUbIt3wh4TOviEqj9+ZsKzW7qAnWvy7o/5zbToRTVpahGJ2/fDGhy xgMf5o7hR2Kl7UUOnLN6UvOMrGuR65JBUpF59RiMOhQroZwml976zETzEf4QrW3nL6Tg 37OyPd+9r/s8A5IV36mSVE9h5OFqEP2WH5tiblyFOvEBCytLw+qw0C2uIzqKCDtW25fe 5rWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UERD+7WB; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=V3ADYC0J; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=IzY2dTo1; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id o38-20020a635d66000000b005b958401e4fsi8076021pgm.418.2023.11.14.04.19.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Nov 2023 04:19:24 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=UERD+7WB; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=V3ADYC0J; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=IzY2dTo1; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1r2sNZ-0004ob-GG; Tue, 14 Nov 2023 12:18:53 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r2sNZ-0004oV-72 for openvpn-devel@lists.sourceforge.net; Tue, 14 Nov 2023 12:18:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pmwZNDdyvDuOEsRYgCvHU6s9JJZQ8uVdrAgiqw2pHUY=; b=UERD+7WBdANPtplC4OudTV5kkn FdvnBMXmfCCnhdgnM9h5JbwT20cwZGj6JDTX9bIoRTTXVRZA4yYCOHFLV3LrigJKy6fx+UHizPFpt c/0BdE7mxJiWQjVJThx3G7ySc3csO1XmqOL67UnWetgCoHkY2UaAeTBwt5TN7Q+9oq3Q=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=pmwZNDdyvDuOEsRYgCvHU6s9JJZQ8uVdrAgiqw2pHUY=; b=V 3ADYC0JeE5h9g8suBP8/SwOpTH9TH/Fsa6Qog+C6uhNr0O+YhQazpfb32rCMo6dvZVLpzJp9lEU0P ZXgubS0PwQREUoOjYEkTo02JX6iF/Y8Aw5yB8K2XtyJziKP59T34GHkxgDuucSR8A2+Piq9EEE1sf IsvahkFR+4vt0L1E=; Received: from mail-wr1-f46.google.com ([209.85.221.46]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1r2sNX-005ak4-Vw for openvpn-devel@lists.sourceforge.net; Tue, 14 Nov 2023 12:18:53 +0000 Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-32dcd3e5f3fso3414979f8f.1 for ; Tue, 14 Nov 2023 04:18:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1699964325; x=1700569125; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=pmwZNDdyvDuOEsRYgCvHU6s9JJZQ8uVdrAgiqw2pHUY=; b=IzY2dTo1ozNSzqBB4NhBl01JOC2op0LRwqlrAx9dW60IRiwH0n0b708kaKH/Ie9Fxt taw+gGwGLPDzPZ45lNp79kr7APDQaZRnXTgs116prpVFpCZFrokM367kAb1vYowMTV1R mLVF978xc/Ztv6PVXTq0xMc/Gw/HQfij7EtQULVp56WXJo2LZuVSzMu1HU4v06auEHYS e275hvJgsAJjgKK6gEFqZQtVn10qpN60lJF0BmzwZOdJ0qLd8mw/VweDHWeqZ479RTVJ nj+q7i7ljc6gRycGPdn73sa3zpFmfuTOKKGqEKi6sDsB89lzM9P6dTkYrLPlUpx0bzlT saGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699964325; x=1700569125; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pmwZNDdyvDuOEsRYgCvHU6s9JJZQ8uVdrAgiqw2pHUY=; b=vwgwtKqnkf0PcS5SNg9lggrDpTbuCHJd/6pWLNIM/7nUphY+KVRV2Vn47Hzb8Cbror qUlJmwWzo8ffpVLNmzfw1EjBQmZUoUZvQLDJZMyxlJrsEkjmNU7tjrBf9S+jlGN2gmID kh/EXb7WbIqqS5MUNCQhCkY9jszb45VwsoWe5Idoay8mEGZfbq89qihJC/WqWqJTsRLb NjWBRDL1csvaE/K7c1D0GyaTp+I1TRUQ5qjzgQ3HlFZjT4urbLEwBWBDNiz04Nfxqf0K lEVMLNfYqLhJRv20ATAXfXJE4mqkGjkKZeB88YIU5mqfQrFQbt9xFOzBmZoboS7rOaoP UVGw== X-Gm-Message-State: AOJu0YyydpqZVp9KxOLalbNj1eY+kmTKLLCLDmk29ERy1ZZxClpST10q vCwzn5RXx2TFobd2u4AQU/9yiI6vFEFPLicd8o0= X-Received: by 2002:adf:f9cf:0:b0:32d:14c5:643d with SMTP id w15-20020adff9cf000000b0032d14c5643dmr6456588wrr.5.1699964325416; Tue, 14 Nov 2023 04:18:45 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id t6-20020adfe446000000b0032da35baf7bsm7714869wrm.113.2023.11.14.04.18.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Nov 2023 04:18:45 -0800 (PST) From: "stipa (Code Review)" X-Google-Original-From: "stipa (Code Review)" X-Gerrit-PatchSet: 1 Date: Tue, 14 Nov 2023 12:18:44 +0000 To: plaisthos , flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I53eaee85d7b284af6bc63da5f6d8f310ddd96c47 X-Gerrit-Change-Number: 429 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: fafb21c987532b5e1212703217b8dd03a1462b43 References: Message-ID: <74f4822077ddd436c408edb6f2e6b1a3d9b5c162-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.46 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.46 listed in list.dnswl.org] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1r2sNX-005ak4-Vw Subject: [Openvpn-devel] [XS] Change in openvpn[master]: config.h: fix incorrect defines for _wopen() X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: lstipakov@gmail.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1782541833610357299?= X-GMAIL-MSGID: =?utf-8?q?1782541833610357299?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/429?usp=email to review the following change. Change subject: config.h: fix incorrect defines for _wopen() ...................................................................... config.h: fix incorrect defines for _wopen() This is a regression from commit 01341840 ("add basic CMake based build") S_IRUSR and S_IWUSR should NOT be defined as 0 but as _S_IREAD and _S_IWRITE, as it was already fixed in commit 077445d0 ("Fix some more wrong defines in config-msvc.h") Those are used as permission mode when opening a file. Passing zero makes file read-only, which break for example --status-file functionality. Fixes https://github.com/OpenVPN/openvpn/issues/454 Change-Id: I53eaee85d7b284af6bc63da5f6d8f310ddd96c47 Signed-off-by: Lev Stipakov --- M config.h.cmake.in 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/29/429/1 diff --git a/config.h.cmake.in b/config.h.cmake.in index f2cdd39..1c0dd6f 100644 --- a/config.h.cmake.in +++ b/config.h.cmake.in @@ -469,8 +469,8 @@ #define strncasecmp strnicmp #define strcasecmp _stricmp -#define S_IRUSR 0 -#define S_IWUSR 0 +#define S_IRUSR _S_IREAD +#define S_IWUSR _S_IWRITE #define R_OK 4 #define W_OK 2 #define X_OK 1