From patchwork Fri Mar 22 15:59:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3662 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:c315:b0:55c:c090:46f0 with SMTP id jk21csp1060543mab; Fri, 22 Mar 2024 08:59:48 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVpdEhf0OLPewHQwDUqhJWPwXL3ZsSEhiSQzB2yd3+i2BtVuSzmCMqk00RJ9KKQUTJLhNkT4msk8YP0/B2NE7bavmVz4G4= X-Google-Smtp-Source: AGHT+IFi9Hr1vGLJYadM9KshkSdVr6Ql9WVHL8usv8r78jQEHVuer28srdBPE/dxbw3KPII9q/EX X-Received: by 2002:a17:90a:a00d:b0:2a0:30b9:d57a with SMTP id q13-20020a17090aa00d00b002a030b9d57amr28545pjp.2.1711123188417; Fri, 22 Mar 2024 08:59:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1711123188; cv=none; d=google.com; s=arc-20160816; b=g3vUm9eUYwmKqoE8WTZBtR4Mq6XDcWLxyAPilnUppfeHmt965v+OHitItmKA2JmCwH 8naEERciAPYzCTiivDDcgV0dpnywKJ4VNGJehXsLWwRrM16jTZAZ+z9r5NKZioSzvJcC U7RQ35VFXn9TW+DzPsr2qDNMwmRCuvFzhRyWEun203XRTAOPtPfaNHrXXknU9z6jUu1X jyfrHcg2JZ/RFQFz5HtBVkuI38KhWxWLBI599rBlLS9smq2Sd1fZ6QVplAQOaf6cW9U2 QuLJ+HjHxhbQjR+z9kpOSu/ZREHozbXPGeN3WGpEwEMaF0JYZB80b3xtMuSeoJOM66p2 ha8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=CFwgDMEUMB4wd4GsrGkK1QjX6k423W5ZSY3n8Gudd28=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=Q+Z4iBTnNbOwKWIZ5w06RaOiGl9vYRwcRwjCBT4AjGUCBfIdW1/Tef7TkyI5Fo5eEP bdrdSyCc2M7D/hNaqX0ps1UgxC+OmjqXjLFp5mzOmaNE4wfkIxeoc/zYsxzCh09mvUP/ 2aPjN1Z/B6LlWA0CObqamhpDqqKO+h3EdO38OzvBjQZxtdkt3JStI9+V/veWkVyFT36+ lfy1KeIO8vD6Cl0WtwURcgBXSpz+6ODn9fBLUE6XQEE9MFrEdlB51G4vCnYFK3DBsAfR 5wFwmZeWd/TSWUZSU3iQjblg1g2cIiQ6eUcZoD6QZgwYFv8fGpYwIopgBUWlHvQ1kvlw ndyw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=CE+B8+Z2; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=T8GCiyA0; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=alKr6NpR; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id y6-20020a17090a600600b002a04111b075si936371pji.141.2024.03.22.08.59.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Mar 2024 08:59:48 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=CE+B8+Z2; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=T8GCiyA0; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=alKr6NpR; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rnhIf-0007Js-2A; Fri, 22 Mar 2024 15:59:21 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rnhId-0007Jl-FN for openvpn-devel@lists.sourceforge.net; Fri, 22 Mar 2024 15:59:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6RasUk8fE+BxzQSKEveXLHT6jkraxTELmQYAsOpzptg=; b=CE+B8+Z2nGjxmW0C772UHmeK2m b9YzPQDPnKBh4Mvm+Y8045tUZkfLrxCNwo6TJ5ldm3rgywt76OaMA5XaGYYy9gHeonpOZDD1S7YcL 6iNTUNHJSEP85Cb2fVoDj/pX/2oErPg6YOw8wcJ8n+goFsYnYM8PbJsE+WblpQaqPrWI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=6RasUk8fE+BxzQSKEveXLHT6jkraxTELmQYAsOpzptg=; b=T 8GCiyA0ur0DWKvyRguPOpJYquBZHy9rrTtqlpbYD8nAo75R4zrDFNsVXwcNFKJS6elNStlWYVSMOk 9JZERlxKUmtmVfCK3dSj1FpHBL4lu1W9cQExN3BOTzVxWT98WLBW/RyMlE7k+4x7fC6ggmqLQFPqT y27nD4Z0KABSJ3TU=; Received: from mail-wr1-f45.google.com ([209.85.221.45]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rnhIa-0003eg-0F for openvpn-devel@lists.sourceforge.net; Fri, 22 Mar 2024 15:59:19 +0000 Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-33ed7ef0ae8so1308632f8f.0 for ; Fri, 22 Mar 2024 08:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1711123149; x=1711727949; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=6RasUk8fE+BxzQSKEveXLHT6jkraxTELmQYAsOpzptg=; b=alKr6NpRgRpxb4eFhZP4DhZctFOBDlQPZCOcMbvuUYB2o2l/4cIFK+hcV9epwPcKJl rHYw2htQZOqW61+06sqYSF+X30MhG+cJQgTtWIUIWOg5eyCTLuJVlmswrzwwU3wy32WW 10d0rWzvCHSauhBHxtKoujaWcrRDflTKhZdP4fMESHeRGkqbvLjocPjYSRm6zm2pnGGL ObT7hywfD9MEGRkP45K/sfcc4+AgUxFE3Nn11Fh8takRB+dPSkDpJRvOsb7Crl8hTOLr Goe99FcKN6+gFG2f5oKQUCNmLlNfLCxzMmro4RnpqyVzKxSeAqaGlBVAur0lcLSG0pO6 drFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711123149; x=1711727949; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6RasUk8fE+BxzQSKEveXLHT6jkraxTELmQYAsOpzptg=; b=vAI1qoSsJ5qxv+uyan0P7yB1NfPCMWTrY8fZ0ZrnLaS2wUdLu8LT4UxybT0Np8ZiX/ rTi8tiX4XkrJqTqJokzpQ5s8jP2tAW4SUo1zq9xrpih24oShyNZhA4a1AfwPMazqYOb0 lsevOpWzNhbNu9qN2yr36bUAZZyeStrFxrHa8GWoDMBsjGWph7QIed4sTY2VUVwOFAzk iWdcKwB604LVj/ntjEW0o2tPp9OGaSTCQDEtw9gK+BGY4OdNqDYTmBSE9rhpeWGU2lxt Kw8G9l4wPEKZSwmvCjKm8clLbUmwapxSfhbGvlm25I9V2GBKzOlZylhmXKed9WoLMtE6 0FgA== X-Gm-Message-State: AOJu0Yz36A3M5l3n9rMKsQHbyRRUWVUlAkxc+PEajJ1RthIS+ASoagD0 XE36Za78QNz1LJepJNj9dRawiRZol2+ZcscXy2+4Rih8c/k/qFLL2SVyfmwpdQyBnBPK+0N9XI7 k X-Received: by 2002:a5d:4943:0:b0:33d:a190:f0c with SMTP id r3-20020a5d4943000000b0033da1900f0cmr1729898wrs.16.1711123148729; Fri, 22 Mar 2024 08:59:08 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id q13-20020adfcd8d000000b0033eab3520a9sm2344286wrj.43.2024.03.22.08.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 08:59:08 -0700 (PDT) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Fri, 22 Mar 2024 15:59:07 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I3c6fd36eb9daee9244d6dc6d9f22de1c5cf9d039 X-Gerrit-Change-Number: 545 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 0600ccb71ea7595b7d8e864b635468948ae6eaf2 References: Message-ID: <7a38a8ac8fa226b0c675a188720c8e89ccff6462-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.45 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.45 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1rnhIa-0003eg-0F Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Use snprintf instead of sprintf for get_ssl_library_version X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1794242708479407737?= X-GMAIL-MSGID: =?utf-8?q?1794242708479407737?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/545?usp=email to review the following change. Change subject: Use snprintf instead of sprintf for get_ssl_library_version ...................................................................... Use snprintf instead of sprintf for get_ssl_library_version This is avoid a warning/error (when using -Werror) under current macOS of sprintf: __deprecated_msg("This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.") Change-Id: I3c6fd36eb9daee9244d6dc6d9f22de1c5cf9d039 --- M src/openvpn/ssl_mbedtls.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/45/545/1 diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.c index b44ddd5..0730d25 100644 --- a/src/openvpn/ssl_mbedtls.c +++ b/src/openvpn/ssl_mbedtls.c @@ -1614,7 +1614,7 @@ { static char mbedtls_version[30]; unsigned int pv = mbedtls_version_get_number(); - sprintf( mbedtls_version, "mbed TLS %d.%d.%d", + snprintf(mbedtls_version, sizeof(mbedtls_version), "mbed TLS %d.%d.%d", (pv>>24)&0xff, (pv>>16)&0xff, (pv>>8)&0xff ); return mbedtls_version; }