From patchwork Tue Apr 23 16:02:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3689 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6bca:b0:576:af48:25c3 with SMTP id c10csp31532max; Tue, 23 Apr 2024 09:03:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW5xLOUlIQgx6GNgaIxQz+goaoRsi+5ymcSJ9GAYrc5fGiWX9ffTpT56nioIG/FzvhtoUJnhLyedL3dgGLJlPx5QN9iDHA= X-Google-Smtp-Source: AGHT+IEAYl3ROJiUQvsOiphzgDnvM9apBO2Y2mvrb1ZhhhEvYDP2yogulxYKRh9bMCG9Kv5etYsM X-Received: by 2002:a05:6a00:7106:b0:6ea:b1f5:8aa with SMTP id lh6-20020a056a00710600b006eab1f508aamr15605433pfb.3.1713888209876; Tue, 23 Apr 2024 09:03:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713888209; cv=none; d=google.com; s=arc-20160816; b=lBrQ0gwkQ8hlvSq/lunpPfsexw94BWARacsr5BNRkVrYFOeV7+2wWHnH2D+lMkPgWr UklICxBPaDx6V8h2+y/ma0X2hJhwRuIFLjp/3e3HwvFzeNwrm8ttqa4y2Ftfgj4Od2gN JAnYs9Kn2mfQxmM5OHyoJcBfvW0RsAM6HH94jpLBZ5kj17Vk5J00wJylaqkv1MdGX71q Sw6m5Du6kPlVMUgT41iGI47bathrV5EsDsL4afTCO6WNlMVKezrxI68+R+3yXh1VQY0o 2k2AlTIWnQZnPSXSzI8sfuOS+XFy5BJHHFm+g69eq0jBTGHTzQAg/yJYE27KcziDefz+ jeNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=OPAHXTA5bus7NFD2WH2UOySZkAhdx345e3S7L9lwL3w=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=ceilcq1FNY4TWJubnbFcrkq9r9Q23YLlm+0Fze/bsRe3sYInYqUSIrz5IfYsKNxdte dLiquhoKB8T2/g9PFyJGwK/FjimWkH93YZTyjF8QoASpifI4gPUqY1N0nAipHY0RmJVI 7A98dXKVmXRFs5OPggDcl5vb74WQ+pKyB511dxzxvAMM1zb8mHdfN7M+ls2wo35LsI11 TiK79dQ5ZIkOG1t/ZlkKu17ZEX9R7DK2uHgmj0sF5MUAElIThEEo42Q69InJt/Nw0ur5 SQBn/b9bmh72jVuMy7xwlzf9SX7UMD2K/QP+eSKAFMpJBqVFJKHHrZVY9H6qQlhbBo3Z 4ElQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=TJLhauty; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=IwRViQkV; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="Tp/XI7rh"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id f25-20020a056a000b1900b006eabed49580si9733777pfu.305.2024.04.23.09.03.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Apr 2024 09:03:29 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=TJLhauty; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=IwRViQkV; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b="Tp/XI7rh"; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rzIbb-0000GF-5H; Tue, 23 Apr 2024 16:02:51 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rzIbV-0000FT-BQ for openvpn-devel@lists.sourceforge.net; Tue, 23 Apr 2024 16:02:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VuF+wHzfPkbLwrzyIBlwjJMYtX/omxK4Wtwu+yVEZgE=; b=TJLhautyAk/T7eZsIgAZsdCLvC IM5GCVp95G9dvbm8KlrYZfTHwfcFDDmFo5LBWvtF6oLNSWmMJLQDQuRH1qV/9EozqFPGCojB0gF8C DBDe8nON+GnRouD22B/L2DrlEKTOzy/jhzIAV6Ah/2sd3Y4sakVVZ3EKU8gtmAS5yjk4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=VuF+wHzfPkbLwrzyIBlwjJMYtX/omxK4Wtwu+yVEZgE=; b=I wRViQkVUQe9RRcTavkNpAlKjw/0czfBRND0IJ/pbANmY3uhJXfEB/sdQZcKTEccx5OgTYDwx5rfy4 r431L05HbvfZiVz3W7K2NOI+gx8+Lh0fWkUy+gNR8gEkjjqO05rcPAlQmhBbdIDji4DmQioYWDaki ZnnB2cYM4pgKdGNM=; Received: from mail-wm1-f44.google.com ([209.85.128.44]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rzIbR-0003M0-JO for openvpn-devel@lists.sourceforge.net; Tue, 23 Apr 2024 16:02:45 +0000 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-41a0979b999so20362065e9.0 for ; Tue, 23 Apr 2024 09:02:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1713888155; x=1714492955; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=VuF+wHzfPkbLwrzyIBlwjJMYtX/omxK4Wtwu+yVEZgE=; b=Tp/XI7rh01WI4rrJncPEVQ5eIBygQE9jfSO+vT43fAoOvF8rqMWxzjEQCC9OhvqYvs D5z8VEkcMZtKRuFe9XYUjWLOWZxV8NxvypOnPwz+pk0kRK68eu3qRVMrRumA4aKOSIjR VGzM9jvpVkzqO1vbgWZ/Np/0C5HW/oRrVVAK6hnQfBVwfsFyLKFxrO5NZnh5FX7LpiwS E1Wb3akv8XaorPI1144Mk23PogUfzjJlOgUO+7JkfqU6jIVWmYD2pie7H3DC9i27h+4s Dba1/fw/+cmYAyUz0MWTKEIJaRtggJ1vy7cubNO17rYESliPcCR13PyN4xArmnd0r4fv tWsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713888155; x=1714492955; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VuF+wHzfPkbLwrzyIBlwjJMYtX/omxK4Wtwu+yVEZgE=; b=WVGR2MrNhk0wTAlohMrHeJ0R+0ARNxxhmlWmSxiAjrX72/rWNpKL4dlC0TRqnmgc0O zvdn0aycYfMLckdCOvRa8dSr11cIdeHBTwvqgK13WRTwom9nyIYEM7GEG/iufgTBwb5O pF/59RpZm4+zl6G4rXjytz2P/g3eOBKppIqINLt8mAzQmbFLjGlz/09g9uO2FDQtPHKJ XK0jzfsD54TgpRgWEeCvxmdyUGZH8B1wvJci5AYZnA5JvDGZAeCzrRVPHxjgiUKcolUQ tzxZq7uss546giiVBXc/+d21LzRlsjqmEv+IIHUzcB1WdhK2Bk8X/nPRz5xTYYxJAYqZ flYA== X-Gm-Message-State: AOJu0YyxyZjH7bnfx64yprHmQ5uDEftErNPFNQrhG0fjeylrbZqLYtmq 2VDplKvkt2503FM2OqJIiV+t5JH8XPkuhRDK/una5djvGst4snqivxE1CPMjkUJnDd1OSipPcQa i X-Received: by 2002:a05:600c:1f1b:b0:41a:5958:d6ac with SMTP id bd27-20020a05600c1f1b00b0041a5958d6acmr4691019wmb.21.1713888155153; Tue, 23 Apr 2024 09:02:35 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id g2-20020a5d5542000000b0034720354152sm14880624wrw.117.2024.04.23.09.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 09:02:34 -0700 (PDT) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Tue, 23 Apr 2024 16:02:33 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I34e96a225446693f401549d86d872c02427ef7d5 X-Gerrit-Change-Number: 558 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: bf7a9576d6a34bf4d85ee470b7d906b596e185e6 References: Message-ID: <8214f2a517b457547debbd1e352a68142eb56308-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -5.2 (-----) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-5.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [209.85.128.44 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.44 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1rzIbR-0003M0-JO Subject: [Openvpn-devel] [M] Change in openvpn[master]: configure: delete old copy of pkg.m4 X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1797142043517258865?= X-GMAIL-MSGID: =?utf-8?q?1797142043517258865?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/558?usp=email to review the following change. Change subject: configure: delete old copy of pkg.m4 ...................................................................... configure: delete old copy of pkg.m4 It has been 12 years, let's find out whether we really want to carry around this old code. Change-Id: I34e96a225446693f401549d86d872c02427ef7d5 Signed-off-by: Frank Lichtenheld --- D m4/pkg.m4 1 file changed, 0 insertions(+), 159 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/58/558/1 diff --git a/m4/pkg.m4 b/m4/pkg.m4 deleted file mode 100644 index cca47a7..0000000 --- a/m4/pkg.m4 +++ /dev/null @@ -1,159 +0,0 @@ -# pkg.m4 - Macros to locate and utilise pkg-config. -*- Autoconf -*- -# serial 1 (pkg-config-0.24) -# -# Copyright © 2004 Scott James Remnant . -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 2 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, but -# WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -# General Public License for more details. -# -# You should have received a copy of the GNU General Public License along -# with this program; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -# -# As a special exception to the GNU General Public License, if you -# distribute this file as part of a program that contains a -# configuration script generated by Autoconf, you may include it under -# the same distribution terms that you use for the rest of that program. - -# PKG_PROG_PKG_CONFIG([MIN-VERSION]) -# ---------------------------------- -AC_DEFUN([PKG_PROG_PKG_CONFIG], -[m4_pattern_forbid([^_?PKG_[A-Z_]+$]) -m4_pattern_allow([^PKG_CONFIG(_(PATH|LIBDIR|SYSROOT_DIR|ALLOW_SYSTEM_(CFLAGS|LIBS)))?$]) -m4_pattern_allow([^PKG_CONFIG_(DISABLE_UNINSTALLED|TOP_BUILD_DIR|DEBUG_SPEW)$]) -AC_ARG_VAR([PKG_CONFIG], [path to pkg-config utility]) -AC_ARG_VAR([PKG_CONFIG_PATH], [directories to add to pkg-config's search path]) -AC_ARG_VAR([PKG_CONFIG_LIBDIR], [path overriding pkg-config's built-in search path]) - -if test "x$ac_cv_env_PKG_CONFIG_set" != "xset"; then - AC_PATH_TOOL([PKG_CONFIG], [pkg-config]) -fi -if test -n "$PKG_CONFIG"; then - _pkg_min_version=m4_default([$1], [0.9.0]) - AC_MSG_CHECKING([pkg-config is at least version $_pkg_min_version]) - if $PKG_CONFIG --atleast-pkgconfig-version $_pkg_min_version; then - AC_MSG_RESULT([yes]) - else - AC_MSG_RESULT([no]) - PKG_CONFIG="" - fi -fi[]dnl -])# PKG_PROG_PKG_CONFIG - -# PKG_CHECK_EXISTS(MODULES, [ACTION-IF-FOUND], [ACTION-IF-NOT-FOUND]) -# -# Check to see whether a particular set of modules exists. Similar -# to PKG_CHECK_MODULES(), but does not set variables or print errors. -# -# Please remember that m4 expands AC_REQUIRE([PKG_PROG_PKG_CONFIG]) -# only at the first occurrence in configure.ac, so if the first place -# it's called might be skipped (such as if it is within an "if", you -# have to call PKG_CHECK_EXISTS manually -# -------------------------------------------------------------- -AC_DEFUN([PKG_CHECK_EXISTS], -[AC_REQUIRE([PKG_PROG_PKG_CONFIG])dnl -if test -n "$PKG_CONFIG" && \ - AC_RUN_LOG([$PKG_CONFIG --exists --print-errors "$1"]); then - m4_default([$2], [:]) -m4_ifvaln([$3], [else - $3])dnl -fi]) - -# _PKG_CONFIG([VARIABLE], [COMMAND], [MODULES]) -# --------------------------------------------- -m4_define([_PKG_CONFIG], -[if test -n "$$1"; then - pkg_cv_[]$1="$$1" - elif test -n "$PKG_CONFIG"; then - PKG_CHECK_EXISTS([$3], - [pkg_cv_[]$1=`$PKG_CONFIG --[]$2 "$3" 2>/dev/null` - test "x$?" != "x0" && pkg_failed=yes ], - [pkg_failed=yes]) - else - pkg_failed=untried -fi[]dnl -])# _PKG_CONFIG - -# _PKG_SHORT_ERRORS_SUPPORTED -# ----------------------------- -AC_DEFUN([_PKG_SHORT_ERRORS_SUPPORTED], -[AC_REQUIRE([PKG_PROG_PKG_CONFIG]) -if $PKG_CONFIG --atleast-pkgconfig-version 0.20; then - _pkg_short_errors_supported=yes -else - _pkg_short_errors_supported=no -fi[]dnl -])# _PKG_SHORT_ERRORS_SUPPORTED - - -# PKG_CHECK_MODULES(VARIABLE-PREFIX, MODULES, [ACTION-IF-FOUND], -# [ACTION-IF-NOT-FOUND]) -# -# -# Note that if there is a possibility the first call to -# PKG_CHECK_MODULES might not happen, you should be sure to include an -# explicit call to PKG_PROG_PKG_CONFIG in your configure.ac -# -# -# -------------------------------------------------------------- -AC_DEFUN([PKG_CHECK_MODULES], -[AC_REQUIRE([PKG_PROG_PKG_CONFIG])dnl -AC_ARG_VAR([$1][_CFLAGS], [C compiler flags for $1, overriding pkg-config])dnl -AC_ARG_VAR([$1][_LIBS], [linker flags for $1, overriding pkg-config])dnl - -pkg_failed=no -AC_MSG_CHECKING([for $1]) - -_PKG_CONFIG([$1][_CFLAGS], [cflags], [$2]) -_PKG_CONFIG([$1][_LIBS], [libs], [$2]) - -m4_define([_PKG_TEXT], [Alternatively, you may set the environment variables $1[]_CFLAGS -and $1[]_LIBS to avoid the need to call pkg-config. -See the pkg-config man page for more details.]) - -if test $pkg_failed = yes; then - AC_MSG_RESULT([no]) - _PKG_SHORT_ERRORS_SUPPORTED - if test $_pkg_short_errors_supported = yes; then - $1[]_PKG_ERRORS=`$PKG_CONFIG --short-errors --print-errors --cflags --libs "$2" 2>&1` - else - $1[]_PKG_ERRORS=`$PKG_CONFIG --print-errors --cflags --libs "$2" 2>&1` - fi - # Put the nasty error message in config.log where it belongs - echo "$$1[]_PKG_ERRORS" >&AS_MESSAGE_LOG_FD - - m4_default([$4], [AC_MSG_ERROR( -[Package requirements ($2) were not met: - -$$1_PKG_ERRORS - -Consider adjusting the PKG_CONFIG_PATH environment variable if you -installed software in a non-standard prefix. - -_PKG_TEXT])[]dnl - ]) -elif test $pkg_failed = untried; then - AC_MSG_RESULT([no]) - m4_default([$4], [AC_MSG_FAILURE( -[The pkg-config script could not be found or is too old. Make sure it -is in your PATH or set the PKG_CONFIG environment variable to the full -path to pkg-config. - -_PKG_TEXT - -To get pkg-config, see .])[]dnl - ]) -else - $1[]_CFLAGS=$pkg_cv_[]$1[]_CFLAGS - $1[]_LIBS=$pkg_cv_[]$1[]_LIBS - AC_MSG_RESULT([yes]) - $3 -fi[]dnl -])# PKG_CHECK_MODULES