From patchwork Fri Jun 14 12:55:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3730 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:a68e:b0:57d:b2cb:6cf with SMTP id hn14csp211425mab; Fri, 14 Jun 2024 05:55:55 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXgIVzTxsMeaMzD8OrGDrC2lZcKafMcjJXQOYFFMCEqZwO7IXLkob1C+QHPirqs79lzhXGcz453L+MYs2pyMr4whuTXrTI= X-Google-Smtp-Source: AGHT+IG2o6lTs9vYcyFIcQRbWNqHlDDQP5GQpCZHVSuElpubtTHMPMGC71g6HyI9h2FUF9t/x70U X-Received: by 2002:a05:6a21:7898:b0:1b5:9670:33e8 with SMTP id adf61e73a8af0-1bae82ca19cmr3129753637.5.1718369754873; Fri, 14 Jun 2024 05:55:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718369754; cv=none; d=google.com; s=arc-20160816; b=UV5cFCBuu0Ca8ImS1prv/Prwz8QFS6LxMQ22up+nQ7ewHix93mUkdL7fvulbfBbm1b 9pRZcK1YbFfPK3bPly9AdFTDPGUSp2b0d5Ud1++5UvvQXXdVHk6wX+euIME8b/1AS+oi 7DtWb5tl8HXAkNWwuzDdxl3PS0hZUYvlAtHU2A3+kUVIKaml5cCFRCvPmHv/PGdzB9vW fPZH/q0YkjwqAu7np+FvLwqQcXRTJzgzPHst6RLhUI+OpUAt9sLFo/5+IL5LzNDNXDDE 123CdZxIJ1WJ43hUiJVMBFn7x1EGqezz9Xl4gc+vH5InmveZ/70zYmSJ62wgJ+OxZm6t etxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=GoY6o+HmZX8Mv2zjJBc7eRXUd84q2fEhR5aL86Y4GuA=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=IDnNZjBbR+tjHMbL1OgUV9A0oHhEtJmeyE/i0NPAbfNWvBCws4aQKH45jPuEd9bXy6 XZAGZjNsW4XWHd76kycH9pXtJgnEjX7FIgUNRUrfYgSoTFgB4gxUm7TeZwgm0PM+D41O AvldKqSHrHT1856esWN7DTjhw+y886m5e4KQGq5T2TbrGxpZoOQb0SaSsccbEGoudW+E 0j4Pd4jPxdlTXFSSjcXSJMwa06ihqRZb041thShEcm3AFlNToVC2kSn0angC6BukZi9y mOVfadPHRlzoyq2OpK+ViQWoGKO1oYxvgz89IK1MBrOd5hnFjJ44Y3Np1MAy7rRV1/7R PVlQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=MH587pGq; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=beysG96W; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=U2xEceiO; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id d9443c01a7336-1f855ef4d9asi35531975ad.434.2024.06.14.05.55.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jun 2024 05:55:54 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=MH587pGq; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=beysG96W; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=U2xEceiO; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sI6Sn-0004Xk-OL; Fri, 14 Jun 2024 12:55:29 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sI6Sn-0004Xd-8I for openvpn-devel@lists.sourceforge.net; Fri, 14 Jun 2024 12:55:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mlKA0A12xMsScqqwuAOs3/vGVZ3IoulXxbDpOarrwZM=; b=MH587pGqad02k0MdpB2f08URW0 ArDeJLTyPjJIWp/6W6Hcjvr/mXmDRNa01C0Q0LVV01JaKPnpAlk/vaCNYa27fFFjgRc8Ko02ZKGxV ZA8AYkoZJgrxGyuUYKYQW8/4hPD6aU/N98CHASc+zXuFt/7p6Fjt3I9xCOyT+NOlgqXY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=mlKA0A12xMsScqqwuAOs3/vGVZ3IoulXxbDpOarrwZM=; b=b eysG96W0Mbyg7jQ69UmoR3x1JX3FLVzH9RepNYpTcDeUzZoIQh5/aE2ZSoMXk5MBlXcYV2hNZU5As 8Y85tr+tH+pWXExddPAWYJznWejliT7uWCgnH91A2gFk853OtNyHzI9/LKSdyZJplDMaTNrBxB6/D oIB7ZmbAG4woXAkM=; Received: from mail-lf1-f53.google.com ([209.85.167.53]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1sI6Sm-00080a-6g for openvpn-devel@lists.sourceforge.net; Fri, 14 Jun 2024 12:55:28 +0000 Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-52c4b92c09bso3242610e87.1 for ; Fri, 14 Jun 2024 05:55:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1718369716; x=1718974516; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=mlKA0A12xMsScqqwuAOs3/vGVZ3IoulXxbDpOarrwZM=; b=U2xEceiOkjhlhZaqHfYfgMZbYAEvcckhXV6RTmcILxyyKYQ7Y1QYvCEDaXnzhNoPak 0ESaXk/3P7rn3rgCJ9kH1y51WS0pCrvn5AjK4SnOieXe9H9rsZfNgJ5RTmv9PcAChMD5 gUaM/gkIxk1PonNrE91xczK16NyBFGAWeeyYijd68zAAJgOwVlDE43BYtObwHa3E4erR 9kxxT+2kKHqfGQDzOg+x5E8xNo47s+w/N/KcWTNa1JnsubAEqw767UW4SHs2MX1UjVi8 L9i8sgOWSVaH0LoAx6cPvnvGJinInuCcMEMcH/Js+B7Ve5a8Ry1NswaUVNCAZ8Wza+VP Rncw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718369716; x=1718974516; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mlKA0A12xMsScqqwuAOs3/vGVZ3IoulXxbDpOarrwZM=; b=oiJMqQ4m+ErmrOQrIUgAEUrGGFtYWimAeYpt5bKoa7JSLEkX0qiDqQMiRQGlEC+ksS 9tL4L363BxPDU9n+6oL/46fch4rrYgQnxraRdjbiS8s/d8+LawAV8p7EP/opSNgNYNKA 15tcKf0/szo2DUic9mmP3D+dbDEBDU5zKGOOkcWUPXP94IeLYHW60gwR2e6S5kBrr+3V 1503+GLfHujnMP0GhrfuIeJt46RWZNf90aX4eVYLWiH4R/kPNPesWhz3d3KSLprBn13P ZquY4m0GdmUAzOy8Y4Udlb0oaF1rHEvRLCe8gY3lbg8t25C6fWjKAyMUHfLA5d3B3rmU Tf+Q== X-Gm-Message-State: AOJu0YzhHyrx17DHWNviyVBNRcqy43+1DkdgTfAjZwo5UGXAxRzwRKL7 XFe4+H7QHfehqWX+gW6C33OYBnT0XefIZ0HsG7uumwSZaep2XpjhxNHYq5WHnU0uCnjSo9VURT2 P X-Received: by 2002:a05:6512:3991:b0:52b:c10f:995d with SMTP id 2adb3069b0e04-52ca6e9a84emr2340092e87.67.1718369715336; Fri, 14 Jun 2024 05:55:15 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-360750ad20bsm4293373f8f.54.2024.06.14.05.55.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 05:55:15 -0700 (PDT) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Fri, 14 Jun 2024 12:55:14 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I913bb70c5e527e78e7cdb43110e23a8944f35a22 X-Gerrit-Change-Number: 664 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: fc430c7d66ac9e147cb462c95d2dceec27673341 References: Message-ID: <8a97a2c846c3307974268b2232e5c1420e53fe00-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: openvpn.net] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.167.53 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.167.53 listed in sa-accredit.habeas.com] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.53 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1sI6Sm-00080a-6g Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Remove "experimental" denotation for --fast-io X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1801841283848843314?= X-GMAIL-MSGID: =?utf-8?q?1801841283848843314?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/664?usp=email to review the following change. Change subject: Remove "experimental" denotation for --fast-io ...................................................................... Remove "experimental" denotation for --fast-io This option is very old (from SVN days) and has been used by Access Server for many years. I don't think it makes sense to claim that it is "experimental" at this point. Change-Id: I913bb70c5e527e78e7cdb43110e23a8944f35a22 Signed-off-by: Frank Lichtenheld --- M doc/man-sections/generic-options.rst M src/openvpn/options.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/64/664/1 diff --git a/doc/man-sections/generic-options.rst b/doc/man-sections/generic-options.rst index f8a0f48..eb9cf28 100644 --- a/doc/man-sections/generic-options.rst +++ b/doc/man-sections/generic-options.rst @@ -215,7 +215,7 @@ are supported by OpenSSL. --fast-io - (Experimental) Optimize TUN/TAP/UDP I/O writes by avoiding a call to + Optimize TUN/TAP/UDP I/O writes by avoiding a call to poll/epoll/select prior to the write operation. The purpose of such a call would normally be to block until the device or socket is ready to accept the write. Such blocking is unnecessary on some platforms which diff --git a/src/openvpn/options.c b/src/openvpn/options.c index abcde89..f2c7536 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -268,7 +268,7 @@ #if ENABLE_IP_PKTINFO "--multihome : Configure a multi-homed UDP server.\n" #endif - "--fast-io : (experimental) Optimize TUN/TAP/UDP writes.\n" + "--fast-io : Optimize TUN/TAP/UDP writes.\n" "--remap-usr1 s : On SIGUSR1 signals, remap signal (s='SIGHUP' or 'SIGTERM').\n" "--persist-tun : Keep tun/tap device open across SIGUSR1 or --ping-restart.\n" "--persist-remote-ip : Keep remote IP address across SIGUSR1 or --ping-restart.\n"