From patchwork Thu Feb 13 15:25:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "stipa (Code Review)" X-Patchwork-Id: 4136 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:1d8f:b0:5e7:b9eb:58e8 with SMTP id hp15csp624959mab; Thu, 13 Feb 2025 07:25:29 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCX6x3fHFPq7t9Opa5EFHsrTmRxvirWyuo90gQZqJWfHbqn32pmqC2zhrQSV5s5jF+SFHfssZ18Qmg0=@openvpn.net X-Google-Smtp-Source: AGHT+IHQA1kVhFW5DuRQ+3MX4oRZs7MHg3G9IzWjYCHZmze10dnN4sb0rXYZuSZtud2L5AIBABeu X-Received: by 2002:a05:6e02:1a2a:b0:3cf:fd90:946a with SMTP id e9e14a558f8ab-3d18c235c47mr28484485ab.10.1739460329075; Thu, 13 Feb 2025 07:25:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1739460329; cv=none; d=google.com; s=arc-20240605; b=Qej1h9Bgh1VcCXvWIIcqe40QovQIMLk4fzhbS5rUx36hHapmCDi/eHeMqu8uc2dGkY zlPk/nSrCCuIrZQ8ltTP8CzpdgCgmXG0w3oXefY//ARBtUCNhNMxC7q8vNWXBXDTAFXk hxZ2EVWLjXXVNKULJqKY8JK+tFoVNAFpSMIVz00CTpwi4slgELm4zMkqpnyL2haFbYih ldV8Ngxsy6FxAJBgMpsxUXPRfmD4x/U7t5jKHv3cLjq7IE6fHA5qLRfxFoaBZk+B5EDr /m4FKqlwevjiwlLTe/t0+MfiXtC9eWxIlsrJoeiLBx+/o1H59iW7l38NYn5Mtt1xW2vC NfTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=hCA/k1FvgyJ1nFZsnbbpv3JCwvV6U2zAyEWR4CA27G0=; fh=lm0MLPW7DntlrDqRECIiC9JlE1uPxhepE0URYHIf+eE=; b=OictqecIuDM+sLIWSCy+XNYCjB5WE3x2bUzLKHln4uU5WumYD2NQT3GchSVUTTmT5f tDiQCKdhwHwT+JSKuedh8KgzCarp3+urplTCXrs6ldKWH2J5D08OnVbCaxh3ys4x0hhD Z40igTA8cta8bnuXsGQmlfadDTvntCO4mwBr8NS7Ehx2vHr/nVMHrNg4CKLL1ywqM+uU VtOpyGTOnBUsmrwZF2jMFeDOwoD9sOnh+oEJFgh7dfHQk/KGdXx77MgD39dzV/Bxc19f QcfDmtPQWsDA9EYqf0Fi+eHugM7zv+0LZ1wEFssItZ0lL1Yye4z8QgoMrlwrQfsLcbND p2mw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=cJNgv8H6; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=ddqIPvfP; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=ACRMz+d1; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id e9e14a558f8ab-3d18fb9a4d7si9726595ab.150.2025.02.13.07.25.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Feb 2025 07:25:29 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=cJNgv8H6; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=ddqIPvfP; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=ACRMz+d1; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tib5f-0006Fn-Rw; Thu, 13 Feb 2025 15:25:24 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tib5d-0006Fh-W6 for openvpn-devel@lists.sourceforge.net; Thu, 13 Feb 2025 15:25:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rkWoPrEE8xEpzsoyCSwnoaqkRR3HZeJmIWrL+QQOSA8=; b=cJNgv8H6n/ooOo0EW9+Vj3v1Tr azI3Gm9GQrTNwgmpNXL2WUjkYRAtJQ5som7TEGkulsx+j5LWDP79q2nYthQ+1zEJPaN1WOaHL80z+ DlNWkUFm/maZsylgJx3atNJh90dk1IPoB8cLartQE+32YhI6QBcnh2a1/rj56ILRx+og=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=rkWoPrEE8xEpzsoyCSwnoaqkRR3HZeJmIWrL+QQOSA8=; b=d dqIPvfPhmNww193EU5rlPrINyZdTtLe/Bs84wbh8ZYe0PhGcH/jmw5YGBzOY7piBBtB84lfsRnvTS LibzCm4BPqhmjVLuQOcTTs2xIQ/JGh88aNOkPnLsoTZ2zOzti6Ua7PLHbszS0+1ua/XFw/V0vzh8s QuCVGsI/SkxkeAGk=; Received: from mail-wr1-f54.google.com ([209.85.221.54]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tib5d-00087c-I1 for openvpn-devel@lists.sourceforge.net; Thu, 13 Feb 2025 15:25:22 +0000 Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-38f286b5281so336956f8f.1 for ; Thu, 13 Feb 2025 07:25:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1739460315; x=1740065115; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=rkWoPrEE8xEpzsoyCSwnoaqkRR3HZeJmIWrL+QQOSA8=; b=ACRMz+d11mFLx8XxT4We1F78tAtpIwsVndfDzeGaPE+uoMzs97w8Fp656zr09kwETQ th+SHXX4aXSX/E500d9uqwwLMVrO4lXn6W+aLM9rNfjm5imc5V2I/YSr9Tjrd8QDUVGA J9WbfAbKe0LqYZU5+RLlKY3+zTnfg7puxVJ7HjbOTOvMhP2SOXHs6qqnb26LCu7cKGzQ il/iU2BEbbkQVTQ3aOuk8xC4TBG6CeCZ6JIlh+5GfKM9RcX92BceaLtPHk0/CgLlkFzH NuD5uBfVK2xDUTAkbBWiIYlYpXcANYitvP9DIsLa2abBuNLLy+qv6pjVJJ0W2jPXcU9O iBYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739460315; x=1740065115; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rkWoPrEE8xEpzsoyCSwnoaqkRR3HZeJmIWrL+QQOSA8=; b=MDFq1fQxcCtJgdf+tWehRG5+/KESE3BXMenj75bBrzpaREpnFMW9DoPhkMA2vGeWnb flSnrgLzBi45kmB5c25PV4rIwihgrwMxot5wz5lCLKXNSKxbbhF5+5qNtgGKp/dyYtFD x65lusswXoZLFvMHw8A4IYbo9pp3gYMjM5urwUaBnCc2GcYJmlyMNgVwRtzsqzzOTeV2 n4kAKwkP4X+SYVzF+eZZ+Bem78pjR9aaiLUGUO5fw4bhe/hjhddnUBhXVlwdvPKu5lQJ LLSs+7L0gqACM07CThx7NaAyIngWw4kZWf7hXEVP0oE0x6eNkXTAsp+QCd9sieTvnmG+ v43w== X-Gm-Message-State: AOJu0Ywyr3/uV9zq5lQzP3nW0SXcE4g7NXygQZytR/Ry3UF2afqrtFIH +xsmwehDmsI7BJBBo9SjJu6hRvJpbg6w0Y0HjD8E9DFbTWoDAhUnwjR0ekHPiu5adVt2RJgV3Cf t X-Gm-Gg: ASbGncvTO5ANtYu8Sm6NiqiIbjCkjMtngw6tMHvyyOCYvMz/+py/ho1E1x2Ro2iLKis 0l0v9DSVGvruY9HSU1UNZCYSK2lueLo9Yo2CHt56MtBZ933E9TJkyIVa9SaUgHysh9ks6FJQYA/ zHCjwwYI28jMzcGVj4hVgdGwCWmFZLpDA61wjIERFIDHCU+G8GdE7q6mld1ULVBJDQziJiRJZVF 8WoDyXu8PTPvjPT+JIH74hcHTPjs/5/iCCKdbdkfmdPxDuFYL1R7bSqg3WgVZXVLyYKUj2lidHh cEIdvVsV+samfc0gYrju9X7Jo0TPc2YZZLI4Xbc8WnH+n4uSd20I8vgTuVcjWjY86zXnaTl91J9 pP20G13Q= X-Received: by 2002:a05:6000:178f:b0:38f:2413:2637 with SMTP id ffacd0b85a97d-38f24132b7fmr4984547f8f.35.1739460309791; Thu, 13 Feb 2025 07:25:09 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258fc8b4sm2210932f8f.50.2025.02.13.07.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2025 07:25:09 -0800 (PST) From: "plaisthos (Code Review)" X-Google-Original-From: "plaisthos (Code Review)" X-Gerrit-PatchSet: 1 Date: Thu, 13 Feb 2025 15:25:08 +0000 To: flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Ieb787a040f9eaf34d9d16996af1d63d7eae94944 X-Gerrit-Change-Number: 896 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: c54072b17f0e5f2e7629d4837b7d5e7aa5221a50 References: Message-ID: <991534b17e0d7ea6815039e7bc17021d3e6e9d04-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.54 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.221.54 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.54 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.54 listed in list.dnswl.org] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1tib5d-00087c-I1 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Add android build to Github Actions X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1823956354294823996?= X-GMAIL-MSGID: =?utf-8?q?1823956354294823996?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/896?usp=email to review the following change. Change subject: Add android build to Github Actions ...................................................................... Add android build to Github Actions Change-Id: Ieb787a040f9eaf34d9d16996af1d63d7eae94944 Signed-off-by: Arne Schwabe --- M .github/workflows/build.yaml 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/96/896/1 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 3ebea79..0be5440 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -35,6 +35,30 @@ run: test ! -s uncrustify-changes.patch working-directory: openvpn + android: + runs-on: ubuntu-24.04 + name: "Android - arm64" + # Github images already setup NDK with ANDROID_NDK_ROOT pointing to the root + # of the SDK + env: + VCPKG_DEFAULT_TRIPLET: arm64-android + VCPKG_ROOT: ${{ github.workspace }}/vcpkg + VCPKG_INSTALLED_DIR: ${{ github.workspace }}/vcpkg/installed + steps: + - name: Checkout OpenVPN + uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 + - name: Install vcpkg + uses: lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1 # v11.5 + with: + vcpkgGitCommitId: 80d54ff62d528339c626a6fbc3489a7f25956ade + - name: Install dependencies + run: ${VCPKG_ROOT}/vcpkg install openssl lz4 cmocka + - name: configure OpenVPN with cmake + run: cmake -S . -B openvpn-build -DUNSUPPORTED_BUILDS=yes -DCMAKE_SYSTEM_NAME=Android -DOPENSSL_ROOT_DIR=${VCPKG_INSTALLED_DIR}/arm64-android -DENABLE_PKCS11=false -DBUILD_TESTING=true -DCMAKE_ANDROID_ARCH_ABI=arm64-v8a -DENABLE_LZO=false + - name: Build OpenVPN Android binary with cmake + run: cmake --build openvpn-build + + mingw: strategy: fail-fast: false