From patchwork Mon Oct 9 12:13:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3391 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:b412:b0:f2:62eb:61c1 with SMTP id dj18csp1989136dyb; Mon, 9 Oct 2023 05:14:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6Su2y6fdpPVp6xRR2nQCT5Vh+4lEfJroDkSmveOt+2YVikCfjcdIEi+L972LcSvX2u945 X-Received: by 2002:a17:903:22cc:b0:1b8:2ba0:c9a8 with SMTP id y12-20020a17090322cc00b001b82ba0c9a8mr17006908plg.2.1696853643055; Mon, 09 Oct 2023 05:14:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696853643; cv=none; d=google.com; s=arc-20160816; b=nfuCZ5u+pTgKRMMS4PMegU0mRPtK9p1d8lJajgn2X0DGW40QFG4vnISd/0Ujz+wZ8K tEjSTNSX/dBoKeET7m6/fIjx2myOvwE4+kWn4ZoYL8LjMzlNpKvDk6+PgIz51EI48Xtv hJ3GyC1gPfc2zFMyRYVK42ICgQPJ+hGJiqrY/jrF+iklj0vgfuM2/0HivDuiOSSv0Ymz CZeKL+1SmFFqCB2qs4WIbjEqdFFBjOel5eJ8nFtBHzcVyZVBroVWGvkn6Gxrh5hfXTb4 fqR0EosR4BzoeIQoNxcqoP7l8Q7nA5ifuVONcNWQnR4r/mwvP+q4+ipicJ+wSwaAqYbJ cbPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=p3DHoMWPR5KMvcfFQq87ioR3v1S3A1iF+3MCrMLTnho=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=LdEBtErkC8VNOgo11OzE//fMbnQBJWUAd7w2RWVz1lvDLnAnytgH9eoDj6yczPANka 6p+p0+Tp38omxQlozqDnE1wu0afPUo6Z0hpF5nEH0FrDo0ONOrhsbYkgHeGKzUwMHDO7 pFkrgUIVnNeI6s+vT+JGawBAAaIFTX0R27HEo7LOljfiq2AVpsoUJ0UiqZfhaTcECk5e a6uK2pOk0QpZugQOJ8nUzke26M41UPmI7lChIc/8Eh2h7rrfeAS3DShFBraFFXCjNoHY BJCdN2bOPTCr3dyFMVJi4+3ooi5i0kqO9kKlhwPl/jo0hbzr1V0xhkeKiUIdBjx3Vgop ZMxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=JRi3OP2r; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=IV4KZXlV; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=TYb3ZAoO; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id d10-20020a170902654a00b001bf01fee6bcsi9462556pln.610.2023.10.09.05.14.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Oct 2023 05:14:03 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=JRi3OP2r; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=IV4KZXlV; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=TYb3ZAoO; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qpp8i-0000Qp-Bd; Mon, 09 Oct 2023 12:13:36 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qpp8h-0000Qi-9z for openvpn-devel@lists.sourceforge.net; Mon, 09 Oct 2023 12:13:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4MB3+cXoixX6/jwW7rqzktG78Az2Rkb3zQ9EXit+GeE=; b=JRi3OP2r3QFKJy2vt/4bZDabUT ZfqqhMMEBhUepSLILCyOrO2r0MhQ87YuRgf/U9qHMcyMhTjsbI6PTIR4rSZT5NbbQHAe5A7Y6E0pt D1UkgG25hRsbeELRFzCse+kWbUVmTBmImDHBBM/9f4WrXwYRYCqu88YrvWqUcDPeO/UQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=4MB3+cXoixX6/jwW7rqzktG78Az2Rkb3zQ9EXit+GeE=; b=I V4KZXlVSDBz5m9tFZUwal47Vws5/c9YcxYhg4vnusl1KA1Fo3jBTOPZzL6OsB9zs7rtf2DdLv5pyg xOMwu0k4cFYKmclReZPF6CU3kqjgnx/qKB0t0TmFUEfGNy0ULTEw8n7cDFO5Vrj2+5iOeWnsN8DKq VrwABs4fOmP9dSLY=; Received: from mail-wm1-f51.google.com ([209.85.128.51]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1qpp8c-0008SQ-KC for openvpn-devel@lists.sourceforge.net; Mon, 09 Oct 2023 12:13:35 +0000 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-405524e6768so43216905e9.2 for ; Mon, 09 Oct 2023 05:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1696853604; x=1697458404; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=4MB3+cXoixX6/jwW7rqzktG78Az2Rkb3zQ9EXit+GeE=; b=TYb3ZAoOO42OLxcWag77kfQyFGuP+/1/Rl/KkkWwuv/6qAle881Cxv2/erPue/mzpg DAt88iJuTMBp+adJZh5fSfuy5cBiOyEqfJITuS/EctkYtA2S96WUm7mFfBT65KFE7vm1 CxaLAixk4DnSbnkdOgVBej2AYX31Xp+NuZAjTgR818TR4bJ0x6+8364owbJWPYsCgpDG A4w0HA0BV5d3QReQ98oPh13kaAvdAP/ng9yuMfD/1fGVDjJlpRfC9V+WcmsbkEgJxxRr aO6XSpBvc0kHe5FT4k5xC4yUqbzOUkUovtL7gSCgJnCHNiK4PLv+nRqjY3BsYUSplr2Z 3WDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696853604; x=1697458404; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4MB3+cXoixX6/jwW7rqzktG78Az2Rkb3zQ9EXit+GeE=; b=Mx4Xxx++VisgX/ZyyHGWDOJIoIE0Nl3rXKp/RVoHb1cxr1hLCggRKbwuobq+mxFyGt I2toqiwQo4nfziTSqTLx0aVGmGzo6NIAO2IZtwz7z+453XH/DRp7fnQfO8WASNomNbks DGXYQPsbL4dSTQWADIwhpLbbRbGRnHPoc6a3f4d8DMY4/TNVivo6Q3woifXzm/Wnc7xT by7H4FYeXobt8+SWb1xRy1TVkdCsOrqSBjeEKM/QSRskRA8aC2MfK4JtDpg/Dzk03oRh W0zNIlLkThJ3DE2EZRLx9RNvKQXvI2WHG3A/wXLu4joE68wjWx5fyvKdP1SMxgF2ylUO eVYQ== X-Gm-Message-State: AOJu0Yw0q30B0dzfJqe3l+Rjjd3rSlMNLE1CDzJ6XrlLNrXfUqS7DW4h RK+yQbRM9Svst9gPxiFb60Fwiw== X-Received: by 2002:a5d:4b11:0:b0:31f:ecb2:1bed with SMTP id v17-20020a5d4b11000000b0031fecb21bedmr14392100wrq.15.1696853604236; Mon, 09 Oct 2023 05:13:24 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id a9-20020a5d5709000000b0032320a9b010sm9560671wrv.28.2023.10.09.05.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 05:13:23 -0700 (PDT) From: "unauthorized (Code Review)" X-Google-Original-From: "unauthorized (Code Review)" X-Gerrit-PatchSet: 1 Date: Mon, 9 Oct 2023 12:13:23 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I9c1c255f412f3e8ea68ccb1b16ecdd7ad891b308 X-Gerrit-Change-Number: 401 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 6f31481621abeef2a06862429bc7fa8bae0737c1 References: Message-ID: <9c060110e432e7a48cf79af8d37eed934d61732d-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: 0.1 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (0.1 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.51 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.51 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 FREEMAIL_REPLYTO_END_DIGIT Reply-To freemail username ends in digit [flichtenheld79[at]gmail.com] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1qpp8c-0008SQ-KC Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Test change X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: flichtenheld79@gmail.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1779280005690149527?= X-GMAIL-MSGID: =?utf-8?q?1779280005690149527?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/401?usp=email to review the following change. Change subject: Test change ...................................................................... Test change Change-Id: I9c1c255f412f3e8ea68ccb1b16ecdd7ad891b308 Signed-off-by: Frank Lichtenheld --- M configure.ac 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/01/401/1 diff --git a/configure.ac b/configure.ac index 266b66f..4a52266 100644 --- a/configure.ac +++ b/configure.ac @@ -23,6 +23,8 @@ dnl Process this file with autoconf to produce a configure script. +echo TTTESTTT + AC_PREREQ(2.59) m4_include(version.m4)