diff mbox series

[Openvpn-devel,XS] Change in openvpn[master]: t_server_null: run server processes with 'ulimit -t 300'

Message ID 9da209bed85d709b06f7bb579e65937db12a86aa-HTML@gerrit.openvpn.net
State New
Headers show
Series [Openvpn-devel,XS] Change in openvpn[master]: t_server_null: run server processes with 'ulimit -t 300' | expand

Commit Message

flichtenheld (Code Review) Oct. 4, 2024, 7:09 a.m. UTC 
Attention is currently required from: flichtenheld, plaisthos.

Hello plaisthos, flichtenheld,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/777?usp=email

to review the following change.


Change subject: t_server_null: run server processes with 'ulimit -t 300'
......................................................................

t_server_null: run server processes with 'ulimit -t 300'

"ulimit -t" will hard limit the usable CPU time for any process started
to the specified number of seconds.  So if we have a stuck-and-looping
server process (which was observed frequently) this will make sure
the situation will fix itself eventually.

Change-Id: I7e5ac9b4a8594251c3b5c4655f9d74b021950098
---
M tests/t_server_null_server.sh
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/77/777/1
diff mbox series

Patch

diff --git a/tests/t_server_null_server.sh b/tests/t_server_null_server.sh
index 10bb44b..bcbd002 100755
--- a/tests/t_server_null_server.sh
+++ b/tests/t_server_null_server.sh
@@ -8,6 +8,10 @@ 
     status="${server_name}.status"
     pid="${server_name}.pid"
 
+    # limit CPU time of processes to "5 minutes"
+    # (so a stuck-and-looping process will auto-terminate)
+    ulimit -t 300
+
     if [ -z "${RUN_SUDO}" ]; then
         rm -f "${status}" "${log}" "${pid}"
         "${server_exec}" \