From patchwork Fri Oct 4 07:09:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "flichtenheld (Code Review)" X-Patchwork-Id: 3886 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:731c:b0:5b9:581e:f939 with SMTP id b28csp280577mag; Fri, 4 Oct 2024 00:09:35 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU5O2/TpoU7Fey4xmohEzTMnIM5kVCPKXWsxdiGLefvEAXjmxxUf28+pZ80SF6BTUGsBY9giKazDBs=@openvpn.net X-Google-Smtp-Source: AGHT+IECq7oieaTzEYn1PPcHE+M9nZMMumfq9uybdzswTdMvr1T9Hm1lWrIXGNqL3h8d3jYgHRYi X-Received: by 2002:a05:6602:8f:b0:805:2048:a492 with SMTP id ca18e2360f4ac-834e774a108mr426524439f.6.1728025775592; Fri, 04 Oct 2024 00:09:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728025775; cv=none; d=google.com; s=arc-20240605; b=WgQRpSnMH5A03LZhS304GyP8tpOnFMb8l4yV4x3h6KGbJV4faGJieuUMARl/JzB1sZ 0ktiy8RqNDKBCvM95FoBJswldvM5hxtQRyDxhe40fKShP4ZbW8cqV9yM1naYZOrCXFV6 aQfJNacGlFlwDhITkZ2MLOSAIAJLFAS3AhOkB+CIFzcryvrLTQ8DvXxC5SxQC0M9UHz4 ab23/S8xWOtC1MbGXDqYd5GyADF8vcK4BdtW7WxaI7G2ZhHAegMfJ66eORiQA+/+6jXD YJHHRom9Ri588mH7jNXqwbq441z2E1+ShR8fgokueWUIK7Mgnnu14BLZi9yfeBff+5nd IqdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=tgZYOtlZptbaOBVHeiy9+FaGxylJTHlPwow0MmJq60k=; fh=U7wEyxtwz2o5+UdevFSA47vNeG9knhWH0KV//QhD5a0=; b=KCskwAcN0PMK85SxMT1LSNW3W9M20faaD3nCUj0DWpr9F8A2mthhe6NfFg4sN7PYy6 IRxHJq5xAgG0CANcxOzNXzMxLbR7bIstqHdFdpm7McvheNhhZgZlIi1QzvfWyCMaFg+b IsDW2SpKE/pF/+3mZ0bZt0Bty6+HbdZtd9sBUseIDXN/Iti9QvoqkIgmqlTHeHl6DayG YXaLM1Tc0FkcyK1WIJ36ep1FgsLJq2L+srCQbOYtFYESyFsXd3hX0gjQaLsU+KlpSdQF dqJi9VKuxX+u6/UaRspNRWvQ+AEAEP8QtP211ypKn4qgh51s7ZX/nqNelAxN3KgGokdY OJzg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=mPcgtgs+; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=N3ynJtkL; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=I6FLK9hf; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id ca18e2360f4ac-834efc9c2b3si128847339f.23.2024.10.04.00.09.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Oct 2024 00:09:35 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=mPcgtgs+; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=N3ynJtkL; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=I6FLK9hf; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1swcRK-0002YF-JA; Fri, 04 Oct 2024 07:09:26 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1swcRJ-0002Y7-D9 for openvpn-devel@lists.sourceforge.net; Fri, 04 Oct 2024 07:09:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fFzQLgLwz5XR4hVNELpsTURRTH0P2ysp9TZTjHeZP98=; b=mPcgtgs+YID7xSr4xS69RoK8kK WdFViOcsAhgmrfr7z3eEwtTglT4rt60K8rdO8yAjQGPWVDCQorIn5ILfQUIIV1ojG52yHJqZYLDzn yxCUmV1DhrSBynj6bYSh4/t6CnfZhL82bEHqKaKo9qXgBlyAnvMLeeJMaSU1yJwCGroo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=fFzQLgLwz5XR4hVNELpsTURRTH0P2ysp9TZTjHeZP98=; b=N 3ynJtkLWGQTLKSL6USTm4JFlr8R5SI0Z33zNUJgD2o9UP8xNx/K2hU7dyCGKDJIq8V6x+9VLKzdQ0 2ENiksuI+/yEz41hgMCawqTlrsY2fiz//xgbqKJDIGST1T8wP4WAuzKxKKcdCqhGSYgs00quAPhcF AuJF4vIFLlUZDgpM=; Received: from mail-wr1-f50.google.com ([209.85.221.50]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1swcRI-0005cg-Ii for openvpn-devel@lists.sourceforge.net; Fri, 04 Oct 2024 07:09:25 +0000 Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-37cdb42b29dso1174220f8f.0 for ; Fri, 04 Oct 2024 00:09:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1728025753; x=1728630553; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=fFzQLgLwz5XR4hVNELpsTURRTH0P2ysp9TZTjHeZP98=; b=I6FLK9hfU+qoofmnZn4wKiiZs+MG4XjrCndC/bApkNq9fQUL+ibNMKdPHFQ0gIWWNE b6Gu3PR/lebzllbjz7p2P0cbUPjoUI7CQflrkdqoBaCzDd7/wrv7hn2P8xu3HkeHpMb3 /bL+xcRFfF1bLOUvFfs7MLu6H4Aly5qrgBabTb5yCoCFmqKsarFfI387b5i4qa9zwBav pTMO4PUTGBA7tCLgoRMO93ZR9sQxtFpXezx2i/cntklQf4fq/roDVupKz1EmKcBUyoj6 iCrIaVYlBwWhbAQAXagwt6k6SxmLe8cYXD4pa1LFlM3lK0p22NwNUjDdsX6JGGzJ33/7 1Y5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728025753; x=1728630553; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fFzQLgLwz5XR4hVNELpsTURRTH0P2ysp9TZTjHeZP98=; b=hy1cMbs9dn/I13YL50motIFPX5u3AfFNEhNNA5VR72y3UMHsMtiJYgFNi8zzNXs5gy ArRvpzQfSVGrS2weSJTSNC3W+9Zlly5VWFaqftMLF3FOIzDy9Nq2ELnlErrXlpTGBWfJ LJflDJCtVJ19ieeg+8p+4o+mxvc4Lqp5IQdcgAusP8znb/XROD3P3XwgkYtZdJXAbe0V t8b7EdSCcKo+Cdmc+Ws5uJPTa56to++O4PLNozSQx4dj4JIrgbL9xy3EPtNcX8WDHgMR mPyecJE+BPx+73mcxQhnrANDNlSGY1B2kfx2aVZpy+t03j+VCcIEGJZ/F7x8MHbASMZ9 zMEA== X-Gm-Message-State: AOJu0YxClGyMJ71lda3KhtAnD/fCArI6pqLJ1tfkYiWdqj0pOGixK5TZ okkYce0qMv2pNyAPdyvd8704qEdGjzzuUzttgzhLjTXcHW6QnA9muPUwOKNDlb4= X-Received: by 2002:a5d:648a:0:b0:375:1b02:1e3c with SMTP id ffacd0b85a97d-37d0e8de99dmr1542311f8f.45.1728025752828; Fri, 04 Oct 2024 00:09:12 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d082498cdsm2643739f8f.59.2024.10.04.00.09.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 00:09:12 -0700 (PDT) From: "cron2 (Code Review)" X-Google-Original-From: "cron2 (Code Review)" X-Gerrit-PatchSet: 1 Date: Fri, 4 Oct 2024 07:09:11 +0000 To: plaisthos , flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I7e5ac9b4a8594251c3b5c4655f9d74b021950098 X-Gerrit-Change-Number: 777 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 98efc646bb9df6447450045b5cf8c49673d627b9 References: Message-ID: <9da209bed85d709b06f7bb579e65937db12a86aa-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.50 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.50 listed in list.dnswl.org] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1swcRI-0005cg-Ii Subject: [Openvpn-devel] [XS] Change in openvpn[master]: t_server_null: run server processes with 'ulimit -t 300' X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: gert@greenie.muc.de, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1811966355621457735?= X-GMAIL-MSGID: =?utf-8?q?1811966355621457735?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/777?usp=email to review the following change. Change subject: t_server_null: run server processes with 'ulimit -t 300' ...................................................................... t_server_null: run server processes with 'ulimit -t 300' "ulimit -t" will hard limit the usable CPU time for any process started to the specified number of seconds. So if we have a stuck-and-looping server process (which was observed frequently) this will make sure the situation will fix itself eventually. Change-Id: I7e5ac9b4a8594251c3b5c4655f9d74b021950098 --- M tests/t_server_null_server.sh 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/77/777/1 diff --git a/tests/t_server_null_server.sh b/tests/t_server_null_server.sh index 10bb44b..bcbd002 100755 --- a/tests/t_server_null_server.sh +++ b/tests/t_server_null_server.sh @@ -8,6 +8,10 @@ status="${server_name}.status" pid="${server_name}.pid" + # limit CPU time of processes to "5 minutes" + # (so a stuck-and-looping process will auto-terminate) + ulimit -t 300 + if [ -z "${RUN_SUDO}" ]; then rm -f "${status}" "${log}" "${pid}" "${server_exec}" \