Message ID | b6d77eb7a6a30c52e59dd86b0e7c23528728b186-HTML@gerrit.openvpn.net |
---|---|
State | New |
Headers | show
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net> Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:c520:b0:5e7:b9eb:58e8 with SMTP id jx32csp226999mab; Thu, 30 Jan 2025 10:13:38 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWEM+yKhVgyj5Z8fjZIWopG2yCW8yrVOqOR8DLQJPramtzYdLZh5s0aurQEnnvv3NzJ6DBhyCLDC74=@openvpn.net X-Google-Smtp-Source: AGHT+IHg7yjKrtDABE+tzYwHNaUAPSbSBlfEhGWfai+0+b82KG3jufl7TIV3nkxOaYGAd9JAbpwb X-Received: by 2002:a05:6e02:1aa4:b0:3a7:8720:9de8 with SMTP id e9e14a558f8ab-3cffe3ff5aemr77464225ab.5.1738260818178; Thu, 30 Jan 2025 10:13:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1738260818; cv=none; d=google.com; s=arc-20240605; b=PpZmL0G8WtDki/2pSCTJ5yEy+p/xpgnwzl/uj/zltlpcvRw5pr+9re2QHBFGhv30o6 jHljHXII9LYm0EzCrZnezqNSWCQwRvW3EQlaA6kWXOYEJuomHmsI4GRhCM+vWw55b8gq BreFAqtoc/q4yZMnp/r+8ulzbby167FNIu1F6SFWr79ZoK12TGSkaDSuLJ1pEyO0dSdK hRX2N9wN5VRphpdBc/j1y7tgV2OzewiWGbJRn9nS9LHl0+aRQOCwgIhHzx2dmRsgBs0Z FSsRJk1dUpm0jPLlooRbw/HOXWVz0MVf9xwSlbXnBJZpuFnG1HZkknTfNq/vG4N/TuBL mIgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=Cp47vgI1w5iHqZAYa9vfNZsqaiuO9SOaw2SULrDIcds=; fh=U7wEyxtwz2o5+UdevFSA47vNeG9knhWH0KV//QhD5a0=; b=QrZad5Y5IoB51PvOdUB6YNIP+/f6VKPAgiluKryot+34UuGaCW1WZEpSW/K++9B70u luNzIiOi6oCUZMGL/r87kVei7Tx4K02iRgcpH28wMiurYEn8eAY+D3B7bsYakfz6lI0Z VYvHgPA/xXhK2t7gIQ6uye8kT6uMhNMkQ7n038Dim2ZwdBZ83SKOm8B16xNkK9MjTBvw BodDOi6tY3LG3ICkd+SSI+1WLJkV3Dc6BXzEkbqu1PhpLgNdzng0z9fRA+pkhpOVfj0k XHThymSSu5fMgFN9i5Prw2Ca7jpXMBjJUO9EenLc7EQw08gk/CulZHcOPw980LwfKtCx Lxbg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=HiQOw97X; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="T1IE0/IO"; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=XxVOtGtW; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id e9e14a558f8ab-3d00a50939asi17562285ab.42.2025.01.30.10.13.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jan 2025 10:13:38 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=HiQOw97X; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="T1IE0/IO"; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=XxVOtGtW; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from <openvpn-devel-bounces@lists.sourceforge.net>) id 1tdZ2f-0003Vd-Ng; Thu, 30 Jan 2025 18:13:29 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from <gerrit@openvpn.net>) id 1tdZ2e-0003VX-QJ for openvpn-devel@lists.sourceforge.net; Thu, 30 Jan 2025 18:13:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gE8jAA34lQAh8uGW1zIYnnQeli7sd/kgYY/Sd2R6e3s=; b=HiQOw97X5IdSnFUG8jLYtQwCrW Ldc3cmwufdM7X4T7rpIifq5Gsr6hep712XCBYQGM8rah2qpvg5wA3pm5tv/Vxocl0mhuDPEZbvu3G FeE3/ZaNuAf4oba7R71FUBBMfuDWPANNVViEXoPZcTs0J66YP7M4HamSFWR3MT5s/RvM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=gE8jAA34lQAh8uGW1zIYnnQeli7sd/kgYY/Sd2R6e3s=; b=T 1IE0/IOjJFQGy7YFnslvxx+vkYYB/9RaqEelH9C2xyqM7wbNtIAQLK4PuZ9nxWMgufh/3we33Bp2J UjjAGS+f+HiKZlGVYEfGmDQ1KsE/m2Cd0KMPHDj+pdR9y+f7Q3gv4+l9xqqY5Cbo5kKhK5YcfGpKA FeLAX95kSX/tVy0A=; Received: from mail-wm1-f47.google.com ([209.85.128.47]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tdZ2d-0002fP-Cb for openvpn-devel@lists.sourceforge.net; Thu, 30 Jan 2025 18:13:28 +0000 Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4361b0ec57aso11973985e9.0 for <openvpn-devel@lists.sourceforge.net>; Thu, 30 Jan 2025 10:13:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1738260801; x=1738865601; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=gE8jAA34lQAh8uGW1zIYnnQeli7sd/kgYY/Sd2R6e3s=; b=XxVOtGtWyTQNnOZLle0r8BgDvqMTxVMi8Y6rCkPCAzrNx2bI/Vvl/lCrW8ZCu4wPbl 289dUPe3CcifShpdfzzWyl2bSgBW7j0jEWJhNKvnHguBAjM0LMgJtHFiQmzRb03Xy1HL t8epzkEv/PqNU40o5joL2V8ATmBa6kWpmQYgmFH4w1vVcwfn0T2Io0a49bP/NZe/ejmd KFeacWS3L4Ew3V7zYWKDqC2SEIXYccPxAd+E5BD8jG5K6ada4HcCvP0bZxibrbaWOu1e BeAyVMWAXbRrduPwMQrqU3Zzf1kdHj64nRYEfXBdXGrTUa5KN/uyR7gH+i1fPxaYf2s1 2OMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738260801; x=1738865601; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gE8jAA34lQAh8uGW1zIYnnQeli7sd/kgYY/Sd2R6e3s=; b=ZymxVQQWzCWGWPFXSIHV0sObDGeTFSwuWKZa2jtjdsP8FGQLHMdMYED+XgBxLcMXgi ZeC69s7mX39jRzajJri6jAxxZcHpYYfBta8/a29QjbuBeGkqSLlnBnYWgOHvWUlvOBtz gZ8/O3WV4m3gI8z7rd/8u8PqH/zMOmTQEL3kXWjz3Q84Bt9pVhkB9qDO+zoUR3oJndGy gjTRpZs0sHn8OF9MNqX4jbJrfwmONilJt4zv98SV5vRrPPNHx3XoFztK0knQNE25W0Ss LcQrTRPEc9EJbxeNk1p9gh4KEqCSeF3vlkxML5+myPvlLG6DzGw/hD5sqxRPT0Wf/zp6 wCCA== X-Gm-Message-State: AOJu0Yxvdou/YWXPX6D3oiLrbBAQk+ZdSWWsCrz28RNiItu850xoHbVz 4IVtE8ntya7Hc2tZyWeYMepxsyAhTKtmY7VYtENwQo3a9zQDFb5OWnZD34BOXEo= X-Gm-Gg: ASbGnctGvpcUy94vGdfAI73J51Q5WxqtGvZ4yBEfoq/q06qyCV7O50QKgt3yaD7H/ik sJjf9lAbMKzuwYJC6SUfUq+d/Im5Xf3mUfSbDPjfqsEyR95t56jxjSBxhhY4ap+Nmx25M1mW5nU fqE7tSmm6/mHqec6CkhGX9YQZ1PLP3ikHJWPVnJUA+B9DKCHhmAjXfnDQkE2uMJcskA5Y0S5gMU KC3Z+Ial+FgTv7pdd1euA4pVdYJ08bzR47F0SvqriLyQjslQptkqaPTeiktKJBxBl+6+rFqrG+A KAkCREW3wa2//ZUnASZFeKB3ZGQf3DAngRXfChwPI2bjNUqKl5n8UgPCEfdt3OddFmilz1itxi5 FQu81T3E= X-Received: by 2002:a05:600c:3b0e:b0:435:d22:9c9e with SMTP id 5b1f17b1804b1-438dc40d6ddmr65867555e9.19.1738260800823; Thu, 30 Jan 2025 10:13:20 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438e23de35csm30838925e9.10.2025.01.30.10.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jan 2025 10:13:20 -0800 (PST) From: "cron2 (Code Review)" <gerrit@openvpn.net> X-Google-Original-From: "cron2 (Code Review)" <gerrit@gerrit.openvpn.in> X-Gerrit-PatchSet: 1 Date: Thu, 30 Jan 2025 18:13:20 +0000 To: plaisthos <arne-openvpn@rfc2549.org>, flichtenheld <frank@lichtenheld.com> Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I1db72d7dca648a8ea4ec65d173290a819971305c X-Gerrit-Change-Number: 883 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: <http://gerrit.openvpn.net/c/openvpn/+/883?usp=email> X-Gerrit-Commit: 80356f270e37e8efea53c96115750ebec26d3104 References: <gerrit.1738260795000.I1db72d7dca648a8ea4ec65d173290a819971305c@gerrit.openvpn.net> Message-ID: <b6d77eb7a6a30c52e59dd86b0e7c23528728b186-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.47 listed in sa-trusted.bondedsender.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.47 listed in bl.score.senderscore.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.47 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.47 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1tdZ2d-0002fP-Cb Subject: [Openvpn-devel] [XS] Change in openvpn[master]: get_default_gateway(): implement platform support for Linux/SITNL X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: <openvpn-devel.lists.sourceforge.net> List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>, <mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe> List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel> List-Post: <mailto:openvpn-devel@lists.sourceforge.net> List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help> List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>, <mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe> Reply-To: gert@greenie.muc.de, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel <openvpn-devel@lists.sourceforge.net> Content-Type: multipart/mixed; boundary="===============0387000579760068744==" Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1822698575907075712?= X-GMAIL-MSGID: =?utf-8?q?1822698575907075712?= X-getmail-filter-classifier: gerrit message type newchange |
Series |
[Openvpn-devel,XS] Change in openvpn[master]: get_default_gateway(): implement platform support for Linux/SITNL
|
expand
|
diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 3501e35..3605671 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -3333,7 +3333,7 @@ CLEAR(best_name); /* get default gateway IP addr */ - if (net_route_v4_best_gw(ctx, NULL, &rgi->gateway.addr, best_name) == 0) + if (net_route_v4_best_gw(ctx, &dest, &rgi->gateway.addr, best_name) == 0) { rgi->flags |= RGI_ADDR_DEFINED; if (!rgi->gateway.addr && best_name[0])
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/883?usp=email to review the following change. Change subject: get_default_gateway(): implement platform support for Linux/SITNL ...................................................................... get_default_gateway(): implement platform support for Linux/SITNL This adds Linux/SITNL platform functionality to the framework started by commit 9df51cf56 and commit 0fcfc8381f. Change-Id: I1db72d7dca648a8ea4ec65d173290a819971305c Signed-off-by: Gert Doering <gert@greenie.muc.de> --- M src/openvpn/route.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/83/883/1