diff mbox series

[Openvpn-devel,XS] Change in openvpn[master]: Move cipher/data-ciphers warning to D_LOW (verb 4)

Message ID cedbdcaecfbceb9d718b197844ff07afd73dedc8-HTML@gerrit.openvpn.net
State New
Headers show
Series [Openvpn-devel,XS] Change in openvpn[master]: Move cipher/data-ciphers warning to D_LOW (verb 4) | expand

Commit Message

plaisthos (Code Review) Sept. 16, 2024, 1:04 p.m. UTC 
Attention is currently required from: flichtenheld.

Hello flichtenheld,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/746?usp=email

to review the following change.


Change subject: Move cipher/data-ciphers warning to D_LOW (verb 4)
......................................................................

Move cipher/data-ciphers warning to D_LOW (verb 4)

These warnings served a purpose in OpenVPN 2.6.x to warn people
about the changed behaviour. But for 2.7 this is will be more
log spam than a helpful message. So only show this warning on a
high verbosity level.

Change-Id: Ie2797a82ad769cb640440d1ba7dfeb416e7b932d
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
---
M src/openvpn/options.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/46/746/1
diff mbox series

Patch

diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index 61f6285..6009e5f 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -3546,7 +3546,7 @@ 
          * parts of OpenVPN assert that the ciphername is set */
         o->ciphername = "BF-CBC";
 
-        msg(M_INFO, "Note: --cipher is not set. OpenVPN versions before 2.5 "
+        msg(D_LOW, "Note: --cipher is not set. OpenVPN versions before 2.5 "
             "defaulted to BF-CBC as fallback when cipher negotiation "
             "failed in this case. If you need this fallback please add "
             "'--data-ciphers-fallback BF-CBC' to your configuration "
@@ -3555,7 +3555,7 @@ 
     else if (!o->enable_ncp_fallback
              && !tls_item_in_cipher_list(o->ciphername, o->ncp_ciphers))
     {
-        msg(M_WARN, "DEPRECATED OPTION: --cipher set to '%s' but missing in "
+        msg(D_LOW, "DEPRECATED OPTION: --cipher set to '%s' but missing in "
             "--data-ciphers (%s). OpenVPN ignores --cipher for cipher "
             "negotiations. ",
             o->ciphername, o->ncp_ciphers);