| Message ID | d1434392bdaf6b1dfe2f393ed5fd3b2d851d23e7-HTML@gerrit.openvpn.net |
|---|---|
| State | Superseded |
| Headers | show
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net>
Delivered-To: patchwork@openvpn.net
Received: by 2002:a05:7000:6a49:b0:5e7:b9eb:58e8 with SMTP id v9csp178588mat;
Mon, 27 Jan 2025 17:50:46 -0800 (PST)
X-Forwarded-Encrypted: i=2;
AJvYcCWI6bH9ykJIOs0pWphOlzhP6TR+pfyMS8HVp6K6/OvFeKGowDyvyjiN2/bqIt+4FO0OLs2wWLtegek=@openvpn.net
X-Google-Smtp-Source:
AGHT+IGNDnMRq5cPTtWN7gwI3X3ggfAvgJMbArjq/yRNRNI4wmMfwFAKfLqmCAalCSNfBbg1X9bb
X-Received: by 2002:a05:6830:6186:b0:718:12af:c89b with SMTP id
46e09a7af769-7249da5684fmr28602884a34.1.1738029045854;
Mon, 27 Jan 2025 17:50:45 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1738029045; cv=none;
d=google.com; s=arc-20240605;
b=cXNVLW4aK+UzrYRil+yygJO4Sz1iiVsLfTUtYhjahjKEJ0a5AM9wDfNnztbPuSW9Am
Bsa0aWz4uQr22knnkd6Gf5tUJLH7WoOku7N4/BvmuMMXJK9nktLDy2/dPp2kliGWEZBH
kGJZMWeCK/p8npkDJsA2xAWpKwDYtFvYLZq7EFkYnzBVv+NEEh+gncwcsKvlhC2QiU0p
cZZZ4dhU0SY10Ghty0uX6K0g3S31uzfE1cONCFfWKCaqg7RX1Nl3Tp7JvBySYvNVribl
oWAfrLmFWSImj6o2lbrAomRU0GqjKaJHj3u/M9xA5YtzDSVONRHmp00FVjf1CDhmlkXy
F1fQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20240605;
h=errors-to:cc:reply-to:list-subscribe:list-help:list-post
:list-archive:list-unsubscribe:list-id:precedence:subject:user-agent
:mime-version:message-id:references:auto-submitted:to:date:from
:dkim-signature:dkim-signature:dkim-signature;
bh=TBx9GMAvi67brRGDP7HSPb+UYvV36JpXaY0FdxNmJsg=;
fh=U7wEyxtwz2o5+UdevFSA47vNeG9knhWH0KV//QhD5a0=;
b=idphaaXwrB7dIhJyEWeZie7DE63C5AijAXXF0aj3Eaqb+WuKa0sI5TdOZzsqd5fKq9
RzUuTksji3NIvbLGRZLX+IzlQH+fwCnQBnpr47QKozW18hYxqSJZz+sL++PnelTQrDEX
kEz3PD47xHKD5P/1rsMb/CJ1sPLIs6rw/GA4Nigo4QY1L9AlDdpPAmHUkxz87qeRuevy
YNGLIYfEqtJbNTC8fRUXHar8X+tPyw7xgGBAP7ZiGg3uy1GNTIGec/4CBdrcIcnlybiX
isHXXf+JAKsBozhCC9eKGBtZoh6IbSomwRr8wOAwzafA6s9mV7oIoEvM/uWi9vAqQgTz
pWIA==;
dara=google.com
ARC-Authentication-Results: i=1; mx.google.com;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=aBeU6+fW;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=BeRof6l5;
dkim=neutral (body hash did not verify) header.i=@openvpn.net
header.s=google header.b=eFEQOI6v;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net;
dara=fail header.i=@openvpn.net
Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7])
by mx.google.com with ESMTPS id
46e09a7af769-724ecf7e4b7si7086242a34.124.2025.01.27.17.50.45
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Mon, 27 Jan 2025 17:50:45 -0800 (PST)
Received-SPF: pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) client-ip=216.105.38.7;
Authentication-Results: mx.google.com;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=aBeU6+fW;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=BeRof6l5;
dkim=neutral (body hash did not verify) header.i=@openvpn.net
header.s=google header.b=eFEQOI6v;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net;
dara=fail header.i=@openvpn.net
Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com)
by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95)
(envelope-from <openvpn-devel-bounces@lists.sourceforge.net>)
id 1tcakQ-0000hX-SY;
Tue, 28 Jan 2025 01:50:38 +0000
Received: from [172.30.29.66] (helo=mx.sourceforge.net)
by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95)
(envelope-from <gerrit@openvpn.net>) id 1tcakP-0000hO-Nv
for openvpn-devel@lists.sourceforge.net;
Tue, 28 Jan 2025 01:50:37 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version
:Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:
From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=8rITNK5t4Ad8TVBV57CW4uPzefZnN3Ryg+2r9RJux60=; b=aBeU6+fWryzk5FOo2xOe7N5N6s
3mDZkk3md2T6reAxG4Hiq6enmHRiEd0NWI4cMfjW1/rpXiAaaXSpbusccpndcGu+sVU3FtermVRRe
cEHLPOrvuepNBWPplhF2qEwedgHe1vQQTblc7ExFIkz2vBMtNZdT9wMBQc+3rPqtddHE=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To:
References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID
:Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:
Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post:
List-Owner:List-Archive; bh=8rITNK5t4Ad8TVBV57CW4uPzefZnN3Ryg+2r9RJux60=; b=B
eRof6l5jaBwFjviv6cVzGyMOWzHHkglhihkzJnPQR3jEcD/tkEQERiHXNhP0U3QPhbhoPuzMHPOdo
weTWDwHH6UALLZq3jiHYv9sVOogwBMhXFzKbvE3TiXndH+BkjJYR14wNbWw1AFnlQ+gW7HLz7D4Ja
gNFacC/Vh5zRCYn0=;
Received: from mail-wm1-f49.google.com ([209.85.128.49])
by sfi-mx-2.v28.lw.sourceforge.com with esmtps
(TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95)
id 1tcakO-0000HH-Kp for openvpn-devel@lists.sourceforge.net;
Tue, 28 Jan 2025 01:50:37 +0000
Received: by mail-wm1-f49.google.com with SMTP id
5b1f17b1804b1-4363dc916ceso38412855e9.0
for <openvpn-devel@lists.sourceforge.net>;
Mon, 27 Jan 2025 17:50:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=openvpn.net; s=google; t=1738029030; x=1738633830;
darn=lists.sourceforge.net;
h=user-agent:content-disposition:content-transfer-encoding
:mime-version:message-id:reply-to:references:subject
:list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc
:subject:date:message-id:reply-to;
bh=8rITNK5t4Ad8TVBV57CW4uPzefZnN3Ryg+2r9RJux60=;
b=eFEQOI6v9p2+S7+IhO0pjgFkMgb2/fSZwe9KDJVFwLPGjgAcXEobHMHJsautVKIZCv
0uBIt5KnVfjSlQ9c93PIUAdO6vO11dy7drEW2ITEn8faHevGjbkUDsyv54AD28APRgfa
qEi4AxxbwJsY1RpPXiagsu+eli48Gcy5YTdeNQgNHI6RKcnfv+X8hWrWN17tMsWHnnL8
Hto5S/F4wgzphD5FiVo54U5Sevz4PI3qA7fPH0+qB1hICbWVHOIGWpO/PiwYQ/tDGrw6
8QAmgqo2qlrVZFthVQdqHuZ2Pm8er1COzlu6AyG+BLFr+iZzDFbMc2PjrsPtwjPPiahc
KMVA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1738029030; x=1738633830;
h=user-agent:content-disposition:content-transfer-encoding
:mime-version:message-id:reply-to:references:subject
:list-unsubscribe:list-id:auto-submitted:cc:to:date:from
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=8rITNK5t4Ad8TVBV57CW4uPzefZnN3Ryg+2r9RJux60=;
b=ru/DALUuxZ9hZEwXNDI8FvtjSiGKW7G8s6q0bPh/8LcTZ5w9hnM3crmXxy/wTRneGg
ZnYbpE11fCSGFe+vslT0dwjTiKkLQyTI+V0kRrgIkVtSAjvBMpGkxLqXxouK1B4mOYsX
O4Ti8zPla9rcsMk57P2OfdcitynmBsib34GI0vU5VT+0F3dmJwG+M3Ml3sfGPz9Tu0sA
9vRXd15KQgZeM8jMsllyrKMvNiQryZonRYRcQPaPpzt39A1oMH/hwTI3tKCmNox6WiAR
4lS7TkE15bNMBuXmIf5pLo5gBGXr0pzRs6dRJdVdyWAliRS4S7jAtMzwI5s7fcsNoZar
tVHQ==
X-Gm-Message-State: AOJu0YxMC9+aIQhIhQmT2PyPe56raWKamStVJnE4soXeo32vIa7cU4Dm
ToLSh2FPsjp/fncTXikQtb8bYm5IbdJaOB5ER6RMGpscmDXZGhkmvD4wEHTA6Z4H+ViXqQWgP1+
k
X-Gm-Gg: ASbGncsFZRu/YSQvwGeE7bYDy0vycY2Oz/yT7oFIH+Fd0ArhOa4v6nSerOvwlHX19Jq
BBfQ+WsWQIC92//UXEClhj6IwHLHiiXEWCEQHQLKFHEa6K3uxjhbhSNBNIFXkfHO6cPj6BRbbrX
qiJlqxEggXM8VhPeER/F7bm5zUJbhvh3gl4wQg//+eUesCxvuuBP7+wxGAmG4AIt7egPFsxY1lz
4Yhz3f8r0wGDhNRhp7S1JKyokU1sl1QKsEN/VosIG75RVg0LATM68GpxSWAYUi1cTN2VEe7M5x5
pN5SUjarIF1QLbOmGgzr/01l+JrmwFZ20bkIa/WmDh9kDcscJkVRnDNTHOZ8f9cmngTeG/7w
X-Received: by 2002:a05:600c:6a18:b0:434:fc5d:179c with SMTP id
5b1f17b1804b1-438d598101dmr12029005e9.13.1738029029940;
Mon, 27 Jan 2025 17:50:29 -0800 (PST)
Received: from gerrit.openvpn.in
(ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78])
by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-438bd575848sm147077885e9.37.2025.01.27.17.50.29
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 27 Jan 2025 17:50:29 -0800 (PST)
From: "kallisti5 (Code Review)" <gerrit@openvpn.net>
X-Google-Original-From: "kallisti5 (Code Review)" <gerrit@gerrit.openvpn.in>
X-Gerrit-PatchSet: 1
Date: Tue, 28 Jan 2025 01:50:29 +0000
To: plaisthos <arne-openvpn@rfc2549.org>, flichtenheld <frank@lichtenheld.com>
Auto-Submitted: auto-generated
X-Gerrit-MessageType: newchange
X-Gerrit-Change-Id: Ieca0f8aa07413682d39e73dd3ed21a0038d41f49
X-Gerrit-Change-Number: 690
X-Gerrit-Project: openvpn
X-Gerrit-ChangeURL: <http://gerrit.openvpn.net/c/openvpn/+/690?usp=email>
X-Gerrit-Commit: 00c3b13a62adc9f6f4d0244bb4434576f5b24b14
References:
<gerrit.1738029022000.Ieca0f8aa07413682d39e73dd3ed21a0038d41f49@gerrit.openvpn.net>
Message-ID: <d1434392bdaf6b1dfe2f393ed5fd3b2d851d23e7-HTML@gerrit.openvpn.net>
MIME-Version: 1.0
User-Agent: Gerrit/3.8.2
X-Spam-Score: -0.2 (/)
X-Spam-Report: Spam detection software,
running on the system "util-spamd-1.v13.lw.sourceforge.com",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Attention is currently required from: flichtenheld,
plaisthos.
Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit
Content analysis details: (-0.2 points, 6.0 required)
pts rule name description
---- ----------------------
--------------------------------------------------
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [209.85.128.49 listed in list.dnswl.org]
0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[209.85.128.49 listed in bl.score.senderscore.com]
0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[209.85.128.49 listed in sa-accredit.habeas.com]
0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.128.49 listed in wl.mailspike.net]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP
0.0 HTML_MESSAGE BODY: HTML included in message
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
author's domain
-0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from
envelope-from domain
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily
valid
0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted
Colors in HTML
-0.0 T_SCC_BODY_TEXT_LINE No description available.
X-Headers-End: 1tcakO-0000HH-Kp
Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Haiku: change del
to delete in route command. del is undocumented
X-BeenThere: openvpn-devel@lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <openvpn-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive:
<http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel>
List-Post: <mailto:openvpn-devel@lists.sourceforge.net>
List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe>
Reply-To: alex@terarocket.io, arne-openvpn@rfc2549.org,
openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com
Cc: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Content-Type: multipart/mixed; boundary="===============4990841310041053858=="
Errors-To: openvpn-devel-bounces@lists.sourceforge.net
X-getmail-retrieved-from-mailbox: Inbox
X-GMAIL-THRID: =?utf-8?q?1822455545222620762?=
X-GMAIL-MSGID: =?utf-8?q?1822455545222620762?=
X-getmail-filter-classifier: gerrit message type newchange
|
| Series |
[Openvpn-devel,XS] Change in openvpn[master]: Haiku: change del to delete in route command. del is undocumented
|
expand
|
diff --git a/src/openvpn/route.c b/src/openvpn/route.c index d17b285..12d6c07 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -2359,8 +2359,8 @@ #elif defined(TARGET_HAIKU) - /* ex: route del /dev/net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.1 netmask 255.255.0.0 */ - argv_printf(&argv, "%s del %s inet %s gw %s netmask %s", + /* ex: route delete /dev/net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.1 netmask 255.255.0.0 */ + argv_printf(&argv, "%s delete %s inet %s gw %s netmask %s", ROUTE_PATH, rgi->iface, network, @@ -2551,8 +2551,8 @@ "on connect only and will clean up automatically."); #elif defined(TARGET_HAIKU) - /* ex: route del /dev/net/ipro1000/0 inet6 :: gw beef::cafe prefixlen 64 */ - argv_printf(&argv, "%s del %s inet6 %s gw %s prefixlen %d", + /* ex: route delete /dev/net/ipro1000/0 inet6 :: gw beef::cafe prefixlen 64 */ + argv_printf(&argv, "%s delete %s inet6 %s gw %s prefixlen %d", ROUTE_PATH, r6->iface, network,
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/690?usp=email to review the following change. Change subject: Haiku: change del to delete in route command. del is undocumented ...................................................................... Haiku: change del to delete in route command. del is undocumented Change-Id: Ieca0f8aa07413682d39e73dd3ed21a0038d41f49 --- M src/openvpn/route.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/690/1