From patchwork Sat Dec 16 10:17:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3530 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:8d12:b0:fc:24ac:f0cb with SMTP id i18csp8491647dys; Sat, 16 Dec 2023 02:18:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHopbX1sDoeo2t9vEpwsmL+GRmQ9pOwf/OgQERwi7NZ4WEG3JaoT3cWMzwxh+N8Lni/mY05 X-Received: by 2002:a17:903:2311:b0:1d0:7c59:2a4f with SMTP id d17-20020a170903231100b001d07c592a4fmr26397681plh.0.1702721882573; Sat, 16 Dec 2023 02:18:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702721882; cv=none; d=google.com; s=arc-20160816; b=DvXojNf7UcAou9INwgmSkYneC1NWyalxl5PXb6IdlRbRUFPuY6TVuLmaczTYsY0/3t B88/cNXzYXqhTqQufYBxI4EKE8sFAWGNFJRLm9F7vv9HPYmwrG5+Oy/U2o60TlhB+bKk jZl1c7mTApdbWe31vX9rXhKSv1ELq58lEtBdMQ3TBBIkXbQy18CKl2oXS8Yycl5KK9gM mHplXfAejK0KCcPDybTySJV49Z07VItdTOH7Eu3shTFqSj55hhQQWupTaQPMnadL6dxh fx8lpb6S1gMqrPdWXfy7c3P4ZkkWZN72OTbKJIjYXBfN63nKp9lyLtvk/KTiGhAUYxry vSxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=vXzjdw+zhzA4XMmun6atTRRp4WRuLSY8KOMkMP4WyYQ=; fh=U7wEyxtwz2o5+UdevFSA47vNeG9knhWH0KV//QhD5a0=; b=knxeyBFff4XLadpHDfA6XVZ67uku/3sZ5x7yoOXRqUk4akA0s58c7hlmRSts4uFhqR Y5TmxJL61Q7K/czn1W6rRI4VJP39oWZgCikYs97OazLuFOfjJdRTp0pi8beK3afS0JFj wYb72G19SLZpypL1Vpe85ZJICEWvj7W12PvNCys9N+zbh19UT7QK+mBxBO7ktzVoAGRh 0Mnm21jirT/C3QUBcDq7UnVi8sIWzZ2nXbx+eJdpX0Db7VQeGne7wgy1q+v2xJnOmTgP VumWcLT9yOxs/REQv+ocCtR5nymHrGnS1GB1C62MfQLKDLscgw1zc0t38QMz6mtNDSym za9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=C2871GBC; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=QYHqKaa8; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=gM6dNGmy; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id k5-20020a170902c40500b001d2eb1a4f12si14911325plk.233.2023.12.16.02.18.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Dec 2023 02:18:02 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=C2871GBC; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=QYHqKaa8; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=gM6dNGmy; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rERjn-0000qi-FR; Sat, 16 Dec 2023 10:17:39 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rERjl-0000qc-Fa for openvpn-devel@lists.sourceforge.net; Sat, 16 Dec 2023 10:17:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NFIFSveAByCiWteRnJz1+y008f7m9L4N36TFHv8eORM=; b=C2871GBCa6q5mG2ZzSfSqjI7wR xvCDeeoJ0Ni8EseXQE1F2zp0y8mlCjCG/a4DAqHUDAGlKKsLhje5VvqxlLJAkcFomWdqGyi1Ln1te EflGfcTQniIdhG/2XAnEOag98FW4HRwKr7ujX3fILzXI/9ZG6YNsaFfsRFr0YER4pJ6Y=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=NFIFSveAByCiWteRnJz1+y008f7m9L4N36TFHv8eORM=; b=Q YHqKaa8d2KZH4ATX7FVDtvVnBBnV4fY2SqV8fBvBMLQEjWoEpkhTVH9/gmtbeamHaA8enPfe2uAVS c4wLqsSbWECjCAOmFO8UtPrlyJclZ6K03Xu5zBRsCiU+mjPH5L71xB611i5iEvKYWAk+VcmX3UVZQ RhiQYtJh6cnmXzw0=; Received: from mail-wr1-f53.google.com ([209.85.221.53]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rERjh-00048C-6H for openvpn-devel@lists.sourceforge.net; Sat, 16 Dec 2023 10:17:37 +0000 Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-3363aa2bbfbso1335187f8f.0 for ; Sat, 16 Dec 2023 02:17:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1702721841; x=1703326641; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=NFIFSveAByCiWteRnJz1+y008f7m9L4N36TFHv8eORM=; b=gM6dNGmyOVibNIABr0EPnvT+kehjOo48BeS+4hQhRCH7hZPSSUkR2+abWtfa7pWgGG zPKSjmQfjRv3NUErvYLj7McnsC3o3qnSo6iDF5xT4FfsoszSE/6MopXwJtemKEZfDvVN t7UHJPsyr1sMfqfCzLOBAENtdY/x9U5Ty38WluOOk2O1Nhyx6KvEiAtQTsuyBUHPHVm/ w8gkD/GdEqZ7chcTYvRKF0E48RVTF1wWmJi6BVzaLHEl2lAlsf2/v2VI3vy7XzX/NDpK UfT2vS8z9SA/J6+LToW78UYqrJhzGIdy7jr/kYDIPUHevuimkpBzDoxhKKNmmbiTveGj CqEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702721841; x=1703326641; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NFIFSveAByCiWteRnJz1+y008f7m9L4N36TFHv8eORM=; b=E2eaVopHlqn9icq8ie1zrll95nKh2u3GG901He/xuvKsCiibGLGupqPPNnmA2GQeV0 7ZXbiaVTrt7a9AHs3sE6o4A4XfOHQP8qoUxssqBUVq/0/sawbIw6Fnsw8/rPOP+G/j/D 2FxvNK5HAgReHNx3eubBLgMmKa3VCi856fMXGvEAU8dL6vYeGgseckxUxC9/E4U6JjfX SBtkIT2HymeMrTnZUP2dr8eEJs5j3DWwt8sE8hU5hG9syKNSnf81DZgEzsptl9d+ZAd3 YnChQXlrQOlweYbbrKiZejCtgYtLz8BGonpPUY0FqkY6D5ge3eyBdmun1PILAJEfg61m a5pw== X-Gm-Message-State: AOJu0YzbbuTIhLrqh2kMhP566GZM8ab6hVMbauUKQ8Skdf7GZ3j1N4bU 21nPbjEMgrujDWLnXRl2dRoHMbC5wUSGgq2PlRs= X-Received: by 2002:adf:f44b:0:b0:336:1035:b781 with SMTP id f11-20020adff44b000000b003361035b781mr7654565wrp.89.1702721841305; Sat, 16 Dec 2023 02:17:21 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id d9-20020adfef89000000b0033342978c93sm21169823wro.30.2023.12.16.02.17.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Dec 2023 02:17:20 -0800 (PST) From: "d12fk (Code Review)" X-Google-Original-From: "d12fk (Code Review)" X-Gerrit-PatchSet: 1 Date: Sat, 16 Dec 2023 10:17:20 +0000 To: plaisthos , flichtenheld Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I5d835f37d9b75a2eba39504e673597cf7b6f8989 X-Gerrit-Change-Number: 484 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 77288f8622b7ca44c20bfd46beed203ffa6d0cc4 References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.53 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.53 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Headers-End: 1rERjh-00048C-6H Subject: [Openvpn-devel] [XS] Change in openvpn[master]: cmake: build native binaries with debug info X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: heiko@openvpn.net, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net, frank@lichtenheld.com Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1785433300542066950?= X-GMAIL-MSGID: =?utf-8?q?1785433300542066950?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/484?usp=email to review the following change. Change subject: cmake: build native binaries with debug info ...................................................................... cmake: build native binaries with debug info Since the cmake unix builds are not the officially supported way to build openvpn, it makes sense to always do debug builds for during development. Change-Id: I5d835f37d9b75a2eba39504e673597cf7b6f8989 Signed-off-by: Heiko Hund --- M CMakePresets.json 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/84/484/1 diff --git a/CMakePresets.json b/CMakePresets.json index 135b19d..46aeeef 100644 --- a/CMakePresets.json +++ b/CMakePresets.json @@ -199,8 +199,9 @@ "configuration": "Debug" }, { - "name": "unix-native", - "configurePreset": "unix-native" + "name": "unix-native-debug", + "configurePreset": "unix-native", + "configuration": "Debug" } ], "testPresets": [