diff mbox series

[Openvpn-devel,XS] Change in openvpn[master]: console_systemd: remove the timeout when using `systemd-ask-password`

Message ID d87c0c72c3c6dd06d7f978da27f368425f2f45f7-HTML@gerrit.openvpn.net
State Not Applicable
Headers show
Series [Openvpn-devel,XS] Change in openvpn[master]: console_systemd: remove the timeout when using `systemd-ask-password` | expand

Commit Message

plaisthos (Code Review) Jan. 14, 2025, 1:43 p.m. UTC 
Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/866?usp=email

to review the following change.


Change subject: console_systemd: remove the timeout when using `systemd-ask-password`
......................................................................

console_systemd: remove the timeout when using `systemd-ask-password`

Without this, the password request will expire after 90 seconds leaving
no way to provide the password without OpenVPN asking for it again.
Given that interactive use will wait for input without a timeout, it
makes sense to have non-interactive usage also wait until the user is
ready instead of forcing users to race against the timeout.

Change-Id: I2791d09ab698d89dc7e0183151f77b84024ad6d1
Signed-off-by: Ben Boeckel <ben.boeckel@kitware.com>
Acked-By: David Sommerseth <davids@openvpn.net>
---
M src/openvpn/console_systemd.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/66/866/1
diff mbox series

Patch

diff --git a/src/openvpn/console_systemd.c b/src/openvpn/console_systemd.c
index 858504d..91ebb35 100644
--- a/src/openvpn/console_systemd.c
+++ b/src/openvpn/console_systemd.c
@@ -72,6 +72,7 @@ 
     }
 #endif
     argv_printf_cat(&argv, "--icon network-vpn");
+    argv_printf_cat(&argv, "--timeout=0");
     argv_printf_cat(&argv, "%s", prompt);
 
     if ((std_out = openvpn_popen(&argv, NULL)) < 0)