Message ID | d87c0c72c3c6dd06d7f978da27f368425f2f45f7-HTML@gerrit.openvpn.net |
---|---|
State | Not Applicable |
Headers | show
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net> Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:b7cb:b0:5e7:b9eb:58e8 with SMTP id en11csp2247521mab; Tue, 14 Jan 2025 05:43:51 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUlBljOVq0Usievipz36bp9VHUmQk8Dm65ZNzgHX480r+RFT9Hr1N8wY1Tis9ZjPfymQpq+qmcbW8E=@openvpn.net X-Google-Smtp-Source: AGHT+IERgLICYMJGWc9lNNYOrabikUXbcxyjxMiQih5A34bM/pJ5RARCX1JBZQdxWhGHwlrmr8lV X-Received: by 2002:a05:6870:2f18:b0:296:beb3:aa40 with SMTP id 586e51a60fabf-2aa0699904emr14841130fac.36.1736862231681; Tue, 14 Jan 2025 05:43:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1736862231; cv=none; d=google.com; s=arc-20240605; b=LGKvNOAUlple69vJeDeTksh4JPcDteQahtgYGVDHOU9+IB7wUm5fenSXr2UM7PodGx ihiTEuKHnh763erS/5A93sQ4arEtpi/NQVpOBXK6/wBjvS99nJ97CMZxMfvHrN9UDBfN W/tDQ7jZ5ZjdeaS1FAoGgN8z6bx6RQhlISRWlYNJ5mvo2GEgn/aQ74zvcy14epgYLXSt Lrr2tJTBU5sUSjyz8PjuYR3LRwOEA5T6KIyZVhDaHW1ywuHT3fmZvFTRxmUNFUSGuyqu CfGEXhLsdU1RqhHj8PYyCnoc6MMOkq/NxFyshKcKuAR9ivJqxFR8QGWXBj8/0JW2V2Wn UNdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=DXY8biYCuN5mBpuzT5tRjcUdpwRTpL0woxumZ1NdO+c=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=Onrb02TaDVF9MP9lShHTE27dR1Dg9iap4qYgTs+Df6Cosazo3tSR5CgnjuZoJjNL0G /r6Iil7v4GKVcTNT7Z5PEqyV3gSkBcWB/VxD0xpOLFk3RuhyOWS/WO9Ui1Z0f+/t2L6E z90zdstvvoQ7tcxmGD5CugimIevX/xZm/TC0tHbjh4Djr0K4OYOw59vTHAlURysO9Zqq 2i35gQJ4BY+aliqzYYmdX9tUKUh7KvyPG6KTqVJQYedYD8dLa/1M/rtZeoNSjosFwbIl 5XyFAuzFgn1ag+GREgoZaS94U3up2kSIfSWYqO6RYFu9rDWIIWyzQoR85s1kYd64vh8j xW3w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=GlJpPegq; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=lj4RUeMq; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=dPsFHbhh; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-2ad8049773bsi9917913fac.1.2025.01.14.05.43.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jan 2025 05:43:51 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=GlJpPegq; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=lj4RUeMq; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=dPsFHbhh; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from <openvpn-devel-bounces@lists.sourceforge.net>) id 1tXhCk-0001tM-Mr; Tue, 14 Jan 2025 13:43:38 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from <gerrit@openvpn.net>) id 1tXhCi-0001tE-Vo for openvpn-devel@lists.sourceforge.net; Tue, 14 Jan 2025 13:43:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SJpXvsHHVgF8pWWhlImXMov5m9wxC50hCuFTnl3Ht8Q=; b=GlJpPegqP9/rZDPVkTiHX7u7RW +iEiBKqVbi+hI1Lql6yF2K3FSEtUpyXcRwLjB3GDlD6Gc3gry5fbzS+c653YWEuIy8+9eEfVu88q7 U0j6whPUVaACFEdsfxQIXHY6dEKElm4Ywr2FLhbrb3oPYkekyEcCW3poDFg+fYEhaO8M=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=SJpXvsHHVgF8pWWhlImXMov5m9wxC50hCuFTnl3Ht8Q=; b=l j4RUeMq97TpzNubMstk63aSe+YxlJEjwRYbuGae0qMUiWkXSsQ4P9cVlDVnjG/lhnNUWnCYDqm/sU BRq2tSLNfxFsB8kstgpLrucwpCsX55994f8Hrg3+P9e3fRpq6flcaBPcnnP+Fp8QhzOaMQrLNnq1q SB+uczhJMr1Y+2Fw=; Received: from mail-wm1-f52.google.com ([209.85.128.52]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tXhCi-0005P0-03 for openvpn-devel@lists.sourceforge.net; Tue, 14 Jan 2025 13:43:36 +0000 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4361f664af5so62793465e9.1 for <openvpn-devel@lists.sourceforge.net>; Tue, 14 Jan 2025 05:43:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1736862204; x=1737467004; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=SJpXvsHHVgF8pWWhlImXMov5m9wxC50hCuFTnl3Ht8Q=; b=dPsFHbhh82mkAHwKToqjsMpY8LcNwAuQkHo/bQy7zfO2hwwduiNj9obW6p9AQfiC4Z tVhD+DkllktWn1WTMO8sAI/fVWGmMUAlPDoHCqnvSYIImUzdfyzA1S4c0v5Rm1isZJmn 5WVf9KDINNFlJuEAlqzI3drJbraC05W9KQD/sXdq9g/IGJ0hV8U+q/j0YBnUfu7j6+V5 XlSHpZ+VSZIF8hAj49uF5Y1QSk1txrb9XO+l0qS57Nr6rz/s6BSHxdZGJXhq6hnAxZ8L 9jFyMTZG8c8+2/gOJvnUUZOMFcdIFmXCNAHw/cnTqdCxVgA+Xntg3+jXW5ATmQ8grQWZ FIlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736862204; x=1737467004; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SJpXvsHHVgF8pWWhlImXMov5m9wxC50hCuFTnl3Ht8Q=; b=bDnRdP0RB7hEM2BKUJ/1axQ0bsfBiSmTeeeBrMPqonmr4odcqaDcifGTmPHIaq6vq5 y064K9kzMLEoKQcTpZBp0/eAtAyvrO+o5hcjAFziQ2uGzTFuEKH0OG5V85qQLjKBidSd dTZHjQhA5mlzw7COi09Uae8+fcGAa9xEaAMzCqaGG5l4xABVHXu49NI6D3zIrdT+poEI 9QY5tY+fQ5WzspvTlB3JJn9vlCBwy3trrFEnOWcmz8ceg+ODgbIjhXG5+8Ryr7pN878u bykuVjJoH04iuowZApXe4u3Z7eOHk6glYs1WatuXifchk7jzuimStDM9H7yfBDI9ezSa ZIGg== X-Gm-Message-State: AOJu0YwXewb7B+uaz9+HAsyYkhWJMywzjrk+rfRTneoepu94t68zdYML pJhU0CNZby2GYzL5YPmbVB9nqE99l5pVsieDVY6uEEJMlLlGIvi74xcs1408HaeI5IrodoDAL4s u X-Gm-Gg: ASbGncu82tAUmmrhAARKgfpyrlGbpPbArfxxRMrEtWAoVcpV9nKrADnKb1HLZo4lzBZ D1bmPiGrnJMgblzHkwzstQMaGSP7fc685gOKxTPqzEhCv5PWBthkayHhDgOkAsoV3yVd1F201Sr o1O8MOP/zG78e64hACIuhyQ6yw7xAm01SjRWv9yk/yP5mzsTzpkbUBE4gsaiWr6FrZwU5Wu8Q1b qxtQKzgBNsOcpT0miD8QImZgVr9FkZlhhmMvtMgRjruc9nJxk13FH5NXQSgQr+9nUMHC1D2JB0M x2BTfeBzkwJ0I/8MXUpRUzbHQymLD7ToQYYxeud1KgS6N0y4 X-Received: by 2002:a05:600c:1d10:b0:434:a202:7a0d with SMTP id 5b1f17b1804b1-436e27075e2mr200194095e9.22.1736862204027; Tue, 14 Jan 2025 05:43:24 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2ddc5f5sm210124885e9.18.2025.01.14.05.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 05:43:23 -0800 (PST) From: "flichtenheld (Code Review)" <gerrit@openvpn.net> X-Google-Original-From: "flichtenheld (Code Review)" <gerrit@gerrit.openvpn.in> X-Gerrit-PatchSet: 1 Date: Tue, 14 Jan 2025 13:43:23 +0000 To: plaisthos <arne-openvpn@rfc2549.org> Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I2791d09ab698d89dc7e0183151f77b84024ad6d1 X-Gerrit-Change-Number: 866 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: <http://gerrit.openvpn.net/c/openvpn/+/866?usp=email> X-Gerrit-Commit: 92878dc61860b5a3242c0a72f4af6e868994e87b References: <gerrit.1736862200000.I2791d09ab698d89dc7e0183151f77b84024ad6d1@gerrit.openvpn.net> Message-ID: <d87c0c72c3c6dd06d7f978da27f368425f2f45f7-HTML@gerrit.openvpn.net> MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -2.0 (--) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-2.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.52 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.52 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.52 listed in sa-accredit.habeas.com] -1.8 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.52 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1tXhCi-0005P0-03 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: console_systemd: remove the timeout when using `systemd-ask-password` X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: <openvpn-devel.lists.sourceforge.net> List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>, <mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe> List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel> List-Post: <mailto:openvpn-devel@lists.sourceforge.net> List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help> List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>, <mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe> Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel <openvpn-devel@lists.sourceforge.net> Content-Type: multipart/mixed; boundary="===============6439625257009355678==" Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1821232051450010671?= X-GMAIL-MSGID: =?utf-8?q?1821232051450010671?= X-getmail-filter-classifier: gerrit message type newchange |
Series |
[Openvpn-devel,XS] Change in openvpn[master]: console_systemd: remove the timeout when using `systemd-ask-password`
|
expand
|
diff --git a/src/openvpn/console_systemd.c b/src/openvpn/console_systemd.c index 858504d..91ebb35 100644 --- a/src/openvpn/console_systemd.c +++ b/src/openvpn/console_systemd.c @@ -72,6 +72,7 @@ } #endif argv_printf_cat(&argv, "--icon network-vpn"); + argv_printf_cat(&argv, "--timeout=0"); argv_printf_cat(&argv, "%s", prompt); if ((std_out = openvpn_popen(&argv, NULL)) < 0)