From patchwork Tue Jan 14 14:44:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "mrbff (Code Review)" X-Patchwork-Id: 4059 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:b7cb:b0:5e7:b9eb:58e8 with SMTP id en11csp2283124mab; Tue, 14 Jan 2025 06:44:38 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXw0YUOpQ24gh1XgML7D5C2H8fAp2QNxvXgM1ZQHCjrWKKH5cJmAQaURWMpqV0KdnZlLXWsfxlaT/0=@openvpn.net X-Google-Smtp-Source: AGHT+IHCR4PtveF7ScYK3TF8Y4y7IFpTE1tYYABWEC69D2AVbi3W503NlhpVMJj9/fMq6vWfGCCk X-Received: by 2002:a05:6808:1a0e:b0:3e3:bd1c:d584 with SMTP id 5614622812f47-3ef2ec6ddfbmr19191595b6e.9.1736865877806; Tue, 14 Jan 2025 06:44:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1736865877; cv=none; d=google.com; s=arc-20240605; b=CuM/MT+7ZbplRiDJsOEuIZsJGJROHa5cmdD1hJg14p96hIMcvRZu8uVxFnp/+HnyWA zI6/chA7jJG+x16UW2883ssu09IoFA24VNEAO536DxQbHmwAKJmCLaq0EyGehHEVlFL1 xSFC9Kmr9qjzGzeAZFB5idcqJEAyWU5IofS9I4I87FWDZ7buE2AmC35mVq1JLqhuHKSr QXfDaxXdVQ35Bsqi5I5zrXCVDqR1Rrnf+iNSnaFwAq/La+PhEvRVkLcD7VXehH7jCmvp JREUeH2t1TGR23k4eOvB5cGpvvwoPa0osEnoqiWxC9rLL1VRnV0pMQSBfEvlFNzhzOs8 SoSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=WiXWoqHnrEvy5EDHUJxEyyIVbHbZPTrEQ7vlMjcUNDs=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=fdQ83ELj/XguI4wdXRgloCFSQU4cCnv+Ah04lFOm+GQcTENWvE6XynS+/MJWkNUtxk ADeN3tHKhXMUsTlKqa8kpVP+98CFQGAFRwEcpULAQhOtTEkHT5T3HbW7lizYqZ8++PVm ax2Du20SAUDjffqt7e8ZuN9BDMCQHEZk5YGmv+2FlQeTau9V6pCon4Iguxq6lwy7GDwc GhSs/4MS1hR24ccnsMLFPqJqoFglanwi/7w+3/6L71Es15tI2xRCgQz5KfLqtZn0RiFR 5JWLrB3FXqSimyScOpieMvWdgWpUE3yhceI/yA8L2M9Q8xCyYT6q8XVCLN25bZmHCjJa qKHQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="CYG/5xz4"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=IOYTJVA0; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=SvwQb7SC; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5614622812f47-3f037a2d168si9976334b6e.178.2025.01.14.06.44.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jan 2025 06:44:37 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="CYG/5xz4"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=IOYTJVA0; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=SvwQb7SC; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net; dara=fail header.i=@openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1tXi9h-0003Du-Ue; Tue, 14 Jan 2025 14:44:33 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tXi9h-0003Do-Gt for openvpn-devel@lists.sourceforge.net; Tue, 14 Jan 2025 14:44:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=s659GGOmSAe8S17EIU2kDie8RCRMf9BW5x3SdlN5tPo=; b=CYG/5xz4lw8Wl0MvAHtyCAPSIM fDZ4/PcWmPap9om3vHnk659YSrN68xWAZu4rABf9l7G9A4CnzpMMNTufzVNyXbh70JwRwWGrwnwj0 +UShAscg2/loAJCkY0Xs0/+AAObdcQEV2Ut0U2i+IC0bZYw8goQcmcy0vkjL/Mgf3YEo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=s659GGOmSAe8S17EIU2kDie8RCRMf9BW5x3SdlN5tPo=; b=I OYTJVA0l8r3hc8Rrhe/kLUL32IOSHHf8faoNydthtcEXSdP4vWVPp4B27716tgidw+YBM0gk3EokD aU0CoGVbm+SAOhkDxtSoqlmHLC7MXHqz2lqUZAlxPuFOpWf7klyQLJwub7UQH4EPI/+LvI0Pzq3TQ uQokNNvnbhzvMaFk=; Received: from mail-wm1-f53.google.com ([209.85.128.53]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1tXi9g-0000d9-Pd for openvpn-devel@lists.sourceforge.net; Tue, 14 Jan 2025 14:44:33 +0000 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4361f796586so58252725e9.3 for ; Tue, 14 Jan 2025 06:44:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1736865861; x=1737470661; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=s659GGOmSAe8S17EIU2kDie8RCRMf9BW5x3SdlN5tPo=; b=SvwQb7SC0+wRiztS3iBQY5Sqqep8owQAj3JcjEX80D53msaDEVuEkJ1kvY5NEQpibl yDrYGEIK+zMCzbT9aNR8lbGTIqGyj+8saOCJfRSFtnEvuIn5igM/qSlzQTs4cwQxMt+x Lq7tLN9OA42KN/d2nnQehzViHPo+dAsR0ZWEPpDYQYd1SEgwVm0yuunpC6B3RGoAsMlC jHK5APJ0v/R43HOgBBfCslHBMPRFs4t82+XgELX0y3RBgz9pO8B87QLjx5o94knuH1ZG qo/+PvUjU9DyaJK4d4j7o6yl4mQAmleKAXcMkr1MHFHnJuzMHNUcF4mRz12b2Vjwq9L5 RL7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736865861; x=1737470661; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s659GGOmSAe8S17EIU2kDie8RCRMf9BW5x3SdlN5tPo=; b=M5l/Hvnl+0afeCh6lQlPMFwHJnPP0xgx3PJ2ERkvORsV+r2kOHoa7kqCZI4q0P+DVc 8G/6Y3A5BfP3AGUB5ERD3SQ32v+u2P/TSv7KH+CepQrG8E0aosVle8sC1tC4ZmnteaY4 usIsINCdnuXx3jF0I3q46oPvV3XYt3t8ClnfAi7m5R0ldap05DwdoV58kNXEw5pVDH6P PiD3Kr7wVL+bGOnDckauvfTbF8peovEDzEL5JJu/F3sf0YemjUWJfL+Eakgr+7Lgv1cM nrkdkMrrvAYyjn/ihy1mHbQDBZLHv/gHG4uFd96zH3sm3GSdmbHdu1J8HOPSr9AJTrIC bfIQ== X-Gm-Message-State: AOJu0YzQhdgTIf6YOHTS5+ALW5C0SMJ5TShYxRhvI29LT0hBPGb/sXRj PdyROBqRmNixsAegE0S9E6J3ZkxoALqsSd72I/1qfKGSQK+eAV1MKC0Bwlw2yAQ= X-Gm-Gg: ASbGncsA1UtveVwhExMsBHBvmNTMvMfADQnjq5538B9AcPpXkK3hmB75sKiiq3jD0D9 g9gfSenX02uD12+UW+ztWWWThVBkuHk2H0/GuWdak1mEC+Js9BuUpZT4yAf+XhqFduKQ6bppbxk uRaZfmDXqgBrwgGfPdk+3+As/j6HmDXaKRFlcGuWmUpx8wc6UVNhZCLjytmUlPtdc4io8JzC8Fg S/xOAgr7cEJJwfYVtLCDl1ODQV8bh7bhBZRSfBQSJZCMc2BsJcdC/QMe8iE73Q8udccmG4sOaaA BrYKEpy7hsXkM1emZ/1S1i7qy6g7UumXbN0BAQabgl73w+kW X-Received: by 2002:a05:600c:1c9a:b0:428:d31:ef25 with SMTP id 5b1f17b1804b1-436e26975f1mr252449535e9.12.1736865860790; Tue, 14 Jan 2025 06:44:20 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2e89de4sm209629015e9.34.2025.01.14.06.44.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 06:44:20 -0800 (PST) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Tue, 14 Jan 2025 14:44:19 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: Iaaf80c688ddff79ac9472d7237003713637c140b X-Gerrit-Change-Number: 867 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: bc4039aec97644b5b7a8c82c7c47c78150defaa7 References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -2.0 (--) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-2.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.53 listed in sa-trusted.bondedsender.org] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.53 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [209.85.128.53 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -1.8 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.53 listed in wl.mailspike.net] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1tXi9g-0000d9-Pd Subject: [Openvpn-devel] [XS] Change in openvpn[master]: tls_crypt_v2_write_client_key_file: Fix missing-field-initializers co... X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1821235874626778760?= X-GMAIL-MSGID: =?utf-8?q?1821235874626778760?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/867?usp=email to review the following change. Change subject: tls_crypt_v2_write_client_key_file: Fix missing-field-initializers compiler warning ...................................................................... tls_crypt_v2_write_client_key_file: Fix missing-field-initializers compiler warning GCC wants us to be more explicit here. Change-Id: Iaaf80c688ddff79ac9472d7237003713637c140b Signed-off-by: Frank Lichtenheld --- M src/openvpn/tls_crypt.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/67/867/1 diff --git a/src/openvpn/tls_crypt.c b/src/openvpn/tls_crypt.c index 24df930..4c421aa 100644 --- a/src/openvpn/tls_crypt.c +++ b/src/openvpn/tls_crypt.c @@ -691,7 +691,7 @@ struct buffer client_key_pem = { 0 }; struct buffer dst = alloc_buf_gc(TLS_CRYPT_V2_CLIENT_KEY_LEN + TLS_CRYPT_V2_MAX_WKC_LEN, &gc); - struct key2 client_key = { 2 }; + struct key2 client_key = { .n = 2 }; if (!rand_bytes((void *)client_key.keys, sizeof(client_key.keys))) {