From patchwork Tue Nov 21 12:54:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "its_Giaan (Code Review)" X-Patchwork-Id: 3469 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:53c1:b0:f2:62eb:61c1 with SMTP id u1csp340276dye; Tue, 21 Nov 2023 04:56:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqBiY2X9OuYSPuJLdK0FvZbhXlVtWSTNLAU1riCBQjbQ02TfbyZ/Beq9J6AaWYGGKH+VKh X-Received: by 2002:a05:6a20:3ca4:b0:187:f03e:48cc with SMTP id b36-20020a056a203ca400b00187f03e48ccmr14051554pzj.5.1700571405006; Tue, 21 Nov 2023 04:56:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700571404; cv=none; d=google.com; s=arc-20160816; b=rB3Jx9zUGkAXEFX24zrOnxkV3WAJ2O73PRl4Ht0fN6CtbnJXnC/au1ab6XnTYJlQDU 65DJijzjiBrQgreXoXEtAMoE5wDx05Ls0jV39FNHqwq1saeg7KlI4vrzexF5WQB4Db9w BG4CBTRW4ZWX25VmRgXXd9gGeouVY4iuvVvgxt7JC56efZF+WcxbzwjB5nviuTwoXrwk xOYty1MGUSfDbOboWKx2GqdVxh294oBdNF8qj8S05jwMKrb93L+J2vcQVvMm+Fy+3QlW mDz977s3f0qGlu0MB5pIZudVvTeRevCn1lc2655gDGOGKDBG/0ZTYRNzd03gz2rCGSXv CdFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=dupifafjLFHlXtV1tf2D9fIYkPF5t7ZamVYUC+B6ysc=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=mwLDL18fXOFeY//r1Du58QQ331cf7mp+0KlzSdJ47cDRUwYqbRwa3P/Zo5oOOD4rAZ 1NJxnFgGA9/Vgg2f56ZNKKe/V4BNxgkbzYrExFYDtwLpxNL7NUaFLijcJ5XcRkD4+mcp PQuWpsDDWDVlyw8keeE9LLssEhZ6NmOiKiBSBMblzabkZXgRNJ8OXgZJ7xSMBP1sUFD1 Ym8E85Bt9scJSZ+AIFUi+aW2RUiBDj8K9+9iTwfQaqPo8mp6QeTZm+DhTl3gfTgFtanT Ka9HrZvWlphUx4jzIkCeuV9BE3P4I6XOgWITh+Lr7Iw+88ZjpkqPDlrSk7KiMFOkOmkx g6Iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=NVizs09M; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=luuC7Stg; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=cCQ7xjaK; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id p123-20020a625b81000000b006c0db523732si9767402pfb.136.2023.11.21.04.56.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Nov 2023 04:56:44 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=NVizs09M; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=luuC7Stg; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=cCQ7xjaK; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1r5QHT-0005ib-Q8; Tue, 21 Nov 2023 12:55:07 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r5QH8-0005iC-GM for openvpn-devel@lists.sourceforge.net; Tue, 21 Nov 2023 12:54:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Jnf/Gf6n5TmORsgts2y+t/F9GR92pib8rm2OkuCVWMA=; b=NVizs09MufxDHIOoG6ouijy20o 46ImPhFEQ8+856isDp3iuZTMXIFEyOkKzxET7TiyZYGrtmxCjQoLfOKpEyQrJEI0QZxJCtiPgpVqs 2JaBHysYYQRoT0yrbaAnL4a8GWFX86iVOk656IwtvZGMfwucOjFCgHmrzNnKruXJP8C4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=Jnf/Gf6n5TmORsgts2y+t/F9GR92pib8rm2OkuCVWMA=; b=l uuC7Stgg/QSkyij0Vxz6tAZyysuwC5rGZg9v7BU1FOmSHqNQL8DMdvQeeFlO5QY80zcYGJFoohXbF fYzXqgbDRo052XeFxPyx7m/Q3NLUWTW+pTL2JUlrapqm5sqLByZxeuqced7ngtN70UejNfsSLxBMJ aQNBmVBqOCZzGqJ0=; Received: from mail-wm1-f53.google.com ([209.85.128.53]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1r5QGm-0005Cv-Ul for openvpn-devel@lists.sourceforge.net; Tue, 21 Nov 2023 12:54:40 +0000 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-40b2b3da41eso3301185e9.3 for ; Tue, 21 Nov 2023 04:54:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1700571258; x=1701176058; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=Jnf/Gf6n5TmORsgts2y+t/F9GR92pib8rm2OkuCVWMA=; b=cCQ7xjaKogEpsnJxy1ixnKzNv0iTZWb5nVdZfoj7MWIB7yUZui9IbeGlxRPnrsX+6a Abzv87TB4k/xje22BJ1xPpjOTA0E1p0PtJ+hEvn8IS5b978/rgo74uGbYYFXJrhqwDw1 r2SZ5sVwmVWb8tCU79ZdgNALqQzCo9cy4KXTfIPBhDW9qtoLdCR7Q+zRyJDu9nv+SbSw huqbw8QO7LTQesB8hyGX1VURwRxkw4ZGF7n9Q3BV1FUP0vhUH8c4SoYhEXnNSQ6KgFjm WhaZJOl+CvD4QTLUVamwcdWmV0ClzhMrCxjnLKMXrbdlmoz18cFYy7O8Xh7jR15oapxW oHUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700571258; x=1701176058; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jnf/Gf6n5TmORsgts2y+t/F9GR92pib8rm2OkuCVWMA=; b=RuqURUIFF6SmYpFzsmTiddeg/2/JSam4z9zr8ffUsyKu6uEx6Qk2vp71Uy84d09ZEF a+m1wvOgfZsqRyQ0oKVPU4woWTLfbOaW8hiDHzoCifZCT/EMdbHxFDaxqlPFTeG3sg70 kcBB2/NlYRd4zzBl/EAAUnUTeTndVxYguQ+ZQ/ZQJfqNRHRzMTSDkhNnwp2EkdpeEY9x 43KgPFh3PihWqv+wbfNT33MdpMMsrze0p536FiGvYjNG3ZIQG89H7i2arJgKnVExBMRu ppZ2+R9LA3I0kicJ8K90oqcF3oEUKhw8YKEK3Lk6rZQ0CbQFNvjcVszvhylwT0DkjRU5 c54Q== X-Gm-Message-State: AOJu0YzEqD6rJ4duyk3Bm3oHqhOe5/uTVaiM+W+mJsuXLsrSLad4uJx+ glUxfQtDRYAx0Oy3KOBAc3KUinKGStGk0icq2bI= X-Received: by 2002:a05:600c:3551:b0:40b:2b82:dad8 with SMTP id i17-20020a05600c355100b0040b2b82dad8mr744144wmq.5.1700571258533; Tue, 21 Nov 2023 04:54:18 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id x7-20020a1c7c07000000b0040684abb623sm20897007wmc.24.2023.11.21.04.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 04:54:17 -0800 (PST) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Tue, 21 Nov 2023 12:54:17 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I7da7c2d7d34c7e5efd52d448646b4398a1005e77 X-Gerrit-Change-Number: 453 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 6331f6e923a094049cbc3052757b0a90d572dc0b References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.53 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.53 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1r5QGm-0005Cv-Ul Subject: [Openvpn-devel] [XS] Change in openvpn[master]: configure.ac: Remove unused AC_TYPE_SIGNAL macro X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1783178361412511057?= X-GMAIL-MSGID: =?utf-8?q?1783178361412511057?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/453?usp=email to review the following change. Change subject: configure.ac: Remove unused AC_TYPE_SIGNAL macro ...................................................................... configure.ac: Remove unused AC_TYPE_SIGNAL macro Recent autoconf warns: configure.ac:448: warning: The macro `AC_TYPE_SIGNAL' is obsolete. And it turns out that we do not actually use RETSIGTYPE. Additionally, there is no reason to do so since as the autoconf documentation says: "These days, it is portable to assume C89, and that signal handlers return void, without needing to use this macro or RETSIGTYPE." Change-Id: I7da7c2d7d34c7e5efd52d448646b4398a1005e77 Signed-off-by: Frank Lichtenheld --- M configure.ac 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/53/453/1 diff --git a/configure.ac b/configure.ac index 84eaad6..5cc55c3 100644 --- a/configure.ac +++ b/configure.ac @@ -445,7 +445,6 @@ AC_TYPE_PID_T AC_TYPE_SIZE_T AC_TYPE_UID_T -AC_TYPE_SIGNAL AX_TYPE_SOCKLEN_T AC_CHECK_SIZEOF([unsigned int]) AC_CHECK_SIZEOF([unsigned long])