From patchwork Fri Jul 28 13:03:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3308 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7301:3787:b0:d7:3b0f:3938 with SMTP id jw7csp719598dyb; Fri, 28 Jul 2023 09:45:56 -0700 (PDT) X-Google-Smtp-Source: APBJJlFYjW7n2QsfRUtRfC0C+6VllGtnGzq8yLqYRKGD19KYOjonEXhqlEz7lZseTodkQC4nvX4/ X-Received: by 2002:a05:6808:1b2b:b0:3a4:1484:b3eb with SMTP id bx43-20020a0568081b2b00b003a41484b3ebmr4843389oib.12.1690562756301; Fri, 28 Jul 2023 09:45:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690562756; cv=none; d=google.com; s=arc-20160816; b=Y5+NoQe5o16g4AN8Hoz0GLhLMgKOVpQD53+oe88XIFLAr4g8HN29i3+Q428nGX6Swl emXckSk9aR/KYjquXqd4t8JSPihatz3fjQArfLld3ySbdJNDLhD7sEvRcx7pFnmUyARE L6lDwYNWbx4PSnV+yM3mS+t24+PLJtNtDO7R3z6wRFqgdc3e0R5R+XuJqQJ5LsIwRAED l0dWQAdZICchi7L4XETmL72Gk+fugf09tj/f2Gt7HJHJCYMrR9bEAVtOfSgiAy2fRR2/ JlV0VOGGU5jHsiSYqJ2a3AcgEZGMKtnXh3TOipp1ypmlCfMOCoCVwUvlSBvNPM9lBQ7B ZzwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:reply-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:user-agent:mime-version :message-id:references:auto-submitted:cc:date:from:dkim-signature :dkim-signature:dkim-signature; bh=4xls4jqTVI15E2b2l26X5M8sT1JewNF0ltWmf7Xlfgw=; fh=ejqQk4evxSbcB4TOY987ChV164zUZaeCjiIZ6JGqg/c=; b=UFWwayzlIO8rHAYOILB0I5clEmc3Fc3N4mod4Hc4T4CR8/mNcwMp/6ENNgzb2/1Lnm z5EOvFCovrrp8zwoyb9ZLT6Fd/hHeTc0ai0AXT5n1lPfd2S6jIEjD9+NPjZklU8SCGBn PEceBF/P3Rd/u1j6SaArNxrpHXQF5MqqvmirDK/QEyqjlB9WDSV055vII18eKTIEQ0dn g/V185E0UkKl2qNAEKdW+BuDQwzt0Bb1iSn5K9a1kiBhdcAJwZ06Lk2asiPdoTxpiaCq yuK50OUDcVdaY6bqnAI0UL/4Q8VYZiLtb3Qj3Bl0vaX9CDEEAzndk2JekMi8T9sEgujn XtFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=HFoWsMoT; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=UtrWgWAP; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=WiU+F0+A; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id l9-20020a17090add8900b00268293118efsi798367pjv.47.2023.07.28.09.45.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Jul 2023 09:45:56 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=HFoWsMoT; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=UtrWgWAP; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=WiU+F0+A; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qPQaI-0004hz-14; Fri, 28 Jul 2023 16:44:58 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qPQaH-0004hs-9Y for openvpn-devel@lists.sourceforge.net; Fri, 28 Jul 2023 16:44:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:Date:From :Sender:To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=w4g5+Ucs66aFLt64ZnEyXuaTQ8gbHC9OhFkHIwLqx10=; b=HFoWsMoTULxUSbErrKtqehtgxL QIuBaTzwmh1sV0XO5z14jjjgdIP0bXfPxZZJN/B/6PfzgTXNHvoGbx/AwO8XM4mO17rb/J+YJ3uHp fgucIpKRZEiLn3Eq63rMCxC7UivQqu7IH6j7HulQBKL8NaFuvBAE+KAs6iL2VAkLXAZE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:Date:From:Sender:To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=w4g5+Ucs66aFLt64ZnEyXuaTQ8gbHC9OhFkHIwLqx10=; b=U trWgWAP+WgsqOdnu5yN9cZ7QgP3I/4LMYID1TiT4eWhn9IiBDJL0RFVnKyegkZYa58Q41/OJjDme/ pMXu/xDW4+/PFTav80QF1AR1AY0IOuj9PS0wUVixkzK/M6T4lTwp0AIqXxstT0NRB8Qte2UfAm/Xq COEw5++ggsw2VRSY=; Received: from mail-ed1-f45.google.com ([209.85.208.45]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1qPQaB-005q9e-GL for openvpn-devel@lists.sourceforge.net; Fri, 28 Jul 2023 16:44:57 +0000 Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5221b90f763so3023698a12.0 for ; Fri, 28 Jul 2023 09:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1690562685; x=1691167485; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:date:from:from:to:cc :subject:date:message-id:reply-to; bh=w4g5+Ucs66aFLt64ZnEyXuaTQ8gbHC9OhFkHIwLqx10=; b=WiU+F0+A+phS8nmmw5CHieYKhlx4LMgKu1PIYrPwuNM9IGzNTDDJeSytfy2KJxXs2O DwE0RFVopF5nlZ9DaxMOvNrMxklCvFy95i9+0gACPMpzxIE2cwC0ODpN96MZ8kKN6WN7 zyNyvfLY7pLNxe/mL9yhBJNYGEFmFd4SiC8QbbxxcHceF5og5hep4ZY+N8LLk5x27xcx VfXHsD1mi0+R/Wil34jlqFF2MxZ8KwnuqHsJw26TH2Z6t+vwdGv5DfzcPxJi7SuqVuUw pkawCo0JpnnkGmVTjhh1dJJstiKnwjg//cKHvdo3FcqnKt/+EWEklKiMVi9yqigMt7AT Eijw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690562685; x=1691167485; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w4g5+Ucs66aFLt64ZnEyXuaTQ8gbHC9OhFkHIwLqx10=; b=bv+i90al8EnhpoGtaNgmEYqtm1q4ntl3lZRFbCZUa2Yxy3owp/Bdvrgv00qzH652du cgQrA3u1gbqwj65JdxRGyW2CroO8xePqLGGnBFYRtpvlwsrstQtspWvw8yLO2/nhQfVc CnCfJHDAjESKjNlS6t2xNAc2MrmkLcABcY0Y9e4m37/JSjgLH3nqD+52k8g5eSUjq9IV NkRdnCnuVAHG5hDfatZv5cGsi940VE1EwT0zhevNWY7c71IMOppYWWq1AKRa3w+suer3 RUwdNjy+D7DYq0ssFTvBw/2RtcNDCcMXlBDcz/4reJHeV+FHzYbGtAOb6IHOzfA6onuI Ssyw== X-Gm-Message-State: ABy/qLYO6F9BnI+YjVFVqDhXacr2ExRiqJgK8U14zFM1XtqkRlrz3Wfh Q/AUSsvmW3I2ogDffbXwtt/kuFCts4j8m28owLE= X-Received: by 2002:ac2:5e3a:0:b0:4f8:4245:ed57 with SMTP id o26-20020ac25e3a000000b004f84245ed57mr1580807lfg.35.1690549408896; Fri, 28 Jul 2023 06:03:28 -0700 (PDT) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id y18-20020a1c4b12000000b003fbd597bccesm6853223wma.41.2023.07.28.06.03.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 06:03:28 -0700 (PDT) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Fri, 28 Jul 2023 13:03:27 +0000 Cc: openvpn-devel Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I45cd0917d24570ae9e9db7eb6c370756e4595842 X-Gerrit-Change-Number: 318 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: 7852d95351385c0d4a666c874856f31606c802aa References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.0 X-Spam-Score: 1.0 (+) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/318?usp=email ) Change subject: Fix various "Uninitialized scalar variable" warnings from Coverity Content analysis details: (1.0 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.45 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.45 listed in wl.mailspike.net] 1.2 MISSING_HEADERS Missing To: header -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1qPQaB-005q9e-GL Subject: [Openvpn-devel] [S] Change in openvpn[master]: Fix various "Uninitialized scalar variable" warnings from Coverity X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, openvpn-devel@lists.sourceforge.net Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1772683532561956940?= X-GMAIL-MSGID: =?utf-8?q?1772683532561956940?= flichtenheld has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/318?usp=email ) Change subject: Fix various "Uninitialized scalar variable" warnings from Coverity ...................................................................... Fix various "Uninitialized scalar variable" warnings from Coverity These are all not actually problems, since the uninitialized parts are either .unused members of the struct (mroute_addr) or only written to (buflen), but still doesn't hurt to explicitely initialize them. Change-Id: I45cd0917d24570ae9e9db7eb6c370756e4595842 Signed-off-by: Frank Lichtenheld --- M src/openvpn/mudp.c M src/openvpn/multi.c M src/openvpn/pkcs11_openssl.c M src/openvpn/socket.c 4 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/18/318/1 diff --git a/src/openvpn/mudp.c b/src/openvpn/mudp.c index 81625ea..e6c99ae 100644 --- a/src/openvpn/mudp.c +++ b/src/openvpn/mudp.c @@ -188,7 +188,7 @@ multi_get_create_instance_udp(struct multi_context *m, bool *floated) { struct gc_arena gc = gc_new(); - struct mroute_addr real; + struct mroute_addr real = {0}; struct multi_instance *mi = NULL; struct hash *hash = m->hash; diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index aad11b1..728a7b8 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -1234,7 +1234,7 @@ bool primary) { struct openvpn_sockaddr remote_si; - struct mroute_addr addr; + struct mroute_addr addr = {0}; CLEAR(remote_si); remote_si.addr.in4.sin_family = AF_INET; @@ -1273,7 +1273,7 @@ int netbits, /* -1 if host route, otherwise # of network bits in address */ bool primary) { - struct mroute_addr addr; + struct mroute_addr addr = {0}; addr.len = 16; addr.type = MR_ADDR_IPV6; @@ -3118,7 +3118,7 @@ void multi_process_float(struct multi_context *m, struct multi_instance *mi) { - struct mroute_addr real; + struct mroute_addr real = {0}; struct hash *hash = m->hash; struct gc_arena gc = gc_new(); @@ -3532,7 +3532,7 @@ if (BLEN(&m->top.c2.buf) > 0) { unsigned int mroute_flags; - struct mroute_addr src, dest; + struct mroute_addr src = {0}, dest = {0}; const int dev_type = TUNNEL_TYPE(m->top.c1.tuntap); int16_t vid = 0; diff --git a/src/openvpn/pkcs11_openssl.c b/src/openvpn/pkcs11_openssl.c index 40080ef..0ddabc7 100644 --- a/src/openvpn/pkcs11_openssl.c +++ b/src/openvpn/pkcs11_openssl.c @@ -166,7 +166,7 @@ CK_RSA_PKCS_PSS_PARAMS pss_params = {0}; unsigned char buf[EVP_MAX_MD_SIZE]; - size_t buflen; + size_t buflen = 0; size_t siglen_max = *siglen; unsigned char enc[EVP_MAX_MD_SIZE + 32]; /* 32 bytes enough for DigestInfo header */ diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c index 2d765cc..58231fb 100644 --- a/src/openvpn/socket.c +++ b/src/openvpn/socket.c @@ -3301,7 +3301,7 @@ { struct iovec iov; uint8_t pktinfo_buf[PKTINFO_BUF_SIZE]; - struct msghdr mesg; + struct msghdr mesg = {0}; socklen_t fromlen = sizeof(from->dest.addr); ASSERT(sock->sd >= 0); /* can't happen */