| Message ID | efcefeae049fc452931e2d920dea3170be0d0856-HTML@gerrit.openvpn.net |
|---|---|
| State | Superseded |
| Headers | show
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net>
Delivered-To: patchwork@openvpn.net
Received: by 2002:a05:7000:c127:b0:5e7:b9eb:58e8 with SMTP id
jm39csp2281573mab;
Mon, 27 Jan 2025 04:28:30 -0800 (PST)
X-Forwarded-Encrypted: i=2;
AJvYcCWTc0IxWV6agxoG23NlffdWXJ+TvqSuCjCLXG5dK/kSMt5oSf3pC3+uMAe7gUO74jGtwEq6CeWQpl4=@openvpn.net
X-Google-Smtp-Source:
AGHT+IEbX6tVBvksNFX/t8zMSOjP9YtjaLJYlXJuXNP2ppHscXQLQhXr/rBPqs4I5mJg++HMzdw/
X-Received: by 2002:a05:6871:7581:b0:29e:5cb1:b148 with SMTP id
586e51a60fabf-2b1c082478emr21182274fac.6.1737980910356;
Mon, 27 Jan 2025 04:28:30 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1737980910; cv=none;
d=google.com; s=arc-20240605;
b=a3Bqu5p9EkQ7BitdFLA+RF9tgHPKQe7+rjKw71YWwfqKXdHGQ1wR5PXtKpbTXd/n+v
ciKbQQLXz0h6ge5Gzy9fnYE7ZF2GrwvlnJ4be4bng05hQWr9ysvt2LWxU6e+Yqol5DA6
LecrnDFngaJhzIo6BHo0Fb8Sn5hZGF0V5SXDum4pgCm9MpcI6QDQOGzEwkXB9wgHCb1z
aFfi/1Ai0FuaQ7lb6jksxSO+ER6qBA179env5TB5+QPxC2OX/l8IFy2y0P4OCtjVgMHK
z6ejLnLmwegEi+4uDkuG/07yuezdHRLKy1I/ejsHBNzgvMk9TSun+prUCrKbfBZcBcUR
lmXg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20240605;
h=errors-to:cc:reply-to:list-subscribe:list-help:list-post
:list-archive:list-unsubscribe:list-id:precedence:subject:user-agent
:mime-version:message-id:references:auto-submitted:to:date:from
:dkim-signature:dkim-signature:dkim-signature;
bh=hUPWYW5FNEGHi1Ok8648wlaQkP2yoDUU76LG+kT19Dc=;
fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=;
b=dFpRFYvV/9MVwz3IDqDufodp/Kx5q3ObKuNK9s+b1IxxT6bwlULbf8pVl5azf2p5bY
ldgJe3BUg2S9/HDdzjPm09akzvKZ/OJhcY0O1IB87JcnQMJ8QLQLvlYxMm4nzrWJaw/X
EtpuQ+fr0OUQDiNyK0tvI444FIPVTtvjNWxT53ZJoz0J3NUm/GwPKVNSI6W4yhfamxNw
MiPF5JdcUpPi8Oq0Fnw77mJlaClmpumdV6DGJtYg/RT/938Dq+yO+MGUdiU5d+w4sjm3
gXSq2RQmWWzDZBMMebnJTL5IxWgRFJdQoUyL51pnD+ILufQGemR8nEu9ve7mJGifMs/8
CDeA==;
dara=google.com
ARC-Authentication-Results: i=1; mx.google.com;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b="PM4J8q/r";
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=UCQAS3yB;
dkim=neutral (body hash did not verify) header.i=@openvpn.net
header.s=google header.b=H9JnXf7H;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net;
dara=fail header.i=@openvpn.net
Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7])
by mx.google.com with ESMTPS id
586e51a60fabf-2b28f588fa0si5788731fac.196.2025.01.27.04.28.30
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Mon, 27 Jan 2025 04:28:30 -0800 (PST)
Received-SPF: pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) client-ip=216.105.38.7;
Authentication-Results: mx.google.com;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b="PM4J8q/r";
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=UCQAS3yB;
dkim=neutral (body hash did not verify) header.i=@openvpn.net
header.s=google header.b=H9JnXf7H;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net;
dara=fail header.i=@openvpn.net
Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com)
by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95)
(envelope-from <openvpn-devel-bounces@lists.sourceforge.net>)
id 1tcOE7-0005p9-JS;
Mon, 27 Jan 2025 12:28:27 +0000
Received: from [172.30.29.66] (helo=mx.sourceforge.net)
by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95)
(envelope-from <gerrit@openvpn.net>) id 1tcODd-0005og-8o
for openvpn-devel@lists.sourceforge.net;
Mon, 27 Jan 2025 12:27:57 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version
:Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:
From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=wlr1j4jEVRQIzNSyLGacasdLPDKp8WZS2aCYI5TawNg=; b=PM4J8q/rkD9IVp626LxapcIdHs
uu0cGvXOb7m8B8IWCRrRfP6U1jXEZfynNZj8Gs9wq5Fppsa9qEaNB1+Avx+d3eMvHMDvBRZMLUJae
IMceLlqsFESvlf7KpWUai2wcnVKG3uF/jM686kcuBpnvbcevGBg/X2n24kQmjrtHRqMs=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To:
References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID
:Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:
Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post:
List-Owner:List-Archive; bh=wlr1j4jEVRQIzNSyLGacasdLPDKp8WZS2aCYI5TawNg=; b=U
CQAS3yByhsOWRknv3if44hti+ud2FijqtSmjtK2nF7cUg2TPKkOVI6/oyV0Oy/2Ij+FjD7iY2bHPQ
3TdMyAVXmYUhZQ68DvPFhweo+iW3jgMFMHa92ajw4frtZOBNB8Xe8+KT4stui1cLZwO2F3/NqpA2G
qMNinwzd6QWEHYh8=;
Received: from mail-wm1-f54.google.com ([209.85.128.54])
by sfi-mx-2.v28.lw.sourceforge.com with esmtps
(TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95)
id 1tcODb-0003sh-Vy for openvpn-devel@lists.sourceforge.net;
Mon, 27 Jan 2025 12:27:56 +0000
Received: by mail-wm1-f54.google.com with SMTP id
5b1f17b1804b1-436a03197b2so28723095e9.2
for <openvpn-devel@lists.sourceforge.net>;
Mon, 27 Jan 2025 04:27:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=openvpn.net; s=google; t=1737980864; x=1738585664;
darn=lists.sourceforge.net;
h=user-agent:content-disposition:content-transfer-encoding
:mime-version:message-id:reply-to:references:subject
:list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc
:subject:date:message-id:reply-to;
bh=wlr1j4jEVRQIzNSyLGacasdLPDKp8WZS2aCYI5TawNg=;
b=H9JnXf7HkEMYcJK61KAr0vOm7qru5S91qJ7MkoLoUJbfYzHz0yzEFPUh5v2M5j/c0d
siXRpJzhh0PlRa7+QWCr/SnJ91Pw4ChFwqMbm3gag9vvt1lB8A+ZmteiEt7PevM0b8c7
KBZILMrqd4Q7ZFG6kHQ9lx5KuHL0bt3SOBwDYV/iFT7FpfBkex7yufT8FUGJsgbXLpbD
K4XGMbYzKcbEc9CeHi50wu0phgCFni50JH8nWi9fVQdNBymgprCmZRUWZCwqAE8UcZDA
JbwMoCPkS5Ql/1BmHTgLsmxOiF+FpSNx0nqTFbC7aOAUvVCaEDwCSVo9jxbWD6iF+SkO
7JFA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1737980864; x=1738585664;
h=user-agent:content-disposition:content-transfer-encoding
:mime-version:message-id:reply-to:references:subject
:list-unsubscribe:list-id:auto-submitted:cc:to:date:from
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=wlr1j4jEVRQIzNSyLGacasdLPDKp8WZS2aCYI5TawNg=;
b=WhcNIv2R3K7Jk/WNydFufPQiCf4oOdknwm7lc1qP6kmHC0Usx2awBsm223q/5cg1jv
xSsJ5qHfU3wdDkjldf2CcdTNC5TrgctCaoBJSCGl8LVpLbd3SRmJxeDSenAqHTrvQ5RB
uHFoiQ+Ivrvh0qzbn0vew+HLrE7YNjfc02/PbR03FF1FO7eOZPdKRbBB8VXgNQMidekC
WTiiTYE0XQTwFWwJ7M2XDlQgiGR3109N89Fvz94yag4q1ZE623bgAMFcszCsVMvgRUWJ
Ywdo65T3uIeSWKD3MQffcdRUIHV+QSLF84dITjxRqS/joa/4nN35NPff7uCUuO71M6Yg
RFbg==
X-Gm-Message-State: AOJu0YyPrCL9Y1j3/qyXq0kl+PgijL7gFW3dh3cbWt8txTCgMyLClTk/
P8BJ7qWmy+UOwadflyJoSTvIOV2ZKxAsILIWBZo5iamuTZpL/2FkT0f+QoyoIwtBDlmwN9TF5iO
s
X-Gm-Gg: ASbGncspNPK9CvQX01haakvoeT/fe6j7tpSDgBuPq/z0kqb60yv36BWh6svOa0mmmoV
DRNzl1BN/SUH/LqiXJ1fYiHSj/dkwA55wZijlyqJKaGDFXJ8Plf4J3cC3k2/AMunCgbCDEu/xCv
ITdom8oSX6u1MQrsG/5MGZYVyU+r0xPIQZlDnP6+acNocQ112lmB6koroP382FxtOp5Ysg22SO/
/jP/IVLgUCZgQUjgZ6f6CWjRI8fTpt5g+QxmBdgV9ucVNyOON+8ZDPYEyA/mBpyjaM7MOBdBupw
Elpr3Cg1+gAfoOQjygIShIKU8DJn1IsCnWeF21Wmf1ZUSMr50nItJJhy+X5kT9oNxdsbk+4uiOt
xz5b+zMg=
X-Received: by 2002:a05:600c:8717:b0:434:fbcd:1382 with SMTP id
5b1f17b1804b1-438913ca6acmr430475635e9.11.1737980864363;
Mon, 27 Jan 2025 04:27:44 -0800 (PST)
Received: from gerrit.openvpn.in
(ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78])
by smtp.gmail.com with ESMTPSA id
5b1f17b1804b1-438bd54c04bsm128452885e9.27.2025.01.27.04.27.43
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 27 Jan 2025 04:27:43 -0800 (PST)
From: "flichtenheld (Code Review)" <gerrit@openvpn.net>
X-Google-Original-From: "flichtenheld (Code Review)"
<gerrit@gerrit.openvpn.in>
X-Gerrit-PatchSet: 1
Date: Mon, 27 Jan 2025 12:27:43 +0000
To: plaisthos <arne-openvpn@rfc2549.org>
Auto-Submitted: auto-generated
X-Gerrit-MessageType: newchange
X-Gerrit-Change-Id: I0133085ac68f7b0db574b88276f6d5e1d3ad62d5
X-Gerrit-Change-Number: 877
X-Gerrit-Project: openvpn
X-Gerrit-ChangeURL: <http://gerrit.openvpn.net/c/openvpn/+/877?usp=email>
X-Gerrit-Commit: 96bcb361eac229432ef91d6c338a217e2feed36a
References:
<gerrit.1737980858000.I0133085ac68f7b0db574b88276f6d5e1d3ad62d5@gerrit.openvpn.net>
Message-ID: <efcefeae049fc452931e2d920dea3170be0d0856-HTML@gerrit.openvpn.net>
MIME-Version: 1.0
User-Agent: Gerrit/3.8.2
X-Spam-Score: -0.2 (/)
X-Spam-Report: Spam detection software,
running on the system "util-spamd-2.v13.lw.sourceforge.com",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Attention is currently required from: plaisthos. Hello
plaisthos, I'd like you to do a code review. Please visit
Content analysis details: (-0.2 points, 6.0 required)
pts rule name description
---- ----------------------
--------------------------------------------------
0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[209.85.128.54 listed in wl.mailspike.net]
0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[209.85.128.54 listed in sa-accredit.habeas.com]
0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The
query to Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243
for more information.
[209.85.128.54 listed in bl.score.senderscore.com]
-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/,
no trust [209.85.128.54 listed in list.dnswl.org]
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP
0.0 HTML_MESSAGE BODY: HTML included in message
-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature
-0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from
envelope-from domain
0.1 DKIM_SIGNED Message has a DKIM or DK signature,
not necessarily
valid
-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from
author's domain
-0.0 T_SCC_BODY_TEXT_LINE No description available.
0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted
Colors in HTML
X-Headers-End: 1tcODb-0003sh-Vy
Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fix doxygen
warnings in crypto_epoch.h
X-BeenThere: openvpn-devel@lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <openvpn-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive:
<http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel>
List-Post: <mailto:openvpn-devel@lists.sourceforge.net>
List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe>
Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org,
openvpn-devel@lists.sourceforge.net
Cc: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Content-Type: multipart/mixed; boundary="===============7119353560300301619=="
Errors-To: openvpn-devel-bounces@lists.sourceforge.net
X-getmail-retrieved-from-mailbox: Inbox
X-GMAIL-THRID: =?utf-8?q?1822405071247858440?=
X-GMAIL-MSGID: =?utf-8?q?1822405071247858440?=
X-getmail-filter-classifier: gerrit message type newchange
|
| Series |
[Openvpn-devel,XS] Change in openvpn[master]: Fix doxygen warnings in crypto_epoch.h
|
expand
|
diff --git a/src/openvpn/crypto_epoch.h b/src/openvpn/crypto_epoch.h index b2f3d86..9290482 100644 --- a/src/openvpn/crypto_epoch.h +++ b/src/openvpn/crypto_epoch.h @@ -71,7 +71,7 @@ * Generate a data channel key pair from the epoch key * @param key Destination for the generated data key * @param epoch_key Epoch key to be used - * @parm kt Cipher information to generate the data channel key for + * @param kt Cipher information to generate the data channel key for */ void epoch_data_key_derive(struct key_parameters *key, @@ -100,6 +100,7 @@ * - recv key matches the epoch index provided * - send key epoch is equal or higher than recv_key epoch * + * @param co crypto_options to update * @param new_epoch the new epoch to use for the receive key */ void
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/877?usp=email to review the following change. Change subject: Fix doxygen warnings in crypto_epoch.h ...................................................................... Fix doxygen warnings in crypto_epoch.h Introduced by commit 92adbc88b1b37095cebde2a1c5b6ae242f382678. Change-Id: I0133085ac68f7b0db574b88276f6d5e1d3ad62d5 Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com> --- M src/openvpn/crypto_epoch.h 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/77/877/1