From patchwork Mon Dec 11 15:54:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "plaisthos (Code Review)" X-Patchwork-Id: 3516 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7300:8d12:b0:fc:24ac:f0cb with SMTP id i18csp5262842dys; Mon, 11 Dec 2023 07:55:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IGJHmLQDWeBtzRFbV+PTETAt2OdrtfRA0JHpXfkqoJv99YRVZe8djJHy/6zn47d/hV0BsbQ X-Received: by 2002:a17:90a:c285:b0:286:bf9e:a6 with SMTP id f5-20020a17090ac28500b00286bf9e00a6mr7887979pjt.4.1702310111556; Mon, 11 Dec 2023 07:55:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702310111; cv=none; d=google.com; s=arc-20160816; b=C3HOrOuNg/DTrp4oek+6ejHH1mobeAK6QdWuKCzKLIcdMVxCp4iDrqrjHDxnwFO0LC 8wN46LsS5+gRtiJf5Ku7k2ZhIgU1ItJGBkakqE41ismuq/Oi/5mKXCxCAwca8zNSrE5p bqp/PhF9FEfpSld9KXxdEzb4gdK5ndobojKC9USqufnonS3pjzWdXaGcUDl5HAhwPvvf XWFdiUCBmofkjG1q3DYD+fTzyigx6YGlJf8jOXYmZhAGWzBn0nCaqs0eGogsJWROnZsD s/MW0doqUvzpL9WPSnjF4jVZoEwcxIXKZYUtPUq3PbExsWH/mS4zs1SHPOlz5xc2hWcK d+9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:user-agent :mime-version:message-id:references:auto-submitted:to:date:from :dkim-signature:dkim-signature:dkim-signature; bh=Kq2+l1l1rDRVOtiOT2aUyUPmi3ldKHc4v/TH0ikEPsc=; fh=GFP4qDxgyJ2WEPo/oeLZg3Mj4NqvY1j2nTvTt7psNwg=; b=ngVfbJafKEamKsypJ+0GMw55+a6rrxCqdZhJpzwJ3+FKMw7zOqXFcsmL5P4Y6xKQ70 H/6GW5QABIrGgZA7XDftLZcaQgDW7HM9AAdUenXOEUM79irjLA1vSNUA2vOK8ueCE4H+ 7Wg/5Gh7A0qpLXlfzgqWSKc8CFgK9bHz9lL9/EIysOrhQNyWWYj4K13FQ8Ehcc432/fK L283lLTyZB/phP+iXCu8C+VfZdtnokXGYYsARDOmaAHAn5liYwX8Oa3Mg6SJE59k0xYL xYjzowIy/Uf/f0zuQmwqoFX0Qn7n8bMACbcUAD87voZhUbzeRHlndzwbgq9HdySCcxMC 00gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=QxyNnfXv; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="XG9nRq/K"; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=Sy2wHsPP; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id i17-20020a17090acf9100b00286a2a7a67asi6395183pju.64.2023.12.11.07.55.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Dec 2023 07:55:11 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=QxyNnfXv; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="XG9nRq/K"; dkim=neutral (body hash did not verify) header.i=@openvpn.net header.s=google header.b=Sy2wHsPP; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=openvpn.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rCibt-0002j4-5r; Mon, 11 Dec 2023 15:54:21 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rCibs-0002iu-47 for openvpn-devel@lists.sourceforge.net; Mon, 11 Dec 2023 15:54:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:Content-Transfer-Encoding:MIME-Version :Message-ID:Reply-To:References:Subject:List-Unsubscribe:List-Id:Cc:To:Date: From:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qWc3q+Gq2BuCGDu8jbDDGRPw5wC111OWqjYJe7vgrlk=; b=QxyNnfXvzCWTyADvqWNLoDkPIi DQRTp0rlV/DQ+o3leIahqdXthQETYJLylqCHUIq7rTHTUrbpHs9Y2Ne8eqLvbGsNUz58qlszlAEXM oZg/HbESFlEnhdeI7h1EaoxHmJSSq8ZAsGSaLizMjKhg1P0KJm5R5TcNuiKs1hlOH21A=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Reply-To: References:Subject:List-Unsubscribe:List-Id:Cc:To:Date:From:Sender:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:In-Reply-To:List-Help:List-Subscribe:List-Post: List-Owner:List-Archive; bh=qWc3q+Gq2BuCGDu8jbDDGRPw5wC111OWqjYJe7vgrlk=; b=X G9nRq/K/NtOkRf7JZE5KfIn8EWIqaJgPOVNuufCpo0s+wN+V91b/FC4lVmGt8mmFoHviuAQWwKPN1 M2CehxHMZXBo5Kxn5WbBYIL243YXpSnW6wqCifobCic8LDyMyh7hQPkiZ1TJX/OiI7OUfMjC1cUuD kFgrlawY1s/N4WlI=; Received: from mail-wr1-f54.google.com ([209.85.221.54]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1rCibo-0005E2-8U for openvpn-devel@lists.sourceforge.net; Mon, 11 Dec 2023 15:54:20 +0000 Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3332efd75c9so4252083f8f.2 for ; Mon, 11 Dec 2023 07:54:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1702310041; x=1702914841; darn=lists.sourceforge.net; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from:from:to:cc :subject:date:message-id:reply-to; bh=qWc3q+Gq2BuCGDu8jbDDGRPw5wC111OWqjYJe7vgrlk=; b=Sy2wHsPP859wKCVIi90wsEZ7kmqBcJkXO7ZaCeqU/CZMZBjvSHvP4n7H5i9iSowx/r WBpha8x1rRVKyoMI8RSgiNCBFEx6P2nkOgTzW5IYc620IxiJu2sTJIt3M5E+VXfGf1Fe 1ehgqIl18B0lKGq8c96A8987kkTFy4+f3TYPS2B8jgFr745Y+pwFjf+5Ntdn3p9lyUql ii7IAT/GuO73jcwoy9ftvcKwlJNrSXwrMndJaChoGH6cHYiTueGpiESSlcdeFNK0usxV OGHS5mQL292tQxgFEDhHG9voFPVPENi+WfdA9yb7j+Q41yoQ4NdScUZIoS/ICeEueZKn Idjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702310041; x=1702914841; h=user-agent:content-disposition:content-transfer-encoding :mime-version:message-id:reply-to:references:subject :list-unsubscribe:list-id:auto-submitted:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qWc3q+Gq2BuCGDu8jbDDGRPw5wC111OWqjYJe7vgrlk=; b=ItILt5mldvK5Uu6V2P3hvpeqoSJbPU9u9f/LNwviNVdpy74oiZG4POpRzt+vIHkczK j7r6gyZe4geGSbrbyUi0UsIfYlPRVc7DIB4P0K/eELpqm7Vpxc4DSVNk5Jk3pum1KAf3 RS4qT2GELyVXElwf8BuwI4ctJMSUBs0fOYAyIGqtv9xFFbdX3A3Lbt1Yv+B95kw1awCA CUjBEnxVP+/jXDQxkJXV2i+TMp5RdfU5Uzstz/dZ3WZnlFpP02fndAl2lHLMWPkhx56K nCvYMH2ggbwNt9OdGGA0G8kQOp4MhbgF5MDb1ADYnwGo6inBTvM1JZokHtorfim9vXXC K28g== X-Gm-Message-State: AOJu0YykVF0u9g+0mQZeuu7EYoul06kvEM0b+mPXrZX6VhODaeSiX2oa juo4DR/5HZWevBlA7kJ+0gMK8w== X-Received: by 2002:a05:600c:245:b0:40c:34eb:5940 with SMTP id 5-20020a05600c024500b0040c34eb5940mr994138wmj.368.1702310041275; Mon, 11 Dec 2023 07:54:01 -0800 (PST) Received: from gerrit.openvpn.in (ec2-18-159-0-78.eu-central-1.compute.amazonaws.com. [18.159.0.78]) by smtp.gmail.com with ESMTPSA id j17-20020a05600c1c1100b0040b48690c49sm13423319wms.6.2023.12.11.07.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 07:54:00 -0800 (PST) From: "flichtenheld (Code Review)" X-Google-Original-From: "flichtenheld (Code Review)" X-Gerrit-PatchSet: 1 Date: Mon, 11 Dec 2023 15:54:00 +0000 To: plaisthos Auto-Submitted: auto-generated X-Gerrit-MessageType: newchange X-Gerrit-Change-Id: I11e0091482d9acee89ca018374cb8d96d22f8514 X-Gerrit-Change-Number: 479 X-Gerrit-Project: openvpn X-Gerrit-ChangeURL: X-Gerrit-Commit: b8cb5f3be0a99a6904aa6a509bc9098e8051ae97 References: Message-ID: MIME-Version: 1.0 User-Agent: Gerrit/3.8.2 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "util-spamd-1.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit Content analysis details: (-0.2 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.54 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.54 listed in wl.mailspike.net] 0.0 WEIRD_PORT URI: Uses non-standard port number for HTTP 0.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 T_KAM_HTML_FONT_INVALID Test for Invalidly Named or Formatted Colors in HTML X-Headers-End: 1rCibo-0005E2-8U Subject: [Openvpn-devel] [XS] Change in openvpn[master]: forked-test-driver: Show test output always X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank@lichtenheld.com, arne-openvpn@rfc2549.org, openvpn-devel@lists.sourceforge.net Cc: openvpn-devel Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: =?utf-8?q?1785001527426137177?= X-GMAIL-MSGID: =?utf-8?q?1785001527426137177?= X-getmail-filter-classifier: gerrit message type newchange Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/479?usp=email to review the following change. Change subject: forked-test-driver: Show test output always ...................................................................... forked-test-driver: Show test output always We want to see the progress, especially for slow tests like t_client.sh. Change-Id: I11e0091482d9acee89ca018374cb8d96d22f8514 Signed-off-by: Frank Lichtenheld --- M forked-test-driver 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/79/479/1 diff --git a/forked-test-driver b/forked-test-driver index be73b80..1baaa84 100755 --- a/forked-test-driver +++ b/forked-test-driver @@ -109,7 +109,7 @@ # to ameliorate tests themselves also writing to the log file. Our tests # don't, but others can (automake bug#35762). : >"$log_file" -"$@" >>"$log_file" 2>&1 +"$@" 2>&1 | tee -a "$log_file" estatus=$? if test $enable_hard_errors = no && test $estatus -eq 99; then