From patchwork Fri Sep 18 10:20:11 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marco Baffo X-Patchwork-Id: 5383 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6446:b0:8a0:ea1f:253a with SMTP id n6csp8588112mag; Fri, 18 Sep 2026 03:20:35 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBywQYr2rukmhm/INGfkZneW1rh+o+lQrVirgOmXPwy3FwivwydC5zw69lJLcvrUxgLxdWGM9Pt+eAk=@openvpn.net X-Received: by 2002:a05:6830:44a8:b0:7e9:ead3:4449 with SMTP id 46e09a7af769-80ddf967e9cmr2062305a34.6.1789726835317; Fri, 18 Sep 2026 03:20:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1789726835; cv=none; d=google.com; s=arc-20260327; b=q5X/tJxmvUlcVMscfevZrxJeCMzyp+fBrhj64Cab9eqDdHY8vYqGNeXOVZeFG4JZVN VhdmCXc1hN4KydGEgmnzTtLTurQ0X4ynInl076RqzeaxXJVVs1EILiInKUEdAcf0rD7f 5vzu4Ns9vaILsiaTB3RvpGC24qz04Qh4SoiTvnpxTrHHn8vUdp9Wr+w9QrRifDPysLhA MOPLD3BeHhczlvasH6xuSAvsdoDF7qKm5zSmy+1UV3K0q6rgnGh7JO6EfcvmTIqWGDeO HmUQBTJlIPkdzddqG2V41Pr96itB5X/gGgchDfmFunlHRGUqRhThXTdvEps5oid9zdqX L28g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=dJEtbAIQwuE1MXiN91NhRO6+T2W/tN8qN2JbWfvOano=; fh=BsMg/B0Yb/hS/rzP5Npz4luh0IleZm8REk1XWiWRt2A=; b=DD+aZI/IA7ZjLxz8+/aDxkmiak2QKA6RAQ+ARknWLCWM+4dIbEL/I3JsQ2OnANPGAE aPK+kN8pCXLJwwYYtfQli6OOeI5iCNUeR48WIFVtpF+FQiHI7TsFMl/LEQVSQmPDrZbY SINYO43d/z7PmkJBdu5mzp+LnsT7ZNZlwDlLBzp438eQNB7RbH5ji+MUlEKZ24D89Fqu EgomTWPtignoE+rG+K9CrDRg7DYMuG8d/xukM6Cq5N1eplw85CQ8BvCi8saoGU+vUin4 o6KocVt5/kkqZgZGpy3wTGVF7xQnWuPVlouZOxdlY4Sy8uZal2p/lMOCiRCRdVoEaGGD R9+A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=etCadQNQ; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=dS+OJgbY; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gwCsY8WC; dkim=neutral (body hash did not verify) header.i=@mandelbit.com header.s=MBO0001 header.b=LWCPtPkn; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-80e4271b801si2167796a34.1.2026.09.18.03.20.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Sep 2026 03:20:35 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=etCadQNQ; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=dS+OJgbY; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gwCsY8WC; dkim=neutral (body hash did not verify) header.i=@mandelbit.com header.s=MBO0001 header.b=LWCPtPkn; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dJEtbAIQwuE1MXiN91NhRO6+T2W/tN8qN2JbWfvOano=; b=etCadQNQLGRSoqxNxxjH1YrIv4 0RBOCskESiIQQu2gFuLlnFyV/uD6pWijYBNGBRqSq6Exw0mKYLOvSWmKxR5wY2GW2aTkGUbQaEc5j ukPbNETTmY+YyO8GcyCN0pXY7xMQokH8ZDIvUaUGtYYc6iXL9j7tM2KY3rh4z/Vt13jc=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1x7Vhn-00015a-VS; Fri, 18 Sep 2026 10:20:29 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1x7Vhn-00015S-7Z for openvpn-devel@lists.sourceforge.net; Fri, 18 Sep 2026 10:20:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MRgESvANamGDZOJCOnnBJ9FIqHlHm79vhgW2xP6z/hg=; b=dS+OJgbYvaTiqBJL/umSB3HpbB 2E/RGDy/x0uhmNRh3Yx0Njcinp6DzOF/2KE/LoNacBQZKQsa6Ki1O7ZM6RoGmyqrLc7PJH3slEpgT E1CAIEQDP9G8Th9aogPsFVIX3loqVc2vfslIjPRVXICTqRDkBwR41Wh7dl3qv4oF2f/o=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MRgESvANamGDZOJCOnnBJ9FIqHlHm79vhgW2xP6z/hg=; b=gwCsY8WCAQh6YMcgGFrZsnCck/ tqFLN0doG4sxY7nbI1UckpmJonG/2rKASnyzP/UETp+SXfmFetopX0sUbAjpDAbMliFW4Dhjz7M3n 5SGVhlbvqlf50OM8yGLpEqo1SUgZmNZoByEdXzH7NjSODUZqnoxuY+i7GnT/c6cKtPGU=; Received: from mout-b-106.mailbox.org ([195.10.208.46]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1x7Vhj-0007PW-4z for openvpn-devel@lists.sourceforge.net; Fri, 18 Sep 2026 10:20:28 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-b-106.mailbox.org (Postfix) with ESMTPS id 4hmTCQ5JmszNlf7; Fri, 18 Sep 2026 12:20:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandelbit.com; s=MBO0001; t=1789726818; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MRgESvANamGDZOJCOnnBJ9FIqHlHm79vhgW2xP6z/hg=; b=LWCPtPknjGwxPuwSUzcwSIzYliByXbHi9bCXNZN3VJNkNhVR24FAhMc7Xy4ZKIIxpPmd/r uVNX2XAwUfGSZYTXQhBbivCTkwNBRbiJnRnwWy/P+MMdD8pCTEW8YMvqp6I6crkwH/Khbj ompOfd2nJPjp6IaFJpIB1sROLr5ShheKphFTv5BdDExB6fzYiUQ7B+m1cQGsk22lbnE6Hp J7Kvav/PJ+LfSU7nJe7cIV22ls98MZwGIIyOnQdqQHyDGJ2lbCDDcXhUznR8BZjSsQGVY6 C5RlK3Gt3IN9CaS6lVzsSO2yIFta0x0X/poQoBBXYAaxGsWQJbf5eWy466GHWQ== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of marco@mandelbit.com designates 2001:67c:2050:b231:465::2 as permitted sender) smtp.mailfrom=marco@mandelbit.com From: Marco Baffo To: openvpn-devel@lists.sourceforge.net Date: Fri, 18 Sep 2026 12:20:11 +0200 Message-ID: <20260918102011.1710915-2-marco@mandelbit.com> In-Reply-To: <20260918102011.1710915-1-marco@mandelbit.com> References: <20260918102011.1710915-1-marco@mandelbit.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4hmTCQ5JmszNlf7 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Add a test stage that verifies the ovpn module forwards broadcast (IPv4) and multicast (IPv4/v6) packets to all active peers. For each mode we start tcpdump on every client peer, send a single ping from peer0 to the broadcast/multicast address, and verify all peers captured the packet. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-Headers-End: 1x7Vhj-0007PW-4z Subject: [Openvpn-devel] [RFC ovpn net-next v8 2/2] ovpn: add broadcast and multicast selftests X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antonio Quartulli Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1876664606151347371 X-GMAIL-MSGID: 1876664606151347371 Add a test stage that verifies the ovpn module forwards broadcast (IPv4) and multicast (IPv4/v6) packets to all active peers. For each mode we start tcpdump on every client peer, send a single ping from peer0 to the broadcast/multicast address, and verify all peers captured the packet. Assign link-local addresses explicitly for the IPv6 multicast test so that ping to ff02::1 has a valid source address. Signed-off-by: Marco Baffo --- Changes un v8: - Moved the disabling of automatic address generation to the previous patch. Changes in v7: - Disable automatic IPv6 link-local address generation and assign addresses only for the IPv6 multicast test, avoiding background traffic that affects the mark test's packet counts. - Replace fixed startup delays with bounded tcpdump readiness checks. - Consolidate capture handling in a shared helper with timeouts, per-peer diagnostics, and process/temporary-file cleanup. tools/testing/selftests/net/ovpn/test.sh | 78 +++++++++++++++++++++++- 1 file changed, 76 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/ovpn/test.sh b/tools/testing/selftests/net/ovpn/test.sh index 9b5610837032f..11a0bd92c2827 100755 --- a/tools/testing/selftests/net/ovpn/test.sh +++ b/tools/testing/selftests/net/ovpn/test.sh @@ -56,6 +56,79 @@ ovpn_prepare_network() { done } +ovpn_run_mbcast_test() ( + local label="$1" + local destination="$2" + local filter="$3" + local capture_dir + local deadline + local p + local ret=0 + local -a pids=() + + shift 3 + capture_dir=$(mktemp -d) || return 1 + trap 'kill "${pids[@]}" 2>/dev/null || true + wait "${pids[@]}" 2>/dev/null || true + rm -rf "${capture_dir}"' EXIT + trap 'exit 1' INT TERM + + ovpn_log "Testing ${label}:" + # Allow five seconds for startup, plus time to send and capture the ping. + deadline=$((SECONDS + 5)) + for p in $(seq 1 "${OVPN_NUM_PEERS}"); do + : >"${capture_dir}/${p}" || return 1 + LC_ALL=C timeout 10 ip netns exec "ovpn_peer${p}" \ + tcpdump --immediate-mode -p -ni "tun${p}" -c 1 \ + "${filter}" >/dev/null 2>"${capture_dir}/${p}" & + pids[p]=$! + done + + for p in $(seq 1 "${OVPN_NUM_PEERS}"); do + while ! grep -q "listening on tun${p}," "${capture_dir}/${p}"; do + if ! kill -0 "${pids[p]}" 2>/dev/null || + ((SECONDS >= deadline)); then + printf '# %s: capture not ready on peer%s\n' \ + "${label}" "${p}" + cat "${capture_dir}/${p}" + return 1 + fi + sleep 0.1 + done + done + + ovpn_cmd_mayfail "send ${label} ping from peer0" \ + ip netns exec ovpn_peer0 ping "$@" -qc 1 -w 3 -I tun0 \ + "${destination}" + for p in $(seq 1 "${OVPN_NUM_PEERS}"); do + if ! wait "${pids[p]}"; then + printf '# %s: capture failed on peer%s\n' "${label}" "${p}" + cat "${capture_dir}/${p}" + ret=1 + fi + unset 'pids[p]' + done + + return "${ret}" +) + +ovpn_run_mbcast_tests() { + local p + + ovpn_run_mbcast_test "broadcast" 5.5.5.255 \ + 'icmp and dst host 5.5.5.255' -b || return 1 + ovpn_run_mbcast_test "IPv4 multicast" 224.0.0.1 \ + 'icmp and dst host 224.0.0.1' || return 1 + + for p in $(seq 0 "${OVPN_NUM_PEERS}"); do + ovpn_cmd_ok "configure IPv6 address on peer${p}" \ + ip -n "ovpn_peer${p}" addr add fe80::$((p + 1))/64 \ + dev tun${p} scope link + done + ovpn_run_mbcast_test "IPv6 multicast" ff02::1 \ + 'icmp6 and dst host ff02::1' -6 || return 1 +} + ovpn_run_basic_traffic() { local p local header1 @@ -293,9 +366,9 @@ trap ovpn_stage_err ERR ktap_print_header if [ "${OVPN_FLOAT}" == "1" ]; then - ktap_set_plan 13 + ktap_set_plan 14 else - ktap_set_plan 12 + ktap_set_plan 13 fi ovpn_cleanup @@ -303,6 +376,7 @@ modprobe -q ovpn || true ovpn_run_stage "setup network topology" ovpn_prepare_network ovpn_run_stage "run baseline data traffic" ovpn_run_basic_traffic +ovpn_run_stage "run multi/broadcast traffic" ovpn_run_mbcast_tests ovpn_run_stage "run LAN traffic behind peer1" ovpn_run_lan_traffic [ "${OVPN_FLOAT}" == "1" ] && ovpn_run_stage "run floating peer checks" \ ovpn_run_float_mode