From patchwork Fri Sep 18 16:03:36 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ralf Lici X-Patchwork-Id: 5387 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6446:b0:8a0:ea1f:253a with SMTP id n6csp8968841mag; Fri, 18 Sep 2026 09:04:28 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBz69nTFl8R68zHQEazQIF9dBqAckPdGWa2QZmJ7/UhQ/UeWinpqataN8mkn5+i09/5+QkR6/b8EQn4=@openvpn.net X-Received: by 2002:a05:6870:7d16:b0:485:d31b:775d with SMTP id 586e51a60fabf-486e74133b2mr2912132fac.27.1789747467954; Fri, 18 Sep 2026 09:04:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1789747467; cv=none; d=google.com; s=arc-20260327; b=cIayppy9tmP6DIBTzssEznKP4p9gESQ6gMA6ylFso8l0fRYqXSGWwenDRpejHszs09 Emgst9bECFDTE7Pu9J53NBPhUwLSW63FlocCnaLdgiYH6MlbOgK9KraYdCRt/Bx48G78 giV22d3HDMEMdK8DwZ/OoX9Te36Ik1F7pz5MZu8SOnjCqGS7Fd1OIsVQfb1Ivw+kIjIY PQ9oZ5Ej0whGNZLj73sCN8+sX3inFSOcL07qopC+HVmRh7xDRwt0mv5nMQpYrfLJCLCB DiVV9Na+FEhV0kTKsX7b7lKmxVaZlh/fbuQ6I4sXb3jh1qOLK+pBRgdZNlduuU1hXarN NOlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=NuepX+4H+xSDVsB5hRRP8xRJYW9ELdN81oe93SUnOvc=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=m/f8esbtYAeJyp04rhmypTE4a5U0vm0U+F8TPo2o2Qsrt7vyG61wCeh5WRSCVe+cLZ CROSO9GjAAA+66fZjzDXAWwNOq23I9Br6TzFM7oLsFS3Tt5HcvEFV6ki8lUwPwkt76Cc EhHD2tmldHy1jOt673WnhmKqez7vv7tWp5TOhwQFdsIzoVH1alh8t8kzz4MJeJ1dCnW0 //uoi/945JRCNlzelj2Ue9HL3bavFp3RVylHV/vtPsWsMXxe8GApq5BnLyHRZ+MIvhWe EyBlTrxcnmsG/LfL5Kn9paMOt/neD/StqI+AdvqARBU6WoMtGhA2M4hCCpGsfl5RRRIN kmBQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=eIESosN5; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=HISOtwEY; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="OL9K/vtm"; dkim=neutral (body hash did not verify) header.i=@mandelbit.com header.s=MBO0001 header.b=CLiFlLJX; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-487397560c6si2456969fac.91.2026.09.18.09.04.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Sep 2026 09:04:27 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=eIESosN5; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=HISOtwEY; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b="OL9K/vtm"; dkim=neutral (body hash did not verify) header.i=@mandelbit.com header.s=MBO0001 header.b=CLiFlLJX; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NuepX+4H+xSDVsB5hRRP8xRJYW9ELdN81oe93SUnOvc=; b=eIESosN5scip90TwyhYaLo3y48 WnMuIMxQttNa/ZEadoLwDSO45dNMTGz7T0YpS4797o18/ZaNmgM7IIjQBwInJWc7Ci/sgDVjboZSQ rMst9/o88Z08jHRog64RcebPwz/Uh73MGKkP0+Bl/ITEJHXQoDkkfFhni/aEDGIPIctU=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1x7b4Z-0000TG-B2; Fri, 18 Sep 2026 16:04:24 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1x7b4Y-0000T5-7g for openvpn-devel@lists.sourceforge.net; Fri, 18 Sep 2026 16:04:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Fh7eou2oqxg+8c/XKPIVykOTEtVLOayPCyw61ORg9DM=; b=HISOtwEYuW6Gr4EC6zGiG1ouhZ WyNGyVFUkV9w+/eRceYa79nEEjWc/yX2PGSoClLwlHw36/6TH4Kkasj3Aif/SlOrl9fTVvbjWMolC 1+6guHr7dktQ2yMnElbeMoVbljDOTkuACbWEGB/K/IbgIol/DoD5BFVHFn5LBC/TZTLs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Fh7eou2oqxg+8c/XKPIVykOTEtVLOayPCyw61ORg9DM=; b=OL9K/vtm1ZlZFaylF6llG+bTiS T9Gy87IV6udFxrx04Np5yR13v9SiGm7prd+CoXg4WpRevu+ckwP253K7OEBYxRa9vdOrtDRJDighW cBtN4xw9SmN7lS/D6zwFOKVLVbR4T2kKTdI0Ae/6Gbrp2Lwi9eRJueYwV9dwDLVnEXaA=; Received: from mout-b-203.mailbox.org ([195.10.208.52]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1x7b4X-00067o-QM for openvpn-devel@lists.sourceforge.net; Fri, 18 Sep 2026 16:04:22 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-b-203.mailbox.org (Postfix) with ESMTPS id 4hmcrF2BKRzLmFJ for ; Fri, 18 Sep 2026 18:04:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandelbit.com; s=MBO0001; t=1789747453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fh7eou2oqxg+8c/XKPIVykOTEtVLOayPCyw61ORg9DM=; b=CLiFlLJXu7UIMMrrKdLynrDrK7x4ExQusb81k3zbIDTBfYQBwYWOxu/2GlzGOO79Yo+xKz B7a+o/SXKXDdZD3l5mreNsegzjrVaJ+WP9gO9F73W5OiScKVKZfG0wEpTenrtUOsBXrFZw nb9knAgdPQDiBn4MbQRU4Gd5QfOHopkvx8lQTk/MDxZbR20Zuy4l8KMo3eIUBhb9l9dgNf Ycz8GBqIKc1DYsXFFA3eQq0ToZvbLKKzMQLZu+ppbxTPbCQeH7D6f1p0Bb/FgI3ZUieQa9 F+vW9yn4P5mjeB/q8MB6m98EIZgssuxLnUPtZQn+gLI8YSVQn2lNUb60E41o2A== From: Ralf Lici To: openvpn-devel@lists.sourceforge.net Date: Fri, 18 Sep 2026 18:03:36 +0200 Message-ID: <6743db29e84f7e7018e7d2ce71cbdf379d228c1b.1789746543.git.ralf@mandelbit.com> In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Packet processing holds a key slot until asynchronous crypto completion. Parallel traffic using one key consequently updates the same kref cache line for every packet, even though key slots are normal [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [195.10.208.52 listed in wl.mailspike.net] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-Headers-End: 1x7b4X-00067o-QM Subject: [Openvpn-devel] [PATCH ovpn net-next v2 2/2] ovpn: use percpu references for key slots X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1876686241235512578 X-GMAIL-MSGID: 1876686241235512578 Packet processing holds a key slot until asynchronous crypto completion. Parallel traffic using one key consequently updates the same kref cache line for every packet, even though key slots are normally long-lived. Replace the key-slot kref with percpu_ref. Kill the initial reference after atomically unpublishing a slot, while ordinary packet completions only put their live references. Key destruction needs process context to release the crypto transforms and an RCU grace period for lockless configuration readers which do not hold a key reference. With percpu_ref, the release callback may run from the internal RCU callback which switches the reference to atomic mode. Queueing rcu_work from there would create a nested callback which the module cleanup rcu_barrier is not guaranteed to wait for. Record the RCU state after unpublishing the slot and queue ordinary work from the release callback instead. The worker conditionally waits for the recorded grace period before freeing the key. This provides explicit RCU synchronization without depending on percpu_ref implementation details or unconditionally starting another grace period. Peer teardown kills its keys before dropping the final netdevice reference, so rtnl_link_unregister cannot return before the key percpu-ref callbacks have been registered. The existing rcu_barrier drains those callbacks and destroy_workqueue subsequently drains the ordinary key cleanup work. Initialize the reference only after the rest of the key slot is ready, allowing the existing destruction path to handle allocation failure. The conversion adds an 8-byte counter per possible CPU and a 56-byte control allocation for each installed key slot; with at most two long-lived slots per peer, this is a bounded memory tradeoff for removing the shared reference cacheline from the packet path. After the peer conversion, perf c2c still identified the key-slot kref cacheline, with 15 sampled HITM loads attributed to its locked reference update. This change removed that line from the shared-cacheline profile as well. In a set of interleaved 32-flow iperf3 runs, the combined peer and key conversion moved throughput to 8.812 Gbit/s, against 7.734 Gbit/s for the baseline, a +13.95% improvement. Single-stream control found no reproducible regression. Signed-off-by: Ralf Lici --- Changes since v1 https://lore.kernel.org/openvpn-devel/9551c9c842e4ac926089badc81f445becca513e5.1789658051.git.ralf@mandelbit.com/ - Replace the nested rcu_work teardown with ordinary work so module cleanup cannot destroy the workqueue before the work is queued. (Sashiko) - Record the RCU state after unpublishing a key and conditionally wait for RCU-only readers in the final worker. (Sashiko) drivers/net/ovpn/crypto.c | 16 ++++++++-------- drivers/net/ovpn/crypto.h | 27 ++++++++++++++++++++++----- drivers/net/ovpn/crypto_aead.c | 17 +++++++++++++---- 3 files changed, 43 insertions(+), 17 deletions(-) diff --git a/drivers/net/ovpn/crypto.c b/drivers/net/ovpn/crypto.c index 7e545428900a..25c3a2b6da48 100644 --- a/drivers/net/ovpn/crypto.c +++ b/drivers/net/ovpn/crypto.c @@ -18,12 +18,12 @@ #include "crypto_aead.h" #include "crypto.h" -void ovpn_crypto_key_slot_release(struct kref *kref) +void ovpn_crypto_key_slot_release(struct percpu_ref *ref) { struct ovpn_crypto_key_slot *ks; - ks = container_of(kref, struct ovpn_crypto_key_slot, refcount); - queue_rcu_work(ovpn_wq, &ks->free_work); + ks = container_of(ref, struct ovpn_crypto_key_slot, refcount); + queue_work(ovpn_wq, &ks->free_work); } /* can only be invoked when all peer references have been dropped (i.e. RCU @@ -36,13 +36,13 @@ void ovpn_crypto_state_release(struct ovpn_crypto_state *cs) ks = rcu_access_pointer(cs->slots[0]); if (ks) { RCU_INIT_POINTER(cs->slots[0], NULL); - ovpn_crypto_key_slot_put(ks); + ovpn_crypto_key_slot_kill(ks); } ks = rcu_access_pointer(cs->slots[1]); if (ks) { RCU_INIT_POINTER(cs->slots[1], NULL); - ovpn_crypto_key_slot_put(ks); + ovpn_crypto_key_slot_kill(ks); } } @@ -66,7 +66,7 @@ bool ovpn_crypto_kill_key(struct ovpn_crypto_state *cs, u8 key_id) spin_unlock_bh(&cs->lock); if (ks) - ovpn_crypto_key_slot_put(ks); + ovpn_crypto_key_slot_kill(ks); /* let the caller know if a key was actually killed */ return ks; @@ -104,7 +104,7 @@ int ovpn_crypto_state_reset(struct ovpn_crypto_state *cs, spin_unlock_bh(&cs->lock); if (old) - ovpn_crypto_key_slot_put(old); + ovpn_crypto_key_slot_kill(old); return 0; } @@ -141,7 +141,7 @@ void ovpn_crypto_key_slot_delete(struct ovpn_crypto_state *cs, } pr_debug("deleting key slot %u, key_id=%u\n", slot, ks->key_id); - ovpn_crypto_key_slot_put(ks); + ovpn_crypto_key_slot_kill(ks); } void ovpn_crypto_key_slots_swap(struct ovpn_crypto_state *cs) diff --git a/drivers/net/ovpn/crypto.h b/drivers/net/ovpn/crypto.h index e3feb16d5498..a0209b1280de 100644 --- a/drivers/net/ovpn/crypto.h +++ b/drivers/net/ovpn/crypto.h @@ -10,6 +10,8 @@ #ifndef _NET_OVPN_OVPNCRYPTO_H_ #define _NET_OVPN_OVPNCRYPTO_H_ +#include +#include #include #include "pktid.h" @@ -47,8 +49,9 @@ struct ovpn_crypto_key_slot { struct ovpn_pktid_recv pid_recv ____cacheline_aligned_in_smp; struct ovpn_pktid_xmit pid_xmit ____cacheline_aligned_in_smp; - struct rcu_work free_work; - struct kref refcount; + struct work_struct free_work; + unsigned long rcu_state; + struct percpu_ref refcount; }; struct ovpn_crypto_state { @@ -61,7 +64,7 @@ struct ovpn_crypto_state { static inline bool ovpn_crypto_key_slot_hold(struct ovpn_crypto_key_slot *ks) { - return kref_get_unless_zero(&ks->refcount); + return percpu_ref_tryget_live_rcu(&ks->refcount); } static inline void ovpn_crypto_state_init(struct ovpn_crypto_state *cs) @@ -121,11 +124,25 @@ ovpn_crypto_key_slot_primary(const struct ovpn_crypto_state *cs) return ks; } -void ovpn_crypto_key_slot_release(struct kref *kref); +void ovpn_crypto_key_slot_release(struct percpu_ref *ref); static inline void ovpn_crypto_key_slot_put(struct ovpn_crypto_key_slot *ks) { - kref_put(&ks->refcount, ovpn_crypto_key_slot_release); + percpu_ref_put(&ks->refcount); +} + +/** + * ovpn_crypto_key_slot_kill - stop new users and drop the initial reference + * @ks: key slot which has already been unpublished + * + * percpu_ref does not guarantee an RCU grace period before release. Record + * the RCU state after unpublishing the key so the final worker can synchronize + * with lockless readers without unconditionally starting another grace period. + */ +static inline void ovpn_crypto_key_slot_kill(struct ovpn_crypto_key_slot *ks) +{ + ks->rcu_state = get_state_synchronize_rcu(); + percpu_ref_kill(&ks->refcount); } int ovpn_crypto_state_reset(struct ovpn_crypto_state *cs, diff --git a/drivers/net/ovpn/crypto_aead.c b/drivers/net/ovpn/crypto_aead.c index 74eaf6fac2f5..77ae958a971a 100644 --- a/drivers/net/ovpn/crypto_aead.c +++ b/drivers/net/ovpn/crypto_aead.c @@ -391,8 +391,13 @@ static void ovpn_aead_crypto_key_slot_free_work(struct work_struct *work) { struct ovpn_crypto_key_slot *ks; - ks = container_of(to_rcu_work(work), struct ovpn_crypto_key_slot, - free_work); + ks = container_of(work, struct ovpn_crypto_key_slot, free_work); + /* Reaching this worker means every reference held by packet processing + * and asynchronous crypto has been returned. Separately wait for any + * RCU-only reader which observed the slot before it was unpublished. + */ + cond_synchronize_rcu(ks->rcu_state); + percpu_ref_exit(&ks->refcount); ovpn_aead_crypto_key_slot_free(ks); kfree(ks); } @@ -427,8 +432,7 @@ ovpn_aead_crypto_key_slot_new(const struct ovpn_key_config *kc) ks->encrypt = NULL; ks->decrypt = NULL; - INIT_RCU_WORK(&ks->free_work, ovpn_aead_crypto_key_slot_free_work); - kref_init(&ks->refcount); + INIT_WORK(&ks->free_work, ovpn_aead_crypto_key_slot_free_work); ks->key_id = kc->key_id; ks->encrypt = ovpn_aead_init("encrypt", alg_name, @@ -458,6 +462,11 @@ ovpn_aead_crypto_key_slot_new(const struct ovpn_key_config *kc) ovpn_pktid_xmit_init(&ks->pid_xmit); ovpn_pktid_recv_init(&ks->pid_recv); + ret = percpu_ref_init(&ks->refcount, ovpn_crypto_key_slot_release, 0, + GFP_KERNEL); + if (ret < 0) + goto destroy_ks; + return ks; destroy_ks: