From patchwork Fri Jul 3 06:18:01 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ralf Lici X-Patchwork-Id: 5082 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:1887:b0:869:83bc:8c48 with SMTP id r7csp1698046max; Thu, 2 Jul 2026 23:18:28 -0700 (PDT) X-Forwarded-Encrypted: i=2; AHgh+RpgBlP3/fL+MClg6LoyCmBnSgAqEZmwBG63X1rMtTAmFmFS3jDSIXY7z9AtR6Z3OU9xk93B8fHwcB4=@openvpn.net X-Received: by 2002:a05:6870:224e:b0:430:7c2:9a30 with SMTP id 586e51a60fabf-44cab573c34mr5843910fac.15.1783059508735; Thu, 02 Jul 2026 23:18:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1783059508; cv=none; d=google.com; s=arc-20260327; b=QDgAbsTA4+L0IU9F2hoyh6qFFAGrTkhgV+fWem41xxrIJN2b0eRo+QzYr82m+wfFdY fR4kxEVt/RuFkHXW60qP9q8OhmUleYL2m7A7U2HFHRFokuA5nFsHwQNyNFppLFeY/uyZ 1zruZ0U0P5Obn8PVGqFWPJ28rW0xGoLzW+NyJzlYo3sYMAmx6OXW2O8Z77r9g0y9dYiB riEKZtF18ld9Y1aTfvAW+Gweg6gRi3tNRXuVrmNrvAqecYX/N+lBeKVLAY3bmeGtck9B IVi5Ydk0FJV5MPGVTozYCqnBrLWj9WHc+liTHrQ6OKl69HfAVTsGyHM6XXCojcsjbI1y xzgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:dkim-signature :dkim-signature:dkim-signature; bh=bSBhfsFUZowmcHUuviu3aOepF5xLLUyzmSFJrz028N4=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=KiM+KqS0XmBIn9PpUAftLRsrHbegO+UU3IV7n6Nip2ymtgjZPHwFdrKsNp87xaWz/i T4Rwbt7H6mkDqBwIK/eGNkobN3De50CMmpxn1JxyuwScOJyRatCFJTXPug7I04j0En/w Vs4Z8u7OrElPt3TsGWTntLHBF7DKvPiE9eZMOyU1on2koM7yBGvGPlV8h9DAthQ0kClv MWwk7xni24pyah0rFQ8IdsM+JJDz96AlFSk9eNSLpJF8AuASxTj2U2PR+3f+EJv9lPJi 7WLRUhj1wplOUqFxVsEMWFHxB15ydCY0xwC3j90NGBueBbCv8Rk7xnFYb/Z0TqpSFMcU TMUQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=amgX4oVS; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=c2NjKvfC; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=RLVNTc0k; dkim=neutral (body hash did not verify) header.i=@mandelbit.com header.s=MBO0001 header.b=NPfkxFMc; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-44cfb669160si779209fac.113.2026.07.02.23.18.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jul 2026 23:18:28 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=amgX4oVS; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=c2NjKvfC; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=RLVNTc0k; dkim=neutral (body hash did not verify) header.i=@mandelbit.com header.s=MBO0001 header.b=NPfkxFMc; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:Message-ID:Date:To:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=bSBhfsFUZowmcHUuviu3aOepF5xLLUyzmSFJrz028N4=; b=amgX4oVSkmPXIcZoejzhTXJnWP QqmxPDaFm/90xmBYEX41eHzdMOyGndA+zGjudnYggOflF3/t5YKW1CqNeNjxmi/HVci7TvECm1G4a PW71N7OUg96FuVuQSqUUhxokr+3rBvln1hQrv+7W4PXrlIFW2J4XwOLL0ynHq8l8uGCg=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wfXEK-0005G1-0T; Fri, 03 Jul 2026 06:18:25 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wfXEI-0005Fs-Dm for openvpn-devel@lists.sourceforge.net; Fri, 03 Jul 2026 06:18:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jIhf5rxLYyBFLm8fb6Nucu0yAHBduIkw8MK1cbgZU9A=; b=c2NjKvfCIugC4HnlR9s3DTiCYZ /kDAPhCN9oRllBXKbSuP9gGmcVZSAycjst0Q/VkTQnbgG6HcYFTynXnFxAYyiY+elHGviLaNwegqy yKStYd4u3wHRuuMBxJqDpHXMaOYP0bgufMbPOfdt4ngWHbNrS2uv+mjkGHM8C1QUePGo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=jIhf5rxLYyBFLm8fb6Nucu0yAHBduIkw8MK1cbgZU9A=; b=R LVNTc0kuMIdIdC/+8NIIT8RCVjSCkeBXq5bIgsu5s9P62xEg6YBibgx6LmFsiGS5/Z+ljKP4l70ny MM/5ur6lBSh0ZBbhgqNvHQAYuYGrSMnaomkzfm4Va5ZDZVsDuoC3YhDs1GGRDxAsGL9DSbsQRzp3I KWPSLAaP7qka14YI=; Received: from mout-b-202.mailbox.org ([195.10.208.62]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wfXEE-0004gI-Qn for openvpn-devel@lists.sourceforge.net; Fri, 03 Jul 2026 06:18:23 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-b-202.mailbox.org (Postfix) with ESMTPS id 4gs3Tg2MplzDsFg; Fri, 3 Jul 2026 08:18:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandelbit.com; s=MBO0001; t=1783059495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=jIhf5rxLYyBFLm8fb6Nucu0yAHBduIkw8MK1cbgZU9A=; b=NPfkxFMci2H2wksh6RT712PMqpUQf3wXxii1+xAaBUsvaDXLtgrfSo8PI9zJ2yCB/Zkjns kx6XCaz1+sfO7V0ApCSiczfEBrLn4+9y/7SkutcrpkfBHMN6IR/jr8VLho/FdwJAdCtt4V e9Oz9FI/UdxyzdE+oFkdFU4WSlxViGk7FEupeHyWWoLlzMPWC5R66h5Q2JPKgIrcZavpGp M6iD8lrjSn2ripeV8M4c/kG/Cih8Fy8JrSewPK3oRwmgvU0wx74ftsMpBK/AxrVWss6cR2 vvIYZiUFwdytmyaLpeIEFolz1ik2D2mhbim5BZUnvZPtYYf0MThOfWxIlUXBNw== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of ralf@mandelbit.com designates 2001:67c:2050:b231:465::1 as permitted sender) smtp.mailfrom=ralf@mandelbit.com From: Ralf Lici To: openvpn-devel@lists.sourceforge.net Date: Fri, 3 Jul 2026 08:18:01 +0200 Message-ID: <8577555cc95646d0bd58a5b78e59c7e6a9b1a0c6.1783058844.git.ralf@mandelbit.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4gs3Tg2MplzDsFg X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Currently, in ovpn_nl_key_swap_notify, the OVPN_A_KEYCONF_KEY_ID attribute is packed as a 16-bit value despite being defined as a 32-bit u32 attribute in the YAML policy. Fix this inconsistency by using nla_put_u32. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1wfXEE-0004gI-Qn Subject: [Openvpn-devel] [PATCH ovpn net] ovpn: use nla_put_u32 for the key ID attribute in ovpn_nl_key_swap_notify X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1869673407044075419 X-GMAIL-MSGID: 1869673407044075419 Currently, in ovpn_nl_key_swap_notify, the OVPN_A_KEYCONF_KEY_ID attribute is packed as a 16-bit value despite being defined as a 32-bit u32 attribute in the YAML policy. Fix this inconsistency by using nla_put_u32. Fixes: 89d3c0e4612a ("ovpn: kill key and notify userspace in case of IV exhaustion") Signed-off-by: Ralf Lici --- drivers/net/ovpn/netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ovpn/netlink.c b/drivers/net/ovpn/netlink.c index 4c66c1ec497e..abf038206a62 100644 --- a/drivers/net/ovpn/netlink.c +++ b/drivers/net/ovpn/netlink.c @@ -1335,7 +1335,7 @@ int ovpn_nl_key_swap_notify(struct ovpn_peer *peer, u8 key_id) if (nla_put_u32(msg, OVPN_A_KEYCONF_PEER_ID, peer->id)) goto err_cancel_msg; - if (nla_put_u16(msg, OVPN_A_KEYCONF_KEY_ID, key_id)) + if (nla_put_u32(msg, OVPN_A_KEYCONF_KEY_ID, key_id)) goto err_cancel_msg; nla_nest_end(msg, k_attr);