From patchwork Wed Sep 16 11:46:15 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ralf Lici X-Patchwork-Id: 5369 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6446:b0:8a0:ea1f:253a with SMTP id n6csp6082454mag; Wed, 16 Sep 2026 04:47:09 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBz4z6r7UXsfuGYZf0UxUUcLgGADXrF/2+VxGIuBmAhl0YESjvH8f74xb4gJICBHpcPs6JqnFaGiLo4=@openvpn.net X-Received: by 2002:a05:6830:d89:b0:7e9:cf6f:aef8 with SMTP id 46e09a7af769-80b2c5a9b5amr2688407a34.11.1789559229168; Wed, 16 Sep 2026 04:47:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1789559229; cv=none; d=google.com; s=arc-20260327; b=LNWoqbKfuD/8HMIZNTe0aoc6g4I8d+Q+lgmaJpfjHyUXq2hphdQSRzzPjQDsA5DX4s rlXsnRCfIgrk//VAe3NYlbUqiZJGmQSnCS6yPbP9Iuio6yLc2D5/GI+Q0S5wtLsC16WL YRFdEBAND20dlVEOl3ElVBUw6VHViqEF6NSbyeyF19lzCiYYdjBNa40V4yV6hfc02FFD brCasX43z1js2ko2j6RajQNPG6yM4KNhOLdmAEplSnVWuJvoAgPZEOUeyDTkmEFZ47mm 6tOmGfoL6oCRXyMjLMh2OpGCqSPM+YfJ5j5Hh5ygwlzSgjPJpAvBQHZXHR53wJMax3mq wlCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=1+FaM/Ylc5ev9YdNU3iGGrwufPnY7GrJrTlJGVrx1z8=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=Rt+xa/fxUIzgT6lKkRT/V4W4fbHoTc467oQ8bcHPuIhtoFM11XgfuN8xLWSNXx/mCO HURjgikQvXDRKLgjmgCNYmTqi2uMYnIa55vjVRwZk+qAXJUuTlCScMgAV9qtiKbAOWoc j02bmN1efT1N9A52PsqW7BGMB68kss54TVy6WJPjkgQBaLu6zeT9P+nNI+a83qQD1Dei KVmhks85hjec3OGDmd1SsoxvQEqhK7BCm3fNRkSuPt2R//N24N85RIaprRYjjTrlpYjM kEckhyNqaDd6zvlcxZhLQ+Q/PP3pMFTPXywISHJytkIdROVYaCVGfEUhVgZ+FUPTs/B5 sZ5Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=f2SFcgb0; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=knX9dm17; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gIUApmCT; dkim=neutral (body hash did not verify) header.i=@mandelbit.com header.s=MBO0001 header.b=qIM6UpzI; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-4842aac032fsi2921740fac.312.2026.09.16.04.47.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Sep 2026 04:47:09 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=f2SFcgb0; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=knX9dm17; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=gIUApmCT; dkim=neutral (body hash did not verify) header.i=@mandelbit.com header.s=MBO0001 header.b=qIM6UpzI; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1+FaM/Ylc5ev9YdNU3iGGrwufPnY7GrJrTlJGVrx1z8=; b=f2SFcgb07nc0APjKGNgkLWragU ftiCZfXs/HPsjI86svPDoV0j3vXgtL+CdaX4HdNwhgyC4tNNRIs0rBWT1e5aqZXIyI3yi6YhnAcjA 0k38V5GgALDkW/sfuZvkjS0PfKYJz39R8WOTpexBNueHWkW6cbht2TK3A2PiUECKVYvo=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1x6o6S-00028g-Qm; Wed, 16 Sep 2026 11:47:02 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1x6o6Q-00028G-On for openvpn-devel@lists.sourceforge.net; Wed, 16 Sep 2026 11:47:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=a5eLvu8ZQmQhhnMC3sv5sJDQCyWbpFRBXI10CDKwk58=; b=knX9dm17sqJkRxJNxfp5agsHa5 8yODcie6zLi17FIXbzEX1EdbCFEM91l4A9WbxNJXo0sysLzSaQfigU7+VEAQ/kLZxB0algL6mCZAJ fF7E26A2nNLeGT9V9TBVSaVL4/8uKG4RYDqGwnQzNORKvXNCMh4ybSdSFuh/DfdWMETs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=a5eLvu8ZQmQhhnMC3sv5sJDQCyWbpFRBXI10CDKwk58=; b=gIUApmCT9MitbcndMKOmnqdkJY MC3Xj09Cbmae+I+w962bmx/jX9follQAo1qPhBc6UoX+p2W/CukRe/us8n/t1i0vV1WXZlhUsYetV Wa/szTp0BhqPjKJWAIFO7jin1uYepWO423SVKs0VWXOf2pLe2PKpvn7HqQ8FKEcsVmXE=; Received: from mout-b-203.mailbox.org ([195.10.208.52]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1x6o6K-0005OW-Op for openvpn-devel@lists.sourceforge.net; Wed, 16 Sep 2026 11:47:00 +0000 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-b-203.mailbox.org (Postfix) with ESMTPS id 4hlHCr4VkRzLlZN for ; Wed, 16 Sep 2026 13:46:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandelbit.com; s=MBO0001; t=1789559192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a5eLvu8ZQmQhhnMC3sv5sJDQCyWbpFRBXI10CDKwk58=; b=qIM6UpzIqJVl7Yr04YrZssLNIyzfknZwNzI8i7TBkEJpT8ZCR5ixYK9io8wBLyY2SRSuDM 2mQPm6mJkAM6wn/Qg3o+IHQFo9TMufXnjc/k9d6wjcpP7juofWcog2XhtUxp6ixrAu5oVU NtuFa6H7/xIAXgM/nsG4KonceSDKBJTYpkI4+6p3G5BzZvHJda+9soCngxKQ01IsJvkHp3 +qpZHPFgHJ2FDfk4gr1Qn9g52GOwTwdPdZZX/4fFBYu7pUcVii88kODWafvXz/xxdllv67 qqqj0w+KQxuHucOGgMsEhdpVV+ePldLnkuzjjbolCggZsL33hQxGTeIA0fNHgg== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of ralf@mandelbit.com designates 2001:67c:2050:b231:465::1 as permitted sender) smtp.mailfrom=ralf@mandelbit.com From: Ralf Lici To: openvpn-devel@lists.sourceforge.net Date: Wed, 16 Sep 2026 13:46:15 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 4hlHCr4VkRzLlZN X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Software segmentation exposes the complete skb list before encryption begins. While encrypting each segment, request write ownership of the next linear segment cache line by cache line. A single skb n [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-Headers-End: 1x6o6K-0005OW-Op Subject: [Openvpn-devel] [RFC ovpn net-next v4 7/9] ovpn: prefetch GSO segments before in-place encryption X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1876488858251939634 X-GMAIL-MSGID: 1876488858251939634 Software segmentation exposes the complete skb list before encryption begins. While encrypting each segment, request write ownership of the next linear segment cache line by cache line. A single skb naturally skips the prefetch path. Signed-off-by: Ralf Lici --- No changes since v3 https://lore.kernel.org/openvpn-devel/cc6cda4eb421a6c1ba12da441256b4dfb8438c12.1789546917.git.ralf@mandelbit.com/ No changes since v2 https://lore.kernel.org/openvpn-devel/3f903692549ee58887b1bb421f8b283059f66a1d.1789540779.git.ralf@mandelbit.com/ No changes since v1 https://lore.kernel.org/openvpn-devel/382879c187b1acca65198c467d1263266243ea50.1789485693.git.ralf@mandelbit.com/ drivers/net/ovpn/io.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ovpn/io.c b/drivers/net/ovpn/io.c index 11f7f16d7b79..cb7503a3e79c 100644 --- a/drivers/net/ovpn/io.c +++ b/drivers/net/ovpn/io.c @@ -472,6 +472,12 @@ static void ovpn_send(struct ovpn_priv *ovpn, struct sk_buff *skb, * independently */ skb_list_walk_safe(skb, curr, next) { + /* encrypting this segment can hide the cost of fetching the + * next segment's data into the cache + */ + if (next) + ovpn_skb_prefetchw(next); + if (unlikely(!ovpn_encrypt_one(peer, curr))) { ovpn_dev_dstats_tx_dropped(ovpn->dev, 1); kfree_skb(curr);