From patchwork Wed Jul 29 10:21:42 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ralf Lici X-Patchwork-Id: 5167 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:fd0b:b0:87d:ab56:3700 with SMTP id cw11csp1746428mac; Wed, 29 Jul 2026 03:22:25 -0700 (PDT) X-Forwarded-Encrypted: i=2; AHgh+RqcbVCvaSw9DuKkAeDiRQPRDUPTnmtXDM87YJj8psmDn26KG4PiSj0PFVa94F4mkYNgXUWmaKQBdug=@openvpn.net X-Received: by 2002:a05:6870:1414:b0:430:b7d:f248 with SMTP id 586e51a60fabf-4586cd28564mr3628971fac.24.1785320545144; Wed, 29 Jul 2026 03:22:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1785320545; cv=none; d=google.com; s=arc-20260327; b=aRKbRitT7PY4Ko9Gs4enZm8XozMjNSzuGvB3RTqN+f37ur2q1ZSr0tgAXrCPwpghEG CgG6mKprrffxdHZeW7oKGgaLBLQNy9G6qUFXe3G1R5FlgJJvnnwjQVZBsQvTm71ZBpJ4 qSx5GJN2oOEoGeqOTtolurcvDS6iRif8gGzPU9Q45gMysX2m30F7crJ1eLwWwZphfLB3 J9Ooegu7o2j5uKtUi+xtqSNbQouRVIp/+Qc/xY2w1Y0FpHDeIWLDkNIfPGQnw5/+9ilI zeS7Vf/8N2zxeyirvRKSRM1TD6/RGPGPvMOiwubb56gT9AArO995EoiFO5M4BFy+EPCU I3dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:cc:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=kMNkgUjNrDHWjhafr/m2PoOCq5FcztEQ3XSBKmeFVzk=; fh=bDmbXayvKcQuWZaaz4JM7kgnS3MJBk3QUq2ehqNuBVc=; b=sKdPew3648nkqi5GUH+yG0mJ+RXgT4RrdP2RdZ7TImRbF/qO+n2sdIowCJ9A5c0ibC J1OJoO8cfGPlMDkxTXYYqaO91FYP0SK+/jo8eOSF8upeTgK+w+o/PepSCWj2xc/Tl7+n zl7rZ8LKamjdOE9xbccGd7gcHAbTGEnBxG8ftXFUduNniXqIWlJtJeHbxtGO7n1NZXd1 s5plx6kLzpfxJOMRWil8Hg/2+W93X7vaYlXD6LgOc46G0iFdSy98rU7niucDkFz9Omwj 36vFHAFrddGZ+fXxCGWmZwvv7Z8JKLJwB9QyYJL6RoZ6Fqt1v17/otSkXvzTzvqCkB/n 4/LQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=AGVKeG4y; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ZpZkhczZ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=bnjGu8J6; dkim=neutral (body hash did not verify) header.i=@mandelbit.com header.s=MBO0001 header.b=OuckQJ77; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-4588696519fsi2310648fac.140.2026.07.29.03.22.24 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jul 2026 03:22:24 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=AGVKeG4y; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=ZpZkhczZ; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=bnjGu8J6; dkim=neutral (body hash did not verify) header.i=@mandelbit.com header.s=MBO0001 header.b=OuckQJ77; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kMNkgUjNrDHWjhafr/m2PoOCq5FcztEQ3XSBKmeFVzk=; b=AGVKeG4yM0+P3kB4PguHMr3Osl QYs+f0fvknZuttvmMlpJ2B0CeIgrH6hC/4wsQwfVE9wIy4oUwzqxX9B9M/111vccZlPKMkuOBVnY2 xXq5q1SDLZWzXf/PUaxxfUoClaB/cA1eEIC9cvi6mvRVzdIV5JQiVJqO79X7yaAwmeOg=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wp1Qe-0002o7-9C; Wed, 29 Jul 2026 10:22:21 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wp1QP-0002nc-WF for openvpn-devel@lists.sourceforge.net; Wed, 29 Jul 2026 10:22:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=s7mKFePLkVlKhOpo7ibGf89xR4bksuWw337+41qyzQA=; b=ZpZkhczZJnGm/hVneSf9J9FTD9 NiUG3fWIhKIK2zf3DBbmOTS7B8aV7SUS/IYXZvmm5XF6dzeDTI37Rb5KKSbrDwgfqQxAP3vifYrNs dvuwW9VYxWk/s3B/gVgCk/Vnx+vPTRndS+/dhkMwJW1IV8NxQUYu5TmRQEeRg5saoas0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=s7mKFePLkVlKhOpo7ibGf89xR4bksuWw337+41qyzQA=; b=bnjGu8J6GR36wys6XvYp6G/HHA +NUv5FmoE1wPxqKehnQWl9cFnsm4MHWHALwabW/rx5Ge6bfjJvlW7I14Xb6kNKlKkWOpLc4dks7i/ QhMcbnbFTzreTZzXXTfrgo3DO+Nb1qt++eBrzO1MksHWhk+EA1yFFw7vP79QCClVxyGw=; Received: from mout-b-106.mailbox.org ([195.10.208.46]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wp1QO-0002fC-Ru for openvpn-devel@lists.sourceforge.net; Wed, 29 Jul 2026 10:22:07 +0000 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-b-106.mailbox.org (Postfix) with ESMTPS id 4h97fs0SLHzNkMP; Wed, 29 Jul 2026 12:21:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandelbit.com; s=MBO0001; t=1785320517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s7mKFePLkVlKhOpo7ibGf89xR4bksuWw337+41qyzQA=; b=OuckQJ77/xY1Ohkm5e9wVza5iH7JcnwFEVUISPpIojZ+rGkeH9Qy32kSnOAzlbkwiy83q2 5dGwJtGyqRd/uJyylqi/3tVf2hUulSdDlb8HBQ82iYTKfF4UeTvMS816riWDdrxJRmiggP 9Bt1Hdo19zRo9HZ8sQX+b1JKd0fYBHk/16K9VKWSgKvlstMXKPoHYjWW0ig6KKNjt6M9tz oA9QjAx2ahsrUskyJ1QNXEEZxpkz4Tomycb4e11fQfWAQhsUrdkIvFQDG81SlAtaZWtR97 AvSMbrvbtjE0gooT0tQCg9Y4UdOfQeBDteO380YhmXpwLBxtjCYOTw6h+0MD4w== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of ralf@mandelbit.com designates 2001:67c:2050:b231:465::102 as permitted sender) smtp.mailfrom=ralf@mandelbit.com From: Ralf Lici To: openvpn-devel@lists.sourceforge.net Date: Wed, 29 Jul 2026 12:21:42 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 4h97fs0SLHzNkMP X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Currently, in ovpn_nl_key_swap_notify, the OVPN_A_KEYCONF_KEY_ID attribute is packed as a 16-bit value despite being defined as a 32-bit u32 attribute in the YAML policy. Fix this inconsistency by using nla_put_u32. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1wp1QO-0002fC-Ru Subject: [Openvpn-devel] [PATCH ovpn net v6 2/6] ovpn: use nla_put_u32 for the key ID attribute in ovpn_nl_key_swap_notify X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sabrina Dubroca Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1872044275932889438 X-GMAIL-MSGID: 1872044275932889438 Currently, in ovpn_nl_key_swap_notify, the OVPN_A_KEYCONF_KEY_ID attribute is packed as a 16-bit value despite being defined as a 32-bit u32 attribute in the YAML policy. Fix this inconsistency by using nla_put_u32. Fixes: 89d3c0e4612a ("ovpn: kill key and notify userspace in case of IV exhaustion") Reviewed-by: Sabrina Dubroca Signed-off-by: Ralf Lici --- Changes since v5 https://lore.kernel.org/openvpn-devel/6e44855f0fcd704da43dd83b42a1236cb804c76e.1783336121.git.ralf@mandelbit.com/ - Add Sabrina's Reviewed-by tag. Changes since v4 of this series https://lore.kernel.org/openvpn-devel/981d2ea51cca45138210aa52c6e5a0e55c0da7a0.1783099626.git.ralf@mandelbit.com/ - Add this previously posted standalone fix to the series so the whole set can be picked in order. - No changes since v1 of the original single patch https://lore.kernel.org/openvpn-devel/8577555cc95646d0bd58a5b78e59c7e6a9b1a0c6.1783058844.git.ralf@mandelbit.com/ drivers/net/ovpn/netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ovpn/netlink.c b/drivers/net/ovpn/netlink.c index 4c66c1ec497e..abf038206a62 100644 --- a/drivers/net/ovpn/netlink.c +++ b/drivers/net/ovpn/netlink.c @@ -1335,7 +1335,7 @@ int ovpn_nl_key_swap_notify(struct ovpn_peer *peer, u8 key_id) if (nla_put_u32(msg, OVPN_A_KEYCONF_PEER_ID, peer->id)) goto err_cancel_msg; - if (nla_put_u16(msg, OVPN_A_KEYCONF_KEY_ID, key_id)) + if (nla_put_u32(msg, OVPN_A_KEYCONF_KEY_ID, key_id)) goto err_cancel_msg; nla_nest_end(msg, k_attr);