From patchwork Wed Sep 16 08:35:15 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ralf Lici X-Patchwork-Id: 5361 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:7000:6446:b0:8a0:ea1f:253a with SMTP id n6csp5930101mag; Wed, 16 Sep 2026 01:35:51 -0700 (PDT) X-Forwarded-Encrypted: i=2; AKwUvBxuNPljEmvKl8qFC7ZGsvFe4oXLrrVziJ/JO3pxxHU2txAbuKReRE+KvpU6methxJJp/I6r+FWSS6k=@openvpn.net X-Received: by 2002:a05:6870:d38c:b0:465:fdf:bd44 with SMTP id 586e51a60fabf-48475e95f2cmr1748507fac.14.1789547751529; Wed, 16 Sep 2026 01:35:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1789547751; cv=none; d=google.com; s=arc-20260327; b=rEY35zUvXjvRkkxMmwgErdVpaz24iqG22tcW4q+S7Rg7XcKUcIaaFzERq9TPZf3PAF vE9OjdV50Y2oGWh2BBYzqKgBDZncXtccfrfuQpTNUFGhiM6lvDvEtPgxAq+qB+YhHafN DTv8pIuLWyisGK8yfu4RE1Ag12AG/rZcuurxEyiYcfqP5680VJNVboOyHo/i3a4VqZYx KiAYjTETp1BveG4NWWVGQ8bXM8qqSpX4vH7YSOnP3C3V5h9od9/Nyx6G11PkgGjLtJSI RJPFLGWH3cmqZxxRli9qrEWPCPBw6IB2d3hTFxeQVs/By5Wp8gq6c703PUhbdnZOefyj fcCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=dgL5SahhRczTVpp1QryyyKT6lpA50z1s7vl25gAfU7o=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=jQIRnRQCfe78Qnce/FKyGsTBC/8m7lw9SPA1C/q57EmRmbaxGy98PWqNW84qoWBUW5 Kj+PngNsTbQn/5mX/eaxPqf5Ooer6b0bJsCCT7iAsxWGd68JYLGEr1fy5w9fh1ao6/1R 4pTCDkNgEf0UyLa/bFQ0yMS6NsAnMzyv2us4TCqplZTqiqoXymZiuQVKJ4Svr/ZDKGVf DZPmSckgq07y3bsqT1CNyXnLsLxOUO6QvjvoLYRMmO/BdBl9LKfv2O7b6djW1EN/4HNY xkYfk6UkfyukVn06+xNaEGlJGlLX+XetQ17nzzP1q1vFWlpKocC2OZCHpX3/p+pPak4/ 2dfQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=DENpl97P; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=LrPrwbbf; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=lu0UUJIo; dkim=neutral (body hash did not verify) header.i=@mandelbit.com header.s=MBO0001 header.b=hnpiCM1j; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 586e51a60fabf-4842a9bed66si2268977fac.300.2026.09.16.01.35.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Sep 2026 01:35:51 -0700 (PDT) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=DENpl97P; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=LrPrwbbf; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=lu0UUJIo; dkim=neutral (body hash did not verify) header.i=@mandelbit.com header.s=MBO0001 header.b=hnpiCM1j; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dgL5SahhRczTVpp1QryyyKT6lpA50z1s7vl25gAfU7o=; b=DENpl97PqIYnujFgPgG3S3JPiY If+A/wNSZKbrF6zlBf3Tut8mTzbLXrU81Yd8lm1Cp9GccdxMD7KNjj6tVnfPyTFFvyiQF2vuEncPv bPGNidCEwOf3xyBMFNyORi+EIBTgIouu1m/byqqExgeT41CRMZxpu3tQzxQ3hjDqVrEU=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1x6l7M-0002Jx-2l; Wed, 16 Sep 2026 08:35:48 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1x6l7H-0002JS-S2 for openvpn-devel@lists.sourceforge.net; Wed, 16 Sep 2026 08:35:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uRUxsZoOGryxI6iEUVGA3A6clvp1g5IhYIPzQfHaZ9c=; b=LrPrwbbfw9lRNSFRF5wSqB9E/U qOX0X/NIuoypq6+68AY3I/UCxeHAbInudPjRnjye7glucXgDdtfwuFHBtj84G6+eWQJyetXcbYVzQ cRh/HvZ0iE56sfM+RjWhLjrVncsWaAo5X+UdCjXdLwjWsEzzLkEZWhYCV57cmEByKh84=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uRUxsZoOGryxI6iEUVGA3A6clvp1g5IhYIPzQfHaZ9c=; b=lu0UUJIoOlz+Zi8lP8JrRezPpL NIw8iDV/bfELk49CW4/pP02uDeZzwrtt3Q5UzDbHR3ijnSLCA61hBcLoukBvz7k4LehBHuy62QWoT 0sXXfNq/OhTUcC3lvxSFn6GXY8iHMUMNBoueA5I91ljdZ+AbEFjZehoTySkVXD/lGULg=; Received: from mout-b-112.mailbox.org ([195.10.208.42]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1x6l7F-00053J-F8 for openvpn-devel@lists.sourceforge.net; Wed, 16 Sep 2026 08:35:43 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-b-112.mailbox.org (Postfix) with ESMTPS id 4hlBzT0c5Dz5wxq for ; Wed, 16 Sep 2026 10:35:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandelbit.com; s=MBO0001; t=1789547733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uRUxsZoOGryxI6iEUVGA3A6clvp1g5IhYIPzQfHaZ9c=; b=hnpiCM1j5aBy7S7pkavxmLzGwm66jzerUmSmsvbe5l+CAFYvAP6dC4tUmh6xFVPHQ7B9q9 0As0uPdWj72/uJncrhzWf/zVwpvY/uPp414EncNlJWxe0nwSNtcSeb+4SHxnFlpPVzFDuX xAHhGf578SxJwhI+VTV8rrV0oXrttZLBmPrgLiqrD9oXpmqP3nKxGWF1uHoc8qkcZpBej3 qGpwX+7vkL9gWo1nyhJyjom2OyXHB97eRz3/059zP+HIbpNC4s64gHddMArMo2fnFeQZko D++9rlGnoV3cI1gwrgNBbFAOjuAm2kCqwUSRpK8Rvi1JQqFD4X+k7orjsxyQYQ== Authentication-Results: outgoing_mbo_mout; dkim=none; spf=pass (outgoing_mbo_mout: domain of ralf@mandelbit.com designates 2001:67c:2050:b231:465::2 as permitted sender) smtp.mailfrom=ralf@mandelbit.com From: Ralf Lici To: openvpn-devel@lists.sourceforge.net Date: Wed, 16 Sep 2026 10:35:15 +0200 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Rspamd-Queue-Id: 4hlBzT0c5Dz5wxq X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Frag-list GRO exposes later encrypted records before the receive path decrypts the current one. Use this lookahead to request write ownership of linear ciphertext cache lines two records in advance (a [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1x6l7F-00053J-F8 Subject: [Openvpn-devel] [RFC ovpn net-next v3 6/9] ovpn: prefetch encrypted records before GRO batch decryption X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1876476823261224854 X-GMAIL-MSGID: 1876476823261224854 Frag-list GRO exposes later encrypted records before the receive path decrypts the current one. Use this lookahead to request write ownership of linear ciphertext cache lines two records in advance (and maintain the same distance throughout the batch), overlapping their memory access latency with the current AEAD operation. An ordinary single-record UDP receive has no later record and therefore skips the prefetch path. Only prefetch the linear part of each skb. Walking non-linear fragments here would duplicate the scatterlist walk performed by crypto and could cost more than the cache hint saves. A same-binary comparison using three 30-second samples per direction found distances one and two effectively tied forward, while distance two was 3.3% faster reverse and less variable in both directions. Profiling also measured slightly fewer decrypt cycles at distance two than at one, while wider distances provided no repeatable benefit. On a direct 100 Gbit/s ConnectX-5 link using one TCP stream, AES-128-GCM, a 1408-byte inner MTU and 8192-entry rings, five interleaved 60-second samples per direction increased throughput by 16.9% forward and 18.0% reverse. Signed-off-by: Ralf Lici --- No changes since v2 https://lore.kernel.org/openvpn-devel/4d8357e320fc7c8fd4ab6e42a0bc38b275b1ff5d.1789540779.git.ralf@mandelbit.com/ No changes since v1 https://lore.kernel.org/openvpn-devel/712708baf265c5509aed4f9d476abf514a242b8a.1789485693.git.ralf@mandelbit.com/ drivers/net/ovpn/io.h | 14 ++++++++++++++ drivers/net/ovpn/udp.c | 21 ++++++++++++++++++++- 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/drivers/net/ovpn/io.h b/drivers/net/ovpn/io.h index 1a94f0fda1d1..49180214fe08 100644 --- a/drivers/net/ovpn/io.h +++ b/drivers/net/ovpn/io.h @@ -10,6 +10,9 @@ #ifndef _NET_OVPN_OVPN_H_ #define _NET_OVPN_OVPN_H_ +#include +#include + /* DATA_V2 header size with AEAD encryption */ #define OVPN_HEAD_ROOM (OVPN_DATA_V2_OVERHEAD + \ max(sizeof(struct udphdr), sizeof(struct tcphdr)) +\ @@ -21,6 +24,17 @@ #define OVPN_KEEPALIVE_SIZE 16 extern const unsigned char ovpn_keepalive_message[OVPN_KEEPALIVE_SIZE]; +static inline void ovpn_skb_prefetchw(const struct sk_buff *skb) +{ + unsigned int offset; + + /* crypto overwrites data in place, so request write ownership of each + * linear cache line before the AEAD implementation reaches it + */ + for (offset = 0; offset < skb_headlen(skb); offset += L1_CACHE_BYTES) + prefetchw(skb->data + offset); +} + netdev_tx_t ovpn_net_xmit(struct sk_buff *skb, struct net_device *dev); void ovpn_recv(struct ovpn_peer *peer, struct sk_buff *skb); diff --git a/drivers/net/ovpn/udp.c b/drivers/net/ovpn/udp.c index ee3b9d1aec25..ce2584ecc934 100644 --- a/drivers/net/ovpn/udp.c +++ b/drivers/net/ovpn/udp.c @@ -32,6 +32,9 @@ /* like UDP and TCP frag-list GRO */ #define OVPN_UDP_GRO_CNT_MAX 64 +/* leave enough work between a cache hint and the record which consumes it */ +#define OVPN_UDP_GRO_PREFETCH_DISTANCE 2 + static bool ovpn_udp_gro_header(struct sk_buff *skb, u32 *header) { const unsigned int offset = skb_gro_offset(skb); @@ -187,7 +190,8 @@ static struct sk_buff *ovpn_udp_gro_detach(struct sk_buff *skb) static void ovpn_udp_recv(struct ovpn_peer *peer, struct sk_buff *skb) { - struct sk_buff *list, *next; + struct sk_buff *list, *next, *prefetch; + unsigned int i; list = ovpn_udp_gro_detach(skb); if (IS_ERR(list)) { @@ -198,8 +202,23 @@ static void ovpn_udp_recv(struct ovpn_peer *peer, struct sk_buff *skb) } skb->next = list; + /* a frag-list GRO aggregate makes later ciphertext visible before the + * current record is decrypted, so we prime the first two records, then + * keep the cache hints the same distance ahead while draining the list + */ + prefetch = skb->next ? skb : NULL; + for (i = 0; i < OVPN_UDP_GRO_PREFETCH_DISTANCE && prefetch; i++) { + ovpn_skb_prefetchw(prefetch); + prefetch = prefetch->next; + } + skb_list_walk_safe(skb, skb, next) { + if (prefetch) { + ovpn_skb_prefetchw(prefetch); + prefetch = prefetch->next; + } + skb_mark_not_on_list(skb); /* keep the current reference alive for the next record before