From patchwork Wed Jul 14 03:46:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: david korczynski X-Patchwork-Id: 1883 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director10.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net with LMTP id OIvqLifs7mAIWAAAIUCqbw (envelope-from ) for ; Wed, 14 Jul 2021 09:52:39 -0400 Received: from proxy3.mail.ord1d.rsapps.net ([172.30.191.6]) by director10.mail.ord1d.rsapps.net with LMTP id aHHtLifs7mDRaQAApN4f7A (envelope-from ) for ; Wed, 14 Jul 2021 09:52:39 -0400 Received: from smtp18.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy3.mail.ord1d.rsapps.net with LMTPS id SDmWLifs7mBZcAAA7WKfLA (envelope-from ) for ; Wed, 14 Jul 2021 09:52:39 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp18.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=ADALogics2.onmicrosoft.com; dmarc=none (p=nil; dis=none) header.from=adalogics.com X-Suspicious-Flag: YES X-Classification-ID: c00a0cf2-e4aa-11eb-b6e5-5254005167a7-1-1 Received: from [216.105.38.7] ([216.105.38.7:33114] helo=lists.sourceforge.net) by smtp18.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id A2/3E-11581-62CEEE06; Wed, 14 Jul 2021 09:52:38 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1m3fIl-000249-6d; Wed, 14 Jul 2021 13:51:51 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3fIj-000242-Bc for openvpn-devel@lists.sourceforge.net; Wed, 14 Jul 2021 13:51:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Content-Type :Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=A+FjE1oMFdqjr7ycgY5zzdxji1Mk6MybCj4YOVvcUQA=; b=M23SkK4gphPxQ4wsRG+kSk3z13 +pyYY4plWC0W5yPyRnVkcb8X3SgAFCjJ5pVNiSz2zVAuzDXJ/NTb6ST+wP+Kx30vVhcbX4t8Rf6Op Kx6TXQqaKnNPADpS/za1Wkvp3FlUGSQQQU8H/BJW0VFmLSUvgrByKbcv9OzuWasLQD1I=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Content-Type:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=A+FjE1oMFdqjr7ycgY5zzdxji1Mk6MybCj4YOVvcUQA=; b=H DHS97uabX65NJ95p1pTevbQuzPhzDryx5FfKM73NGOwZ+5wahQMfroHCQF9yX6jf87qT7tFvgqOnH DsADYs1ZtRgP7gBy7p0iDdvQxWwJNUGcJ2ijaQlPRmfA4ckUl8KTX+JDES14LnOixHtTJn1v8GzPV nag893bnu6xnG1pA=; Received: from mail-eopbgr100137.outbound.protection.outlook.com ([40.107.10.137] helo=GBR01-LO2-obe.outbound.protection.outlook.com) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1m3fId-0086xU-4Q for openvpn-devel@lists.sourceforge.net; Wed, 14 Jul 2021 13:51:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KHqL1z3p0wEMN1nhnkdUVHkhn0XmWzxZXx7YBsdib7LTmoqiMLJ2o9pj7628a1M3XNjAYgzqH5yh+FlNWXvn1JFYodICaQgeF7taamK+dr8EmafZw4leJIonnY0/SAFlTnsykDxuTtlGul9Btfa3ko7xD+msNcvIpjswb64ukSCdT/ujUIWxovPbKjlKRnhDEJC8gC7ATobEXXid2DKqoVcEEenj9NP20WrMfhADgLVwZ6xAJxFXNVG3smyqa9ISkipHve06Y8PeUwhJwwbETjkMyHUloNx/tCc4RcFqWmGCqJAlSo55NiI5yfpLYiFoCEUj6MoeNO0gxndFocHj0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A+FjE1oMFdqjr7ycgY5zzdxji1Mk6MybCj4YOVvcUQA=; b=IslSvuMsVIHvD2Z9a3/TJi6xvRYABZcrd4qhlWWUMI1vOzic5krPSlGot9PQV4lWlay1rbNZPaFZ0BNhHmU/sQxxFjzY8AybKKQKmboGEnFxWKYj5BFahQ/JKQ1Vwu1nxj94Xsl7fmJKTx3ny6cwSm17FCFqrnRm2hjbDncQZs3rlIdSJqsbqG+Bow5GPC8Xev2dFILvRfnXD/c2PJqBDigu4Vtivp4vAznEmkQaYJkb2uyFSDMoQY6L29h0v88AWpJ3tzmcN4mTcAwlSPwwp85fBfexkAkYfToElXVi01DtD/Hqa+YgoEciK668v7v2V/o2ZklqvV3PfX5SoL8y0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=adalogics.com; dmarc=pass action=none header.from=adalogics.com; dkim=pass header.d=adalogics.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ADALogics2.onmicrosoft.com; s=selector2-ADALogics2-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A+FjE1oMFdqjr7ycgY5zzdxji1Mk6MybCj4YOVvcUQA=; b=vNEjgzb3m0FRsY/QftnWuhzTp8hZxnRJtdV4uz1M5NJjiK5RDjyff59GqHMG0EOvHhz2m4+0cR3VeW9zLGEPuHJU8/33p3UySgwjIs1K/U1jIwhgQ7os4W7+FEnYax3ypN11X+R1m7jK4HIsuZfwtDA4svw0zZ73gi4CLAlFfq0= Received: from LOYP123MB2767.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:e5::7) by LOYP123MB3341.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:122::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Wed, 14 Jul 2021 13:51:34 +0000 Received: from LOYP123MB2767.GBRP123.PROD.OUTLOOK.COM ([fe80::d49f:a292:e4a1:586c]) by LOYP123MB2767.GBRP123.PROD.OUTLOOK.COM ([fe80::d49f:a292:e4a1:586c%3]) with mapi id 15.20.4331.021; Wed, 14 Jul 2021 13:51:34 +0000 From: David Korczynski To: openvpn-devel@lists.sourceforge.net Date: Wed, 14 Jul 2021 14:46:42 +0100 Message-Id: <20210714134642.12964-1-david@adalogics.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: LO4P123CA0367.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::12) To LOYP123MB2767.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:e5::7) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from davkor.Home (2a02:c7f:d4b1:5200:11fa:4ec:a7a:c717) by LO4P123CA0367.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Wed, 14 Jul 2021 13:51:33 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62337a9c-403f-435e-2d3c-08d946ce7e07 X-MS-TrafficTypeDiagnostic: LOYP123MB3341: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:346; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wnlACoscg/PEuvw61au6rViqQWU54vclP3+AjvkDyjBe5gIJX/bxr8vwbG3cHQLsI8mTnjXFqB8C1Jnzc0HPdcOj1KcuQc8ffiajb0ei/s79CndOGk39aw4ZI3S+oCtsvMIqjrc3614nyVIFjrM49l/JxTanHHpzIMhhquS381rcmQcFSu6Ne6xuj/K7VHig/DOReOsdp9ohL3ylBqPt5o1OHgb8eEWAmHvS8q+yW3nYFpDtDdN+I7XFBWpCu1dwtiFptXWtkloDlo3vmN2C+W902/ZSQYReW4bBU/7CR5e1jIPL2QaM4/G2wapMuuCnOtXLCcbizoSVyFrrHTN34t3j5nN9GwFM2somiu12r3qPLN2QBObKGMgq41TBNpr9a0O/r1op07Hi5lCjwgSPcHYCKqfZliCgY77qp9posHA6WtEG/vRS0SdG/MIKd0rIBwzDhI6DvvbKFrop7rpupB2+UXKjhSfdmtKA7tyJCxxeWjxnOogjXa5qs9xSFzpo1TctA9a+GVxzS7r85hq2vs+Tt4yjAaqj7YETyVskgtqhgySYu5mAthZ/Y4t8UaihGrvQ7LTV1g2B9P0uqcMhPTXK163AgMnR3akBZPUmd5xVRTgUgfTlLczIDuovcFXgGUQqoLtFUeBmFACvDLCUFA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LOYP123MB2767.GBRP123.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(366004)(136003)(376002)(39830400003)(396003)(346002)(36756003)(38100700002)(186003)(107886003)(8886007)(6666004)(86362001)(1076003)(4326008)(6506007)(5660300002)(2616005)(8936002)(6916009)(478600001)(8676002)(316002)(4744005)(66946007)(6486002)(66476007)(52116002)(66556008)(6512007)(2906002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: vsqmq+bS9b0thyHaF683fxjqoLABysTaor7IPlu0rEAU51bURWT+IZO/T11JPnm7RiYTLRQi6cEr2yX7f+b3+uloN8ra6g0NeFrV3RPopGRH/iVX7W9o3Y6/Nl+T+p8k23MYPuIAb7zaShcjxA5NRdAOa7uA/oirNAZfeLAp3bPXJsqDrjW/AA/G4cwsFzg2FhLAO3DBPlFcPPOoxPTvRPJzdJHOI1mtVHElzdeZRoUjZgiN7RAiI2XjhmZ/x1XNQtZ+Lr5iltzU/H68Z4xex1/19Lpso6mGKD5qmvX9cKncrK0dba7ofb7Tr6w6fkRTw5ccDDnpq8xoNeairn3jiBoBcQNPP2P6X3OsQXgp+W2F9NEQ0SxwXTvTSOsoSwOq5IVp0nqlT4Qrjo5w0BC00IdAOHipvXfNv5E0neoWkcWKmn5y9CIiXTRtUuXvfJrPF6WJEFLgLxRzh9O07mNH0znJwqcsggE0c7/bMQXM0t2nUtMY6zxsTF72YTAboopoyEetItTyiEdcogHePgBQtw+TGunu38U4GHGpdSjPXOLPKoWOgJHzaYb0xQEO0AYmNLuonyzDodOWGh3vOxT++HyfbDvaJNohPow8a0jNG4HrZv1iTP2bsv0HDt9UkQGmuqrXxg8k9YS9mPx61brC/mOc5bRUUHuRz9AVVLylF4Q9XE+3MGy8TKCd1MAeb7MBjqHF6jwhesD2NLlf5ESXKYuLlKqF4s5MzOXvzOIaosBW+a8tfUfOIb8cTpFYgG77yUyGQ7O7oicyMd6PQtZAUbjFZBBDilTrmcm+q687abXmj9qh/oQw5ikzHd+sbLk/qY9zVuBcFiB5I/UkTlCbXDEcKSFWJl7FyvZSf46ZKtH9Z0WVDO5wiROa5quPk5hqScs2tf1tG0CtEPR5IGnk38JxWFesHUfhVkG7HGTS9HNKQ0gkuiPhzQwlFeD3z8vdxRgKfiXAihxwneUYh9UynOwkOowdoc1FW1xhNSG5X8zRbQjkgHe8GJOc/weKV1rdeLM9essriElyf4xvJDYJ9TsYKyJVMC2mQXT0JQLbh2Ze19CXZn5qXo+DjtS0xTNRfa8OLsYiShy/MmUWDuXVJ1um0vpKy5C2cYZh0qmwOju+s06P6Ij1D2FVnl15V818lAnQoWJWL20aNVRYkt0ewgw2i0ENqpbznNmiRG82HOfx4/1BWIl3pPMUGWdzIYtFb7QJcuZ5RFweWAWFiTws0AkIfV3SKpLCKSce6IUVgUfHYMGLRLmYgQ/5IDRjqBOKYwWzyHfHN/hmiJfX/joL08YZW2hlOW86KM9KInzPaPkiDLUVTXOFeXN+/6mf2fJRiMea9swo2Is0QRSSGG6LffHPmxYb14iZcTYiBd44GKfdzbuvHwINeHvSGALSvSEV X-OriginatorOrg: Adalogics.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62337a9c-403f-435e-2d3c-08d946ce7e07 X-MS-Exchange-CrossTenant-AuthSource: LOYP123MB2767.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2021 13:51:34.3383 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4a262c48-49eb-487e-893b-c5902e6682ae X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GbhYn6V6Tb4jK4nfoWpeJuqch7Ix7eH/puFrBw5rk8o0g12FzMo7MQm1Q6jh1a2I3Ntf6CMWOMyhq4Ia+x0MfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LOYP123MB3341 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: adalogics.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [40.107.10.137 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [40.107.10.137 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-Headers-End: 1m3fId-0086xU-4Q Subject: [Openvpn-devel] [PATCH] Avoid leak in add_route. X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox Signed-off-by: David Korczynski --- src/openvpn/route.c | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 ADA Logics Ltd is registered in England. No: 11624074. Registered office: 266 Banbury Road, Post Box 292, OX2 7DL, Oxford, Oxfordshire , United Kingdom diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 3b2af8b4..e429e8c0 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -1584,6 +1584,7 @@ add_route(struct route_ipv4 *r, if (!(r->flags & RT_DEFINED)) { + argv_free(&argv); return; }