From patchwork Mon Sep 13 04:45:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Quartulli X-Patchwork-Id: 1948 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director9.mail.ord1d.rsapps.net ([172.28.255.1]) by backend30.mail.ord1d.rsapps.net with LMTP id oIZaBmJkP2G1GQAAIUCqbw (envelope-from ) for ; Mon, 13 Sep 2021 10:46:58 -0400 Received: from proxy7.mail.ord1c.rsapps.net ([172.28.255.1]) by director9.mail.ord1d.rsapps.net with LMTP id 0IEbBmJkP2FZLAAAalYnBA (envelope-from ) for ; Mon, 13 Sep 2021 10:46:58 -0400 Received: from smtp23.gate.ord1c ([172.28.255.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy7.mail.ord1c.rsapps.net with LMTPS id cHfMBWJkP2EBWQAAknS3pQ (envelope-from ) for ; Mon, 13 Sep 2021 10:46:58 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp23.gate.ord1c.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=unstable.cc X-Suspicious-Flag: YES X-Classification-ID: 7153e9da-14a1-11ec-91e7-b8ca3a678528-1-1 Received: from [216.105.38.7] ([216.105.38.7:55492] helo=lists.sourceforge.net) by smtp23.gate.ord1c.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 2F/09-01526-1646F316; Mon, 13 Sep 2021 10:46:57 -0400 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1mPnDb-00076K-7Z; Mon, 13 Sep 2021 14:45:59 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPnDa-000763-4E for openvpn-devel@lists.sourceforge.net; Mon, 13 Sep 2021 14:45:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ir9+GQXk0epUEdyO8GnlOkwICLpDqBnHfQhqfvu3dFc=; b=XsdkbNUrZXBVED856xFugVqm4D SuUelqwSDSDY5oo5IlSfw7sDPHC2Z8wv2TY8TDgVq3E8bgSAvRYySie7sbqlubi+XJZ18cVb/Xl6b DIPVCS3GTTu3S3ITICD0TEXP5/NdddIDAzY0e1ZA2mkRz84D2ckq5qXxDxg14sxt73KM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=ir9+GQXk0epUEdyO8GnlOkwICLpDqBnHfQhqfvu3dFc=; b=d v3jq+FkURUJfF/ALJnXmXl8ahWdSNBN7HbDM4giBAXWoyUEnZQuSWea/r2VfY5H0K6OBLTkZXeuPv nxQLZaL/nTZ/BdR8ykNxXQgxrQ8b861Y+oycTedwEPxfimvduzW18ZsYJtkdYYJnd9Ps5/ojIjITg jPVius+S3blRbTH0=; Received: from [5.148.176.60] (helo=s2.neomailbox.net) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mPnDY-0007Bf-AC for openvpn-devel@lists.sourceforge.net; Mon, 13 Sep 2021 14:45:58 +0000 From: Antonio Quartulli To: openvpn-devel@lists.sourceforge.net Date: Mon, 13 Sep 2021 16:45:31 +0200 Message-Id: <20210913144531.8889-1-a@unstable.cc> MIME-Version: 1.0 X-Spam-Report: Spam detection software, running on the system "util-spamd-2.v13.lw.sourceforge.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: After getting rid of all PF related ifdef blocks, a pair of useless brackets has remained in multi_process_incoming_link(). These brackets do nothing at the moment and can be just removed. Signed-off-by: Antonio Quartulli --- src/openvpn/multi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) Content analysis details: (1.3 points, 6.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1mPnDY-0007Bf-AC Subject: [Openvpn-devel] [PATCH] multi: remove extra brackets in multi_process_incoming_link() X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antonio Quartulli Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox After getting rid of all PF related ifdef blocks, a pair of useless brackets has remained in multi_process_incoming_link(). These brackets do nothing at the moment and can be just removed. Signed-off-by: Antonio Quartulli Acked-by: Gert Doering --- src/openvpn/multi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c index 3453d6aa..103e882e 100644 --- a/src/openvpn/multi.c +++ b/src/openvpn/multi.c @@ -3250,10 +3250,8 @@ multi_process_incoming_link(struct multi_context *m, struct multi_instance *inst /* if dest addr is a known client, route to it */ if (mi) { - { - multi_unicast(m, &c->c2.to_tun, mi); - register_activity(c, BLEN(&c->c2.to_tun)); - } + multi_unicast(m, &c->c2.to_tun, mi); + register_activity(c, BLEN(&c->c2.to_tun)); c->c2.to_tun.len = 0; } }